mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-15 08:47:14 +00:00
02420d3e93
* Handle some nullable cases
Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization
* Handle bits more obviously without null
* Make SaveFile.BAK explicitly readonly again
* merge constructor methods to have readonly fields
* Inline some properties
* More nullable handling
* Rearrange box actions
define straightforward classes to not have any null properties
* Make extrabyte reference array immutable
* Move tooltip creation to designer
* Rearrange some logic to reduce nesting
* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum
* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case
* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable
* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator
* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever
* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)
* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
73 lines
No EOL
3.1 KiB
C#
73 lines
No EOL
3.1 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class SAV7SM : SAV7, ISaveBlock7SM
|
|
{
|
|
public SAV7SM(byte[] data) : base(data, SaveBlockAccessor7SM.boSM)
|
|
{
|
|
Blocks = new SaveBlockAccessor7SM(this);
|
|
Initialize();
|
|
ClearMemeCrypto();
|
|
}
|
|
|
|
public SAV7SM() : base(SaveUtil.SIZE_G7SM, SaveBlockAccessor7SM.boSM)
|
|
{
|
|
Blocks = new SaveBlockAccessor7SM(this);
|
|
Initialize();
|
|
ClearBoxes();
|
|
}
|
|
|
|
private void Initialize()
|
|
{
|
|
EventConst = Blocks.BlockInfo[05].Offset;
|
|
EventFlag = EventConst + (EventConstMax * 2); // After Event Const (u16)*n
|
|
HoF = EventFlag + (EventFlagMax / 8); // After Event Flags (1b)*(1u8/8b)*n
|
|
TeamSlots = Blocks.BoxLayout.TeamSlots;
|
|
}
|
|
|
|
public override PersonalTable Personal => PersonalTable.SM;
|
|
public override IReadOnlyList<ushort> HeldItems => Legal.HeldItems_SM;
|
|
public override SaveFile Clone() => new SAV7SM((byte[])Data.Clone());
|
|
|
|
#region Blocks
|
|
public SaveBlockAccessor7SM Blocks { get; }
|
|
public override IReadOnlyList<BlockInfo> AllBlocks => Blocks.BlockInfo;
|
|
public override MyItem Items => Blocks.Items;
|
|
public override MysteryBlock7 MysteryBlock => Blocks.MysteryBlock;
|
|
public override PokeFinder7 PokeFinder => Blocks.PokeFinder;
|
|
public override JoinFesta7 Festa => Blocks.Festa;
|
|
public override Daycare7 DaycareBlock => Blocks.DaycareBlock;
|
|
public override Record6 Records => Blocks.Records;
|
|
public override PlayTime6 Played => Blocks.Played;
|
|
public override MyStatus7 MyStatus => Blocks.MyStatus;
|
|
public override FieldMoveModelSave7 OverworldBlock => Blocks.OverworldBlock;
|
|
public override Situation7 Situation => Blocks.Situation;
|
|
public override ConfigSave7 Config => Blocks.Config;
|
|
public override GameTime7 GameTime => Blocks.GameTime;
|
|
public override Misc7 MiscBlock => Blocks.MiscBlock;
|
|
public override Zukan7 Zukan => Blocks.Zukan;
|
|
public override BoxLayout7 BoxLayout => Blocks.BoxLayout;
|
|
public override BattleTree7 BattleTreeBlock => Blocks.BattleTreeBlock;
|
|
public override ResortSave7 ResortSave => Blocks.ResortSave;
|
|
public override FieldMenu7 FieldMenu => Blocks.FieldMenu;
|
|
public override FashionBlock7 FashionBlock => Blocks.FashionBlock;
|
|
#endregion
|
|
|
|
protected override int EventFlagMax => 3968;
|
|
public override int MaxMoveID => Legal.MaxMoveID_7;
|
|
public override int MaxSpeciesID => Legal.MaxSpeciesID_7;
|
|
public override int MaxItemID => Legal.MaxItemID_7;
|
|
public override int MaxAbilityID => Legal.MaxAbilityID_7;
|
|
|
|
private const ulong MagearnaConst = 0xCBE05F18356504AC;
|
|
|
|
public void UpdateMagearnaConstant()
|
|
{
|
|
var flag = GetEventFlag(3100);
|
|
ulong value = flag ? MagearnaConst : 0ul;
|
|
SetData(BitConverter.GetBytes(value), Blocks.BlockInfo[35].Offset + 0x168);
|
|
}
|
|
}
|
|
} |