Commit graph

9325 commits

Author SHA1 Message Date
Kurt
2adbeed48a gen4 improvements
simplify redundant code
fix pcd writing (used wrong const)
reduce linq usage for byte[] get/set
2017-01-15 16:16:35 -08:00
Kurt
97227fdfe9 More simplification
Extrabytes index selection done in setPKMFormatMode

if (visible) is bad, why do I forget? If the control is not shown (ie
another tab) but possible to be visible it'll return false. Use enabled
instead.
2017-01-14 16:59:57 -08:00
Kurt
3f218968c5 Refactoring & fixes
Fix blank sav creation for gens 1-3 (data vs Data references, version
overrides)
Fix main form init with gen2 first (check for altform usage like all
other gens)
Use GameVersion specific blank fetch instead of generation ID
2017-01-14 16:43:16 -08:00
Kurt
12c46d18a8 Disable custom exception handling for debug mode
VS wouldn't break at the line that threw the exception; only have the
custom exception handling for release builds (ie the CI server & posted
builds).

makes it easy to debug again
2017-01-14 16:41:27 -08:00
Kurt
e321c48871 Refactoring
Add blank save creation to Core SaveUtil methods.
Simplify main form resource usage (remove redundant qualifiers)
2017-01-14 13:10:36 -08:00
Kurt
c075ff3c47 Enhance clone detection for gen1/2
Would only return unique species as PID is not used, use IV values as
unique identification.
2017-01-14 12:10:42 -08:00
Kaphotics
f0b5adcfe3 Merge pull request #720 from kwsch/b/mono-tests
Tests no longer build in Mono build configurations
2017-01-12 18:30:24 -08:00
Kurt
e83ed49eea Add gender-skin mismatch confirmation
Closes #718
2017-01-12 18:29:44 -08:00
Evan Dixon
c6867a367b Tests no longer build in Mono build configurations 2017-01-12 14:27:39 -06:00
Kurt
ddf7327bf8 Add bv7 music offset
silent bgm boolean property too
2017-01-11 22:29:30 -08:00
Kurt
f4797e06a0 More refactoring
More extension methods for other types of images
2017-01-11 22:28:35 -08:00
Kurt
db5e084ef9 Further refactoring
Move System.Drawing usage out of Core to WinForms, as System.Drawing is
not in .NET Core/Standard. Simple methods to return resource name
strings have been added instead.
2017-01-11 17:55:42 -08:00
Kurt
1d1179465a Add typo null check
Updating legality with an invalid move name causes SelectedValue to
equal null. Use the util function that has null check for combobox &
selectedvalue.
2017-01-10 20:59:31 -08:00
Kurt
c1e613280b Hide save buttons if no save has been loaded
buttons enabled by default => only show button panel if the save is
valid AND at least one enabled.
2017-01-10 20:01:33 -08:00
Kurt
29658c28f2 Fix event OT friendship check
Should compare to the original species not to the current
Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-10 17:14:48 -08:00
Kurt
130807c698 Add duplicate relearn move check
Same duplication check as moves
Closes #709
2017-01-09 22:51:11 -08:00
Kurt
c9e721fc5b Update settings load
bad settings files cause exceptions, silently delete them
move language init out of loadconfig (want it to happen regardless of
config errors, so load config value instead)
2017-01-09 19:15:46 -08:00
Kurt
1fcdffc654 Add pkm value indication
Grab an example PKM (from main window) to get the current value to
assist users in creating their modification scripts.

Added 3 tooltips for hovering over property/type/value controls
2017-01-08 21:06:15 -08:00
Kurt
51352c3c13 Remove more find-replace errors
yay for unsaved changes
2017-01-08 17:14:39 -08:00
Kurt
1e40667b63 Update sav5 block documentation (b/w) 2017-01-08 15:27:15 -08:00
Kurt
1e3a46d760 Find replace is bad 2017-01-08 15:27:00 -08:00
Kaphotics
54f510da03 Merge pull request #702 from kwsch/b/build-configuration
Removed "Any CPU" build configuration
2017-01-08 09:20:45 -08:00
Evan Dixon
87dffcfe57 Updated build paths
to be more consistent with PKHeX.Core
2017-01-08 08:35:23 -06:00
Evan Dixon
1acfdf8f92 Removed "Any CPU" build configuration
Since the solution level one didn't build the dependencies and the project level one built as x86 anyway
2017-01-08 08:28:28 -06:00
Kurt
7da6f1ab1d Cleanup 2017-01-08 00:14:34 -08:00
Kurt
595c7eb4c5 Split winforms to separate project
resources still are associated with winforms, eh
program still runs fine and I've replicated the mono build options. lmk
if this breaks stuff
2017-01-07 23:54:09 -08:00
Kurt
bd1ac8e266 Update wc6 database
g7db was last updated Nov 17, 2016
Closes #701
fix extension suggestion & copy backup logic from main
2017-01-07 09:54:31 -08:00
Kurt
4636042fe1 Add box movement to box layout editor
Box insertion (movement gap ex/ 5->13) untested and not used in code

box movement checked for locked slots
2017-01-06 21:22:42 -08:00
Kurt
29a1a83b07 Add write protection err handling
yay sd cards getting switched accidentally
2017-01-06 20:40:22 -08:00
Kurt
7048b012d3 Add other card types 2017-01-05 22:34:22 -08:00
Kurt
85ee2753e3 Add EVs property 2017-01-05 18:33:11 -08:00
Michael Scire
fda84ae992 Better WC7 Card Flags + Descriptions 2017-01-05 14:45:53 -08:00
Michael Scire
89622862b2 Add Gen 1 Pikachu Friendship Support (Closes #538) 2017-01-05 01:14:19 -08:00
Michael Scire
860742bd33 Add alolan vulpix wondercard to DB 2017-01-05 01:05:10 -08:00
Kurt
e7bf0b9a2c Minor refactoring
Switch EncounterGeneric to IEncounterable. A way to tie together all
encounters.
Added a few setters for mystery gifts if the code is ever reused in
other projects for that purpose.

No functional change.
2017-01-04 22:25:45 -08:00
Kurt
ed47e389d4 Improve supported extension openfiledialog
Existing code supported 3-x, wasn't updated for gen1/2.
Allows gens1/2 to override to their own gen format filter, and allows
gen7 to allow finding of pk1 files (not yet converted).

Noticed the backup would overwrite an existing backup; thus we only back
up if the target file exists AND the backup doesn't already exist.
2017-01-04 22:22:50 -08:00
Kaphotics
769f58ea97 Merge pull request #697 from kwsch/f/mono-fix
Contitionally add mono fix from #440
2017-01-04 18:11:00 -08:00
Evan Dixon
16156a56ac Contitionally adds mono fix from #440
Only affects Mono-Debug and Mono-Release build configurations
2017-01-04 12:00:32 -06:00
Kurt
986eca8f30 Add temporary _0x2A property
Search via !_0x2A=0
2017-01-03 21:21:12 -08:00
Kurt
63d0f0ea1e Minor program text changes
Add version string to top of window alongside SAV name
Update closing prompt for a thinner messagebox
2017-01-03 21:05:26 -08:00
ReignOfComputer
3af23e1e7e Island Scan Klink Incorrect Location (#696)
Seems like Klink has the wrong location value. This should be the correct one.
2017-01-03 20:53:11 -08:00
Kurt
ede8846162 Refactoring
Move fossils check to static encounter
apply small amount of inheritance to all encounter types (including
mystery gifts)
get actual evolution chain to ignore pre-evolution movepools (example
Surf Pikachu event gift cannot devolve to Pichu to get Nasty Plot). #694

A little bit of logic has been moved around, but my 5k pkmdb had no
change in legal/illegal counts. Hopefully no false positives from this
change 👍
2017-01-03 20:51:33 -08:00
Kurt
bf2e3a9abb Fix cosplay pikachu static fetch
with the addition of forme checking, these 'can switch forme' cosplay
pikachu are currently not recognized. just add a skip toggle instead of
duplicating the encounters (variant location and formes)
2017-01-02 22:20:16 -08:00
Kurt
2b0aa6e73d Show secret training for gen6->7 transfers
only training bag is removed on transfer
2017-01-02 22:18:23 -08:00
Kurt
775d68e88f Minor speed improvement
string culture slowdown with none specified, specify ordinal to shave
off 10% of overall legality check ms
2017-01-02 22:17:47 -08:00
Kurt
5d7147de67 rsbox/batrev sav tool hiding
fix loading a batrev sav twice (items can't clear if a datasource is
bound)
2017-01-02 22:16:15 -08:00
Kurt
ab7f9d7df1 Refactoring
move origin validity check to pkm class
2017-01-02 22:15:17 -08:00
Kurt
2173299ad0 Update island scan species prevo table
duosion and luxio weren't devolved to their base species
add budew and azurill too.

reorganize table so that species are listed in their 'modified' groups
(base, base/baby, -1, -2)
2017-01-02 14:34:08 -08:00
Kurt
01f153007b Add static encounter trade evo skip
#604
conkeldurr only trade evo pokemon as a static encounter
2017-01-02 14:23:24 -08:00
Kurt
41593fa0f6 Add bak file extension for openfiledialog
#693
2017-01-02 14:22:44 -08:00