334 commits

Author	SHA1	Message	Date
Kurt	f959179e1a	add more colo encounter locations ... dogs had hypothetical met locations, now fixed (y u so weird cxd) Closes #1556	2017-11-03 21:33:48 -07:00
Kurt	f48afaf12d	Switch slottype to flags ... simplifies some logic, adds some documentation, speeds up loading very slightly	2017-11-03 17:14:18 -07:00
Kurt	d7300ce68f	Cleanup ... add amoongus route22 encounter fix typos in comments resharper suggestions for recent pr	2017-11-02 21:37:28 -07:00
Kurt	495eb26740	Rework colo starter PIDIV detection ... force colo starters to be male only use some c# lang features for EncounterType flags add edge case PIDIV detection for starter gender/shiny lock scenario adds a little documentation for those unfamiliar with the NPC PKM generation quirks. Colosseum Starters will now be recognized with a different PIDIV type which is specific to them & them only.	2017-11-01 21:12:44 -07:00
Kurt	60e719a65a	Misc refactoring ... more usum prep don't allocate empty array on every savefile creation (use linq All comparison) add percent seen/caught savefile properties for data analysis purposes	2017-10-31 09:24:54 -07:00
Kurt	e9cebf933c	Fix headbutt encountertype fetch ... future improvement can be detecting when "none" is appropriate, but for now, whatever. Closes #1502	2017-10-29 20:19:49 -07:00
Kurt	da9e316cd8	Add rock smash encounter type flagging ... I don't believe rock smash (EncounterType 1) exists, tests at Route 19 and Vermillion yielded None & City. Closes #1379 Opens #1502	2017-10-29 19:17:53 -07:00
Kurt	3f533399f2	Simplify slot type loading ... instead of 2 similar methods, use params to achieve a flexible method for both situations isolate rock smash / headbutt type loading	2017-10-29 18:09:30 -07:00
Kurt	afde4514e2	Add realgam tower / deep colosseum locs ... sudowoodo & gsc dogs closes #1549 fix loading issue for abilities in gen3 format, copy the gen4 sanitization	2017-10-29 10:41:12 -07:00
Kurt	9ada593af9	add gen7 nick ot (trades) ... #1249 todo usum table when appropriate	2017-10-28 23:04:02 -07:00
Kurt	d2ebb6340e	Add gen5 nick/OT info (trades) ... #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.	2017-10-28 21:43:47 -07:00
Kurt	e4319fd929	Add gen3 nick/OT info ... #1249	2017-10-28 19:51:55 -07:00
Kurt	2c73e130af	Add gen4 nick/OT info ... #1249	2017-10-28 19:02:18 -07:00
Kurt	9d0b153eab	Add egg hatch suggestion for b2w2	2017-10-28 14:00:44 -07:00
Kurt	a401db608e	Split trade encounter nick/OT verification methods ... #1249	2017-10-28 13:15:51 -07:00
Kurt	0e9960909b	Refactor encountertype check to bitflags ... #1379 need to double check none permissive later	2017-10-27 23:57:21 -07:00
Kurt	00a4c1adf5	Add multilang c/xd ingame gifts ... save space by just using a loop closes #1529 , pokespot proc discussion relocated to associated issue (as previously noted in comments)	2017-10-25 21:53:55 -07:00
Kurt	a6ef105544	Update gen3/4 encounter generators ... revisit for simplification now that EncounterTrade matching is more precise (PID required to match). #1249	2017-10-24 22:25:52 -07:00
Kurt	59319a614a	Add PID values for Gen3/4 ingame trades ... #1249	2017-10-24 22:24:29 -07:00
Kurt	933bfba8e1	Misc cleanup ... check gen2 stadium names, use pkm.Japanese when favorable	2017-10-24 18:27:40 -07:00
Kurt	69cf1eaa9c	add more pkhex.core xml documentation ... adds a bunch of documentation useful for those unfamiliar with the core library	2017-10-23 23:12:58 -07:00
Kurt	60562fb44e	Use empty enumerable when appropriate ... no allocation == no pressure for garbage collector	2017-10-23 15:44:01 -07:00
Kurt	a03ac10fc5	Misc refactoring ... no functional change	2017-10-22 23:26:37 -07:00
Kurt	515a694afa	Add LanguageID enum ... no functional change, just less-magic-numbers for easier to understand src	2017-10-22 21:01:08 -07:00
Kurt	44c80bd722	Exclude light ball pikachu from gen1 species setter ... Thanks Dunsparce! https://projectpokemon.org/home/forums/topic/41880-yellow-version-pikachu-editing-bug/ non-functional change but fix misuse of gameversion checks (used X/Y instead of YelloW)	2017-10-22 17:11:48 -07:00
Kurt	096f6bbd18	Add RANDY Gen2 ingame trade ... closes #1538 rename pid deferral to pidiv deferral for clarity	2017-10-22 10:41:27 -07:00
Kurt	c5b0ed6c35	Move encountertype deferral to main generator ... gen4->gen5/6 electrode will match static & wild slots, but deferral only defers within the same IEncounterable group.	2017-10-22 09:42:15 -07:00
Kurt	528593b59e	Disallow crystal tutors if VC	2017-10-21 19:01:23 -07:00
Kurt	39279a7ad4	Add VC transfer checks ... checks were previously only performed when finding the encounter, once found, the GB encounter was validated. the transfer encounter is derived after all encounter checks, thus remaining unchecked (really, only for Locations). Move generating logic to the generator, and double check the locations are valid. #1535 Thanks @DJPanda065 !	2017-10-20 21:07:15 -07:00
Kurt	00adfda6e4	Flag Hidden Ability -> other change (hacked) ... Closes #1535	2017-10-20 20:10:56 -07:00
Kurt	0e24b5237e	cleanup ... remove redundant/repetitive match update (updateTypeInfo with Format>=7 already updates the encountermatch just prior to this method call)	2017-10-20 20:10:13 -07:00
Kurt	ae0bf5c75c	remove (None) egg gen4 hatch location	2017-10-19 22:00:31 -07:00
Kurt	a75614ed77	Modify eggmove fetch ... fetch is exclusively done with version already known; there are cases where version can change for eggs so it's safer this way. version change reference (gen6+): 212a489335	2017-10-19 21:20:47 -07:00
Kurt	a561948371	Detect mixed->fixed gender incompatibility ... Calculate and compare the original encounter's gender's as well. exclude azurill gender change (only case where this can happen) by continuing the if-else. Add Snorunt-Froslass to FixedGenderFromBiGender. Thanks Davil !	2017-10-19 20:56:59 -07:00
Matt	4353f39286	Ban Sport Ball	2017-10-19 14:33:39 -04:00
Kurt	a53e8ddb7e	Fix grotto mienfoo level range ... Thanks paf!	2017-10-18 21:16:52 -07:00
Kurt	5a09cd9122	Add deferral case for gen6 magmar classic ribbon ... use "when" for easy src code Thanks Nessus!	2017-10-18 18:28:17 -07:00
Kurt	cd6dfceb9e	Update fateful/shiny lock check gen3 wc3 ... VerifyFatefulMysteryGift wasn't hitting for WC3's (g.Format == 3); simplify that branch and reintroduce the shiny check as a separate method Thanks Davil!	2017-10-18 18:18:23 -07:00
Kurt	886b2ef632	misc refactoring ... simplification / splitting, also more usum prep and other readability updates	2017-10-17 23:19:34 -07:00
Kurt	0cc60e6006	Change lookup arrays to hashsets ... faster checking (slightly negligible but using the correct data structure for the use case)	2017-10-17 22:06:07 -07:00
Kurt	a9261a1eec	Fix starly safari ball species ID ... not staravia dawg Thanks Britty!	2017-10-17 19:23:22 -07:00
Kurt	18aa7fe100	ban more safari/hidden ability pairs ... https://projectpokemon.org/home/forums/topic/41840-bug-pokemon-in-ball/?tab=comments#comment-221383	2017-10-17 09:08:48 -07:00
Kurt	4d91aad876	Flag gen2 egg moves when transferred from gen1 ... move must be removed 2->1 so cannot be permitted as egg move. remove unreachable code (ParseMovesRelearn only is called for Generation >= 6, and thus Format != 2).	2017-10-16 17:24:19 -07:00
Kurt	e744dcc340	Add OT too short check ... apparently some people can be this oblivious	2017-10-15 18:11:20 -07:00
Kurt	0120263bd3	Cute Charm gender ratio changing edge case ... Thanks @Admiral-Fish !	2017-10-12 23:18:43 -07:00
Kurt	02c06d154b	Split item cap for usum prep	2017-10-10 19:30:55 -07:00
Kurt	b63e444e15	Add hatch location check for static egg gifts ... to match mysterygift check	2017-10-08 14:48:35 -07:00
Kurt	4b135902f3	Allow EV yields for gen1/2 untrained ... abusing daycare https://projectpokemon.org/home/forums/topic/41788-pk2-gets-dinged-for-having-too-many-evs-at-starting-levelxp/	2017-10-07 08:23:05 -07:00
Kurt	c7dfc3d9b0	Cleanup ... union / count usages remove unnecessary stuff	2017-10-06 21:03:23 -07:00
Kurt	a816f4cea6	Misc event egg tweaks ... Thanks Kirzi!	2017-10-05 23:13:48 -07:00