Kurt
2ed003d668
Check legality parse before checking relearn result
...
closes #1904
2018-04-21 16:42:45 -07:00
Kurt
79f1c780f9
Update ownership sort for better not-mine grouping
...
After the current save's originated pkms, sort by OT name/gender/ID to
group them together rather than leaving them unsorted.
2018-04-21 16:32:47 -07:00
Kurt
df75543f2a
Implement pkm sort option control
...
right click the box tab
* no longer silly key-combos to initiate a clear/sort
* provides multiple sorting options
Advanced sorting includes:
* Recieved Date
* Friendship usage (using it raises friendship, more used pkm will be
sorted to the top)
* Ownership (current SAV's first, then by other OTs)
2018-04-21 16:31:41 -07:00
Kurt
488b5215a7
add optional sort param
2018-04-21 15:07:58 -07:00
Kurt
e91cb806e5
Extract extension->prefer format method
...
fails for 'pkx' (returned 8 instead of 6); establish standard behavior
2018-04-21 14:38:18 -07:00
Kurt
7a245278ea
Relocate mg description parse to core
2018-04-21 09:55:27 -07:00
Kurt
cb930fcaab
Show g7 tid on mystery gifts originating from g7+
2018-04-21 09:18:53 -07:00
Kurt
0b62ab85a1
Nature -> byte instead of int
2018-04-21 09:18:53 -07:00
Chromaryu
ecf191e0e6
Improve ja translation ( #1903 )
2018-04-21 08:37:32 -07:00
smileynation
d0e60b44e0
Update LegalityCheckStrings_ja.txt ( #1902 )
...
Minor fixes.
2018-04-20 09:20:30 -07:00
Kurt
cee43a3c4b
Fix translating non-translatables
...
addnew adds a key when not found in original translation, which results
in translating to the old value when flipping back to that language. can
result in invalid values if the control is used as any data display (ie
Gender label)
https://projectpokemon.org/home/forums/topic/44926-when-i-changed-the-language-a-bug-about-gender-occurred/
2018-04-19 15:36:43 -07:00
smileynation
5b524188cd
Update LegalityCheckStrings_ja.txt ( #1901 )
...
I translated the main error message.
2018-04-19 05:58:28 -07:00
smileynation
6d2153a39c
Update lang_ja.txt ( #1900 )
2018-04-19 05:57:51 -07:00
Kurt
159928b09b
Remove soaring as valid egg hatch loc
...
hatch ctr doesn't update (steps don't count while soaring)
https://projectpokemon.org/home/forums/topic/44854-is-it-possible-to-hatch-an-egg-while-soaring-in-the-sky/?tab=comments#comment-229931
could probably rename the hashset to indicate that it's only used for
egg hatch locations...
2018-04-18 16:01:12 -07:00
Kurt
c3494c61c1
Fix encountertime comparison for surf mons
...
surf does not have another slot set; so they were all being set to
Morning.
Could have set all 3 time flags, but kept as 'any'.
will update release binaries with this one
2018-04-18 15:58:21 -07:00
Kurt
7cbd0e5d10
Update 18.04.18
...
Update event binaries with latest from the Event Gallery
2018-04-17 20:53:13 -07:00
Kurt
353978df59
Add fixed ability pcd valid bypass
...
https://projectpokemon.org/home/forums/topic/44834-bugabout-event-evolution/
2018-04-17 20:48:14 -07:00
Kurt
a48c70ccf2
Add evolution minbound check
...
https://projectpokemon.org/home/forums/topic/44834-bugabout-event-evolution/?do=findComment&comment=229887
(espeon at level 50 originating from a level 50 eevee gift is not valid)
2018-04-17 20:06:23 -07:00
Kurt
fef1d6e0dd
de-linq some evolution dexlevel fetch
...
use shared IList interface instead of IEnumerable
2018-04-17 19:56:43 -07:00
Kurt
a34be35d9f
Add commit contents for previous commit
...
removal of some linq, reorders as described by previous commit
2018-04-17 19:50:25 -07:00
Kurt
8250bc58cd
Fix levelup->evo fetching of next levelup move
...
Correctly fixes #1163 (test cases added), eg wooper->quagsire would
learn yawn at 31 before evolving; the getmoves wouldn't provide yawn
(stopped at 30) with the old code; the lvl decrement was removed in the
incorrect commit, providing a legal verdict which was obtained
incorrectly (dexlevels were inaccurate)
2018-04-17 19:49:33 -07:00
Kurt
f767b2db0f
Differentiate WasEgg (any egg location) from bred
...
https://projectpokemon.org/home/forums/topic/44838-buggen5-egg/
WasEgg is used for other encounter based checks, so can't reduce the
logic usage
2018-04-17 18:54:38 -07:00
Kurt
bb03505144
Better handle g2 unown form changing
...
Closes #1897
2018-04-16 16:01:30 -07:00
Kurt
86333c6db6
Flag VC transfer affection
...
contest check only applies for 3->7 not 1/2->7
https://projectpokemon.org/home/forums/topic/44674-bug-about-contests-ribbon/?do=findComment&comment=229785
Thanks Davil!
2018-04-14 21:36:11 -07:00
Kurt
6db0b673db
Handle ??? type gen4 arceus form check
...
interstitial between steel & fire, shift the form value up by 1 if
applicable
https://projectpokemon.org/home/forums/topic/44806-arceus-not-legal/?tab=comments#comment-229774
2018-04-14 18:20:58 -07:00
Kurt
7a77b4524f
Add b2w2 route 23 amoonguss
...
https://projectpokemon.org/home/forums/topic/44798-bug-report-amoonguss-encount-error-b2w2/
Thanks smileynation!
2018-04-14 08:47:02 -07:00
Kurt
8cfd64df63
Add affection contest check for pre gen6 events
...
https://projectpokemon.org/home/forums/topic/44674-bug-about-contests-ribbon/?do=findComment&comment=229739
2018-04-13 18:52:38 -07:00
Kurt
6b387f9037
Handle alolan species transfer form check
...
https://projectpokemon.org/home/forums/topic/44718-bugabout-xd-alola-form/?do=findComment&comment=229735
2018-04-13 18:44:16 -07:00
Kurt
78f533605c
Handle untranslated Italian LeafGreen Jynx trade
...
lul nice translating team u got there, would be a shame if they forget
to translate something ;) /s
Thanks cicciochiave!
2018-04-12 21:22:04 -07:00
Kurt
6a93a7e435
Fix kor2 string truncation
...
Closes #1896 , thanks @Narithegreat !
2018-04-11 17:06:13 -07:00
Kurt
7c1f163140
Fix gen4 (and 3 by usage) ’ ' apostrophe -> data
...
’ is aliased to ' for cleaner display to user; there's no usages of this
method beside gen3/4 strings.
fix early truncation of gen3 strings (don't put terminator on prior
valid char)
https://projectpokemon.org/home/forums/topic/44777-some-little-bug-in-emerald-leafgreen-and-blue-vc/
Thanks cicciochiave!
2018-04-11 16:51:33 -07:00
Kurt
b1cb5226f7
Fix b2w2 tutor reads
...
yikes what a typo
Closes #1895
2018-04-10 17:36:54 -07:00
Kurt
b8a5ccdf7d
Simplify shedinja evo move check
...
Closes #1895 , re-verified with pkm provided in #1805
there's no shedinja gift, always is an evolution
seal some forms to remove virt call in constructor warning
2018-04-10 17:00:28 -07:00
Kurt
508f056d33
Clear move pp on move deletion
...
closes #1894
2018-04-09 06:10:26 -07:00
Kurt
335379bd2e
Remove unneeded string
...
#1893
2018-04-08 17:54:09 -07:00
wwwwwwzx
27f33a6719
Update Chinese translations ( #1893 )
...
* Update Chinese translations
* Sync missing change
2018-04-08 17:51:06 -07:00
Egzon Qukovci Jusufi
e39269484c
Translated to spanish some of the lines (from 1 to 160) of MessageStrings ( #1892 )
2018-04-08 11:21:04 -07:00
Kurt
6ac8ed0098
Update translations
...
all supported langs now have all 3 translatable resources; translate
away!
2018-04-08 09:19:19 -07:00
smileynation
e7721f10ef
Update lang_ja.txt ( #1890 )
2018-04-07 22:29:19 -07:00
smileynation
bd78a9a3e4
Update text_Forms_ja.txt ( #1891 )
2018-04-07 22:29:10 -07:00
Kurt
7ef8a88678
Add 2 spaces to jynx OT trade name
...
lol nice error, translators
2018-04-07 16:25:52 -07:00
Kurt
be285917b9
Update ingame trade data
...
https://projectpokemon.org/home/forums/topic/44726-bug-in-game-trader-pokemon-flagged-illegal/
Thanks Jimmy Cerno!
2018-04-07 12:34:06 -07:00
Kurt
420efb72bb
Misc refactoring
...
use common edits to set pp
2018-04-07 11:40:01 -07:00
Kurt
9d3f7250a5
Clamp language values
...
pk3->pk4 threw errors
https://projectpokemon.org/home/forums/topic/44719-about-channel-jirachi/
should probably work that logic into a more generic getsafelanguage
2018-04-06 23:37:24 -07:00
Kurt
1f9f8c97f1
length check language & trash byte source
...
https://projectpokemon.org/home/forums/topic/44719-about-channel-jirachi/
future/invalid language values are out of range
fixes the symptom but not the root cause (permitting out of range
languages when generating a wc3->pk3).
2018-04-06 23:36:13 -07:00
Kurt
2acef4eaf7
Add messagestring dumper
...
untested, will monkey with later
2018-04-06 22:51:10 -07:00
Kurt
41653490c1
add better legality string file updater
...
may want to make the export location smarter so that they dump back to
the compiled resource location, meh
assume that english is already loaded; restore english before next so
that new languages use english as the base language for untranslated
strings
2018-04-06 22:06:15 -07:00
Kurt
caa32c1516
Add alolan evo species check
...
can't change to a local variant form if it was originally obtained as a
non-variant form (no evolutions!)
2018-04-06 21:46:27 -07:00
Kurt
51612b8977
Add custom sort via passed func params
2018-04-06 21:33:25 -07:00
Kurt
1d4e815689
Extract more mesage strings
...
all common strings in forms used by multiple generations
would rather rework the individual generation strings to be unnecessary
with better interaction instead (if possible), as translating hundreds
of limited exposure strings is a drag.
2018-04-06 21:23:09 -07:00
