Commit graph

3059 commits

Author SHA1 Message Date
Michael Scire
792f7ce04c WIP PK1 -> PK7 Transfers.
Still needs language/3ds country region
and memories, because I'm not sure how
to do those in the void of a save file
context.
2017-01-25 03:29:38 -08:00
Michael Scire
038fe4c3fc Additional 6->7 accuracy 2017-01-25 00:36:00 -08:00
Michael Scire
fbafbba0b1 Make 6->7 transfers (mostly) bank accurate. 2017-01-25 00:28:16 -08:00
Kurt
b37cb77b74 Remove string conversion 6->7
good, but bad job gf
#734
2017-01-24 23:50:06 -08:00
Kurt
1be7ecafce Add incorrect transfer check
Flags pk6->pk7 imports that were not converted (no data changes)
2017-01-24 23:34:50 -08:00
Kurt
7797af4baa Add gen6->gen7 transfer skeleton
Ingame font changed the order of the faces as noted in #734, this is
just temp until someone tests.

Check old ability & force to new if valid

I bet the transfer method doesn't touch the chars (screwing up faces),
so it can be removed if proven.
2017-01-24 23:09:34 -08:00
Kurt
2cff51be61 Remove pre-bank specific checks 2017-01-24 22:55:51 -08:00
Kurt
0a19b8b59b Split gen1/2 shininess
an attempt was made
2017-01-24 21:28:29 -08:00
Kurt
eebf3fbac3 Add gen1 shininess editing
Since it's the same as gen2's checks, and gen1->7 is now possible...
2017-01-24 21:01:32 -08:00
Kurt
608c570352 Add more trainer stats
Thanks Holla!
2017-01-24 19:50:35 -08:00
Kurt
4cdb6a9271 Add Poké Pelago ball check
Thanks Holla!
2017-01-24 19:49:40 -08:00
Evan Dixon
92d59fc3b5 Merge pull request #736 from kwsch/b/case-sensitivity
Fixed case sensitivity
2017-01-24 10:29:43 -06:00
Evan Dixon
1fd174bb04 Fixed case sensitivity 2017-01-24 10:26:13 -06:00
Michael Scire
5a23fda752 Add support for VC/Horohoro game ID markings 2017-01-24 07:12:14 -08:00
Kurt
bcb5f5f2bb Minor cleanup
extrabytes setting moved to another method, fixes all resharper problems
2017-01-22 23:05:54 -08:00
Kurt
ddac932419 Remove unnecessary line
What was I thinking? Oh, copy-pasted.
2017-01-21 12:10:35 -08:00
Kurt
52bd66f1ff Add DP gift active flags
Only for DP
active = !(gift data is all zero);
Thanks @BernardoGiordano !
#730
2017-01-21 12:09:15 -08:00
Kurt
615526e9a1 Fix PCD clearing
PCD/PGT have nested objects that do not update when the Data array is
updated.
Solve the problem by adding get/set to those properties.
#730
2017-01-20 21:43:59 -08:00
Kurt
2ab175db6e improve pcd<->pgt matching
Hotfix wasn't appropriate: check bytes 0 & 1 in addition to 3+, add
bounds checking
2017-01-20 20:59:50 -08:00
Kurt
f0a570d132 Update cardmatch logic
oops, linq goof
#730
2017-01-20 20:48:04 -08:00
Kurt
eaa233bdd8 gen4 wondercard updates continued
Don't set Slot to 3 for an empty slot
Move slot check comparison to PCD class
Allow PCD->PGT 'swap' override to just set the slot
Update alert message to indicate source type first

#730
2017-01-20 19:35:56 -08:00
Kurt
4f99ef6c09 Set Slot id to 3 if no pcd found
Closes #730
Adds ability to set a PCD to a PGT slot (grabs the PGT from card)
2017-01-20 08:43:44 -08:00
Kaphotics
492a29e950 Merge pull request #731 from BernardoGiordano/patch-1
Fix HGSS checksum offset
2017-01-20 08:20:57 -08:00
Bernardo Giordano
0ddce7f39a Fix HGSS checksum offset
0x12300 is the length, not the end offset. 0x21A00 = 0xF700 + 0x12300
2017-01-20 14:41:15 +01:00
Kurt
63c0eed953 Reassign pgt slot# on save
If a corresponding PCD is not found, the default value of 0 is not
modified.
#730
2017-01-19 23:49:46 -08:00
Kurt
088f9a9aa7 Gen7 update
Never added wc7 extensions; drag&drop use MysteryGift extension instead
of hardcoded .wc6
2017-01-19 23:48:31 -08:00
Kurt
be357a21e0 Increase fr/lg pouch max limit
95->995
#730
2017-01-19 08:42:26 -08:00
Kurt
ed52aa31e1 Fix set import shortly after starting program
CB_Form is not yet initialized with items, do a little sanity checking
before setting index to 0.
Closes #729
2017-01-18 23:18:14 -08:00
Kurt
e13b473979 Enable poke finder camera version changing
Closes #727
2017-01-18 20:01:58 -08:00
Kurt
5fba241576 Add rsbox save renaming to class
Previously ignored the box name input
2017-01-18 19:57:42 -08:00
Kurt
aa0c95dd90 Fix gen4 checksum saving
c[][1] is end, not length
Closes #728
2017-01-18 19:55:50 -08:00
Kurt
390eb56f8a Distinguish Z-Move Physical/Special category
move name string is revised to indicate which damage category
2017-01-17 17:37:26 -08:00
Kurt
469e0940c2 Add gen7 hall of fame editor 2017-01-16 22:40:28 -08:00
Kurt
2981f39704 Update mystery gift logic
Automatically enable mystery gift if any card is active
Flag gift availability on set, hide flag on get.
2017-01-15 16:52:10 -08:00
Kurt
2adbeed48a gen4 improvements
simplify redundant code
fix pcd writing (used wrong const)
reduce linq usage for byte[] get/set
2017-01-15 16:16:35 -08:00
Kurt
97227fdfe9 More simplification
Extrabytes index selection done in setPKMFormatMode

if (visible) is bad, why do I forget? If the control is not shown (ie
another tab) but possible to be visible it'll return false. Use enabled
instead.
2017-01-14 16:59:57 -08:00
Kurt
3f218968c5 Refactoring & fixes
Fix blank sav creation for gens 1-3 (data vs Data references, version
overrides)
Fix main form init with gen2 first (check for altform usage like all
other gens)
Use GameVersion specific blank fetch instead of generation ID
2017-01-14 16:43:16 -08:00
Kurt
12c46d18a8 Disable custom exception handling for debug mode
VS wouldn't break at the line that threw the exception; only have the
custom exception handling for release builds (ie the CI server & posted
builds).

makes it easy to debug again
2017-01-14 16:41:27 -08:00
Kurt
e321c48871 Refactoring
Add blank save creation to Core SaveUtil methods.
Simplify main form resource usage (remove redundant qualifiers)
2017-01-14 13:10:36 -08:00
Kurt
c075ff3c47 Enhance clone detection for gen1/2
Would only return unique species as PID is not used, use IV values as
unique identification.
2017-01-14 12:10:42 -08:00
Kaphotics
f0b5adcfe3 Merge pull request #720 from kwsch/b/mono-tests
Tests no longer build in Mono build configurations
2017-01-12 18:30:24 -08:00
Kurt
e83ed49eea Add gender-skin mismatch confirmation
Closes #718
2017-01-12 18:29:44 -08:00
Evan Dixon
c6867a367b Tests no longer build in Mono build configurations 2017-01-12 14:27:39 -06:00
Kurt
ddf7327bf8 Add bv7 music offset
silent bgm boolean property too
2017-01-11 22:29:30 -08:00
Kurt
f4797e06a0 More refactoring
More extension methods for other types of images
2017-01-11 22:28:35 -08:00
Kurt
db5e084ef9 Further refactoring
Move System.Drawing usage out of Core to WinForms, as System.Drawing is
not in .NET Core/Standard. Simple methods to return resource name
strings have been added instead.
2017-01-11 17:55:42 -08:00
Kurt
1d1179465a Add typo null check
Updating legality with an invalid move name causes SelectedValue to
equal null. Use the util function that has null check for combobox &
selectedvalue.
2017-01-10 20:59:31 -08:00
Kurt
c1e613280b Hide save buttons if no save has been loaded
buttons enabled by default => only show button panel if the save is
valid AND at least one enabled.
2017-01-10 20:01:33 -08:00
Kurt
29658c28f2 Fix event OT friendship check
Should compare to the original species not to the current
Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-10 17:14:48 -08:00
Kurt
130807c698 Add duplicate relearn move check
Same duplication check as moves
Closes #709
2017-01-09 22:51:11 -08:00