Kurt
63242cc24d
Reorder open folder logic
...
Close() still finished executing the method
Closes #2076
2018-07-25 07:26:29 -07:00
Kurt
f0090669bb
Update catch rate related logic
...
#2071
2018-07-24 19:33:42 -07:00
Kurt
c7e7011116
Fix qr crash
...
order of operations idk
2018-07-24 17:18:19 -07:00
Kurt
279f44a645
Simplify GB stat calc, fix pk2->pk1 xfer fainting
...
Remove unnecessary floor operation, don't fetch stat arrays for each
stat
Current HP is a box stat in pk1 format (offset 0x1), which isn't stored
in box pk2's. If the hp is zero, set it to the current HP.
Thanks HaxAras for the conversion tip!
2018-07-24 16:41:18 -07:00
Kurt
3294805380
Update translations
...
Translatable about menu, translatable PKMConverter strings
2018-07-24 15:50:00 -07:00
Kurt
64284eafef
Add pk1/pk2 direct import checks
...
dragdrop: check
import files from folder: check
no other paths convert afaik
Closes #2074
2018-07-24 15:49:00 -07:00
Kurt
81355dfaf4
Update translatables for pkm conversion
2018-07-24 15:36:46 -07:00
Kurt
1943ca37f6
Double check plugin path
...
with MERGED, can enter without having the folder exist
just double check rather than adding more conditional code
2018-07-23 21:47:31 -07:00
Kurt
b59ebb3002
Allow plugins to be activated if merged flag set
...
reduce some nesting
2018-07-23 21:36:26 -07:00
Kurt
8cb82560f6
sync unsaved
...
this closes #2068 , not the prior commit
2018-07-23 19:27:00 -07:00
Archit Date
e52838df37
glow setting ( #2073 )
...
* add PKM glow setting
* change setting name for consistency
2018-07-23 19:25:54 -07:00
Kurt
d685fec327
Sanity check listbox formes
...
SM does not have dex flags for totem forms, but pkhex now provides them
in the form dropdown
Closes #2068 thanks @iiippppk !
2018-07-23 19:15:54 -07:00
Kurt
d6f623ecfb
Fix #2072
...
Just a guess; don't dispose of the bitmaps
suspected race where two beginhovers happen and one cancels the other
2018-07-23 18:31:01 -07:00
Kurt
68d251f89c
Pass -1 for party/battlebox slot arg
...
Sprite creation uses slot>=0 for determining if it's in a box or not;
kinda should redo the logic but there's no upside to passing 0-6 to the
sprite generator for these.
Closes #2069 thanks @iiippppk !
2018-07-23 16:45:47 -07:00
Kurt
922cbdf583
Add glow animation to slothover
2018-07-22 20:04:28 -07:00
Kurt
3c4ba0d52b
Misc cleanup
2018-07-22 17:26:19 -07:00
Kurt
b97e967304
Misc cleanup
2018-07-22 17:14:22 -07:00
Kurt
1e932e14e9
Add custom path popup button
...
autofills with current contents if none found
2018-07-22 14:27:48 -07:00
Kurt
a693ba87ba
Update cosplay sprite handling
...
Cosplay are stuck on gen6, cap pikachu can interact with bank; make
Cosplay the oddball resource.
2018-07-22 12:06:43 -07:00
Kurt
c9408e6af4
Misc clean
2018-07-22 12:00:03 -07:00
Kurt
abe6ef1be3
Move ribbon verifiers to appropriate folder
...
no functional change
2018-07-22 11:50:11 -07:00
Kurt
2675130cba
Fix venonat sprite (glow)
...
#2066
2018-07-22 11:42:59 -07:00
Kurt
f62902ba66
USUM sprites: Zero out transparent sprite pixels
...
Closes #2066
Refer to issue comments for silly fix script
2018-07-22 10:00:32 -07:00
Kurt
e1365c837c
Glow sprite edges
...
Continue using the hover frost effect on the edges too
doesn't really play well with the colorized slot image since it's 1px,
whatever.
2018-07-21 21:55:37 -07:00
Kurt
da839988af
Simplify RBY checksum calc
...
utilize unchecked byte overflow
remove unnecessary zeroing -- t's immediately after the checksummed
region. even if it was included, chk += 0 is still 0.
2018-07-21 19:24:09 -07:00
Kurt
0c5c9bc33c
Misc clean / xmldoc updates
...
remove unused label in QR (use window Font)
escape & -> & for xmldoc proper style
2018-07-21 19:20:11 -07:00
Kurt
1c49b0681d
Extract dex logic
2018-07-21 11:46:38 -07:00
Kurt
3510d72fef
Fix legal/illegal qr image sizing
2018-07-21 10:42:23 -07:00
Kurt
2d472f11e6
Allow "About" form to be translated
...
use tabcontrol instead of toggling buttons
2018-07-21 10:35:01 -07:00
Kurt
63b9b72a49
Relocate save detection to core
...
Environment.GetLogicalDrives is not present in net standard 1.3;
relocate code and add it as a parameter
2018-07-21 10:23:15 -07:00
Kurt
0c632604d2
Move files
...
Saves now has a similar folder structure to PKM
2018-07-20 21:33:55 -07:00
Kurt
c7175fbdb4
Misc reorg
...
bye bye SAVUtil and PKMUtil
2018-07-20 21:32:33 -07:00
Kurt
f27f11bfc8
Clean up pk7/sav6/sav7 simple methods
...
extract GetFormDuration to method, remove unused GetIsCompatible
specialized variant (there's a generalized version in SAVUtil.cs,
IsPKMCompatible -- might do another round of WinForms->Core absorption
2018-07-20 20:25:28 -07:00
Kurt
4b0a2d90b9
Add xmldoc
2018-07-20 20:22:46 -07:00
Kurt
c9abeda508
Update stadium check again
...
#2065
2018-07-20 05:57:57 -07:00
Kurt
1ff8ebf777
Misc overload add/use
...
Some values are already computed; pass them in to overloads for quicker
execution
2018-07-19 19:38:44 -07:00
Kurt
614d2629ce
Remove unnecessary ref passing
...
object is already passed byref, don't need to repoint the reference
2018-07-19 18:09:37 -07:00
Kurt
229dc96c00
Safe convert current level
...
Dry startup can cause a crash if the field is somehow not filled in:
https://projectpokemon.org/home/forums/topic/46313-pkhex-ver-180716-wont-run/
2018-07-19 16:46:56 -07:00
Kurt
9a91619580
Update vc1 invalid transfer pruning
...
Closes #2065 Thanks @WEERSOQUEER !
Single evo species weren't getting flagged in the evolution verification
as they early returned (species matched), just move the sanity check
before that
2018-07-19 16:42:45 -07:00
Kurt
69e7d49d03
Simplify Stadium OT Check
...
TID is always 2000 : #2065
2018-07-19 15:54:34 -07:00
Kurt
33637836f2
Ignore detected saves when displaying backups
2018-07-18 21:26:18 -07:00
Kurt
e5d95bf178
Display autodetected path location better
...
Autodetect location not stored in a button path will show up as "???";
check the typical homebrew autodetect paths, then display the parent
folder
eg, Path.Combine(root, "3ds", "Checkpoint", "saves");
shave off "saves" to return X:\3ds\Checkpoint
add range checks to label translation
2018-07-18 19:32:57 -07:00
Kurt
c69b50daae
Reload savefile from disk when loaded from folder
...
Folderlist stores savefile objects, can open A, edit A, open B, open A,
and all edits from prior are still there. Just re-open the save file
from disk. The folderlist already checks if the path exists prior to
calling it to reopen.
2018-07-18 17:33:03 -07:00
Kurt
ff4ca47ebe
Remove GBEncounterData boxing
...
Interfaces implement enough detail, so can simplify
extract local methods (likely will be inlined)
less obj allocations = faster!
2018-07-18 16:37:21 -07:00
Kurt
1c75093e27
Specify altform for ranch shellos
...
1 not 0
https://projectpokemon.org/home/files/file/336-shellos/?do=findComment&comment=1290&tab=comments
2018-07-18 07:15:46 -07:00
Kurt
e1b983bc59
Fix auto-detect save file on load
...
introduced in
99673706a0https://projectpokemon.org/home/forums/topic/46293-not-reading-card/
2018-07-17 21:26:25 -07:00
Kurt
01c4ca348f
Allow FolderList to be translated
2018-07-17 21:02:01 -07:00
Kurt
170390b49d
Add datagrid filtering for folderlist view
...
can be a little silly if the tab hasn't been viewed yet, but works fine
2018-07-17 20:52:08 -07:00
Kurt
a100488142
add gen12 generator kadabra catch rate case
...
https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/
Thanks Cloud AC !
update misc verifier for catchrate to better indicate for
any->nontradeback scenarios
2018-07-17 16:54:23 -07:00
Kurt
fe7fea877b
Replace boolean OrderBy with DeferBy
...
orderby consumes the entire input enumerable in 'sorting' the list;
since we don't care about the order besides a yes/no, just manage the
yield order ourselves.
don't bother using this method more than the spot it's in; was a fun
exercise but other spots are set up for easier debugging
(overall flow is where->deferby->yield), could make things easier to
read but meh
2018-07-17 16:28:42 -07:00
