Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2025-02-25 11:57:10 +00:00
Code Issues Projects Releases Packages Wiki Activity
5215 commits 2 branches 77 tags 118 MiB
Commit graph

902 commits

Author SHA1 Message Date
Kurt
e8552affca More gb restriction relocations 2018-10-10 16:32:02 -07:00
Kurt
2db8daa07b Add specified ability no-hidden check 
ability=0 allowed abil1/2 but not 4; catch that scenario
 2018-10-10 16:31:40 -07:00
Kurt
2ad103dd46 Extract gb specific core logic to separate class 2018-10-09 21:07:13 -07:00
Kurt
0a62506e11 Micro optimization 
wow such use
length eq to max will always pass
 2018-10-09 19:28:18 -07:00
Kurt
b481358e92 Add number count check for OT/nick 
https://projectpokemon.org/home/forums/topic/47850-legality-issue-names-with-multiple-numbers/
let me know if there's any implications for transferred content (name
reset on 1-3=>n?)
 2018-10-08 17:57:34 -07:00
Kurt
47f20b8c0e Update fixed ability comparison for 6+ 
4aa44c90c1 only updated it for gens 3-5
Closes #2136
 2018-10-08 15:26:43 -07:00
Kurt
f65bc2e984 Reduce allocations for gen1 move parse 
use shared interfaces
 2018-10-07 15:36:32 -07:00
Kurt
4aa44c90c1 Update fixed ability comparison 
ignores <= 0 now
 2018-10-07 15:36:04 -07:00
Kurt
fd1009476e Minor logic simplifications 
reduce size of encountermoves, split into separate object
only execute gb movedata adjustments for gb
 2018-10-06 19:44:50 -07:00
Kurt
4deb5080d1 Misc tweaks 
rearrange getmove with respect to tutors; verifycurrentmoves was getting
tutor moves in levelup
extract not-found hint fetch
Expose gen5 block objects (so I can play with saves in linqpad)
 2018-10-06 18:45:15 -07:00
Kurt
dc839333b7 Add more parse settings 
allows consumers to tweak debatable settings
 2018-10-06 13:43:05 -07:00
Kurt
66faa43e03 Add gen6+ fixed ability hot path 
Closes #2135
 2018-10-06 11:24:46 -07:00
Kurt
f507ab7081 Misc parse settings reorg 
makes it more centralized for defining parsing settings, maybe can have
flags to change severity of certain preferential checks
 2018-10-05 19:58:30 -07:00
Kurt
59af7fef35 Remove unnecessary properties 2018-10-05 19:57:45 -07:00
Kurt
ce9d3abbe4 Misc reorganization 
Move logical checks using encounter data out of Core.cs

might be possible to excise legality checking objects from
Legal/PKHeX.Core so that a 'slimmer' core can be made
 2018-10-04 18:52:00 -07:00
Kurt
03a05364ab Update colo suicune ++ 
location ID was originally added by:

afde4514e2 (diff-83a32d69355a64376bc77bd07e338a33R446)

I
have another save file that uses met location 110 (like this one) so I
assume it was originally a copypaste error from Sudowoodo.

Change Trade strings to not allocate separate empty arrays.
 2018-10-04 08:14:53 -07:00
Kurt
4bbb1f54b9 Change burned tower suicune encounter type 
was initially set by this commit

0e3815b048

field test resulted in Cave/HoO type
https://projectpokemon.org/home/files/file/2953-burned-tower-suicune/
 2018-10-03 16:46:55 -07:00
Kurt
5d6c932353 Spit out move learn generation on verbose 
helps indicate any restrictions on learn source outside of the current
format
 2018-09-30 11:50:08 -07:00
Kurt
db30fea38c Remove gsc dodrio trade OT trailing space 
Closes #2126
Rewrite trade OT validation by using the trade's OTs property
 2018-09-19 19:09:29 -07:00
Kurt
d5816795bf Remove split gsc trade levels for tradeevo species 
#2126
Receiving a lower leveled species from GSC will evolve it away from the
required species, ruling it unavailable.
Receiving a Machoke will evolve it, so can't reuse for Haunter trade
 2018-09-19 19:08:10 -07:00
Kurt
65272d460a stricter mysterygift references 
results in:
- precomputed GetTable() reference
- no casting when iterating for matches
- no db null checks, as they are initally Array.Empty<T>();

reduces noise a little & slightly faster
 2018-09-15 16:22:07 -07:00
Kurt
df321d14b5 Reorder checks 
most common path is now first
 2018-09-15 16:13:17 -07:00
Kurt
b280ffcfef style updates 
should be pretty much it
 2018-09-14 22:37:47 -07:00
Matt
165757d590 Fix Meteorite/Mega Cuff mixup (#2120) 
Meteorite (2) is legal, Mega Cuff is not.
 2018-09-12 22:10:13 -07:00
Kurt
ff25e3cbd0 Remove illegal items from legal key items 2018-09-12 21:52:09 -07:00
Kurt
d511fccdb4 Move basement key item ID to illegal group 
no functional change, item is unobtainable but still can be 'give all'
and in permitted list
 2018-09-12 21:30:24 -07:00
Matt
fc91819410 Add XY Magikarp trade IVs (#2117) 
* Add XY Magikarp trade IVs

* Add Cosplay Pikachu IVs
 2018-09-12 11:02:11 -07:00
Kurt
0c02a0cbbc Add splitbreed mantine to pastgen alolanoffspring 
thanks kr, beast ball now recognized as legal
 2018-09-09 17:19:50 -07:00
Kurt
f444c41ee3 Remove nick req on g5 gigalith trade 
Closes #2114
 2018-09-08 10:45:30 -07:00
Kurt
d02b87a7b2 Expose checkresult properties 
can now check individual strings / identifiers in a LegalityAnalysis
object by:

var la = new LegalityAnalysis(pkm);
var parse = la.Info.Parse;
if (parse.Any(z => ReferenceEquals(z.Comment, LegalityCheckStrings.X))
...
should be faster than doing string.Contains
 2018-09-05 21:27:52 -07:00
Kurt
1750c69b01 Update pcd version distro check 
some events have fixed version IDs in the gift data

https://projectpokemon.org/home/forums/topic/47365-vgc-shiny-milotic-usa-pkhex/
 2018-09-05 16:09:30 -07:00
Kurt
cc20bb38d7 misc updates 
use arrays instead of list when capacity known
use enums for const decoration
remove unnecessary aliases
 2018-09-01 19:55:08 -07:00
Kurt
91c37ab573 Update legality check message string style 
V### names weren't enjoyable to work with; use similar verbose style as
the program message strings.

updating the translation files with the remapped variable names shortly

remap list: https://pastebin.com/jybkVDAK
 2018-09-01 14:11:12 -07:00
Kurt
1fe304e78f Rework mg nick/lang checks 
add common interface

https://projectpokemon.org/home/forums/topic/47295-bug-event-golduck-name-not-matching-species/
 2018-08-30 18:09:52 -07:00
Kurt
c6e4c39bc5 Fix gen1 single chain for gen2 tradeback scenario 
invalid mon -> make sure array is big enough for later move parsing

https://projectpokemon.org/home/forums/topic/47283-unhandled-exception-when-importing-set-from-clipboard-after-opening-gen-i-save-file/
 2018-08-29 21:58:44 -07:00
Kurt
ebae14e6ad Add unnicknamed forced languageID wc7 handling 
https://projectpokemon.org/home/forums/topic/47295-bug-event-golduck-name-not-matching-species/
another edge case
 2018-08-29 20:36:32 -07:00
Kurt
f89d9ca323 Split apart headbutt tree logic 
precompute Index & make readonly when initializing as we use Index at
least once when initializing the treesarea
 2018-08-28 15:10:08 -07:00
Kurt
f74c1e321a no mo go to yo 
pull goto default into 'when' so other cases continue to default

this is a goto free codebase ( ͡° ͜ʖ ͡°)
 2018-08-27 20:48:57 -07:00
Kurt
4dc04cb4b9 Add pelago status value check + etc 
0, [9,19] are set (didn't see 15), but there's also a switch case which
references all values 0-19.

these values are used by a 80 sbyte array (4*20) in the Resort.cro

remove usages of "goto case"
 2018-08-27 20:44:26 -07:00
Kurt
102430ebf5 Update trade nickname check 
reorder for simplicity, add test
Thanks ThePunish3D!
 2018-08-26 18:32:39 -07:00
Kurt
4656909d98 Misc reorg 
use shared class for pk1/2 setnotnicknamed
fix extendedeurope values (copypaste from extendedAmericas)
move ball out of verifiers, move nature/movetype with ball
 2018-08-26 16:29:52 -07:00
Kurt
f7b5a5579d sync missing content 
yay rename
 2018-08-26 11:29:47 -07:00
Kurt
7f87d43c41 Add enum for ball; use in checks 
Increases readability instead of using hex IDs
 2018-08-26 11:15:32 -07:00
Kurt
6a225ad091 Add mr mime to usum additions for egg balls 2018-08-26 09:43:11 -07:00
Kurt
a9f65a4617 add lock for cross thread dictionary manip 
could use concurrentdictionary but after reading some perf drawbacks vs
manual locks, just do it manually. regex checking is the real slow part,
whatever
add some comments to describe
 2018-08-25 10:48:37 -07:00
Kurt
5fe9226c62 Ignore fixed language trades for gen4 korean check 
Closes #2103
Thanks @Narithegreat !
 2018-08-22 22:36:56 -07:00
Kurt
7ccaf8783b Unban bred HA sableye 
yeah totally genderless

https://projectpokemon.org/home/forums/topic/47101-gen-v-hidden-ability-sableye/
 2018-08-20 20:08:42 -07:00
Kurt
d7f39ea343 Extract pkm searching to separate classes 
search logic can now be reused by core projects

adds option to provide extra filters run at the end (prior to clone
check)
 2018-08-16 20:06:40 -07:00
Kurt
eec14645ef Lessen string length severity on egg encounters 
Hatched eggs can have mismatched languages<->OT/Nick restrictions
 2018-08-15 15:26:42 -07:00
Kurt
5514530dfb update OT name edge case 
traded ENG->KOR egg was getting flagged
#2094
 2018-08-15 15:19:54 -07:00