Kurt
279f44a645
Simplify GB stat calc, fix pk2->pk1 xfer fainting
...
Remove unnecessary floor operation, don't fetch stat arrays for each
stat
Current HP is a box stat in pk1 format (offset 0x1), which isn't stored
in box pk2's. If the hp is zero, set it to the current HP.
Thanks HaxAras for the conversion tip!
2018-07-24 16:41:18 -07:00
Kurt
3294805380
Update translations
...
Translatable about menu, translatable PKMConverter strings
2018-07-24 15:50:00 -07:00
Kurt
64284eafef
Add pk1/pk2 direct import checks
...
dragdrop: check
import files from folder: check
no other paths convert afaik
Closes #2074
2018-07-24 15:49:00 -07:00
Kurt
81355dfaf4
Update translatables for pkm conversion
2018-07-24 15:36:46 -07:00
Archit Date
e52838df37
glow setting ( #2073 )
...
* add PKM glow setting
* change setting name for consistency
2018-07-23 19:25:54 -07:00
Kurt
3c4ba0d52b
Misc cleanup
2018-07-22 17:26:19 -07:00
Kurt
b97e967304
Misc cleanup
2018-07-22 17:14:22 -07:00
Kurt
a693ba87ba
Update cosplay sprite handling
...
Cosplay are stuck on gen6, cap pikachu can interact with bank; make
Cosplay the oddball resource.
2018-07-22 12:06:43 -07:00
Kurt
c9408e6af4
Misc clean
2018-07-22 12:00:03 -07:00
Kurt
abe6ef1be3
Move ribbon verifiers to appropriate folder
...
no functional change
2018-07-22 11:50:11 -07:00
Kurt
da839988af
Simplify RBY checksum calc
...
utilize unchecked byte overflow
remove unnecessary zeroing -- t's immediately after the checksummed
region. even if it was included, chk += 0 is still 0.
2018-07-21 19:24:09 -07:00
Kurt
0c5c9bc33c
Misc clean / xmldoc updates
...
remove unused label in QR (use window Font)
escape & -> & for xmldoc proper style
2018-07-21 19:20:11 -07:00
Kurt
1c49b0681d
Extract dex logic
2018-07-21 11:46:38 -07:00
Kurt
63b9b72a49
Relocate save detection to core
...
Environment.GetLogicalDrives is not present in net standard 1.3;
relocate code and add it as a parameter
2018-07-21 10:23:15 -07:00
Kurt
0c632604d2
Move files
...
Saves now has a similar folder structure to PKM
2018-07-20 21:33:55 -07:00
Kurt
c7175fbdb4
Misc reorg
...
bye bye SAVUtil and PKMUtil
2018-07-20 21:32:33 -07:00
Kurt
f27f11bfc8
Clean up pk7/sav6/sav7 simple methods
...
extract GetFormDuration to method, remove unused GetIsCompatible
specialized variant (there's a generalized version in SAVUtil.cs,
IsPKMCompatible -- might do another round of WinForms->Core absorption
2018-07-20 20:25:28 -07:00
Kurt
4b0a2d90b9
Add xmldoc
2018-07-20 20:22:46 -07:00
Kurt
c9abeda508
Update stadium check again
...
#2065
2018-07-20 05:57:57 -07:00
Kurt
1ff8ebf777
Misc overload add/use
...
Some values are already computed; pass them in to overloads for quicker
execution
2018-07-19 19:38:44 -07:00
Kurt
614d2629ce
Remove unnecessary ref passing
...
object is already passed byref, don't need to repoint the reference
2018-07-19 18:09:37 -07:00
Kurt
9a91619580
Update vc1 invalid transfer pruning
...
Closes #2065 Thanks @WEERSOQUEER !
Single evo species weren't getting flagged in the evolution verification
as they early returned (species matched), just move the sanity check
before that
2018-07-19 16:42:45 -07:00
Kurt
69e7d49d03
Simplify Stadium OT Check
...
TID is always 2000 : #2065
2018-07-19 15:54:34 -07:00
Kurt
ff4ca47ebe
Remove GBEncounterData boxing
...
Interfaces implement enough detail, so can simplify
extract local methods (likely will be inlined)
less obj allocations = faster!
2018-07-18 16:37:21 -07:00
Kurt
1c75093e27
Specify altform for ranch shellos
...
1 not 0
https://projectpokemon.org/home/files/file/336-shellos/?do=findComment&comment=1290&tab=comments
2018-07-18 07:15:46 -07:00
Kurt
01c4ca348f
Allow FolderList to be translated
2018-07-17 21:02:01 -07:00
Kurt
a100488142
add gen12 generator kadabra catch rate case
...
https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/
Thanks Cloud AC !
update misc verifier for catchrate to better indicate for
any->nontradeback scenarios
2018-07-17 16:54:23 -07:00
Kurt
fe7fea877b
Replace boolean OrderBy with DeferBy
...
orderby consumes the entire input enumerable in 'sorting' the list;
since we don't care about the order besides a yes/no, just manage the
yield order ourselves.
don't bother using this method more than the spot it's in; was a fun
exercise but other spots are set up for easier debugging
(overall flow is where->deferby->yield), could make things easier to
read but meh
2018-07-17 16:28:42 -07:00
Kurt
e4aa16f396
Fill out gen5 hidden ability banlist
...
now flags gen5 contrary serperior ;)
2018-07-16 21:53:46 -07:00
Kurt
99c790a4b0
Update File name/path/folder fields
...
original file path is not saved with the two listed properties, add
FileFolder and relcoate existing FilePath functions to that field
move some GetVariantSAV usages to the string method instead of byte[]
2018-07-16 21:00:43 -07:00
Kurt
bdb5aaee36
Ignore mismatch if explicitly permitted by prior check
...
Closes #2062
2018-07-16 16:12:19 -07:00
Kurt
7ec1cab9a7
Update gen1/2 trade generator to emit gen1 if match
...
Closes #2060
2018-07-16 15:22:40 -07:00
Kurt
f51ac7d1f3
Update translations
...
Internal repositioning to match source
(auto generated changes)
2018-07-16 15:12:40 -07:00
kang1806
afca1b8145
Update MessageStrings_zh.txt ( #2063 )
2018-07-16 15:09:01 -07:00
Kurt
9a1695f319
Update 18.07.16
...
Update event binaries with latest from the Event Gallery
2018-07-15 21:44:50 -07:00
Kurt
a81c28f114
Upgrade FolderList to show recent/backups
...
sortable grid like the ReportGrid for pkm, can open/browse individual
files
2018-07-15 17:48:31 -07:00
Kurt
99673706a0
Rework recent savefile detection
...
return a reference to the savefile rather than the path, since a
SaveFile has a FilePath property.
2018-07-15 13:35:58 -07:00
Kurt
cc509de83c
Add lgpe properties
2018-07-14 21:55:45 -07:00
Kurt
0f17445ef4
Update gen3 event pidiv method check for eggs
...
closes #2057
Thanks @kamronbatman !
(nothing currently implemented uses BACD_U_S)
2018-07-14 20:19:13 -07:00
Kurt
cb80c02011
Check Yellow catchrates when updating species
...
https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/
2018-07-14 18:08:51 -07:00
Kurt
d2eba35504
Update interface parameter names
...
sync to previous
2018-07-14 18:08:30 -07:00
Kurt
6c8374f26f
Extract inner sprite building to class
...
any romhack maker can replace the behavior with their own builder
2018-07-14 17:53:37 -07:00
Kurt
6b7ba49cba
Remove unnecessary logic
...
gamestrings: call but not value used
text.cs: use gamestrings method for auto-filtered, now removes korean in
Gen3 context
2018-07-14 16:53:14 -07:00
Kurt
8c2b74c149
Refactoring
...
max IVs use flawless method directly with 6 IVs specified
move color blend/stat calc to ImageUtil
move potential string to commonedits
expose color properties for pkmeditor
don't constantly create/dispose brushes for drawing legal moves
2018-07-14 15:08:14 -07:00
Kurt
baac632218
Enable editing gen1/2 hidden power type
2018-07-14 10:56:11 -07:00
Kurt
625a77589b
Extract geolocation logic to interface
...
mixins would be nice but I guess extensions cover this
2018-07-14 10:34:34 -07:00
Kurt
7d1994dc8a
Add xmldoc for public members
2018-07-14 09:55:22 -07:00
Kurt
b039112a1d
Add gen1/2 hidden power setter calc
2018-07-13 20:30:57 -07:00
Kurt
5d20c79568
Add showdownset localization for slot previews
...
Localization only for game strings (not Ability/Nature/Stat/etc labels)
feels kinda goofy but it works
2018-07-13 19:13:25 -07:00
Kurt
83e61923f7
Add bw/2 jellicent deferral case
...
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?tab=comments#comment-233860
Thanks paf!
2018-07-13 13:48:27 -07:00
