Kurt
144a78d688
Relocate method
2019-05-29 16:42:48 -07:00
Kurt
8d781fd167
Simplify sorting to remove linq usage
...
create custom comparer to do the work
reorder some parameters
simplify gb hm set (All and FindIndex is duplicate work)
only usages of linq remaining are for the bulk action Where filtering
(ok)
2019-05-28 22:55:41 -07:00
Kurt
513648638f
Fix incompatible hax conversion (1/2->3 etc) error
...
Shared base classes throw a new snag, where the property may be Declared
in the shared class.
eg:
PKM -> _K12 -> PK2
just filter all public ones that have a setter; works well enough idk
2019-05-28 16:52:59 -07:00
Kurt
a45cddd3ed
Add missing hax item clamp early return
...
Closes #2281
remove unnecessary "else", and break for visual separation
2019-05-27 21:38:04 -07:00
Kurt
33a07a6fcd
Try and force destination language on transfer
...
Closes #2314
2019-05-27 11:23:47 -07:00
PP-theSLAYER
88d7be62d9
Removed Special Funfest Poliwag & updated min Lvl. ( #2315 )
...
According to the link below, the official page states that Poliwag's announcement was a mistake, and they clarified it would not be appearing.
This message was echoed across various pages (Sapporo, Fukuoka, Tohoku), not just the Yokohama one.
https://voice.pokemon.co.jp/stv/yokohama/2013/08/post-2286.html
Additionally, based on tests from me and jojo, Funfest missions forces the grotto encounters to be max level (of the individual grottoes).
https://projectpokemon.org/home/forums/topic/39810-unlock-all-funfiesta-missions/?do=findComment&comment=245303
2019-05-27 00:39:36 -07:00
PP-theSLAYER
968f850138
Added Funfest week 3 encounters ( #2312 )
2019-05-21 23:37:47 -07:00
Kurt
6e8f7fe680
Fix pgf gender criteria roll
...
got stuck in an infinite loop for PID (gender invalid from the start)
https://projectpokemon.org/home/forums/topic/52873-pkhex-mystery-gift-database-not-working/
2019-05-20 18:35:57 -07:00
Kurt
9b8b8f784a
Revert "Add another vc nature checks"
...
This reverts commit b51bdc9230
.
2019-05-20 17:05:53 -07:00
Kurt
52bfa50641
Simplify font loading
...
Don't care about operating system; use the AddFontFile method instead.
Add fallback for font load failure.
This should be easier to maintain in the future, if multiple char->glyph
mappings are to be supported (gen6 is already different from gen7 with
some swapped glyphs).
2019-05-19 14:37:15 -07:00
Kurt
d1bc1d07c8
Disallow shiny aura
...
if hadou were here, it'd get the same anti treatment too
2019-05-17 17:48:45 -07:00
Kurt
827eb94f3c
Add GameSync r/w for lgpe
...
https://projectpokemon.org/home/forums/topic/52797-request-lgpe-game-sync-like-value-to-be-added/
ty @PP-theSLAYER !
2019-05-16 22:26:51 -07:00
Kurt
7f9328e883
Fix vivillon comparisons
...
Fix template->pkm form fetch too; would return 0 for non-subregion
countries rather than the Country Specific form ID
https://projectpokemon.org/home/forums/topic/52800-invalid-internal-error-with-the-spewpa-evolution-line/
2019-05-16 22:01:11 -07:00
Kurt
73b61e5bf0
Add gender changed azurill evo pokewalker edge case
...
Closes #2311 , thanks @SpiredMoth !
2019-05-15 17:14:48 -07:00
Matt
25985f11e6
Fix Static/Gift IV method call ( #2310 )
2019-05-15 12:07:48 -07:00
Kurt
b7f024e3ea
Fix arceus held item compare
...
https://projectpokemon.org/home/forums/topic/52771-bug-report-pkhex-20190515-arceus-forms-error/
2019-05-15 09:46:52 -07:00
ReignOfComputer
7625ab66b4
Fix Import Count on Load Boxes ( #2308 )
...
Calculation was wrong if non-overwrite is selected. Also fixed OCD-triggering extra space in output message.
2019-05-15 09:11:48 -07:00
ReignOfComputer
7421b137eb
Fix WinForms C# 7 targeting ( #2307 )
...
* Fix WinForms C# 7 targeting
Explicitly target LangVersion 7.2.
* Fix WinForms C# 7 targeting - Part 2
2019-05-15 07:00:21 -07:00
Kurt
be8e8851e2
Update 19.05.15
2019-05-14 22:47:48 -07:00
Kurt
1d44136e54
Update xd fateful flag leniency
...
not enough documentation to know what every single flag does; just be
lenient
I assume that flags being present XK3->PK3 will set fateful, so we could
remove that logic...
Exposing bitflags for editing isn't fun for the editor, so just ignore
it behind the fateful bool get/set.
fateful required for all xk3 origin
#2289
2019-05-14 20:14:15 -07:00
Kurt
555e81205d
Update fateful encounter read location
...
Closes #2289
2019-05-14 18:36:48 -07:00
Matt
44a257b832
Make Poffin names match in-game text ( #2306 )
2019-05-14 11:21:34 -07:00
Kurt
4570c7bb21
Bump required lang version for vs17 building
...
vs19 autodetects required language, but specify this for now since
everything hasn't been migrated
2019-05-14 07:25:09 -07:00
Kurt
091b9e2281
Add g4 poffin editor (misc edits)
...
Thanks @sora10pls for docs!
https://pastebin.com/jNeVJQi0
2019-05-13 22:56:45 -07:00
Kurt
5140350ceb
Bump to net standard 2
2019-05-13 22:33:24 -07:00
Kurt
76e3174d8c
Add gen4 poffin logic
...
800 bytes starting at Offset = SAV.DP ? 0x5050 : 0x52E0;
8 bytes per poffin, 100 poffins.
2019-05-13 18:42:30 -07:00
Kurt
56eeca0cbc
Use custom savefile extension detection for err msg
...
#2305
Catches the following as SaveFiles:
"srm", // RetroArch save files
"fla", // flashcard
"SaveRAM", // BizHawk
and whatever else is added by the init
2019-05-13 15:58:36 -07:00
Kurt
018159ef4d
Merge branch 'master' of https://github.com/kwsch/PKHeX
2019-05-13 15:54:02 -07:00
Kurt
04cd0da2ac
Use generic pattern match
...
>7.0 c#
2019-05-13 15:53:27 -07:00
ReignOfComputer
6c42e3b1bb
Enhance Invalid Convert Error ( #2305 )
...
Makes it clearer for conversion failure with Pokemon files - prevent confusion with save files.
2019-05-13 15:38:33 -07:00
ReignOfComputer
2b39d75141
Allow Open WB7Full / WB7 ( #2304 )
2019-05-13 15:35:40 -07:00
ReignOfComputer
9d6127dfc2
Fix C# 7.2 Build Error ( #2303 )
...
Explicitly target LangVersion 7.2.
2019-05-13 15:35:19 -07:00
Kurt
15f93216bd
Fix record flag clearing
...
yay missing ~, Closes #2301 ty @CanoeHope !
rewrite flag loading to not use linq
2019-05-12 15:08:04 -07:00
Kurt
bad16adcee
Fix sav7b clone method
...
underlying data should be a different reference when cloned
2019-05-12 15:06:50 -07:00
Kurt
d4d26fd9b3
Fix eventflag data set to sav
...
cause:
300ef4d60a
Closes : #2301
2019-05-12 13:23:27 -07:00
Kurt
4703a3d364
Fix incorrect method call
...
IVs for regular trade gifts can have random IVs; only VC-era have purely
fixed IVs.
Closes #2300
2019-05-11 17:03:22 -07:00
Kurt
4b770e62d9
Simplify and relocate wurmple evo logic
2019-05-11 14:25:58 -07:00
Kurt
feb36f58b5
Minor simplification
...
#2298
#2299
2019-05-11 13:10:51 -07:00
Andrew Johnson
b1ad10d8ad
Add shiny check for Ash-Greninja ( #2299 )
2019-05-11 13:08:22 -07:00
Kurt
21e7f4317e
Minor updates
...
increase readability, simplifly some expressions
relocate hot path for legality report string creation
2019-05-11 10:12:14 -07:00
Kurt
332784d34b
Misc updates
...
parameter name lowercase
simplify some comparisons/calcs
reuse comparison methods
wrap memory dump into readonly struct
2019-05-11 00:59:07 -07:00
Kurt
55189a6967
Extract most common location numbers to class
2019-05-10 20:46:49 -07:00
Kurt
72edb6aa72
Misc tweaks to 3->4+ branching
...
more lines, a little clearer
2019-05-09 22:47:37 -07:00
Kurt
b51bdc9230
Add another vc nature checks
...
transfer level exp and current exp not being different enough, which
limits the amount of natures possible. Could handle the 100&<=2 cases
the same way, but keep the branches for faster cases.
fix bad test cases
2019-05-09 01:56:44 -07:00
Kurt
b5b4b67263
Fix template IVs getting overwritten on startup
...
Closes #2296
setting datasource triggers a changed event, which updates IVs
set flag to indicate this isn't the user doing this change
2019-05-05 12:57:56 -07:00
Matt
316430985a
Unban Shiny Seel ( #2293 )
2019-05-01 14:23:08 -07:00
Kurt
042e5176a6
Remove hardy shuckie & version split
...
Not version specific; I'm assuming the 00020003 PID is a result of
hacking the save file to change OT gender. Legitimate saves haven't
yielded the Hardy PID. Changing gender probably results in a bad
pointer, fetching the wrong value.
Closes #2290
2019-04-30 17:03:12 -07:00
Kurt
520c9da5c9
Update string loading
...
Remove usage of linq for sorting, use array.sort for in-place sorting.
Wasteful creating temp sorted buffers then enumerating them to dump into
the list.
2019-04-29 21:55:43 -07:00
Kurt
7094132eac
Fix b2w2 fr trade OT name
...
Closes #2291 ty @WEERSOQUEER
2019-04-29 17:42:39 -07:00
Kurt
be50830975
Relocate method to extension logic class
...
GetLocationString is now right below GetPotentialString
PKX no longer has extension methods aside from the two CopyTo sugar
2019-04-29 17:36:29 -07:00