Kurt
2dbdb35955
Misc tweaks
...
possibly fix UI not-1x scaling screwing up drawn pkm images with
items/shiny/illegal.
simplify some logic -> speed improvements (wow so noticable /s)
2017-12-16 18:29:10 -08:00
Kurt
21c1dde3a7
Fix static encounter gift / egg edge case
...
extract EncounterStatic match determination; in doing so fixes "lvl" by
passing byval.
Pichu encounters (2) come before the Gift level 25 pikachu, causing lvl
to be dropped to 5. When pikachu comes around, it compares 5==25 -> bad;
pulling out the method and passing byval allows it to be 25 at the start
of every new encounterstatic checked.
2017-12-16 18:24:03 -08:00
Kurt
06ea6d94a2
Allow box layout / wallpaper editing for sav5
...
was temporarily disabled during sav5 implementation 2y ago, now noticed.
Closes #1702
2017-12-16 14:15:09 -08:00
Kurt
18796d6f92
Misc tweaks
...
fix bk4 ribbon checks (lacked interface inheritance)
change MN -> UM for get blank save (unused in PKHeX solution)
prevent inheriting from derived pkm classes
2017-12-16 14:11:41 -08:00
Kurt
0b58d4ffe9
Add form/nature checks for gen5 trades
...
altform wasn't checked for EncounterTrade
nature wasn't checked for gen5 origin (decoupled from PID, but forced)
#1702
2017-12-16 14:09:03 -08:00
Kurt
e5aa39a6bb
Refactoring
...
get language list now doesn't return new objects (or re-enumerate)
update rand usage to be inclusive for top bound, extend shuffle to
collections
remove unnecessary location overrides (already overriden in legal fetch)
2017-12-14 20:58:55 -08:00
Kurt
9c8e1ab13f
Merge pull request #1701 from wwwwwwzx/master
...
Fix chinese language ID check
2017-12-14 20:27:09 -08:00
wwwwwwzx
6c4a4ff4ec
Fix chinese language ID check
...
Some species have the same unicode name in CHS and in CHT, so it will lose language info after converting from a in-game string to textbox (The game will use different fonts to distinguish them, bad GF)
This change will give CHT encoding a higher priorty if the pkm is in CHT, although it's possible to get CHS encoding default species name with CHT language ID.
Also fixed previous editing error
2017-12-14 19:30:59 -08:00
Kurt
b5640de538
Misc tweaks
...
reorder some args, reuse some standard methods;
add spanish for gen1/2 egg name case
2017-12-14 16:16:47 -08:00
Kurt
278f7cad25
Add pwt record get/set
...
thanks @sora10pls
2017-12-14 12:34:03 -08:00
Kurt
9a39f818f9
Misc fixes
...
#1700
dp personal: add wormadam/deoxys manual forme count values
generator: bcc handling for pkm present in & out of bcc, and static/wild
duplicates
util: fix incorrect variable reference
2017-12-13 16:17:02 -08:00
Kurt
a9ff74059a
Misc perf tweaks
...
checking untraded should just check for the first character (rather than
creating string object)
hashset for wild6 balls
2017-12-13 16:12:53 -08:00
Kurt
816ebf6b0e
Refactoring
...
no functional change
2017-12-11 16:01:24 -08:00
Kurt
0588135b60
sync missing change
...
g already used
2017-12-11 11:01:57 -08:00
Kurt
f1cabdfa25
Handle setting decrypted pgt pkm gift data
2017-12-11 10:13:08 -08:00
Kurt
dd21f9375f
Misc updates
...
Disallow sandygast on US
Add 2 more records
thanks @feralfalcon
Closes #1698
2017-12-08 08:54:00 -08:00
Kurt
a43880184a
Fix artist ribbon gen6+
...
having 4 ribbons is sufficient (normal/super/hyper/master = 4, etc)
https://projectpokemon.org/home/forums/topic/42933-2-issues-invalid-ribbons-artist-encounter-level-in-origin-game/
2017-12-07 07:57:07 -08:00
Kurt
f9946368a0
Remove usage of LegalityAnalysis from PK*
...
CK3<->XK3 transfers to PK3 first now (no direct transfer legally)
2017-12-06 21:28:34 -08:00
Kurt
bd9f7fc7e2
Remove fossils from usum capture list
2017-12-06 21:05:36 -08:00
Kurt
4550f656d0
Update gs vc check female
...
will be revised when/if vc-c is released
2017-12-05 15:08:02 -08:00
Kurt
88f67ebd36
fix crystal gender flagging
...
C->GS->Gen7 keeps female OT but gives GS version
also fixes wrong logic path for format2
thanks randomdice101
2017-12-05 14:43:02 -08:00
Kurt
f3cc29df57
Update 17.12.05
...
Update event binaries with latest from the Event Gallery
2017-12-05 09:04:59 -08:00
Kurt
eff8855729
Allow throw type changes to be saved
...
move SM/USUM branch inside the method
closes #1695
2017-12-05 07:26:55 -08:00
Kurt
5bc2e6da88
Refactoring
...
de-linq some areas where direct accessing is possible (list/array)
2017-12-04 20:16:54 -08:00
Kurt
4a63769351
Add voltorb to beast ball permissible table
...
closes #1694
2017-12-04 16:54:09 -08:00
Kurt
3d7b2a2b29
Misc tweaks
...
RNG frame mismatch -> fishy (for now)
fix xmldoc copypaste
clean up some resharper warnings
2017-12-04 16:26:26 -08:00
Kurt
5a69f1d596
Rework gen3 crc32 to not require a new obj for byte[]
...
removes toarray in favor of iterating over the source array
maybe with the next c# (span)...
2017-12-04 16:13:18 -08:00
Kurt
1007c5ddb8
don't flag pokespot for frame not matching
...
#1693
2017-12-04 16:05:21 -08:00
Kurt
a5dbdf91bd
Misc tweaks
...
detect antishiny cxd
remove unused using
don't set caught for seenAll (gen7 dex)
2017-12-04 13:18:28 -08:00
Kurt
f030161fd6
Merge pull request #1691 from Ntonio36/patch-1
...
Translation update, round 2
2017-12-03 14:06:10 -08:00
Kurt
55c2a603d7
Purge non-dp data for BK4 transfer
...
#1690
2017-12-03 13:10:14 -08:00
Kurt
805efdbdfa
Add missing bk4 property for abilitynum
...
used in legality analysis, was returning 0 (invalid)
Closes #1690
2017-12-03 12:40:10 -08:00
Kurt
593612740f
Fix bk4 IV read order
...
still pending ability mismatch
#1690
2017-12-03 12:35:51 -08:00
Kurt
6773a2801d
update static/magnet slot permutations
...
using certain slot modifiers (swarm/game pak) causes different
arrangements of slots for different static/magnet pull groups to pull
from
store a list of permuted/different slots and add them to the table at
the end with the rest
move static/magnet pull marking into gen4 methods (only leave for gen3)
move trophy slot generation into gen4dppt area fetch (necessary for
static/magnet permuting)
fix electric off-by-one (yay for curse ??? type shifting everything)
2017-12-03 12:20:53 -08:00
Ntonio36
55b82f5ec4
translation update, round 2
2017-12-03 22:20:03 +02:00
Kurt
792910a485
Merge pull request #1689 from pokecal/master
...
fix MailBoxEditor
2017-12-03 07:14:49 -08:00
Kurt
f21906ee9a
store gen3 origin seed for default frames
2017-12-03 07:13:28 -08:00
Kurt
09a41f66ba
Fix z coordinate writeback
2017-12-03 07:12:52 -08:00
Kurt
30914d00ee
Merge pull request #1686 from wwwwwwzx/master
...
Add gen7 flags/consts chinese localization files
2017-12-03 07:03:07 -08:00
pokecal
0f52f94222
fix MailBoxEditor
...
add Mail5, almost same as Mail4.
2017-12-04 00:00:14 +09:00
wwwwwwzx
4aa3b941fd
Add gen7 flags/consts chinese localization files
2017-12-03 01:22:39 -08:00
Kurt
b6b0023d10
Merge pull request #1685 from smileynation/patch-1
...
Update flags_usum_ja.txt
2017-12-02 22:59:55 -08:00
smileynation
a9002e50ba
Update flags_usum_ja.txt
2017-12-03 15:52:52 +09:00
Kurt
d301cb5469
Remove ESV rollback for varied level encounters
...
ESV rand is stored uniquely now via generated frames from FrameFinder,
no need to roll back.
2017-12-02 22:34:54 -08:00
Kurt
bdc9d7edce
fix plaza get set
...
closes #1684
2017-12-02 21:37:46 -08:00
Kurt
133cc22f50
Add bypass for gen4 unown
...
meh
2017-12-02 19:54:50 -08:00
Kurt
2d3203fc1a
Refactoring
...
extract out Mail classes to core
2017-12-02 19:12:04 -08:00
Kurt
44ccae918b
Merge pull request #1683 from pokecal/master
...
fix MailBoxEditor
2017-12-02 18:55:49 -08:00
Kurt
9c32b36709
Don't reuse friend safari message
...
use the string format variant that has less hints.
https://projectpokemon.org/home/forums/topic/42869-bugg7-ditto/?tab=comments#comment-224365
2017-12-02 18:54:41 -08:00
pokecal
3e5e49219b
fix MailBoxEditor
...
fix Gen4 Controls
add Mail .Empty for LegalCheck
add Mail SetBlank() for make BlankMail
2017-12-03 11:24:57 +09:00
