Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-24 04:53:08 +00:00
Code Issues Projects Releases Packages Wiki Activity
4654 commits 3 branches 76 tags 106 MiB
Commit graph

4654 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kurt
26cc266dd1 Move type sprite fetch remapping to pkmutil 
I still don't like it 100%
 2018-03-18 11:25:57 -07:00
Kurt
f55028c1a0 Fix KChart errors 
gen1 & gen2 types aren't laid out contiguously (yay bird type and extra
types)
fix gen2 type accessors looking at the wrong byte

type sprites now load correctly, and 3rd ability no longer throws an
error (forced to None).
 2018-03-18 11:22:20 -07:00
Kurt
1aa70a16a4 Reduce bst green scalar 
average*2 resulted in a value that was too-green relative to the stats.
use the rescaling from KChart
 2018-03-18 11:21:00 -07:00
Kurt
56bd39b336 Add base stat indication (with colors) 
Thanks @zaksabeast for feedback in IRC
 2018-03-18 10:38:29 -07:00
Kurt
88ce27f26b Add R/S roamer data offset 
is different from emerald

Thanks TetsuyaGR!

https://projectpokemon.org/home/forums/topic/44407-bug-rubysapphire-roamer-bug/

(use concatall in encounters4)
 2018-03-18 08:37:40 -07:00
Kurt
75dbec6038 Remove unnecessary switch entries 
null return is only really useful for implementing; can remove the
chance for null when using the api
 2018-03-17 20:05:35 -07:00
Kurt
49d92758c5 xd ribbon fix 
lol
 2018-03-17 10:36:37 -07:00
Kurt
e9a3b4acf1 Merge PIDType and bool? shiny property 
Gen5 does not follow the same convention, 0 = non, 1 = rnd, 2 = always;
not gonna bother updating for just that one

bool? occupies 2 bytes; enum:byte is 1 byte.

should probably move validity checking logic into the IEncounterable
objects instead...
 2018-03-16 19:35:55 -07:00
Kurt
d65d9e0b79 Add missing = 
lul oops
 2018-03-16 17:57:24 -07:00
Kurt
d1a789eeab Fix some pokedex4 behavior 
https://projectpokemon.org/home/forums/topic/44347-gen-4-pokédex-forms-incorrectly-readwritten/
 2018-03-16 17:54:47 -07:00
Kurt
274d2200a3 Correctly flag hidden7apricorn 
[0] -> Last()

Thanks Davil!

https://projectpokemon.org/home/forums/topic/44374-bug-about-hidden-apricorn-voltorb-bronzor/
 2018-03-15 19:04:14 -07:00
Kurt
3e9dabf46d Set forced hatch egg friendship 
use base friendship, obviously (previously used current egg ctr)
fix force hatch on gen2->gen1 handling with nickname
 2018-03-14 22:34:15 -07:00
Kurt
2685fe29c2 Ban hidden-apricorn voltorb bronzor 
Thanks @wwwwwwzx !
 2018-03-14 08:10:12 -07:00
Kurt
46e1d8a4eb Add ability to replace IV marking method 
set the MarkingMethod to a desired func provider (out int markval, int
IVvalue, int IVindex)
#1862
 2018-03-12 20:44:16 -07:00
Kurt
1cdbe6f4f8 Fix ditto5 IV order 
closes #1863
 2018-03-12 19:34:54 -07:00
Kurt
b41095bb28 ShowdownSet gender/markings 
Closes #1862
 2018-03-12 17:40:09 -07:00
Kurt
102550174e Simplification 
invalid/unknown usages were incorrectly interchangable; dex-sets were
looking at Unknown which was impossible for some cases.

only use GameVersion.Unknown as a temp placeholder for later resolution
by the user.
 2018-03-11 18:07:48 -07:00
Kurt
22bde0af52 Fix incorrect variable reference 
new SAV3() throws exception, no more!
 2018-03-11 14:42:56 -07:00
Kurt
59c01396ab Add string[] -> showdownset & showdownset[] 
remove some unnecessary pre-processing / allocation (ToArray)

pls lmk if there's any sets that break (should really have parsing test
cases)
 2018-03-11 11:39:58 -07:00
Kurt
aa65d88d3d Cache pressure slot instead of saving all to list 
faster to do:
null check & comparison for each
vs
collection add (especially if growing collection)

don't evaluate all slots (faster), capturing the dexlevel[] object is
fine until the enumerable is discarded
 2018-03-11 11:02:02 -07:00
Kurt
5148fd2c4e Add minimally filtered encounter generators 
Filters by species at most, resulting in something that can be scanned
for a preferred encounter.
 2018-03-11 00:29:31 -08:00
Kurt
94811d9052 Split up IEncounterable generators 
Can break the filtering out into smaller methods such that the generator
can return results with less strict filtering
 2018-03-10 19:51:09 -08:00
Kurt
84c5decfc0 Comment out unused 
temp = temp permanent lul
 2018-03-10 19:40:57 -08:00
Kurt
2bd9d99d9e Refactoring 
WinForms->Core logic absorbing (CommonEdits)
loading ShowdownSet now applies properties to PKM instead of PKMEditor
Contest/IVs for Static/Trades are no longer set by default (less object
allocations), and are now checked by the encounter generator
 2018-03-10 18:03:09 -08:00
Kurt
9da1913f1b Only check static IVs if original IVs still exist 
https://projectpokemon.org/home/forums/topic/44319-bug-vc-mew/
Thanks Davil!
 2018-03-09 20:00:13 -08:00
Kurt
cda2cfcefd Clean up EncounterLink 
no new gen6 pkm link gifts, simplify usages
 2018-03-09 18:58:00 -08:00
Kurt
452ffe2369 Refactoring 
relocate location of stuff
 2018-03-08 21:18:32 -08:00
ReignOfComputer
8147258e9e Unban Gen 7 Starters HA (#1860) 
HA Starters Event via Pokemon Bank
 2018-03-08 05:55:47 -08:00
Kurt
cbf4038a95 Refactoring 
relocate gift data storage out of legal.cs
 2018-03-05 22:19:56 -08:00
Kurt
21cdf4f642 Reorganization 
wonder if it's possible to provide a more lightweight core by pulling
out legality stuff to a separate project?
 2018-03-05 20:49:45 -08:00
wwwwwwzx
c9a54307c4 Fix WC6/7 IV generation (#1857) 
https://pastebin.com/bbpS6svw
IV lock doesn't work for IV3 case
 2018-03-02 16:17:14 -08:00
Kurt
e4210e2b3e Misc api improvements 
extract common nature amp logic
generic ienumerable copyto which now returns count of elements copied
(maybe useful later). prior usages never tried to copy an enumerable
larger than the dest array (now length checked).
 2018-02-28 21:50:50 -08:00
Kurt
24982fe8c5 Misc simplifications 2018-02-28 21:05:50 -08:00
ReignOfComputer
faab067f80 Fix Inverted Max PP Shortcut (#1855) 
https://github.com/kwsch/PKHeX/issues/1854#issuecomment-369270152
 2018-02-28 08:58:04 -08:00
Kurt
9fb7268434 Fix hidden power combobox 
closes #1852
 2018-02-27 17:48:19 -08:00
Kurt
1411933e27 Relocate pkm stat controls to separate usercontrol 
splits the logic up
change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
 2018-02-26 21:22:35 -08:00
Kurt
89d3437d0b prevent blue flabebe apricorn/beast 
closes #1850
impossible SOS's were already removed from the SOS list (e.g. no slots
in the SOS table with w.Species == 669 && w.Form == 3)
 2018-02-24 17:28:07 -08:00
Kurt
934757eac1 Add Bank7 r/w 2018-02-24 13:03:32 -08:00
Kurt
f9002c6cc9 Add trashbyte copy for OT import on gen1/2 
Closes #1849
NAME_LENGTH is 11 for both gens and the offsets don't vary between
languages, so it's a simple fetch.
 2018-02-22 22:42:50 -08:00
Kurt
016b75fe83 Fix necrozma showdown->short names 
closes #1848 , had deleted short->showdown conversion

Thanks @architdate !
 2018-02-21 20:40:06 -08:00
Kurt
8e0ec17e9f Misc refactoring 
no functional changes
 2018-02-21 20:35:07 -08:00
Kurt
ee1196a57d Set playedtime accurately 
closes #1847
override playtimestring if max time... better than nothing
 2018-02-21 15:22:43 -08:00
Kurt
d62b34f140 Don't set HiddenAbility if HaX 
have user specify via 0x42 extrabyte as it can only be updated from
there.
closes #1846
 2018-02-19 23:34:07 -08:00
Kurt
d20f14504e Refactoring 
pull out BlockInfo logic, standardize common block checking
reduces array allocations
 2018-02-19 11:33:37 -08:00
Kurt
26ca111630 Fix SetHPIVs order 
speed IV last -> speed IV first
closes #1844
 2018-02-18 09:54:17 -08:00
Kurt
e6a74b0145 Only skip nickname set if currently same 
Closes #1842
 2018-02-17 17:42:00 -08:00
Kurt
d7271768b2 Only hyper train if the set level is adequate 
Closes #1841
wasn't clearing if level below
 2018-02-17 16:34:55 -08:00
Kurt
47643f49b6 remove linq personalinfo bit fetch 
reads the bits out of the original array (saves a few ms by not
allocating/gc)
 2018-02-16 19:34:42 -08:00
Kurt
b75313cd87 Sync unsaved changes 
closes #1840
 2018-02-16 17:24:07 -08:00
Kurt
0a0b944de1 Use explicit generation param for forme fetch 
closes #1837
 2018-02-16 16:38:07 -08:00