Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-23 20:43:07 +00:00
Code Issues Projects Releases Packages Wiki Activity
4932 commits 3 branches 76 tags 106 MiB
Commit graph

4932 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kurt
b749db10d8 Null check property value 
EggMetDate, if none set, returns null.

https://projectpokemon.org/home/forums/topic/46265-batch-editor-bug-systemnullreferenceexception/
 2018-07-15 08:46:31 -07:00
Kurt
46ece28f4c Add vc/gen1-2 search option 
refactor out some searchable methods
 2018-07-14 22:18:24 -07:00
Kurt
cc509de83c Add lgpe properties 2018-07-14 21:55:45 -07:00
Kurt
8d89776ae9 Remove unused portions of lib 2018-07-14 21:55:26 -07:00
Kurt
0f17445ef4 Update gen3 event pidiv method check for eggs 
closes #2057
Thanks @kamronbatman !

(nothing currently implemented uses BACD_U_S)
 2018-07-14 20:19:13 -07:00
Kurt
fae36e2086 Add layerimage overload 
transparency=1 is no opacity change
remove Rectangle use, just provide coordinates (looks to be simpler in
the .net src too)
 2018-07-14 18:43:46 -07:00
Kurt
cb80c02011 Check Yellow catchrates when updating species 
https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/
 2018-07-14 18:08:51 -07:00
Kurt
d2eba35504 Update interface parameter names 
sync to previous
 2018-07-14 18:08:30 -07:00
Kurt
6c8374f26f Extract inner sprite building to class 
any romhack maker can replace the behavior with their own builder
 2018-07-14 17:53:37 -07:00
Kurt
6b7ba49cba Remove unnecessary logic 
gamestrings: call but not value used
text.cs: use gamestrings method for auto-filtered, now removes korean in
Gen3 context
 2018-07-14 16:53:14 -07:00
Kurt
77c5d13034 Simplify memory ui handling 
abstract away the details to another class
 2018-07-14 16:32:06 -07:00
Kurt
4d73fa70d8 Simplify binding to ComboItem logic 
could probably look into better binding but meh
 2018-07-14 16:00:28 -07:00
Kurt
8c2b74c149 Refactoring 
max IVs use flawless method directly with 6 IVs specified
move color blend/stat calc to ImageUtil
move potential string to commonedits
expose color properties for pkmeditor
don't constantly create/dispose brushes for drawing legal moves
 2018-07-14 15:08:14 -07:00
Kurt
74f36b79af Extract color config values 
easier to modify
 2018-07-14 13:17:56 -07:00
Kurt
baac632218 Enable editing gen1/2 hidden power type 2018-07-14 10:56:11 -07:00
Kurt
625a77589b Extract geolocation logic to interface 
mixins would be nice but I guess extensions cover this
 2018-07-14 10:34:34 -07:00
Kurt
7d1994dc8a Add xmldoc for public members 2018-07-14 09:55:22 -07:00
Kurt
b039112a1d Add gen1/2 hidden power setter calc 2018-07-13 20:30:57 -07:00
Kurt
5d20c79568 Add showdownset localization for slot previews 
Localization only for game strings (not Ability/Nature/Stat/etc labels)
feels kinda goofy but it works
 2018-07-13 19:13:25 -07:00
Kurt
83e61923f7 Add bw/2 jellicent deferral case 
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?tab=comments#comment-233860

Thanks paf!
 2018-07-13 13:48:27 -07:00
XxPhoenix1996xX
9f2712cf4d Update text_Mail4_es.txt (#2056) 2018-07-13 08:40:18 -07:00
Kurt
ebed1026cd Update national dex magic setting 
bulbapedia is wrong, first 4 bytes are info values:

0x0 = dex order (alphabetical, numerical), unused in frlg
0x1 = mode (unused in frlg), regional vs national
0x2 = national magic rse (always set in frlg)
0x3 = national magic frlg (never set in rse)

refer to disassembly (pokefirered isn't too helpful, less developed.
just compare save files & edit ram!)
the other 2 values being set are the eventflag & event const, could use
the abstraction for those rather than direct ofs writes
 2018-07-12 23:23:36 -07:00
Kurt
d42cc7cacd Add spinda/unown PID properties 2018-07-12 22:07:44 -07:00
Kurt
98a1677d14 Fix property reference 
oops
 2018-07-12 20:36:59 -07:00
Kurt
ea5a981f4a Add Hidden Power type calculation for pk1/pk2 
Use format specific for import, with format guess to the current
savefile known to pkmconverter.
 2018-07-12 18:16:24 -07:00
Kurt
296d1c20ed Use ITrainerInfo interface for trdata 2018-07-12 18:15:20 -07:00
Kurt
3da4873f94 Bounds check species ID for negative 
certain downstream consumers of the library be doin silly things
 2018-07-12 17:09:39 -07:00
Kurt
04765ef411 Add more xmldoc 
Covers all gameversion enum members (whew)
 2018-07-12 16:55:24 -07:00
Kurt
d20706dd70 Update xmldoc 
le lenny goes here
 2018-07-11 19:19:19 -07:00
Kurt
e4e5018aa7 Extract some methods 2018-07-11 19:13:09 -07:00
Kurt
6816c2de43 Update OT affection check for 3-5 memories 
https://projectpokemon.org/home/forums/topic/46180-oras-transfered-pokemon-invalid-ribbon/
Thanks piplupwater!

(there's no other usages of V129)
 2018-07-11 17:43:48 -07:00
Kurt
8a83b9bde8 Update manaphy ability check again 
57250823a8
covered it for format>=6, in 4/5 the abilitynumber is derived from
PIDAbility
Closes #2052
 2018-07-10 21:30:13 -07:00
Kurt
01323c0ee8 Add id7 setters 
can now set TrainerID7 / TrainerSID7 via batch editor
 2018-07-10 21:25:03 -07:00
Kurt
7f31fdf874 Simplify string trim 
RemoveRange instead of while {remove last}
 2018-07-10 17:54:05 -07:00
Kurt
f8c43d4a06 Rework gen1 trade OT handling 
convert all dictionaries to char-byte instead of string (saves 50KB on
compressed dll, lul)
update OT string comparison for pre/post transfer specimens

Showing "TRAINER" for all languages isn't correct, just show a mapped
character

Closes #2049 , thanks @egzonqj & @WEERSOQUEER !
 2018-07-10 16:45:24 -07:00
Kurt
027d898f3d Update Yancy Curtis trade OT checks 
Thanks paf!
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/
 2018-07-10 12:37:40 -07:00
Kurt
c8897161b7 Fix gen6 evo tree resize miss 
https://projectpokemon.org/home/forums/topic/46144-a-couple-of-new-problems-in-the-pkhex-version/

Thanks CreamatedReptile2018 !
 2018-07-09 22:51:01 -07:00
Kurt
93876d98eb Fix CanInhabitGen1 comparison 
extracted and forgot to double check the boolean comparison when
inverting the return value

https://projectpokemon.org/home/forums/topic/46148-bug-gen-1-moves-and-legendaries-incorrectly-flagged-in-gen-2-game/

Thanks Raptor385!
 2018-07-09 21:59:38 -07:00
Kurt
d45a8afef2 Remove erroneous chain trim logic 
latter half of the method seems to do everything that is required

Closes #2048
 2018-07-09 21:26:45 -07:00
Kurt
9a57469ec3 Update shedinja chain handling 
Closes #2045

4ac92b9418
had added it; assuming to undo lvl-1 => lvl for gen3/4.

Level Up, Learn Nincada Move, Evolve to Ninjask & spawn Shedinja, then
learn any Ninjask Moves. Gen3 reverses the spawn&learnNinjask steps,
which is handled separately

Thanks @XxPhoenix1996xX !
 2018-07-09 20:18:31 -07:00
Kurt
57250823a8 Add ranger manaphy ability check 
PCD != PGT

Closes #2044
 2018-07-09 17:33:31 -07:00
Kurt
6bb076aecf Fix mysterygift hidden ability comparison 
Closes #2047
 2018-07-09 17:08:26 -07:00
Kurt
d70990f9cc Fix SOS hidden ability <-> flawless IV count 
3->2
https://projectpokemon.org/home/forums/topic/46142-two-illegal-pokemon/
 2018-07-09 17:02:18 -07:00
XxPhoenix1996xX
3c9b25a662 Update lang_es.txt (#2050) 
* Update lang_es.txt

* Update lang_es.txt
 2018-07-09 11:54:45 -07:00
Kurt
8b1ec36242 fix volbeat/illumise sport comparison 
#2047
 2018-07-09 06:28:29 -07:00
XxPhoenix1996xX
a60d2bd08d Update MessageStrings_es.txt (#2046) 2018-07-09 06:12:53 -07:00
Kurt
6d0dda1df0 Update 18.07.09 
Update event binaries with latest from the Event Gallery
(surpassed 2.5 million cumulative downloads!)
 2018-07-08 21:16:42 -07:00
Kurt
94ad351979 Update translation files 
new release soon

-opower6 now fully editable
-box export to showdownset added
 2018-07-08 18:25:43 -07:00
Kamron Batman
5ecd3b1875 Adds distribution for Negai Boshi Jirachi (#2043) 
* Adds distribution for Negai Boshi Jirachi

* Updates negai boshi to have the proper game origins
 2018-07-08 16:21:49 -07:00
Kurt
97701787a6 Add sav2 daycare view 
tfw they store full egg data there too -- show that in the sidebar

Tested on C & GS (english), assumedly works fine for other languages
(based on the disassembly?)
 2018-07-08 15:46:37 -07:00