Commit graph

2949 commits

Author SHA1 Message Date
Kurt
d8bc2154ba Fix dppt slot species reading
Offset re-read the level value; now we just read the byte for level
(always 0-100) and the species is 4 bytes afterwards
2017-03-25 22:23:36 -07:00
Kurt
7d45b5c4fb Fix levelup egg pre-relearnmove check
Closes #991
2017-03-25 19:57:41 -07:00
Kurt
159ccba8b3 Merge pull request #992 from wwwwwwzx/master
Minor legality string translation fix
2017-03-25 18:35:41 -07:00
wwwwwwzx
8059b6a327 Fix chinese translation
Go over the translation to make it more native and reasonable
2017-03-25 18:17:38 -07:00
wwwwwwzx
1ba78d98b9 Translate all lines of legality report
The string before move haven't been translated
2017-03-25 18:15:28 -07:00
Kurt
805cedcea3 Add CheckIdentifier tostring method
Closes #984
2017-03-25 16:38:40 -07:00
Kurt
ed40cdae64 Misc tweaks
int[][] to List<int> to reduce ToArray() overhead as adding range is
quicker
remove multiple use of ienumerable by calling tolist()
2017-03-25 13:53:33 -07:00
Kurt
aa25d10e53 Misc matching fixes
Transferred 4->5 event met level
Add fateful encounter flags for gen3 encounters
gen5 legendary trio met locations
2017-03-25 12:26:19 -07:00
Kurt
9def544029 Merge pull request #990 from javierhimura/master
Crossgen Moves legal analysis and pokemon box encounter
2017-03-25 12:26:04 -07:00
javierhimura
b5a8a53320 Fix RemoveFutureMoves for VC and GB games 2017-03-25 19:49:34 +01:00
javierhimura
f0b2294e3c Add pokemon box static encounters
Fix gen 3 met egg location to allow 255 (pokemon box) and 253 (in game egg)
2017-03-25 19:02:33 +01:00
javierhimura
5adb2dac22 Adapted base egg moves to new parsemoves format 2017-03-25 18:32:05 +01:00
javierhimura
66a9f8901c Merge branch 'kwsch'
# Conflicts:
#	PKHeX/Legality/Checks.cs
#	PKHeX/PKM/PKM.cs
2017-03-25 18:24:56 +01:00
javierhimura
81217799fe Fix parseMoves and RemoveFutureMoves functions 2017-03-25 18:19:38 +01:00
Kurt
46e7e06326 Fix pumpkaboo average size safari check
Closes #989
2017-03-25 10:18:38 -07:00
javierhimura
69d562685c Gen 2 get moves, returns crystal egg moves by default when origin can not be determined
return gold/silver egg moves in the cases when origin can be proven is not from crystal
2017-03-25 18:14:57 +01:00
wwwwwwzx
d828b72e3e Add PokeWalker encounters (#988)
* Add PokeWalker encounters

* Change PokeWalker location marking method

move `gift = true` out of PokeWalker table
move the combining of EncounterStatic tables into function
`getStaticEncounters`

* Cleanup

Add zeros before move indexes & align the entry
Remove unused chinese translation string
2017-03-25 10:13:02 -07:00
javierhimura
8d4ad80949 Gen 2 WasEgg fix 2017-03-25 18:12:48 +01:00
javierhimura
82b200681e Cross generation check moves 2017-03-25 16:41:45 +01:00
javierhimura
2fd67b98ca Add getValidMovesAllGens to return the valid moves list from every valid generation from a pokemon instead of one list with all generations mixed, for crossgen legal analysis 2017-03-25 13:27:42 +01:00
javierhimura
007105b852 Add optional paramter in functions getMoves and getValidmoves to not remove HM moves on transfer from gen 3 and 4 to next 4 and 5 2017-03-25 13:26:33 +01:00
Kurt
d09b0ba345 marill edge case 2017-03-25 00:09:26 -07:00
Kurt
13965d2766 gender check update
check gender correctly for transferred species
2017-03-25 00:01:02 -07:00
Kurt
047d7a0ae5 Add more event recognition
Transferred events 4->5+ now recognized (met location checks for
transfer value)
Re-mapped gen3 AbilityNumber to gen6 style (1/2/4)
Add gen3 egg hatch location suggestion, gen3/4 met level
2017-03-24 22:41:45 -07:00
Kurt
d7dac3b266 Fix egg move check for 3-5
Inherited levelup moves now properly checked
adds gen5 levelup cases

updates nickname check for all caps nicknames
2017-03-24 19:24:01 -07:00
Kurt
0ba4f9b53f Cleanup
Fix b2w2 tutor tables
fix gen5 recognizing of transferred eggs
fix xml warnings
fix crlf
2017-03-24 18:23:39 -07:00
Kurt
7650ade09b Merge pull request #983 from kwsch/r/checkstrings-refactor
Refactored implementation of #959
2017-03-24 16:51:44 -07:00
Kurt
3a98221d4e Merge pull request #985 from wwwwwwzx/master
complete gen5 encounters database
2017-03-24 16:50:39 -07:00
wwwwwwzx
bde2b1eae3 Add DreamRadar Encounter 2017-03-24 15:50:00 -07:00
wwwwwwzx
bdabe37b10 Add N's Pokemon for b2w2
- add N's Pokemon as static
- move the gift Norua to static
2017-03-24 14:14:57 -07:00
Evan Dixon
056318d108 Altered the order of operations in language changes
Fixes a bug where language changes would not apply in new implementation of legality string translation
2017-03-24 13:18:14 -05:00
Evan Dixon
a80a2489a4 Refactored implementation of #959 2017-03-24 12:59:45 -05:00
sora10pls
a176f387bc Fix invalid fishy check for Gen 4 Eggs (#982)
* Fix invalid fishy check for Gen 4 Eggs

Met Level should be 0, current Level should at least be 1; impossible to have a Lv. 0 Pokemon, therefore it is not fishy to have no EVs on a Lv. 1 Pokemon
2017-03-24 10:40:17 -07:00
Kurt
0c204d7c0f Merge pull request #980 from wwwwwwzx/master
Add gen5 Dream World table
2017-03-24 09:17:02 -07:00
wwwwwwzx
ea7a9dcef0 Fix gen3/4 encounterstatic table
- add static encounters for gen4 (rotom/drifloon/electrode/spiky pichu)
- fix Uxie/Azelf location (Lake -> Cavern)
- fix ball for sinjoh ruins event (the player recieve the pkm without
battle poke ball only)
- fix ball for gen5 zorua (the player can choose ball)
2017-03-24 01:05:09 -07:00
Kurt
d8dcb47252 Add gen4 event recognition
fixes ribbon fetch, unown form comparison, and improves exception
handling (no more swallowing exceptions and yielding a vague message)

properly generate manaphy egg on gen4 saves

will have to iron out the legality checks for nicknames at a later point
in time
2017-03-23 23:15:49 -07:00
wwwwwwzx
cfa1b6d744 Add gen5 pgl dream world gift
- add ability to table
2017-03-23 22:31:55 -07:00
wwwwwwzx
2e64df7b6e Merge pull request #1 from kwsch/master
Update from upstream repo kwsch/PKHeX
2017-03-23 22:24:50 -07:00
Kurt
b6c4eab36b Misc legality fixes & improvements
Recognize gen4/5 events
check ability mismatch
check nature mismatch
2017-03-23 21:42:33 -07:00
wwwwwwzx
f59d62161e Add gen5 Dream World table
- Add a lengthy dream world table with special moves and levels (wonder
if there is already a binary database). I guess location can be a good
flag from PDW.( directly writing the location into table would be
better?)
- Fixed a minor typo at vivillontables.
- Working on adding PGL Gift from Dream World
2017-03-23 21:26:57 -07:00
Kurt
a922bda342 Fix relearnmove suggestion for eggs
Closes #979
Forgot that the window deal was initially programmed to check the order
of the base moves as well, but inheritance allowed them to be shuffled
in.

suggestion is always count=4 due to earlier padding, no need to Take(4).

--mud;
2017-03-23 20:05:13 -07:00
Kurt
cb24ba2857 Add PID-nature/gender checks for 3-4(5)
nature is no longer associated on gen5

split up medals check and some encounter checks
2017-03-23 19:47:53 -07:00
Kurt
7c05bf2aa9 Simplify addExtraTableSlots
remove unnecessary ToArray() as the output of the method is always
ToArray'd
2017-03-23 18:38:31 -07:00
Kurt
e779498aae Cap gen6 boxes unlocked at 30
Closes #975
Doesn't hide the 31st box from the editor, only prevents
adding&selecting 31 from the dropdown for unlocked count.
2017-03-23 18:17:22 -07:00
Kurt
121a821180 Fix clickOT order of operations
Closes #976
subregion was set first, but changing the country caused it to reset the
subregion to 0/existing value.

thus, load country first then subregion (why not move 3DSReg first 👍
)
2017-03-23 18:10:14 -07:00
Kurt
6b25367be7 Change vivillon check invalid->fishy
compact the table for easier browsing
2017-03-23 18:07:15 -07:00
Kurt
05d31ef530 Update relearn check logic
No functional change, just a little optimization and grouping of
suggestion logic (can be more easily commented out if making a slimmer
checker)
2017-03-23 17:57:21 -07:00
javierhimura
0d4c724783 Fix addExtraTableSlots for areas only in extra table (#977)
* Add shellos and gastrodom alt form in east sea locations

* Improved MarkG4AltFormSlots

* Remove inside of truck

* Move code for group by Areas to a propert function, to avoid duplicate code, also group by Areas in gen 2, 6 and 7. Is not needed in gen 1

* Reduce all gen7 areas

* legality_en.txt file format fix

* addExtraTableSlots: Include locations from the SpecialSlots array that does not exits in game GameSlots array
changed the types to IEnumerable to avoid using multiple ToArray when the function is used more that one time for the same game

* Fix Shellos AltForm location
2017-03-23 14:50:01 -07:00
Kurt
49b35371f4 Merge pull request #973 from wwwwwwzx/master
Impl vivillon form legality checking
2017-03-23 11:37:28 -07:00
wwwwwwzx
e0b68bf9b7 Fix typos 2017-03-23 04:22:15 -07:00