Commit graph

106 commits

Author SHA1 Message Date
Kaphotics
9f528e18a0 Add level check for invalid encounters
Extra hints :)
2016-04-11 18:44:26 -07:00
Kaphotics
53da8c3b87 Skip ID check if EncounterTrade
SID = 0 is totally valid.
2016-04-07 22:27:36 -07:00
Kaphotics
e8cc1a386d Add egg level check
Catches level 12 charizards and level 50 tyranitars that were bred
2016-04-07 18:19:21 -07:00
Kaphotics
52ab0bd8d7 More strict checks
Only fishy adds.
Matching TID/SID
Matching PID/EC
Matching EXP/Level
2016-04-07 17:56:39 -07:00
Kaphotics
d3fbaed225 Remove moveID references, use language strings
Fixes #96
The legality core should not rely on text resources for legality output,
and move IDs are meaningless to the common user.
2016-04-06 18:13:43 -07:00
Kaphotics
12c9636a09 Add better contest stat checks
A pokemon from XY that has never been traded cannot have contest stats
other than 0.

Milotic cannot be Beauty-LevelUp evolved in XY as an untraded mon.
2016-04-03 21:46:05 -07:00
Kaphotics
87b65c4c5b Add Link shiny check
Thanks hehrerh!
2016-04-03 16:56:57 -07:00
Kaphotics
42f13c6294 DexNav Hidden Ability
Thanks Wanderer1391!
2016-03-30 19:55:27 -07:00
Kaphotics
8af8602c31 Fix Link Trade eggs
Thanks Wanderer1391!

Traded eggs get their Met Location set to 30002.
When an egg hatches, if Met Location > 0, copy Met Location to Egg
Location and set Met Location equal to current overworld location.
2016-03-30 19:07:52 -07:00
Kaphotics
4869f188bd Check memories for eggs/transfer
Catches some of those jan2014 banked pentagon mons without OT memories
The last check is unused; the last two checks are designed in case past
gen pkm are checked.
2016-03-30 18:53:34 -07:00
Kaphotics
7f8f8c4756 Check Pokeball outside & before egg ball chk
Fixes Fossil pkm getting flagged.
2016-03-28 22:36:01 -07:00
Kaphotics
c00651078a Add Gen3/4 Ball exclusions
Additional Changes:
Removed duplicate EncounterLink check
Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-28 22:30:23 -07:00
Kaphotics
65901f7f41 Add more strict ball checks
Sport/Apricorn/Safari/Dream checked

Also snuck in encountertype tracking for readability/calcOnce
2016-03-27 22:05:51 -07:00
Kaphotics
908ff709c6 Add Apricorn & Hidden Ability check
Thanks Eskuero!
2016-03-26 20:52:06 -07:00
Kaphotics
7a7c8488f3 Add Ingame Trade OT/Nick check 2016-03-26 17:23:53 -07:00
Kaphotics
7868b925d3 Add Master Ball & Gender based Ball checks
Safari ball and general ball checks for past gen pkm are still weaker
than they can be.
2016-03-26 17:12:09 -07:00
Kaphotics
ae424cb116 Update changelog (03-26-16)
new release posted (03-26-16)
2016-03-25 20:39:31 -07:00
Kaphotics
a2c42a2293 RelearnMove suggestion instead of copyMoves 2016-03-25 00:10:11 -07:00
Kaphotics
6d6866de64 Add Link origin game lockouts
Certain link gifts can only be received in certain games.
2016-03-23 17:57:22 -07:00
Kaphotics
092a34e239 Move MatchedWC6 into EncounterMatch 2016-03-22 22:49:46 -07:00
Kaphotics
38d67c9ef1 Refactor Safari to be an encounter slot 2016-03-22 22:31:30 -07:00
Kaphotics
36d74b8d85 Refactoring & Fixes
Add tracking for wild / link encounters
Fixed sylveon ball check
Added Demo link pkm
Added Horde Hidden Ability checks
2016-03-22 19:47:13 -07:00
Kaphotics
fa68aa7a29 Minor fixes
Fix ribbon bits, fix formchange
2016-03-21 23:43:03 -07:00
Kaphotics
903f070e61 Fix Link ribbon check 2016-03-21 23:30:31 -07:00
Kaphotics
8211509d99 Add Ingame Trade ability, chk Fix Egg Ball chk
Missed the return at the end
2016-03-21 21:50:39 -07:00
Kaphotics
b109af18e7 Add History check, Expand ball check 2016-03-21 21:31:06 -07:00
Kaphotics
e938aa6765 Add more stringent wc6 comparators 2016-03-21 19:53:02 -07:00
Kaphotics
b05b66810c Add Ball/Ability checks & wc6 PID check
Probably am going to move the WC6 fetch logic out
2016-03-21 08:01:08 -07:00
Kaphotics
7e6c92f343 Add ribbon legality check 2016-03-20 15:20:11 -07:00
Kaphotics
82a9850c4a Tweak nickname check severity 2016-03-19 18:06:02 -07:00
Kaphotics
0d13e812a9 Fix Keldeo Secret Sword 2016-03-19 07:53:55 -07:00
Kaphotics
d57533ea77 Add level check
Met level > Current Level
2016-03-18 22:49:21 -07:00
Kaphotics
213578163e Fix shedinja logic
Can have egg moves, and locations are irrelevant
2016-03-17 19:37:06 -07:00
Kaphotics
d436caf273 Minor tweaks 2016-03-17 18:28:51 -07:00
Kaphotics
d986b3bb86 Add ingame trade checks
There's memories associated, IVs, EVs, whatever; best to check them in
the individual legality check methods.
2016-03-17 17:25:21 -07:00
Kaphotics
d471c965aa Add fossil encounter checks 2016-03-16 19:15:49 -07:00
Kaphotics
eedddce9a3 Fix dexnav & static encounter locations 2016-03-16 07:45:02 -07:00
Kaphotics
b9893a9472 Minor fixes
Fix hot springs egg location
Fix link gift not returning valid
2016-03-15 22:04:04 -07:00
Kaphotics
7477d4d20e Farfetch'd edge case 2016-03-15 21:40:11 -07:00
Kaphotics
820412e93b Add Egg name checks 2016-03-15 21:15:40 -07:00
Kaphotics
dc4628abe1 Add XY/AO attribute for PK6
A little more explicit.
2016-03-15 19:06:13 -07:00
Kaphotics
116f941dcf Add Nickname legality check 2016-03-15 18:56:18 -07:00
Kaphotics
9b9775b013 Add Friend Safari exclusive forms 2016-03-15 18:35:40 -07:00
Kaphotics
1a2aee930d Add Keldeo move mismatch
Probably going to move to a form check later.
2016-03-14 23:54:13 -07:00
Kaphotics
425de6242a Add duplicate move check
Cleanup the class too.
2016-03-14 23:26:51 -07:00
Kaphotics
c7cb52ecbd Add Shedinja encounter check 2016-03-14 17:04:03 -07:00
Kaphotics
ef8a0ca708 Check for DexNav amped species
Level mismatch on regular wild check was lacking a comparison for
dexnav.
2016-03-13 20:45:18 -07:00
Kaphotics
49e7225c3e Refactoring
Tanabata Jirachi has an underleveled move (illegal), so we have to track
some data. Move LegalityCheck back into LegalityAnalysis, but in a
separate file still.
2016-03-13 20:19:04 -07:00
Kaphotics
7f2b382353 Fix ability check wild 2016-03-13 18:37:54 -07:00
Kaphotics
c1f5c450c2 Add ability check for wild pokemon 2016-03-13 16:42:03 -07:00
Kaphotics
cc8f962acd Add Static/Friend Safari Encounter checking 2016-03-13 14:56:25 -07:00
Kaphotics
74f02eb16f Further relearn tweaks 2016-03-12 14:07:57 -08:00
Kaphotics
cc9cee5d1a Tweak egg move check
Renamed some variables, fixed an internal error
2016-03-12 10:35:17 -08:00
Kaphotics
0ebbcbccb4 Move Legality check rewrite
Moved to checks
Returns why it's invalid
Added base egg move checks -- all eggs need level1 moves, can only be
pushed out. The move table acts as a sliding window; grab a list of
level1 moves, tack on relearn moves, then observe window view (last 4).
Added egg met level check
2016-03-12 09:16:41 -08:00
Kaphotics
c4612e2d9f Legality ContextMenu now returns analysis
Hooked up all the methods and can spit out if invalid.

I plan to put a legality indication where QR! was, but the legality
analysis needs more checks (moves, ability, nickname, ball, fateful...
you get it) and stability.

Have fun playing with the initial legality checks 😄
2016-03-11 19:43:40 -08:00
Kaphotics
b6fca5b306 Add some basic legality checks
Besides moves/encounters, we can check validity of certain traits.
2016-03-10 20:36:32 -08:00