Species selection should be limited to species available in game; upon
adding S&M these comboboxes are ready!
The CB_HeldItem in SAV_SecretBase doesn't need filtering as it is
limited when the SAV is loaded to the main form.
Added an Edited property for the save
blank slot (encrypted) is initialized once and can be used elsewhere
instead of constantly being recreated for no reason.
Fixed having 32 boxes for non-saves
All SAV editing forms now set the Edited flag when saving->close.
Probably breaks a thing or two... time to get testing after this new
commit.
Wrapping the stored 'savefile' into an object which handles its use
allows a clearer separation of function and easier maintenance or future
updates.
May eventually move all get/sets for each form to allow property
fetching from any window, all logic handled within the class.
Big thanks to Siobonbon for finally clearing up the muck that had been
sitting around for so long 👍
The mysterious dex flags are much clearer now, there is no 'via trade'
flag (it's the forms owned flag)
Remove numerous inter-form dependencies, remove hard-coded offsets,
update a few spots to use better programming practices.
Should increase the readability of PKHeX's source code.
Shouldn't call setup methods after setup is complete; I extracted all
necessary operations that need to be repeated (loading the bitflags)
into a separate method.
Thanks ShaKage!
