20 commits

Author	SHA1	Message	Date
Kurt	1486b7f14a	Misc style & minor tweaks ... Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes	2018-08-02 20:11:42 -07:00
Kurt	9a91619580	Update vc1 invalid transfer pruning ... Closes #2065 Thanks @WEERSOQUEER ! Single evo species weren't getting flagged in the evolution verification as they early returned (species matched), just move the sanity check before that	2018-07-19 16:42:45 -07:00
Kurt	d45a8afef2	Remove erroneous chain trim logic ... latter half of the method seems to do everything that is required Closes #2048	2018-07-09 21:26:45 -07:00
Kurt	9a57469ec3	Update shedinja chain handling ... Closes #2045 4ac92b9418 had added it; assuming to undo lvl-1 => lvl for gen3/4. Level Up, Learn Nincada Move, Evolve to Ninjask & spawn Shedinja, then learn any Ninjask Moves. Gen3 reverses the spawn&learnNinjask steps, which is handled separately Thanks @XxPhoenix1996xX !	2018-07-09 20:18:31 -07:00
Kurt	d477e19cf0	Simplify ball/catchrate lineage checks ... should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.	2018-07-01 10:15:10 -07:00
Kurt	77aed3ea14	Adjust levelmin on single evochain ... Early return wasn't adjusting the minimum level; closes #2035	2018-06-27 17:41:53 -07:00
Kurt	09c96558ea	Disable gen2 chain clamp ... not sure of the implications, but fixes #2031 might have to rework this method to clean up the optional params if things are misbehaving	2018-06-24 08:02:22 -07:00
Kurt	7a0b65e74f	Add low bound range check for species not in chain ... Closes #2028 Thanks @iiippppk !	2018-06-23 08:23:05 -07:00
Kurt	173c9f7904	Update evo chain trim for transfer ... Now trims correctly for g3 sneasel -> weavile (gen4 having both) at level = met level	2018-06-22 23:18:52 -07:00
Kurt	5dd58c7197	Update gen1 evo chain detect ... Closes #2017	2018-06-22 22:48:10 -07:00
Kurt	76e52fa2cd	Simplifications ... Rearrange some logic, track decrement, remove unnecessary checks	2018-06-22 20:16:31 -07:00
Kurt	3000a8d007	Reduce linq usage ... No longer recreates collections with ToArray/ToList by instead altering the original chain	2018-06-22 19:40:17 -07:00
Kurt	346c401727	Rework initial evochain trim ... push unsaved IVTotal/EVTotal stuff from prior commit rework exposed types for evo chain initial trim now uses much less linq can probably redo the get initial chain to provide a species to break on...	2018-06-22 17:59:02 -07:00
Kurt	1db41c8b21	Add vc2 evo chain check ... queue should be checking against none left rather than any left. Add test cases	2018-06-20 21:43:54 -07:00
Kurt	ce667729f3	More simplifications ... Can't have species == 0 or invalid gameversion; check for EncounterInvalid instead. Egg chain is always valid (since it is not EncounterInvalid) thus always provide the chain. Since these 2 are the same, simplify the logic to be shared. rearrange some parameters for easier flow	2018-06-20 21:38:56 -07:00
Kurt	47d8220915	Evo chain Simplifications ... Rename "Flag" to "Method"; isn't used besides for indicating the evo Method. Remove some unnecessary duplicate checks - always >=1 in chain at start - mostEvolved already checked for > maxspeciesgen	2018-06-20 19:42:45 -07:00
Kurt	bfdd7247ba	Rewrite most evolved species check loop ... Use queue collection rather than rebuilding with .Skip(1).ToArray() move size checks to dequeue location	2018-06-20 18:25:23 -07:00
Kurt	2ef12f635f	Continued refactoring ... move sylveon check to requireslevelup need to make this generic for transfer species gaps	2018-06-20 15:59:57 -07:00
Kurt	c5ea35a1a1	Continued refactoring ... Move chain prune from Analysis to evochain spawn	2018-06-19 17:50:10 -07:00
Kurt	f10cc183a7	Refactoring ... Relocate Evolution Chain logic minor reorg of check arguments for nesting / grouping	2018-06-19 17:14:22 -07:00