Kurt
93ff841a1d
Update EncounterMovesetGenerator.cs
2020-11-10 22:17:23 -08:00
Kurt
7654ce2123
Add initial legality checks for GO->HOME transfers
...
took me less than an hour to do these changes, and i can flag bad form movesets no problemo
Expect tightening of restrictions (ball, level, shininess) later
if someone wants to curate met date restrictions, go ahead!
2020-11-10 22:10:53 -08:00
ShadowMario3
7b2f76b621
Fix issue #3083 ( #3084 )
2020-11-07 22:48:46 -08:00
Kurt
cb24c20a44
Remove relearn suggestion logic from relearn move verification
...
Sure it's nice to cache a valid array, but the amount of logic was small enough that it can be done with 10 lines of code rather than at the end of each verification method.
Reduces parameter passing & removes 1 field from the info object, as relearn suggestions are only done rarely after legality checking.
Allows for a simpler api surface (pkm, encounter) rather than a bigger object reference
2020-11-07 12:25:15 -08:00
Kurt
227efc1fc3
Only allow checking if lvl60 when lvl<60
2020-11-05 21:17:13 -08:00
Kurt
51c872f4e1
Move more logic closer to where it's used
2020-11-02 14:46:26 -08:00
Kurt
7cb6ee0060
Move some static arrays closer to where they're used
...
Split EvolutionRestrictions to its own class
Can probably refine things further to clamp down access to these arrays
2020-11-02 13:11:51 -08:00
Kurt
b4c9e90c28
Enhance transparency in failed generator test
2020-11-02 13:03:08 -08:00
Kurt
64a6214b82
no nuts here
2020-11-01 16:05:55 -08:00
Kurt
24346cc4e1
Update EncounterTrade1.cs
2020-11-01 15:58:42 -08:00
Kurt
4db6661ffd
Handle JP-Blue trade quirks + stadium2 trade bypass
...
Co-Authored-By: ShadowMario3 <36941677+ShadowMario3@users.noreply.github.com>
2020-11-01 15:27:54 -08:00
ShadowMario3
7659b57c4f
Corrected catch rates for the Haunter and Graveler trades. ( #3071 )
...
* Fix catch rate for JP Blue trade evolutions
2020-11-01 14:39:49 -08:00
Kurt
d7042fb19e
Inline parameter passing
...
nothing passes anything, so swsh is default
shared raids yay
2020-10-30 19:56:37 -07:00
Kurt
a33120c93e
Boo
...
Poor Gourgeist-0&2 being left out of the 60-shiny club...
Mimikyu is a repeat from the Pikachu Mass Appearance in early August.
2020-10-29 19:34:17 -07:00
Kurt
62d5375f67
Update EncounterStatic8U.cs
2020-10-29 08:52:38 -07:00
Lusamine
5e92b7b5f7
Add crossover and static encounters for CT ( #3050 )
...
* Add crossover encounters for CT
* Old Cemetery -> Giant's Foot
* Add some static encounters
* Add Frostpoint Field -> Freezington crossover
2020-10-27 22:08:49 -07:00
Kurt
cb545781b0
Split off es5dr to separate file, require never shiny
...
Shiny check was mistakenly forgotten :)
2020-10-27 18:03:45 -07:00
Kurt
82c579da82
Disallow E birth island deoxys with JP origin
...
Closes #3040
Ty @Atrius97 !
"The Japanese Aurora Ticket was only distributed in Summer 2004, before Emerald (Sept 16th 2004) was released. The software at that time had no support for Emerald games."
2020-10-25 21:42:14 -07:00
ReignOfComputer
43d031604f
Static Encounters Update ( #3044 )
...
Alakazam in the Insular Sea (on the Isle of Armor)
Zapdos at Watchtower Ruins (in a Wild Area)
Zapdos at West Lake Axewell (in a Wild Area)
Moltres in the Soothing Wetlands (on the Isle of Armor)
Moltres on Challenge Beach (on the Isle of Armor)
Moltres in Loop Lagoon (on the Isle of Armor)
Dragapult in the Giant’s Bed (in the Crown Tundra)
Nidorina in Frostpoint Field (in the Crown Tundra)
Glalie on Snowslide Slope (in the Crown Tundra)
2020-10-25 18:10:07 -07:00
ReignOfComputer
29408e3ada
Static Encounter Updates ( #3043 )
2020-10-24 12:33:14 -07:00
Kurt
0c8966796e
Add wild area strong encounters for Crown Tundra
...
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
Co-Authored-By: Chris <28743231+Bappsack@users.noreply.github.com>
Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com>
Co-Authored-By: Archit Date <architdate@gmail.com>
2020-10-24 11:24:01 -07:00
Kurt
2e4af1afc5
Update legality comparisons for Crown Tundra
...
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2020-10-24 11:16:01 -07:00
Kurt
9b2d7c0341
Minor tweak
...
no functional change, just use Generation instead of recomputing
2020-10-24 11:11:53 -07:00
Kurt
799dbde1a2
Add Nest Data for Crown Tundra
...
Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2020-10-24 11:06:05 -07:00
Kurt
8c4b7e9060
Prefer form match for suggested encounters
...
Closes #3038
2020-10-19 11:54:59 -07:00
Kurt
83171ab133
Change shininess check
...
Encounter definitions should be marked as Never Shiny or not in their definition, rather than assuming
2020-10-18 16:05:01 -07:00
Kurt
a4baec9939
Check shiny state for GB Era events
2020-10-18 10:57:18 -07:00
ShadowMario3
f6476a4737
Add Gen 1 North American Mew Events ( #3036 )
2020-10-18 10:01:55 -07:00
Kurt
7a01b1249c
Minor clean
...
Handle more messages, add more xmldoc
2020-10-18 09:43:41 -07:00
Kurt
c09fb9a0ec
Simplify "Flag" field in move source tracking
2020-10-17 13:40:12 -07:00
Kurt
2e8586f364
Read swarm slots correctly
2020-10-13 15:37:18 -07:00
Kurt
1524093099
Revise g5 pid bit check for forced PID statics
...
Closes #3027
Roamers: Get PID generated externally
NPokemon: Get PID from a fixed value
Forced (Anti)Shiny: Get PID altered
Thanks @LegoFigure11 && Princess Emily (discord 4650) !
2020-10-12 11:04:29 -07:00
Lusamine
e6e3166f13
Add Comfey from Honeycalm Island ( #3023 )
2020-10-10 10:07:17 -07:00
ShadowMario3
ba4eadfde9
Add location for Stadium 2 Events ( #3022 )
...
* Fix game version for International Gen 2 events
* Add Stadium 2 Event location
2020-10-10 08:13:54 -07:00
ShadowMario3
559ec76812
Fix game version for International Gen 2 events ( #3018 )
2020-10-08 15:57:19 -07:00
Kurt
3686ee9ec4
Set suggested Encounter Type on Met Location click too
...
Closes #3010
2020-10-08 15:01:23 -07:00
Kurt
0de76b57b1
Handle incorrect bred stunfisk local form value
...
The game uses 0x5E if 0x5A+everstone, otherwise it uses 0x58
For determining the seed species-form, we want to use everstone breeds as that resolves to the correct species-form values.
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Marty-D <1645989+Marty-D@users.noreply.github.com>
2020-10-08 13:12:25 -07:00
ShadowMario3
482dbf0b17
Update Encounters2.cs ( #3017 )
...
Fix OT for PCNY eggs
2020-10-08 08:32:18 -07:00
ShadowMario3
9516458491
Changed es1e to allow multi-OT ( #3016 )
...
* es1e allows multi-OT, merged Stadium Psyduck OTs, added Yoshira Mew
* fixed spacing on Gen 1 event OTs
2020-10-08 07:10:10 -07:00
ShadowMario3
7aac80769b
Update Encounters2.cs ( #3015 )
...
Met + Current level data for non-Egg PCNY Pokémon and Egg legality for PCNY Pokémon fixed.
2020-10-07 18:42:14 -07:00
Kurt
e3ef9bbbff
Add current level property for met:X current:Y
2020-10-07 15:35:12 -07:00
Kurt
dad01cb522
Check egg state, reduce verbosity for language type
2020-10-07 15:28:58 -07:00
ShadowMario3
a81e675d26
Update Encounters2.cs ( #3014 )
...
Added the remaining PCNY events. Still need to fix shiny Pokemon where Met Level is 5 but current level is 40, 50, or 70 depending on Pokemon).
2020-10-07 11:43:34 -07:00
Kurt
5d40009a0c
Add multi-OT for es2e, apply special details on enc->pkm
2020-10-07 10:36:28 -07:00
ShadowMario3
4bae0e823a
Update Encounters2.cs ( #3013 )
...
Started to add some Gen 2 PCNY Event Pokemon and fixed Stadium 2 events.
2020-10-06 22:12:05 -07:00
Kurt
6616996905
Relocate N OT logic
...
Make Legal.cs not care about encounter data :)
2020-10-06 20:09:14 -07:00
Kurt
fe7a4df17e
Clean out some gb era version flagging
2020-10-06 20:05:38 -07:00
Kurt
6e1cbfcfe5
Split GB event types and segregate per VC/GB
...
Handle yielding in the moveset generator as well
Future commits will trim down unused values/abstractions; probably can get all the stadium stuff handled innately
2020-10-06 19:35:03 -07:00
ShadowMario3
1681fc776b
Update Encounters2.cs ( #3011 )
...
Fix Sing Pichu index number.
2020-10-06 10:59:18 -07:00
Kurt
6938d2f94d
Split VivillonTables into two classes
...
Indicate that the content is for 3DS specific logic
Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin
2020-10-04 14:15:13 -07:00