Kurt
f83a9bf833
Expose shiny potential value
...
Not really digging it currently as it doesn't cover multi-state like AlwaysStar-Or-Never, but that single edge case can be handled elsewhere
2022-01-07 17:48:12 -08:00
Kurt
a08330ffd4
Update MoveSetApplicator.cs
2022-01-03 22:27:20 -08:00
Kurt
36bf73818e
Source trainers for encounter database
...
Closes #3364
Related: #3358
2022-01-03 19:33:10 -08:00
sora10pls
3f1335e19f
Add Zone unlock cheat to BDSP Misc Editor
...
As with most event work tampering, make sure you keep save backups. Accessing areas before you're intended to will almost certainly break story progression.
2022-01-03 11:06:06 -05:00
Kurt
47071b41f3
Refactoring: Span-based value writes and method signatures ( #3361 )
...
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.
`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.
The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.
Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-02 21:35:59 -08:00
Lusamine
a9896022ed
Allow Ninjask moves on Gen 4 Sport Ball Shedinja
2022-01-02 21:12:46 -06:00
MewTracker
d5a79079c0
Added named constant for BDSP swarms ( #3362 )
2022-01-02 15:43:18 -08:00
Kurt
4b8adfe28d
Bump winforms proj c# lang to 10
...
no functional change
2022-01-02 15:04:16 -08:00
Kurt
bee4a54148
Ignore encounter if bad catch rate
...
Waffling on this, let's just be less lenient in error messages and just outright reject the encounter.
2022-01-02 15:03:04 -08:00
Kurt
3f769d6f52
Update 22.01.01
2022-01-02 00:53:37 -08:00
Kurt
0cf7b22363
Fix init of custom work value, fix write of named workval
...
Closes #3357
2022-01-01 23:23:44 -08:00
Kurt
ae70525fd5
Use correct reference for unlocking events
...
Was unlocking the real save file, not the editing-shadow. Oops
2022-01-01 23:15:37 -08:00
Kurt
7b4099030a
Properly flag gmax in bdsp
2022-01-01 23:11:45 -08:00
sora10pls
eb71576803
Add New Year's distribution raid data
2021-12-31 19:04:35 -05:00
Kurt
ac1136615e
Fix rival string read/write to General
2021-12-31 13:52:50 -08:00
Kurt
2de2ed4985
Merge branch 'master' of https://github.com/kwsch/PKHeX
2021-12-31 13:52:37 -08:00
sora10pls
a02e97a8af
Unban alternate Lake Verity zone
...
As you progress the story in the Sinnoh games, the water level in Lake Verity will rise allowing you to Surf and reach the Verity Cavern. When this happens differs between DP/BDSP and Pt.
Zone 323 has nothing to do with it being early-game and only when Rowan's briefcase is present, but rather the differing water level. Riley's Riolu Egg can be hatched here without trading, as well.
Co-Authored-By: Billo-PS <63661653+Billo-PS@users.noreply.github.com>
2021-12-28 17:26:05 -05:00
Kurt
dc4a9136ea
Remove trailing whitespace
2021-12-27 14:03:41 -08:00
Kurt
a2f61166e4
Use System.Memory for BigEndian value reads
...
Temp testing commit; will improve performance in the future
2021-12-27 13:56:52 -08:00
Kurt
76cac85243
Minor clean
2021-12-27 13:50:21 -08:00
Kurt
cc8ac7a4f1
Remove unnecessary warning suppression
...
fixed dat .editorconfig in vs22
Catching general exceptions is okay because this program handles user modified data that can potentially be corrupt.
2021-12-27 12:09:15 -08:00
Kurt
5f7caf9ca2
Tweak PB8.FixMemories for importing eggs & handler quirk
2021-12-27 01:53:28 -08:00
Kurt
29fd17a6f9
Add friendsafari to HA metadata permission
2021-12-26 23:05:25 -08:00
Kurt
24e1898410
Update gen4 Shedinja handling
...
PK4->PK5 fixes gendered Shedinja -> genderless.
Clean up PK4 ball value setters and expose those 2 properties separately.
Add edge case permission for HG/SS Sport Ball Shedinja being legal if evolved on DP (DP doesn't change 0x86, lol)
Copy PokéathlonStat and ball values individually for BK4<->PK4 conversion
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2021-12-26 20:13:36 -08:00
Kurt
f50684b794
Remove childless xmldoc
2021-12-26 19:44:04 -08:00
Kurt
749293fc75
Move BoxManip to subfolder
2021-12-26 19:43:42 -08:00
Kurt
3d7967fcfe
Fix recognition for cutecharm Nincada->Shedinja
...
GetGender would return 2, which would abort the Cute Charm check since genderless is not able to be cute-charm'd.
https://projectpokemon.org/home/forums/topic/57375-pkhex-new-update-legality-errors-contribution-page/?do=findComment&comment=271537
2021-12-26 18:22:41 -08:00
Kurt
11039f1119
Extract some event unlocking logic for core
2021-12-26 18:21:34 -08:00
Kurt
76ab09f024
Inline constant value
2021-12-26 01:06:30 -08:00
Kurt
1d0993f852
Remove EvoBase, relocate functions to call sites
...
Utilize FormInfo to remap battle forms into hatch forms so the encounter matches something valid, and is flagged later in FormVerifier
2021-12-26 00:57:40 -08:00
Kurt
5db5f04066
Don't iterate battle forms when displaying encounter lists
2021-12-26 00:44:16 -08:00
Kurt
b348e38a3e
Don't do DP english->jpn bug for BDSP
2021-12-26 00:06:10 -08:00
Kurt
192ef23052
Allow gen5 deerling and sawsbuck slots to be any form [0,3]
2021-12-26 00:00:38 -08:00
Kurt
49a2cd19d0
template=>pk4: Only ENG->JPN if DP, not Pt
...
Language bug was fixed after ENG DP (for other localizations, and Pt)
2021-12-25 23:59:18 -08:00
Kurt
ac6fd085ba
Update translation files
2021-12-25 19:03:11 -08:00
tastymeatball
2d3fae889b
Update flags_e_en.txt ( #3350 )
...
add a lot of flags to emerald
2021-12-25 18:57:02 -08:00
Kurt
9ce0da6c46
Add bdsp approximations for min sheen calcs
...
Closes #3351
2021-12-25 18:51:02 -08:00
Kurt
fbb9e0bf0e
Flag original catchrates on g1->g2->g1 transfers
...
Closes #3328
2021-12-25 18:44:37 -08:00
Kurt
13e0f35e00
Add munchlax slot checking for DPPt/BDSP honey trees
...
Closes #3352
2021-12-25 13:48:28 -08:00
Kurt
2d34411203
Fix g8 meister magikarp matching
...
5b2ad8703c
2021-12-25 12:57:05 -08:00
Kurt
defae6727d
Check bdsp version exclusive hatch locations
...
lol srsly
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-12-24 18:39:54 -08:00
Lusamine
8612404f84
Add Slippery Slope Weavile static encounter
2021-12-24 20:06:31 -06:00
Kurt
42d24ad183
Add sketch check for bdsp legends signature moves
...
Can't learn these yet
2021-12-23 01:57:53 -08:00
Kurt
46f5a9c29a
Remove inaccessible zone IDs from hatch location list
...
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-12-23 01:25:14 -08:00
Kurt
606818b835
Bounds check sketch move IDs for generation
...
Smeargle no longer permitted to have Eerie Spell in gen6 format :)
2021-12-23 01:24:47 -08:00
Kurt
4e7e23cb88
Add battle tower record editing
2021-12-20 23:48:05 -08:00
Kurt
36a97a6eda
Add misc edit to defeat all trainers & rebattle all
2021-12-20 19:26:07 -08:00
Kurt
39f8e9173e
Add contest stat batch modification
2021-12-20 19:16:23 -08:00
Kurt
1e0ac7fb26
Ban more BDSP egg moves before HOME
...
https: //github.com/kwsch/UnityDPtools/pull/2
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2021-12-20 19:00:48 -08:00
Kurt
38a4135bcd
Span-ify the unpacking of mini arcs
...
cuts out some of the internal c# sanity checking for better perf
2021-12-20 18:37:45 -08:00