594 commits

Author	SHA1	Message	Date
Kurt	8c970ec991	Minor tweaks ... no functional change, readability++ add more xmldoc	2021-06-03 12:04:19 -07:00
Kurt	138501da2f	Minor clean ... Condense some expressions Use less linq Rename some fields	2021-05-29 15:31:47 -07:00
Kurt	386d9cc94f	Repoint hall data fetches outside blocks ... Reverts prior commit repointing which was incorrect; these are outside the sav general/storage blocks. 871f9b0627 (diff-3560dca7e50959e98ae8fa32d9403f8846b9243815d653c78a07f2a3455a1874L481) Keep the first as General as it's some value index within the General block used to index which extrablock matches it, or something Closes #3211	2021-05-25 22:16:04 -07:00
Kurt	15afd6f3bc	Move mail get to sav obj	2021-05-22 09:28:04 -07:00
Kurt	f462017670	Fix padding mask ... Closes #3205 -- padding char Closes #3206 -- sav3rs doesn't use SecurityKey, it's always 0 Co-Authored-By: Michi97 <24464847+Michi97@users.noreply.github.com>	2021-05-20 08:27:08 -07:00
Kurt	74e0cba3b0	Minor tweaks ... use assert instead of manual exceptions span remove some dead logic	2021-05-18 16:16:48 -07:00
Kurt	2c820bfbe9	Minor tweaks	2021-05-18 13:29:55 -07:00
Kurt	acdbda4e12	Split DateUtil from Util class	2021-05-14 16:46:48 -07:00
Kurt	50b15cd740	Use range/index ... More in line with modernizing the codebase with latest c# syntax improve web-qr decode speed slightly (no linq skiptake) get money/coin mask without a temporary string (lol performance)	2021-05-14 15:30:55 -07:00
Kurt	871f9b0627	Convert checksum operations to span-based ... Fix SAV.Data references in SAV_Misc4 to use the General block instead	2021-05-14 12:30:40 -07:00
Kurt	d21c1fb135	Set editing mode when loading data to form ... Prevents wiping of Multiplayer sprite assignment	2021-05-12 15:44:28 -07:00
Kurt	d340642b09	Minor perf improvements	2021-05-10 01:01:45 -07:00
Kurt	778aacb9cf	Show larger sprite box	2021-04-19 23:30:46 -07:00
Kurt	0d45075d4b	Rewrite settings handling; enhance some user experiences (#3193) ... - Settings now stored as json next to exe - Settings now exposes all legality checking setttings that can be changed - Slot hovering now can play cries in MGDB/PKMDB/etc, not just the main boxes. - Enhanced hover text for mystery gifts and encounters that have movesets - Show recently loaded save files in ctrl-f browser - Toggle auto-load savefile setting to be none/detect-latest/last-loaded - Custom extensions & extra backup paths can now be configured directly in the json settings - Settings editor now uses propertygrid & tabs.	2021-04-11 18:09:54 -07:00
Kurt	329a2cbd44	Remove indirect data fetching	2021-04-09 19:44:14 -07:00
Kurt	0576b9dfba	68x56	2021-04-09 17:23:09 -07:00
Kurt	d73baebad2	Use wider sprite boxes for Mystery Gift album display	2021-04-09 16:37:32 -07:00
Kurt	c7b997865c	Minor clean	2021-04-09 14:52:49 -07:00
Kurt	f8a2bb3229	Add missing research tab flag set ... Closes #3187	2021-04-07 22:46:28 -07:00
Kurt	b0700ba281	Extract Gen7 HoF class, extend event flag count ... 4k flags exactly, and probably 4950 for USUM (alignment +1 byte for an even 4960) The old flag + count (4 bytes total) are just +32 event flags.	2021-04-07 00:20:02 -07:00
Kurt	673c0d93a6	Extract event flag/work editing from GUI ... now <200 lines for editing (ignoring the diff functions), yay Opening the editor allocates less (no copying save file)	2021-04-05 20:52:49 -07:00
Kurt	790da981f0	Fix gen3 trainer card team list ... don't bother casting	2021-04-01 14:16:33 -07:00
Kurt	645f2b4db5	Revert implicit casting ... Looks like netstandard2.0 wasn't meant to receive that new c#9 goodie	2021-03-29 00:14:44 -07:00
Kurt	3822981590	Rework EncounterCriteria to be ability indexed rather than direct ability (#3179) ... * Exploration: rework ability criteria to ability numbers desired * Sync remaining changes * Update EncounterCriteria.cs * Add xmldoc * Improve speed of IsDualGender check * More xmldoc updates Should be doing this on main but meh, this branch is gonna get merged later * Fix typo * Update WC7.cs * Update PersonalInfo.cs	2021-03-23 17:05:15 -07:00
Kurt	8d3f990667	Make some properties into consts	2021-03-20 12:47:21 -07:00
Kurt	33e2c64721	Split SAV3 into version classes ... Begone are the version-switch cases for value fetching.	2021-03-15 23:51:58 -07:00
Kurt	6bce4eea14	Minor clean ... Annotations (nullable), some switch cases for readability	2021-03-14 16:16:55 -07:00
Kurt	4f6258e492	Add direct object editing for accessor type saves	2021-03-14 16:14:15 -07:00
Kurt	49541e6073	Rework mainline sav3 to not operate off chunks ... Previous style was to resize the sav buffer and concat all the storage chunks at the end. Allocated a double save file. Now, just allocate 3 buffers.	2021-03-07 23:22:07 -08:00
Kurt	8145456ca8	Add u32 hex key -> enter to jump to key (ignoring named blocks)	2021-02-27 22:34:05 -08:00
Kurt	c11cf3d6d4	Extract gen4 pokedex logic	2021-02-21 09:59:10 -08:00
Kurt	a7cc51f633	Show alolan height/weight records	2021-02-05 07:46:06 -08:00
Kurt	4c49d489a8	Update SAV_Inventory.cs	2021-01-20 20:01:59 -08:00
Kurt	46b988b6fa	Remove unused checkbox	2021-01-20 17:06:37 -08:00
Kurt	3c42978afa	Use IndexOf instead of FindIndex when possible	2021-01-16 12:47:02 -08:00
Kurt	613e6db744	Use StringConverter api consistently; use stringbuilder when possible ... Retain a stringbuilder to mutate the string rather than finalizing temporary strings yields some speed improvements (less gen0 string objects allocated)	2021-01-14 22:50:13 -08:00
Kurt	3e0b52195a	Minor clean	2021-01-08 13:17:59 -08:00
Kurt	f615814548	Add xmldoc, increase swish util flexibility	2021-01-07 15:34:26 -08:00
Kurt	cc43550357	Simplify more expressions	2021-01-04 17:31:43 -08:00
Kurt	09089da14e	Use more expression return style ... Reduces indentation & bracketing, a bit more concise	2021-01-01 17:08:49 -08:00
Kurt	2af9e800fb	Add RotomAffection and rotoloto1/2 flag editing to GUI	2020-12-29 11:39:19 -08:00
Kurt	d9a4eacaf4	Allow deactivating all raids	2020-12-29 10:53:47 -08:00
Kurt	e8c23f6644	Simplify some repeated comparisons with expressions ... Less prone for bugs since it uses the same value for all comparisons without re-specifying	2020-12-29 00:37:59 -08:00
Kurt	c119f18af3	spec->species	2020-12-28 22:22:52 -08:00
Kurt	0a46f45b00	Split MetDataSource from GameDataSource	2020-12-28 21:12:46 -08:00
Kurt	74ee22e66e	Make ComboItem a record	2020-12-28 11:57:34 -08:00
Kurt	7298910f04	Simplify some logic ... The save editor buttons were originally checked for visibility in order to determine if we should hide the groupbox completely. This didn't work if the groupbox wasn't being displayed (get visibility checks if it is currently rendered, in addition to can be shown). So the "enabled" state was used to determine if it should be shown. Now that we have the "Blocks" raw editing always being shown, the GroupBox will always be shown. Can just set the visibility directly, rather than doing the workaround. Make the hall of fame editors slightly less SaveFile_type-specific.	2020-12-28 10:26:08 -08:00
Kurt	ee5349ff98	moar is or	2020-12-25 12:30:26 -08:00
Kurt	4a8a495d04	Condense some switch expressions ... Should be it for now; exhaustively searched for all that made sense to change	2020-12-25 10:58:33 -08:00
Kurt	93910df2c6	Use new switch statements	2020-12-23 17:14:38 -08:00