Kurt
e81e5f31da
Remove shadow info index shift
...
Thanks @PP-theSLAYER !
https://projectpokemon.org/home/forums/topic/53405-bug-oddity-with-shadow-recognition/?do=findComment&comment=246125
2019-06-20 20:39:34 -07:00
Kurt
63c705061d
Add recognition for Method 3 encounters
...
Pass them as Legal for wild encounters similar to M1/M2/M4.
Add test cases & test pkm validation
Add pid generator support
I decided against checking these PIDIVs after all others; inlined
methods.
Closes #2328 , thanks @pokecal !
2019-06-19 19:15:06 -07:00
Kurt
dc813da2f7
Add DisplayTID/SID getset
2019-06-19 17:49:56 -07:00
Matt
08835d5d97
Fix ORAS held items/personal reference ( #2329 )
2019-06-19 12:18:09 -07:00
Kurt
5fbf9ba278
Fix cloning of a bad-checksum pk3
2019-06-18 20:55:35 -07:00
Kurt
e02f7ef30f
Reduce allocation required for ability check
2019-06-18 20:54:59 -07:00
Kurt
523c36d982
Add qr parse util
...
used in pkhex.mobile, might as well migrate some logic into core
I'd rather not untangle the decode-api response parsing to use QRUtil.
2019-06-18 20:10:01 -07:00
Kurt
55d486af31
Extract event block diff logic
2019-06-18 18:10:48 -07:00
Kurt
3083b04223
Add all combinations of gameversions
...
closes #2327
recent refactorings resulted in B/W being returned instead of BW
2019-06-17 20:55:36 -07:00
Kurt
de77f949da
Prevent assert on non-exportable saves
2019-06-17 20:55:01 -07:00
Kurt
14138121a9
Fix importing qrs from non gen6/7
...
null\\/# instead of null/# when fetched via API
2019-06-15 15:29:45 -07:00
Matt
59a7e247cb
Update GO Shiny banlist ( #2325 )
2019-06-13 08:46:53 -07:00
Matt
186adca755
Unban GO Shiny Onix ( #2323 )
2019-06-10 22:33:34 -07:00
Kurt
7225b2b87b
Add more sav1/2 option properties
...
Closes #2321
Closes #2322
no gui as SimpleTrainer is kinda getting overloaded; use linqpad or wait
for someone to make a GUI for the specific games
2019-06-09 14:15:42 -07:00
Kurt
455ab32722
Retain override version on clone
...
Also hide the pika friend label when YW features hidden #2283
2019-06-09 13:48:51 -07:00
Kurt
a30a00317f
Add missing trainer location overrides
...
Was missing from #2319
2019-06-08 20:19:39 -07:00
Kurt
904dc84b52
Decapitalize non-nicknamed on 4->5 transfer
...
Closes #2320
2019-06-08 20:16:30 -07:00
Kurt
1b028198ad
Split gen5-7 saves with inheritance ( #2319 )
...
refer to pull request comments for summary
2019-06-08 19:56:11 -07:00
pokecal
84d1354e2f
Update EncounterArea.cs ( #2318 )
...
fix FishingTable of Route12,13(same as R32), R14(water inaccessible).
Some issues about Qwilfish will be solved.
2019-06-07 19:24:59 -07:00
Kurt
0007904cb4
Allow party only forms in party/bbox/daycare
...
Closes #2317 thanks @iiippppk !
2019-06-06 19:53:11 -07:00
Kurt
de774ed131
readonly ComboItem
...
create once, never modified after
2019-06-01 19:12:41 -07:00
Kurt
2b8ef9236a
use some explicit dex numbers as enum
2019-06-01 10:22:49 -07:00
Kurt
36114e6ff9
Update checksum on templating
...
pk3 loading tries to decrypt shuffle or something; this makes it work
2019-05-29 22:50:34 -07:00
Kurt
9cdbc46740
Relocate apply basic template out of gui
2019-05-29 22:40:39 -07:00
Kurt
a9152d36a4
Minor tweaks
...
make some enums non-int (in favor of byte etc)
return current nickname if desired
clamp nature top bound too
2019-05-29 22:40:07 -07:00
Kurt
5879cc8a18
Extract some pkm gui logic
...
probably won't stay this way if things are eventually rewritten; too
much business logic in the pkmeditor.cs, would need a ton of abstraction
2019-05-29 21:35:52 -07:00
Kurt
144a78d688
Relocate method
2019-05-29 16:42:48 -07:00
Kurt
8d781fd167
Simplify sorting to remove linq usage
...
create custom comparer to do the work
reorder some parameters
simplify gb hm set (All and FindIndex is duplicate work)
only usages of linq remaining are for the bulk action Where filtering
(ok)
2019-05-28 22:55:41 -07:00
Kurt
513648638f
Fix incompatible hax conversion (1/2->3 etc) error
...
Shared base classes throw a new snag, where the property may be Declared
in the shared class.
eg:
PKM -> _K12 -> PK2
just filter all public ones that have a setter; works well enough idk
2019-05-28 16:52:59 -07:00
Kurt
a45cddd3ed
Add missing hax item clamp early return
...
Closes #2281
remove unnecessary "else", and break for visual separation
2019-05-27 21:38:04 -07:00
Kurt
33a07a6fcd
Try and force destination language on transfer
...
Closes #2314
2019-05-27 11:23:47 -07:00
PP-theSLAYER
88d7be62d9
Removed Special Funfest Poliwag & updated min Lvl. ( #2315 )
...
According to the link below, the official page states that Poliwag's announcement was a mistake, and they clarified it would not be appearing.
This message was echoed across various pages (Sapporo, Fukuoka, Tohoku), not just the Yokohama one.
https://voice.pokemon.co.jp/stv/yokohama/2013/08/post-2286.html
Additionally, based on tests from me and jojo, Funfest missions forces the grotto encounters to be max level (of the individual grottoes).
https://projectpokemon.org/home/forums/topic/39810-unlock-all-funfiesta-missions/?do=findComment&comment=245303
2019-05-27 00:39:36 -07:00
PP-theSLAYER
968f850138
Added Funfest week 3 encounters ( #2312 )
2019-05-21 23:37:47 -07:00
Kurt
6e8f7fe680
Fix pgf gender criteria roll
...
got stuck in an infinite loop for PID (gender invalid from the start)
https://projectpokemon.org/home/forums/topic/52873-pkhex-mystery-gift-database-not-working/
2019-05-20 18:35:57 -07:00
Kurt
9b8b8f784a
Revert "Add another vc nature checks"
...
This reverts commit b51bdc9230
.
2019-05-20 17:05:53 -07:00
Kurt
52bfa50641
Simplify font loading
...
Don't care about operating system; use the AddFontFile method instead.
Add fallback for font load failure.
This should be easier to maintain in the future, if multiple char->glyph
mappings are to be supported (gen6 is already different from gen7 with
some swapped glyphs).
2019-05-19 14:37:15 -07:00
Kurt
d1bc1d07c8
Disallow shiny aura
...
if hadou were here, it'd get the same anti treatment too
2019-05-17 17:48:45 -07:00
Kurt
827eb94f3c
Add GameSync r/w for lgpe
...
https://projectpokemon.org/home/forums/topic/52797-request-lgpe-game-sync-like-value-to-be-added/
ty @PP-theSLAYER !
2019-05-16 22:26:51 -07:00
Kurt
7f9328e883
Fix vivillon comparisons
...
Fix template->pkm form fetch too; would return 0 for non-subregion
countries rather than the Country Specific form ID
https://projectpokemon.org/home/forums/topic/52800-invalid-internal-error-with-the-spewpa-evolution-line/
2019-05-16 22:01:11 -07:00
Kurt
73b61e5bf0
Add gender changed azurill evo pokewalker edge case
...
Closes #2311 , thanks @SpiredMoth !
2019-05-15 17:14:48 -07:00
Matt
25985f11e6
Fix Static/Gift IV method call ( #2310 )
2019-05-15 12:07:48 -07:00
Kurt
b7f024e3ea
Fix arceus held item compare
...
https://projectpokemon.org/home/forums/topic/52771-bug-report-pkhex-20190515-arceus-forms-error/
2019-05-15 09:46:52 -07:00
ReignOfComputer
7625ab66b4
Fix Import Count on Load Boxes ( #2308 )
...
Calculation was wrong if non-overwrite is selected. Also fixed OCD-triggering extra space in output message.
2019-05-15 09:11:48 -07:00
ReignOfComputer
7421b137eb
Fix WinForms C# 7 targeting ( #2307 )
...
* Fix WinForms C# 7 targeting
Explicitly target LangVersion 7.2.
* Fix WinForms C# 7 targeting - Part 2
2019-05-15 07:00:21 -07:00
Kurt
be8e8851e2
Update 19.05.15
2019-05-14 22:47:48 -07:00
Kurt
1d44136e54
Update xd fateful flag leniency
...
not enough documentation to know what every single flag does; just be
lenient
I assume that flags being present XK3->PK3 will set fateful, so we could
remove that logic...
Exposing bitflags for editing isn't fun for the editor, so just ignore
it behind the fateful bool get/set.
fateful required for all xk3 origin
#2289
2019-05-14 20:14:15 -07:00
Kurt
555e81205d
Update fateful encounter read location
...
Closes #2289
2019-05-14 18:36:48 -07:00
Matt
44a257b832
Make Poffin names match in-game text ( #2306 )
2019-05-14 11:21:34 -07:00
Kurt
4570c7bb21
Bump required lang version for vs17 building
...
vs19 autodetects required language, but specify this for now since
everything hasn't been migrated
2019-05-14 07:25:09 -07:00
Kurt
091b9e2281
Add g4 poffin editor (misc edits)
...
Thanks @sora10pls for docs!
https://pastebin.com/jNeVJQi0
2019-05-13 22:56:45 -07:00