With the refactoring of result strings outside of Checks.cs, the logic
became harder to follow as the result strings functioned as comments.
This commit splits up the large move checking methods into smaller parts
and added comments.
Moved keldeo move check to a form check and simplifies the check to only
search once.
Add gen5 hidden ability check for pkm that shouldn't have hidden ability
(wonder if there's any pkm that can be encountered in wild / grotto)
time to extract more strings
functions properly for games without a party (RS BOX) by checking if a
party exists
if there's ever a game that doesn't have a box, it'll work for that too
:P
- Make the table compact
- fix Delibird location in dppt (216/217)
- fix Spoink location in dppt (224->214)
- fix fishing encounter type in hgss (some pkm can only be caught via
super rod etc.)
* FIx hgss encounter table
- fix roaming location mixup
- uncomment Unown A
* Fix dppt roaming locations
- roaming pkm can be met on water in dppt
- can not go to route 223 224 and northwest island 225-230
- Add 2 non-route location
* Fix FRLG roaming locations
it's also possible to encounter on water
* Fix unable to save uncheck seen&caught states
* Revert unown
* Add shellos and gastrodom alt form in east sea locations
* Improved MarkG4AltFormSlots
* Remove inside of truck
* Move code for group by Areas to a propert function, to avoid duplicate code, also group by Areas in gen 2, 6 and 7. Is not needed in gen 1
* Reduce all gen7 areas
For future translation feature as per #959
3 helper methods provided to facilitate the localization (import /
export / update)
I decided to simplify some duplicate-function sections
Met_RS was unused; since the met location string list is sequential,
GameInfo.cs just used 0-87, 87-196, 0-87|196-212 for RS/FRLG/E.
Cannibalized the array and split it into 3.
Only concatenate the swarm list once all swarm slots have been
generated, use ienumerable to remove the need to call ToArray except for
the finalization
Fixes#954
Incorporates changes from #955
TMHM info was loaded to Emerald personal table
Static encounter table reformatted to separate arrays which are then
combined later (reduces indentation, possible to further separate into
other tables if need be).
