Kurt
805efdbdfa
Add missing bk4 property for abilitynum
...
used in legality analysis, was returning 0 (invalid)
Closes #1690
2017-12-03 12:40:10 -08:00
Kurt
593612740f
Fix bk4 IV read order
...
still pending ability mismatch
#1690
2017-12-03 12:35:51 -08:00
pokecal
0f52f94222
fix MailBoxEditor
...
add Mail5, almost same as Mail4.
2017-12-04 00:00:14 +09:00
pokecal
c4ca3aba75
add MailBox Editor
...
I just wanted to fix PK3 heldMailID.
2017-12-03 07:21:07 +09:00
Kurt
0aa4dad921
Add species parse edge case
...
dashes in species name && dash for forme name, handle edge case.
Closes #1673
2017-11-30 18:24:31 -08:00
Kurt
a7866d3ed0
Simplify crystal detection
...
any crystal-only data => crystal
no change in overall function for legal pkms being transferred
2017-11-24 18:12:30 -08:00
Kurt
1aea5ac7de
Switch crystal detect to gender
2017-11-24 16:21:52 -08:00
Kurt
3483b4bb91
Clean up vc2 legality/transfer stuff
2017-11-24 10:13:42 -08:00
Kurt
c8bd6d8aea
misc kor encoding updates
...
transporter/bank parsed:
fix 벵벴 swaps (verified ingame)
switch ⋯ for … to match bank
add blank space (u3000) for 0xFF to match bank
note 0xB6C is incorrectly 0xB6D in transporter (=> "."); not an issue as
not a valid char choice ingame.
table data dump: https://pastebin.com/R254mB9p
reproduce via exefs: (kor1-B table followed by english analog
kor_table0)
int ofs0 = 0x1BE3C0;
int ofsK = 0x1BBE48;
int len0 = 0x130;
int lenK = ofs0-ofsK;
A+ parsing: https://pastebin.com/FAxpadxs
2017-11-23 10:18:09 -08:00
Kurt
b8a5657d5a
misc tweaks
...
pull out transfer locations to const references
add vc2 & crown beast/celebi met location suggesting
add vc2 crystal sensitive detection
add 2 more usum trainer stats (thanks holla!)
2017-11-22 21:45:30 -08:00
Kurt
1e5fc96e8e
fix gs met location errors
...
override current location if format is GB
update GS transfer location ID
2017-11-20 09:11:37 -08:00
Kurt
f5aa3c3b0a
Fix form not specified check for totems
...
Closes #1634
2017-11-19 14:16:28 -08:00
Kurt
f7e20a3c43
Misc tweaks
...
fix roamer3 not setting IVs
fix usum z items rightmost pixel getting chopped off
use Gen* instead of GenNumber for specific cases (faster)
add WasGiftEgg location case for Gen7
remove some unnecessary array allocations
2017-11-17 22:19:23 -08:00
Kurt
b111b9dad4
Add totem showdown export
...
soontm
https://github.com/kwsch/PKHeX/issues/1626#issuecomment-345417263
2017-11-17 20:38:43 -08:00
Kurt
9d1ca22b6d
Add usum showdown forme/species i/o
...
Closes #1626
2017-11-17 19:14:27 -08:00
Kurt
523c03606e
Add guard check for out of range gen1 species
...
Thanks ShadowMario3!
2017-11-17 17:07:12 -08:00
Kurt
025b8da52c
Flag invalid forms on sav compatibility check
...
closes #1615
2017-11-16 14:30:18 -08:00
Michael Scire
e8d1d1f521
Add "IsSMCompatible" helper method to PK7.
...
Translated from official game code (PokeRegulation::CheckNijiCompatible).
Potentially for future use in USUM -> SM transfers?
2017-11-16 12:23:35 -08:00
Kurt
a39f92cac6
Add rockruff forme list items
...
revert form selection filtering, screwed up scatterbug and other
forced-forme lists. behavior works fine without the list filtering
2017-11-10 04:01:36 -08:00
Kurt
b3436cb791
Add totem forms selection/spritemod and req changes
2017-11-09 21:52:11 -08:00
Kurt
665e94b0aa
misc cleanup
...
add german forme names
truncate some forme names
fix nidoran gender symbols
adds null check for invalid (caught error) pkm
disables accessory giving (needs more research)
2017-11-08 22:56:42 -08:00
wwwwwwzx
9ab2938b84
Fix USUM Chinese species names encoding
2017-11-08 20:20:41 -08:00
Michael Scire
78acb8e13b
Fix save resigning for USUM, add resources for new pokemon
2017-11-08 11:31:09 -08:00
Kurt
ece66e1a02
Misc tweaks
...
allows loading of species > 720 lol
still nowhere near done (large task is resource acquisition)
2017-11-08 00:51:08 -08:00
Kurt
062684f4a6
Relocate transfer block cases to separate method
...
#1559
2017-11-06 18:34:35 -08:00
Kurt
a00f3ed894
random IVs with specified count
...
Closes #1553
removes duplicate logic in batch editor
2017-11-02 09:05:44 -07:00
Kurt
60e719a65a
Misc refactoring
...
more usum prep
don't allocate empty array on every savefile creation (use linq All
comparison)
add percent seen/caught savefile properties for data analysis purposes
2017-10-31 09:24:54 -07:00
Kurt
021ecbfe47
move pkm load compat check to pkmconverter
...
closes #1550 , mgdb/pkmdb throw unconverted files which need conversion;
move main file load conversion to a reusable method and have pkmeditor
call it on every load.
add skip argument to ignore the conversion check (ie if the file is
loaded from an undoubtedly same type source).
2017-10-28 14:26:27 -07:00
Kurt
52b2fd2778
Add fullwidth 0-9 for kor tables
...
since _0 and _B are the same, just share a reference instead of separate
tables with same values.
Closes #1548 , thanks @host1126 !
2017-10-27 16:30:02 -07:00
Kurt
f6927e4fe5
Add gen2 KOR localization exceptions
...
Closes #1547
Thanks @host1126 !
2017-10-26 20:37:11 -07:00
Kurt
c2cf824afd
Fix {0xE8, "췄"} - {"츄", 0xF2} KOR swap
...
that's silly lol
#1547
2017-10-26 20:18:32 -07:00
Kurt
8c2dcb2dd3
Use generation specific species name
...
nickname resetting should use the generation specific value
2017-10-24 20:59:58 -07:00
Kurt
c60fee85b2
fix pk2 korean nickname set
...
closes #1544 , thanks @host1126 !
2017-10-24 18:57:28 -07:00
Kurt
933bfba8e1
Misc cleanup
...
check gen2 stadium names, use pkm.Japanese when favorable
2017-10-24 18:27:40 -07:00
Kurt
69cf1eaa9c
add more pkhex.core xml documentation
...
adds a bunch of documentation useful for those unfamiliar with the core
library
2017-10-23 23:12:58 -07:00
Kurt
515a694afa
Add LanguageID enum
...
no functional change, just less-magic-numbers for easier to understand
src
2017-10-22 21:01:08 -07:00
Kurt
44c80bd722
Exclude light ball pikachu from gen1 species setter
...
Thanks Dunsparce!
https://projectpokemon.org/home/forums/topic/41880-yellow-version-pikachu-editing-bug/
non-functional change but fix misuse of gameversion checks (used X/Y
instead of YelloW)
2017-10-22 17:11:48 -07:00
Kurt
42d1c252ee
Enhance gen1/2 language detection
...
Closes #1540 , check for german only characters (gen1/2 can trade
between resulting in only OT being checkable). May be worth changing the
german check to return an int instead and check for other language
specific values.
2017-10-22 16:52:46 -07:00
Kurt
3970b177af
Fix kor table 0x5 0x30-3A swaps
...
pls no more
2017-10-22 09:27:00 -07:00
Kurt
cc2e379880
Fix kor table 0x5 0x10-0x20 swaps
...
there's still more in the 0x5_30 region
y u rong bulbapedia
2017-10-21 19:05:38 -07:00
Kurt
791a41b1a7
Fix KOR encoding table off by 1
...
Closes #1534
Thanks @host1126 !
2017-10-21 10:32:08 -07:00
wwwwwwzx
0820059adf
Fix Gen3-5 MaxEV per stat
2017-10-21 01:06:25 -07:00
Kurt
7c36190661
Expand IdentifierContains feature
...
now behaves the same as a property filtering
2017-10-20 08:47:31 -07:00
Kurt
6e42d01779
calculate 4->5 string dictionaries
2017-10-18 22:16:48 -07:00
Archit Date
6f5d0489d5
Zygarde 50% Power construct Showdown Import fix
2017-10-19 02:45:45 +08:00
Kurt
886b2ef632
misc refactoring
...
simplification / splitting, also more usum prep and other readability
updates
2017-10-17 23:19:34 -07:00
Kurt
02c06d154b
Split item cap for usum prep
2017-10-10 19:30:55 -07:00
Kurt
50dfa3603e
fix 50/50% male/female gen1/2 7 ATKIV
...
ma boi nixhex with wrong info at smogon
http://www.smogon.com/ingame/guides/rby_gsc_stats#gender
bulbapedia is right
https://bulbapedia.bulbagarden.net/wiki/Individual_values#Gender
Thanks StarFisherX for bringing this to my attention!
2017-10-07 20:42:51 -07:00
Kurt
762b55e957
handle invalid nature stat amps
...
natures (>25) are invalid and causes IndexOutOfRangeException due to
being greater than the length of the array.
sanity check array length and amped stat prior to applying amplification
Closes #1515
2017-10-06 18:44:14 -07:00
Kurt
059451d66e
misc tweaks
...
dictionary species check, max deviation beginnings for USUM
simplification for gen1/2 pokemonlists
2017-10-05 22:37:45 -07:00