Kurt
7a1c438b74
Minor tweaks
...
add method to randomize AVs from interface extension method
revise stat presence check to check ATK since HP is stored in gen1 format
2020-09-17 18:13:08 -07:00
soopercool101
1a1cfbda4a
Fix Hidden Power Power calculations (and add to UI) ( #2989 )
...
* Fix broken hidden power power calculation
* Fix broken Gen 2 Hidden Power calculation
* Add parentheses
* WIP UI
* Finalize UI, only show on gens 1-5
* Inline some logic to reduce allocations
* Add unit tests for both hidden power calculation cases
Co-authored-by: Kurt <kaphotics@gmail.com>
2020-09-14 20:06:11 -07:00
soopercool101
63be1fb0e7
Update Underground Editor UI ( #2988 )
2020-09-14 19:05:49 -07:00
Egzon
4b1a9a89da
Add support for reading and editing Underground Items ( #2987 )
...
Adds a sub-editor with localized support for editing Underground Items.
2020-09-13 14:55:50 -07:00
Kurt
407c986c89
Update netcore target from 3.0 to 3.1
...
.NET 5 is in 2 months, might as well bump things to the current LTS
2020-09-09 18:27:12 -07:00
Kurt
01fb233e48
Minor tweaks
...
Extract some interfaces
Suppress some warning messages with commented reasons if appropriate
2020-09-09 12:47:24 -07:00
Kurt
5d3bc289b6
seal hunting
...
Mark things as sealed as they shouldn't be inherited from or overriden in a derived class.
2020-09-07 13:51:13 -07:00
Kurt
9191f023a3
Minor clean
...
Nullability annotations and some logic simplification
2020-09-06 11:24:54 -07:00
Kurt
cf9e5ec37f
Minor refactoring
...
Change Ability array to IReadOnlyList, add method to check ability index in personal data
Suppress some message warnings
Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue.
Simplify pk5 conversion
2020-09-06 10:53:13 -07:00
Kurt
c2ec4d55e4
Minor clean
...
Add some xmldoc, remove some empty lines, move some small logic pieces to a better spot
2020-09-03 14:28:51 -07:00
Kurt
b03a5f2818
Fix pika beach score reading
...
fix reads as little endian instead of big endian
fix truncation if editor value from byte => ushort
Closes #2976
2020-09-01 16:05:52 -07:00
Kurt
9667e86446
Simplify dreamworld encounter init
...
precompute result size
set Gen5 as lumped group for common encounters
remove linq usage (besides Sum call, whatever)
GetEncounters now only filters the in-game static encounters rather than the dreamworld too, as those are already filtered by separate arrays.
2020-08-30 19:51:44 -07:00
Kurt
bd11affa13
Minor clean
2020-08-30 19:24:40 -07:00
Kurt
75da70069c
Remove access to modified captured variable
...
Get the variable rather than indexing into the array each time
Simplify some expressions in sav7 for readability
Make SAV_EventFlags use comboitem explicitly by type rather than an anonymous type with same member names
2020-08-30 15:48:11 -07:00
Jonathan Herbert
6eb348848d
Handle Exception When Adding Font File ( #2977 )
2020-08-25 11:42:08 -07:00
Kurt
890f3375c9
Misc clean
2020-08-18 15:39:45 -07:00
Matt
f9b4c1950b
Add Catch Rate to KChart ( #2972 )
2020-08-15 16:13:15 -07:00
Kurt
541c9761df
Minor clean
...
Make flag indexes immutable
Rename some properties for clarity
2020-08-14 20:23:54 -07:00
Kurt
d8fe197a3a
Update 20.08.07
2020-08-06 19:15:16 -07:00
Kurt
12d9397c8c
Split GO from "GG" gameversion
...
Make Gen7b as the combined ver for that expression
2020-08-06 18:24:20 -07:00
Kurt
85d1b0e7ad
Split gen6/7 affection stats to interface
...
not in future formats, doesn't belong
2020-08-02 11:06:30 -07:00
Regnum
9e40fa132f
Improved Pokewalker Editing ( #2958 )
...
* Added PokeWalker Courses, Watts, and Steps editing
* Use util method for getting bitflags
* Keep old cheat method
Change signature so that the default value passed is to unlock all; can pass 0 instead to lock all
* Pass reference to derived sav4-type object
Wev'e already type-tested once, capture the reference and pass it into the appropriate load/save methods.
* Add control anchoring for window resizing
Also widen the labels for localization (longer strings possibly)
2020-08-01 09:20:13 -07:00
Kurt
e84ce77008
Split memories from main pkm class to interface
...
pk6/7/8, not pb7
2020-07-31 17:25:14 -07:00
Kurt
b7211000b0
Split Country/Region/ConsoleRegion from ITrainerInfo
...
Only present in mainline gen6/7 game pairs, so it's not wise to have it for all games
2020-07-31 13:53:42 -07:00
Kurt
36684ab867
Minor clean
...
Simplify some expressions
2020-07-31 11:20:48 -07:00
Kurt
27f15d2f20
Split Country/Region/ConsoleRegion to interface
2020-07-31 11:17:31 -07:00
Kurt
a221a27074
Click version/battleversion -> dropdown combobox
...
User error help
2020-07-25 09:58:21 -07:00
Kurt
6bb2612059
Restart program on settings reset
2020-07-25 09:51:56 -07:00
Kurt
318016e9e5
Fix re-layout on grid refresh
...
closes #2946
2020-07-21 23:50:23 -05:00
Alberto Tudela
2bae3e09e0
Spanish minor fixes ( #2947 )
...
Minor Folder list fixes
2020-07-21 11:59:51 -05:00
Kurt
a6a3c6eaaa
Refactoring
...
change some expressions for better perf/readability
2020-07-19 17:48:45 -05:00
Kurt
e4092e64df
Relocate gen3 ereader berry logic
2020-07-18 22:51:55 -05:00
Kurt
851d77ed3a
Show "NEW" for gen8 item edits
...
why not
2020-07-18 20:27:22 -05:00
Kurt
a21bb09c37
Perserve & Display Favorite flag for items
...
Also clamp give all for TMs to 1 instead of whatever the giveall value is, like for prior games' HMs
reuse the "free space" bool; no real benefit in increasing the amount of abstraction (even though that's my current urge for legality)
2020-07-18 20:15:41 -05:00
Kurt
65ecd3ca9a
Sync missing change
2020-07-18 20:07:55 -05:00
Kurt
705822c965
Abstract some gen1/2 encounter types from their parent class
2020-07-18 15:36:30 -05:00
Kurt
5c7f992ea9
Update 20.07.18
2020-07-17 21:45:46 -05:00
Kurt
523edecf7b
Get actual value rather than magic index
...
logic doesn't really work for gen2/3, so gate it behind gen4+ format only
2020-07-06 17:32:40 -05:00
Kurt
993673f0de
Minor clean
...
no functional change
2020-06-27 23:36:53 -05:00
Kurt
a7ba178005
Remove unreachable/const logic
...
Earlier compares result in some logic being unnecessary
The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)
2020-06-27 22:44:14 -05:00
Kurt
0836d3191d
Rewrite some magic gender value logic
...
it's always been a byte for ratios, but we never know; plus, it's a little more self documenting
2020-06-27 12:01:28 -05:00
kckxpyr1
38d9bf18c0
Update lang_zh.txt ( #2906 )
...
This is more in line with the Chinese translation, I hope it can be modified
2020-06-25 07:06:40 -05:00
Kurt
66a797371a
add pokedex urshifu gmax translation strings
...
copied localization from the other checkbox ;)
2020-06-24 19:01:15 -05:00
Kurt
6574732380
Update 20.06.22
...
Update wc8 binary with events from past month
2020-06-21 23:06:52 -05:00
Kurt
6fb2ebe039
Minor clean
...
add some xmldoc
2020-06-21 19:46:06 -05:00
gjfkkk
6b506957c9
Update lang_zh.txt ( #2876 )
...
* Update lang_zh.txt
2020-06-21 09:33:44 -05:00
Kurt
b53a29a0af
Add flag for urshifu-1 gmax pokedex
...
ty @sora10pls
2020-06-20 20:00:35 -05:00
Kurt
4f7845547e
Minor clean
...
Remove met location dynamic sizing for C/XD (already resized for SWSH)
add some xmldoc comments
rename some parameters
2020-06-20 18:23:03 -05:00
Easy World
c0ee00cb7a
Update Chinese Localization ( #2871 )
...
* Update LegalityCheckStrings_zh.txt
* Update lang_zh.txt
2020-06-19 21:18:40 -05:00
XxPhoenix1996xX
0839882fda
Update Spanish Localization ( #2870 )
...
* Update LegalityCheckStrings_es.txt
* Update lang_es.txt
2020-06-19 20:53:21 -05:00