Kurt
7434af48bf
Fix HT know move memory deferral
...
Checks if it can know the move up until the current format, rather than origin game
2021-08-28 13:44:10 -07:00
Kurt
65b7102d4e
Permit gen1/2 format eggs to have eggmoves (GS)
...
Thanks Psyduck!
https://projectpokemon.org/home/forums/topic/57375-pkhex-new-update-legality-errors-contribution-page/page/10/?tab=comments#comment-268691
2021-08-27 23:11:21 -07:00
LegoFigure11
eeaf19f1c2
Fix incorrect met locations in XD GoD ( #3250 )
...
The Hexagon Brothers can be rematched in Phenac City if their shadows aren't snagged at the Cipher Lab, but Seedot, Houndour, Gulpin, and Spheal are all encountered outdoors (Phenac City (XD) [100]). Mareep and Baltoy are both encountered downstairs in the Mayor's House (Phenac City (XD) [096]).
Relevant .xk3 files: https://cdn.discordapp.com/attachments/537784151970021376/880816626176495626/Phenac_Rematches.zip
2021-08-27 07:33:12 -07:00
Kurt
92f30e26cc
Add misc memory checks for gen8 memID 42/51/70 args
...
Closes #3249
Co-Authored-By: Skadiv <62726360+Skadiv@users.noreply.github.com>
2021-08-26 21:20:52 -07:00
Kurt
d5c9ea978e
Indicate version metadata for lgpe gifts
...
Just metadata, no functional change
2021-08-26 15:47:44 -07:00
Kurt
87a268fa7f
Clean up memory generation parameter fetching
2021-08-25 19:45:47 -07:00
Kurt
0e2dac3ff6
Minor tweaks
...
Empty return for invalid species encountertemplate fetch
Expose property for ck3 @ 0xD7
show legal memory context items rather than gen8 always
2021-08-25 19:23:15 -07:00
Kurt
d3ae5e682f
Shift intensity back down by 1
...
Used to be index2,count7 per 9f1a8d1da1
diff. Needed to delete both blank lines, oops.
2021-08-25 10:47:40 -07:00
Kurt
6ea0d9f3bb
Handle bank transferred memory feelings 5->6
...
Apparently they don't use the bit-permission table in Bank to get a random feeling, and instead just do rand(0,10).
Our logic to set a random feeling for bank transfers is still fine, because we set [0,10) within the bit table.
2021-08-25 10:37:53 -07:00
Kurt
c1a7d04c5c
Fix ck3 fateful read
...
Hope 555e81205d
was actually incorrect and that this is finally correct
2021-08-24 22:23:45 -07:00
Kurt
ffcd2e96e0
Fateful Mattle Ho-oh on japanese colosseum
...
must have been an oopsie they reverted for international releases
Thanks @liketolike !
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
#3242
2021-08-24 19:29:51 -07:00
Kurt
6e3bcd5b66
Encounter visualization: Show ball and differentiate visually
2021-08-24 14:03:20 -07:00
Kurt
5a53ae85bc
Update WB7.cs
2021-08-24 13:12:14 -07:00
Kurt
9f1a8d1da1
Split memory text string resources
...
Much easier to maintain and reference now
2021-08-23 23:06:51 -07:00
Kurt
2e3a6cc719
Fix memory 6 (pokecenter) compare for gen8
2021-08-23 23:06:33 -07:00
Kurt
a3633bb562
Update MemoryContext8.cs
2021-08-23 19:15:39 -07:00
Kurt
d684b9fa14
Disallow starter pika/vee on opposite game storage
2021-08-23 16:46:03 -07:00
Kurt
47914c48c8
Update WB7.cs
...
https: //github.com/kwsch/PKHeX/commit/2a51eb174522754da51a5e1b059163e6a1ed9c6a#diff-8b09a6b11c41760f1242b597508eeb0ea4cde4a14cfd7e7ec1a0a37b146924c8L235-R228
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-08-23 16:30:38 -07:00
Kurt
86fde6d42e
Memory 3 updates, revert todo
2021-08-22 23:39:23 -07:00
Kurt
3a8947cc59
Allow battleversion-ambiguous relearn move
2021-08-22 22:23:59 -07:00
Kurt
6e9f230dee
Add cxd/rsbox event data for mainline sav3
...
Closes #3248
2021-08-22 18:52:29 -07:00
Kurt
a631e5cb4e
Rearrange how some memory info is checked
...
Split into different game contexts
2021-08-22 16:41:57 -07:00
Kurt
b099b8d82c
More genloc memory refinements
...
starting to see the flaws in how things are organized
2021-08-22 11:10:29 -07:00
Kurt
40d1249f1e
Add genloc checks for gen8 memories 1,2,3
...
Can definitely be refined as these memories can restrict to capture/hatch/gift encounters. The multi-value arrays can also be restricted for non-hatches too (maybe first element if WasEgg?)
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2021-08-22 01:40:08 -07:00
Kurt
28e7473f1a
Condense some expressions
2021-08-22 01:26:28 -07:00
Kurt
6112c9c91c
Condense into expression, add future-evo case
2021-08-22 00:06:02 -07:00
Kurt
5b42dc8ae4
Minor clean
2021-08-22 00:05:41 -07:00
Kurt
92d1666970
Make PIDIV a readonly struct
...
Add tests to ensure the optimization remains in effect later
2021-08-21 18:24:38 -07:00
Kurt
65c5890e1f
Make NPCLock a readonly struct
...
Reduces allocation, improves locality of data since the contents take less size than a pointer (can pass byval)
2021-08-21 17:44:43 -07:00
Kurt
ae0ca49628
Arrange CXD Shadow encounters, add ShadowID documentation
2021-08-21 17:01:50 -07:00
Kurt
c9b838b492
Inline clone method
...
More obvious what it does
2021-08-21 16:52:06 -07:00
Kurt
8f0fb902d1
ArgumentException -> ArgumentOutOfRangeException
2021-08-21 16:51:50 -07:00
Archit Date
27059268ba
un-trim alcremie form strings (cream vs swirl) ( #3246 )
...
also use proper alcremie forms for showdown
2021-08-21 13:02:37 -07:00
Kurt
8f4f86e88e
Update WC8.cs
2021-08-21 11:50:24 -07:00
Kurt
5da9b4a70a
Force alignment
...
FieldOffset isn't implied, fun.
2021-08-20 22:07:09 -07:00
Kurt
05364212ba
Update Encount5.cs
2021-08-20 20:53:23 -07:00
Kurt
9ef93552c9
Add ability to set swarms for gen3
2021-08-20 20:50:16 -07:00
Kurt
48024f1245
Add Swarm data get/set for gen3-5
...
#3245
2021-08-20 19:52:31 -07:00
Kurt
cd12962a50
Remove Tradeback state caching in PKM data
...
Since we have more metadata with move learn sourcing, we can check if it was traded to gen2 to get new moves / deleted.
Adjust call sites appropriately
might have some issues, to be ironed out maybe
2021-08-20 15:59:54 -07:00
Kurt
bedc52943e
Trailing commas
...
No functional change
2021-08-20 13:49:20 -07:00
Kurt
c6342a163f
Minor clean
...
variable swaps, simplifications
2021-08-20 13:42:25 -07:00
liketolike
8b4730a2ee
Update zh translation ( #3241 )
...
Adds Gen2 zh const/flag name files
Adds Gen7 zh lgpe flag names
Updates GUI translation
Updates gen3,4 const/flag files
2021-08-19 20:19:49 -07:00
Kurt
9f249ef4d6
Add bounds check for API purposes
...
chris doing things funkily, might as well range check ourselves before blindly accessing the array
Use a const value for vivillon max wild form value
2021-08-19 18:59:24 -07:00
sora10pls
5379bad7ff
Add new distribution raids 👻
2021-08-19 21:20:56 -04:00
Kurt
c0d748a975
Add Dream World upload slot indicator
...
Tested & works on bw & b2w2
Thanks Brokemia for the request!
2021-08-16 11:54:03 -07:00
Kurt
a926923a6b
Remove Fullness/Enjoyment from ExtraBytes
...
They show up in the memory editor
2021-08-15 19:32:50 -07:00
Kurt
05d745afe5
Fix inverted format search
2021-08-15 19:32:33 -07:00
Kurt
934628b077
Pre-filter memory mismatch on moves
...
All over the place with prior commits; everything should be correct (and more robust) now.
2021-08-15 14:23:15 -07:00
Kurt
31ddaf2bc4
Don't defer on ability mismatch
2021-08-15 11:07:59 -07:00
Kurt
42330eb771
Memories and special moves, bite the bullet
...
Allocate a list :(
We need to keep all the secondary deferred around, since they have special movepools.
2021-08-15 09:47:31 -07:00