Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-18 16:33:24 +00:00
Code Issues Projects Releases Packages Wiki Activity
5059 commits 3 branches 76 tags 119 MiB
Commit graph

5059 commits

This branch
This branch
All branches
Author SHA1 Message Date
wwwwwwzx
fc72323c2e Add general memory intensity/feeling check (#1916) 
* Add general memory intensity/feeling check

Memory setting subroutines: Y: sub_43C1E4 AS: sub_469A94
Memory table RAM address: Y:0x54A4F0 AS: 0x58A134
https://pastebin.com/h1RHL7nR

* Check if egg's OT memory is blank

All empty memory should be checked before common check.
Don't allow eggs to fall through.
 2018-04-28 06:26:04 -07:00
Kurt
af8084fd34 Rework cosplay pikachu static encounter population 
Now IV3, thanks @wwwwwwzx for finding the hard-coded case (Lati@s is
already IV3).

https://projectpokemon.org/home/forums/topic/45011-illegal-cosplay-pikachu/?tab=comments#comment-230318

remove SkipFormCheck, and just have all 6 populated (so that Form0
pikachu doesn't slip through).
 2018-04-27 21:53:00 -07:00
Kurt
5ad31ad0c9 Generate pkm qr better 
Don't include nature/ability for pre-gen3, export held item string with
correct version context
(whatever for cxd)

Closes #1915
 2018-04-27 18:24:07 -07:00
Kurt
294a61c4c1 Update pkmeditor GB gui loop behavior 
updating HP causes SPD to be updated, which is based on SPA; since SPA
is yet to be updated, we trigger constant updates on an SPA > 15 until
we crash.

just use the SPD IV which is already capped by the pkmdata
(this shouldn't refresh fields anyway when loading... whatever).

Closes #1914
 2018-04-25 20:17:58 -07:00
Kurt
f5c9873348 Update showdownset handling for gen2/3 
Closes #1913 by detecting any required pkm format related to the item.
 2018-04-25 18:45:31 -07:00
Kurt
3f6b1acc93 Add fixed gender checks for non-GBA/NDS games 
Closes #1912 , genderless ~= fixed gender I guess; shouldn't get these
gender-errors unless it's manually tampered data/ShowdownSet

remove unnecessary code in:
* PKMEditor (>=255 is already covered by == 255 and the fact that gt is
always <= 255)
* VerifyGender (3 <= x <= 5) check is already early-returned via
PIDGender check above

Update IsGenderValid knowing that VC mons have a gennumber <= 2
 2018-04-23 19:58:29 -07:00
Kurt
15ce1acfdb update box manipulation 
closes #1911 , changes end to be inclusive rather than exclusive. abuse
the optional to let it fill in the end caps.
 2018-04-23 19:11:55 -07:00
Kurt
a6903953a0 Re-add old boxtab clicks 
#1910
 2018-04-23 18:55:58 -07:00
Kurt
1b4ec11335 Add rebattleable Miror B locations to xd shadows 
https://projectpokemon.org/home/forums/topic/44957-bug-pokemon-xd-post-game-shadows-flagged-illegal/

if shadow lock sets are ever implemented, would need to update this as
well to 'clone' with the different shadow teams available.
 2018-04-23 17:14:52 -07:00
Kurt
505877763b Update ownership sort 
gen4 and below saves don't provide an accurate Version/Game; ignore the
version check if it is not a valid game ID.

secondary sort to current OT name so that same-named OT (ignoring case)
are immediately after the current save's pkms.
 2018-04-23 08:25:32 -07:00
Kurt
e25e3fcc19 update joyful dodrio berry offset 
bc90a4fc1d/include/global.h (L276)

u32 bestScore;
u16 berriesPicked;
u16 berriesPickedInRow;
 2018-04-22 20:11:25 -07:00
Kurt
9e874a0784 Add modify handling to 'sorter' dropdown 
adds hatch all eggs in box(es, with shift)
 2018-04-22 12:43:18 -07:00
Kurt
762c5e5cae Add random sorter 
closes #1909
 2018-04-22 12:16:08 -07:00
Matt
7db2c484ea Update sort menu labels (#1907) 2018-04-22 11:37:01 -07:00
Kurt
19e73a5f85 Generalize meowstic edge case 
lang sensitive, account for no nickname as well
#1905
 2018-04-22 09:53:52 -07:00
Archit Date
4dfcafc720 Fix Meowstic edge case (#1906) 
Edge cases with `-F` as forms are already handled in the code
 2018-04-22 09:11:09 -07:00
Kurt
ea227a8113 Extract OrderByTrainer 
logic to order-group may be useful for later
 2018-04-21 23:03:51 -07:00
Kurt
f6dda90f52 Add icons 
icons are credit to Dave Gandy's Font Awesome pack on flaticon.com
https://www.flaticon.com/packs/font-awesome
 2018-04-21 22:31:11 -07:00
Kurt
e2405346a4 Update usage sorting 
sort friendship delta with high values to front
reference correct method for usage sort
 2018-04-21 21:15:19 -07:00
Kurt
7649d2ef95 Update contextmenu names 
copypasta ftw
 2018-04-21 19:24:50 -07:00
Kurt
8135820e73 Fix gen3 showdownset import 
applying details modifies pkm data, pk3 checks for validity when
determining if it is decrypted or not
#1904
 2018-04-21 17:47:32 -07:00
Kurt
2ed003d668 Check legality parse before checking relearn result 
closes #1904
 2018-04-21 16:42:45 -07:00
Kurt
79f1c780f9 Update ownership sort for better not-mine grouping 
After the current save's originated pkms, sort by OT name/gender/ID to
group them together rather than leaving them unsorted.
 2018-04-21 16:32:47 -07:00
Kurt
df75543f2a Implement pkm sort option control 
right click the box tab
* no longer silly key-combos to initiate a clear/sort
* provides multiple sorting options
Advanced sorting includes:
* Recieved Date
* Friendship usage (using it raises friendship, more used pkm will be
sorted to the top)
* Ownership (current SAV's first, then by other OTs)
 2018-04-21 16:31:41 -07:00
Kurt
488b5215a7 add optional sort param 2018-04-21 15:07:58 -07:00
Kurt
e91cb806e5 Extract extension->prefer format method 
fails for 'pkx' (returned 8 instead of 6); establish standard behavior
 2018-04-21 14:38:18 -07:00
Kurt
7a245278ea Relocate mg description parse to core 2018-04-21 09:55:27 -07:00
Kurt
cb930fcaab Show g7 tid on mystery gifts originating from g7+ 2018-04-21 09:18:53 -07:00
Kurt
0b62ab85a1 Nature -> byte instead of int 2018-04-21 09:18:53 -07:00
Chromaryu
ecf191e0e6 Improve ja translation (#1903) 2018-04-21 08:37:32 -07:00
smileynation
d0e60b44e0 Update LegalityCheckStrings_ja.txt (#1902) 
Minor fixes.
 2018-04-20 09:20:30 -07:00
Kurt
cee43a3c4b Fix translating non-translatables 
addnew adds a key when not found in original translation, which results
in translating to the old value when flipping back to that language. can
result in invalid values if the control is used as any data display (ie
Gender label)

https://projectpokemon.org/home/forums/topic/44926-when-i-changed-the-language-a-bug-about-gender-occurred/
 2018-04-19 15:36:43 -07:00
smileynation
5b524188cd Update LegalityCheckStrings_ja.txt (#1901) 
I translated the main error message.
 2018-04-19 05:58:28 -07:00
smileynation
6d2153a39c Update lang_ja.txt (#1900) 2018-04-19 05:57:51 -07:00
Kurt
159928b09b Remove soaring as valid egg hatch loc 
hatch ctr doesn't update (steps don't count while soaring)

https://projectpokemon.org/home/forums/topic/44854-is-it-possible-to-hatch-an-egg-while-soaring-in-the-sky/?tab=comments#comment-229931

could probably rename the hashset to indicate that it's only used for
egg hatch locations...
 2018-04-18 16:01:12 -07:00
Kurt
c3494c61c1 Fix encountertime comparison for surf mons 
surf does not have another slot set; so they were all being set to
Morning.
Could have set all 3 time flags, but kept as 'any'.

will update release binaries with this one
 2018-04-18 15:58:21 -07:00
Kurt
7cbd0e5d10 Update 18.04.18 
Update event binaries with latest from the Event Gallery
 2018-04-17 20:53:13 -07:00
Kurt
353978df59 Add fixed ability pcd valid bypass 
https://projectpokemon.org/home/forums/topic/44834-bugabout-event-evolution/
 2018-04-17 20:48:14 -07:00
Kurt
a48c70ccf2 Add evolution minbound check 
https://projectpokemon.org/home/forums/topic/44834-bugabout-event-evolution/?do=findComment&comment=229887

(espeon at level 50 originating from a level 50 eevee gift is not valid)
 2018-04-17 20:06:23 -07:00
Kurt
fef1d6e0dd de-linq some evolution dexlevel fetch 
use shared IList interface instead of IEnumerable
 2018-04-17 19:56:43 -07:00
Kurt
a34be35d9f Add commit contents for previous commit 
removal of some linq, reorders as described by previous commit
 2018-04-17 19:50:25 -07:00
Kurt
8250bc58cd Fix levelup->evo fetching of next levelup move 
Correctly fixes #1163 (test cases added), eg wooper->quagsire would
learn yawn at 31 before evolving; the getmoves wouldn't provide yawn
(stopped at 30) with the old code; the lvl decrement was removed in the
incorrect commit, providing a legal verdict which was obtained
incorrectly (dexlevels were inaccurate)
 2018-04-17 19:49:33 -07:00
Kurt
f767b2db0f Differentiate WasEgg (any egg location) from bred 
https://projectpokemon.org/home/forums/topic/44838-buggen5-egg/

WasEgg is used for other encounter based checks, so can't reduce the
logic usage
 2018-04-17 18:54:38 -07:00
Kurt
bb03505144 Better handle g2 unown form changing 
Closes #1897
 2018-04-16 16:01:30 -07:00
Kurt
86333c6db6 Flag VC transfer affection 
contest check only applies for 3->7 not 1/2->7

https://projectpokemon.org/home/forums/topic/44674-bug-about-contests-ribbon/?do=findComment&comment=229785

Thanks Davil!
 2018-04-14 21:36:11 -07:00
Kurt
6db0b673db Handle ??? type gen4 arceus form check 
interstitial between steel & fire, shift the form value up by 1 if
applicable

https://projectpokemon.org/home/forums/topic/44806-arceus-not-legal/?tab=comments#comment-229774
 2018-04-14 18:20:58 -07:00
Kurt
7a77b4524f Add b2w2 route 23 amoonguss 
https://projectpokemon.org/home/forums/topic/44798-bug-report-amoonguss-encount-error-b2w2/
Thanks smileynation!
 2018-04-14 08:47:02 -07:00
Kurt
8cfd64df63 Add affection contest check for pre gen6 events 
https://projectpokemon.org/home/forums/topic/44674-bug-about-contests-ribbon/?do=findComment&comment=229739
 2018-04-13 18:52:38 -07:00
Kurt
6b387f9037 Handle alolan species transfer form check 
https://projectpokemon.org/home/forums/topic/44718-bugabout-xd-alola-form/?do=findComment&comment=229735
 2018-04-13 18:44:16 -07:00
Kurt
78f533605c Handle untranslated Italian LeafGreen Jynx trade 
lul nice translating team u got there, would be a shame if they forget
to translate something ;) /s

Thanks cicciochiave!
 2018-04-12 21:22:04 -07:00