* Fix invalid fishy check for Gen 4 Eggs
Met Level should be 0, current Level should at least be 1; impossible to have a Lv. 0 Pokemon, therefore it is not fishy to have no EVs on a Lv. 1 Pokemon
- add static encounters for gen4 (rotom/drifloon/electrode/spiky pichu)
- fix Uxie/Azelf location (Lake -> Cavern)
- fix ball for sinjoh ruins event (the player recieve the pkm without
battle poke ball only)
- fix ball for gen5 zorua (the player can choose ball)
fixes ribbon fetch, unown form comparison, and improves exception
handling (no more swallowing exceptions and yielding a vague message)
properly generate manaphy egg on gen4 saves
will have to iron out the legality checks for nicknames at a later point
in time
- Add a lengthy dream world table with special moves and levels (wonder
if there is already a binary database). I guess location can be a good
flag from PDW.( directly writing the location into table would be
better?)
- Fixed a minor typo at vivillontables.
- Working on adding PGL Gift from Dream World
Closes#979
Forgot that the window deal was initially programmed to check the order
of the base moves as well, but inheritance allowed them to be shuffled
in.
suggestion is always count=4 due to earlier padding, no need to Take(4).
--mud;
Closes#976
subregion was set first, but changing the country caused it to reset the
subregion to 0/existing value.
thus, load country first then subregion (why not move 3DSReg first 👍
)
* Add shellos and gastrodom alt form in east sea locations
* Improved MarkG4AltFormSlots
* Remove inside of truck
* Move code for group by Areas to a propert function, to avoid duplicate code, also group by Areas in gen 2, 6 and 7. Is not needed in gen 1
* Reduce all gen7 areas
* legality_en.txt file format fix
* addExtraTableSlots: Include locations from the SpecialSlots array that does not exits in game GameSlots array
changed the types to IEnumerable to avoid using multiple ToArray when the function is used more that one time for the same game
* Fix Shellos AltForm location
With the refactoring of result strings outside of Checks.cs, the logic
became harder to follow as the result strings functioned as comments.
This commit splits up the large move checking methods into smaller parts
and added comments.
Moved keldeo move check to a form check and simplifies the check to only
search once.
Add gen5 hidden ability check for pkm that shouldn't have hidden ability
(wonder if there's any pkm that can be encountered in wild / grotto)
time to extract more strings
