Closes#979
Forgot that the window deal was initially programmed to check the order
of the base moves as well, but inheritance allowed them to be shuffled
in.
suggestion is always count=4 due to earlier padding, no need to Take(4).
--mud;
Closes#976
subregion was set first, but changing the country caused it to reset the
subregion to 0/existing value.
thus, load country first then subregion (why not move 3DSReg first 👍
)
* Add shellos and gastrodom alt form in east sea locations
* Improved MarkG4AltFormSlots
* Remove inside of truck
* Move code for group by Areas to a propert function, to avoid duplicate code, also group by Areas in gen 2, 6 and 7. Is not needed in gen 1
* Reduce all gen7 areas
* legality_en.txt file format fix
* addExtraTableSlots: Include locations from the SpecialSlots array that does not exits in game GameSlots array
changed the types to IEnumerable to avoid using multiple ToArray when the function is used more that one time for the same game
* Fix Shellos AltForm location
With the refactoring of result strings outside of Checks.cs, the logic
became harder to follow as the result strings functioned as comments.
This commit splits up the large move checking methods into smaller parts
and added comments.
Moved keldeo move check to a form check and simplifies the check to only
search once.
Add gen5 hidden ability check for pkm that shouldn't have hidden ability
(wonder if there's any pkm that can be encountered in wild / grotto)
time to extract more strings
functions properly for games without a party (RS BOX) by checking if a
party exists
if there's ever a game that doesn't have a box, it'll work for that too
:P
- Make the table compact
- fix Delibird location in dppt (216/217)
- fix Spoink location in dppt (224->214)
- fix fishing encounter type in hgss (some pkm can only be caught via
super rod etc.)
* FIx hgss encounter table
- fix roaming location mixup
- uncomment Unown A
* Fix dppt roaming locations
- roaming pkm can be met on water in dppt
- can not go to route 223 224 and northwest island 225-230
- Add 2 non-route location
* Fix FRLG roaming locations
it's also possible to encounter on water
* Fix unable to save uncheck seen&caught states
* Revert unown
* Add shellos and gastrodom alt form in east sea locations
* Improved MarkG4AltFormSlots
* Remove inside of truck
* Move code for group by Areas to a propert function, to avoid duplicate code, also group by Areas in gen 2, 6 and 7. Is not needed in gen 1
* Reduce all gen7 areas
For future translation feature as per #959
3 helper methods provided to facilitate the localization (import /
export / update)
I decided to simplify some duplicate-function sections
