Kurt
ef3cb34387
Refactor EvoCriteria to be a struct, reduce allocation ( #3483 )
...
* Make EvolutionCriteria struct
8 bytes per object instead of 26
Unify LevelMin/LevelMax to match EncounterTemplate
bubble up precise array type for better iteration
* Inline queue operations, less allocation
* Inline some logic
* Update EvolutionChain.cs
* Improve clarity on duplicate move check
* Search reverse
For a dual stage chain, finds it first iteration rather than second.
2022-04-23 21:33:17 -07:00
Kurt
eed5bb04e3
Merge pull request #3382 from kwsch/pla
...
Update 22.02.04
Individual commits from this PR are not cherry-pickable in a vacuum; these were manually re-committed from a staging repo in order to group together changes for general public viewing. There were over 250 commits on the private development repo for this update.
2022-02-04 18:28:17 -08:00
Kurt
0b32cbf132
Update PKHeX.Core abstractions with latest logic
...
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2022-02-04 17:35:15 -08:00
Kurt
936a0e927a
Handle unavailable hidden abilities for bdsp
...
EncounterSlots now expose Ability, so no need for manual checks there.
2022-01-17 21:44:21 -08:00
Kurt
9cde291595
Enumerate ability permissions in encounter templates, misc updates ( #3368 )
2022-01-08 22:34:04 -08:00
Kurt
51c75dd102
Explicitly implement IFixedAbilityNumber on all templates
2021-12-09 00:46:59 -08:00
Kurt
90956f3b05
Flag encounter slots that cannot obtain HA or use ability patch
...
Ex: old chateau Gastly in bdsp cannot have HA as it is not different from base abilities
2021-12-08 23:43:32 -08:00
Kurt
f53f46c2e4
Revise ability patch/capsule message
...
Fix PCD logic flow
2021-10-02 10:25:52 -07:00
Kurt
f2dc3f1245
Exclude granbull/vibrava/flygon as single abilities
...
per the personal data in emerald, they are the only species that go from 2 distinct abilities to 1; since the game does not update the abilityNumber on evolution, it has the second ability being the same as the first, instead of the usual [ability,none] for all other single ability species.
2021-09-30 21:42:44 -07:00
Kurt
2575d73144
Add IFixedAbilityNumber, hide vivillon region flags
...
tfw can't using static a private class in the file, gotta be explicit.
2021-09-06 18:11:32 -07:00
Kurt
bedc52943e
Trailing commas
...
No functional change
2021-08-20 13:49:20 -07:00
Kurt
7c60363b38
Rework match ranking to have multi levels of deferral
2021-08-15 09:28:47 -07:00
Kurt
69a907c5e7
Pass encounter object to innermost ability verifier
...
Fixes stuff for format3 CXD encounters as the side-games applied ability bits regardless of a second ability existing.
2021-08-06 15:26:21 -07:00
Kurt
de94876822
Minor tweaks
...
no functional change
2021-07-30 16:22:10 -07:00
Kurt
7c697a519e
Make EncounterArea parent reference protected, expose properties
2021-07-30 14:05:23 -07:00
Kurt
a159da0abf
Reduce allocations of default valid/invalid
...
Condense some expressions, make some comments/params clear and consistent.
2021-07-30 13:05:34 -07:00
Kurt
8e5e4487ba
Change interface for method call to less restricted
...
Don't need "Name" or "LongName" for these methods.
2021-07-13 18:22:04 -07:00
Kurt
138501da2f
Minor clean
...
Condense some expressions
Use less linq
Rename some fields
2021-05-29 15:31:47 -07:00
Kurt
2c820bfbe9
Minor tweaks
2021-05-18 13:29:55 -07:00
Kurt
f66662b8db
More deferral tweaks for non-HA having HA
2021-04-22 13:47:33 -07:00
Kurt
012f6678ba
Check for dual ability =>evo w/single ability capsule
2021-03-20 17:49:16 -07:00
Kurt
a71d7d1950
Handle gen3 mismatched ability
...
ty Breil --
https://projectpokemon.org/home/forums/topic/58665-makuhita-in-game-trade-bug-sapphire/
2021-03-20 11:22:56 -07:00
Kurt
1acefbcf93
Remove sigilyph from g5 breed HA banlist
...
https://projectpokemon.org/home/forums/topic/58657-sigilyph/?do=findComment&comment=265330
2021-03-17 20:20:54 -07:00
Kurt
5745f8b44e
Update AbilityVerifier.cs
2021-02-03 22:57:23 -08:00
Kurt
621e708d23
Minor clean
2021-01-10 18:15:33 -08:00
Kurt
c432a15a20
Relocate some tables to a location closer to where they're used
2021-01-02 00:46:09 -08:00
