528 commits

Author	SHA1	Message	Date
Kurt	48564d7e30	Fix celebi iv check ... update version ID as well Closes #1775	2018-01-25 20:39:32 -08:00
Kurt	9b7b0b25d4	Flag iv<5 celebi ... thanks @sora10pls	2018-01-25 19:34:18 -08:00
Kurt	58e374bcc6	Add celebi / more crystal legality handling ... Closes #1772	2018-01-25 19:25:10 -08:00
Kurt	802105d22d	Allow pay day mewtwo, disallow dizzy punch ... #1772 transfer pk1->pk2->pk7 for mewtwo knowing dizzy punch, just so we can keep Pay Day	2018-01-25 19:17:42 -08:00
Kurt	5472f869cf	Remove some crystal vc checks ... now legal assuming x->kor7 sets the language val based on the cart language, should be good for the kor crystal checks.	2018-01-25 09:14:25 -08:00
Kurt	b69a6df6e7	Add roamer glitch IV collision detection ... M1 is checked before M1R. A M1R PIDIV can also be a M1 PIDIV, so check that collision. https://projectpokemon.org/home/forums/topic/43567-gen-3-suicune-unaffected-by-roamers-glitch/	2018-01-24 19:07:03 -08:00
Kurt	713e9ea209	Compress box padding	2018-01-23 17:18:37 -08:00
Kurt	b229a947f2	Fix pt/hgss egg location handling 4->5 ... Closes #1766 pt/hgss egg location data is lost on transfer, retaining faraway place only. 2c8e2176e9 fix was incorrect	2018-01-21 11:57:34 -08:00
Kurt	e616b56bfa	Remove uncatchable grubbin static encounter ... #1763	2018-01-18 14:06:17 -08:00
Kurt	387030e16f	Fix 7th gen pikachu altform check ... https://projectpokemon.org/home/forums/topic/43498-bug-about-event-pikachu/	2018-01-18 13:50:29 -08:00
Kurt	17e4bdbe3a	Add pikachu7 forme nongift check ... other branch was unhandled, flag if we have a mismatch closes #1762	2018-01-15 17:50:33 -08:00
Kurt	029539003b	FormChange check: use original form not current form ... Closes #1758 noticing the different usage for species (encounter species vs current), iterating over possible dexlevels (unnecessary?)	2018-01-13 12:10:17 -08:00
Kurt	fb6738f18b	Add unown 2->7+ shiny check ... closes #1755 also: fix vc transfer checks not being called (EncounterOriginalGB is no longer GBEncounterData). remove usages of GBEncounterData -- class is (as of a ~~month ago) now never leaked out of the EncounterGenerator -- always returns the actual encounter data as the wrapper is not needed. simplify logic flow / references	2018-01-10 16:16:35 -08:00
Kurt	c751c987a9	Add DebutGeneration get ... https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)	2018-01-10 15:40:33 -08:00
Kurt	701edbc592	Remove KOR language from gen3 selection ... add flag for non japanese lang gen3 eggs Closes #1747	2018-01-06 22:43:48 -08:00
Kurt	63a983749e	Don't generate encounter slots for eggs ... Closes #1749	2018-01-06 21:51:58 -08:00
Kurt	6a9e2ed4b9	Refactoring ... improve speed for resource fetch, add optional Shiny parameter (currently unused) #1735	2018-01-02 16:53:39 -08:00
Kurt	0f21fc2217	add location interface for verbose analysis output ... indicates met location for transferred mons most gen1/2 encounters won't show values due to the location not being stored respective to the string tables (anyone wanna do a location remap after initial load?)	2018-01-02 12:00:41 -08:00
Kurt	5888898e7d	fix gen2 egg met level mod ... https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/?tab=comments#comment-225577	2018-01-01 21:51:36 -08:00
Kurt	76385a6b4a	Fix gsc pre-evo species chain filtering ... simplify gsc check to do only once https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/	2018-01-01 13:53:28 -08:00
Kurt	cfe78a7a0c	Add rby power plant static encounters ... https://projectpokemon.org/home/forums/topic/43272-small-electrode-legality-bug/?tab=comments#comment-225537	2018-01-01 10:38:38 -08:00
Kurt	1b409dd327	Ban phione egg in non-pokeball ... Thanks Davil! https://projectpokemon.org/home/forums/topic/43262-bug-phione-ball/	2017-12-31 09:56:27 -08:00
Kurt	0c2b16391f	fix spanish ranch gift name check ... oops	2017-12-29 13:08:06 -08:00
Kurt	90260187f7	Add light of ruin & plasma fists as invalid sketch ... moves not available for sketch without hacking a specimen in https://projectpokemon.org/home/forums/topic/43244-two-problems/?tab=comments#comment-225421	2017-12-29 12:00:06 -08:00
Kurt	43cb0e8d7d	Provide more accurate met level for eggs ... Gen6 egg with met level != 1 (ie 98) will use the gen3-4 metlevel branch. fuzzed input from #1728 to be hacked (met level = 98)	2017-12-28 10:01:48 -08:00
Kurt	a1f2f8708a	Refactoring ... pass identifier on cloning pkm remove unnecessary ref for passing Data (not modifying array reference) const some magic numbers	2017-12-27 16:36:24 -08:00
sora10pls	c3d5266b89	Add XY gift Lapras ability check	2017-12-23 18:28:00 -05:00
Kurt	ea76d6a899	Misc tweaks ... minor perf improvements (don't ToList for encounter slots, store all slots incrementally); has better performance for legal pkm checks	2017-12-23 11:49:20 -08:00
Kurt	7f21728e84	Add area->location references to remaining slots	2017-12-23 11:48:10 -08:00
Kurt	5e59e20ea1	Store matched encounter generation ... previously was only defined for gen1/2, why not all gens can now query encounters in Core for encounters per generation via reflection; can help group encounters for data vis or be faster than getting individual gen numbers	2017-12-18 16:17:21 -08:00
Kurt	80baaea3b7	add b2w2 n's pokemon PIDs ... add b2w2 fixed PID encounters (N's Pokemon), move nsparkle to this class redo static encounter cloning	2017-12-18 15:25:40 -08:00
Kurt	24b5cc48ed	Fix gb encounter move comparison ... don't calc NoMoveReminder for non-gen2 formats, also fix comparisons (gen1 || gen2&&noRemind) Closes #1707	2017-12-17 21:26:31 -08:00
Kurt	47eee3aa98	Add roto powers as held items ... not gonna add sprites because these are useless, anyone can submit via pr (image might need downscaling to <15x15) Closes #1703 remove useless null checks (throws the exact same exception it would if it were not there, except without detail)	2017-12-16 19:52:06 -08:00
Kurt	21c1dde3a7	Fix static encounter gift / egg edge case ... extract EncounterStatic match determination; in doing so fixes "lvl" by passing byval. Pichu encounters (2) come before the Gift level 25 pikachu, causing lvl to be dropped to 5. When pikachu comes around, it compares 5==25 -> bad; pulling out the method and passing byval allows it to be 25 at the start of every new encounterstatic checked.	2017-12-16 18:24:03 -08:00
Kurt	0b58d4ffe9	Add form/nature checks for gen5 trades ... altform wasn't checked for EncounterTrade nature wasn't checked for gen5 origin (decoupled from PID, but forced) #1702	2017-12-16 14:09:03 -08:00
Kurt	e5aa39a6bb	Refactoring ... get language list now doesn't return new objects (or re-enumerate) update rand usage to be inclusive for top bound, extend shuffle to collections remove unnecessary location overrides (already overriden in legal fetch)	2017-12-14 20:58:55 -08:00
Kurt	b5640de538	Misc tweaks ... reorder some args, reuse some standard methods; add spanish for gen1/2 egg name case	2017-12-14 16:16:47 -08:00
Kurt	9a39f818f9	Misc fixes ... #1700 dp personal: add wormadam/deoxys manual forme count values generator: bcc handling for pkm present in & out of bcc, and static/wild duplicates util: fix incorrect variable reference	2017-12-13 16:17:02 -08:00
Kurt	a9ff74059a	Misc perf tweaks ... checking untraded should just check for the first character (rather than creating string object) hashset for wild6 balls	2017-12-13 16:12:53 -08:00
Kurt	816ebf6b0e	Refactoring ... no functional change	2017-12-11 16:01:24 -08:00
Kurt	dd21f9375f	Misc updates ... Disallow sandygast on US Add 2 more records thanks @feralfalcon Closes #1698	2017-12-08 08:54:00 -08:00
Kurt	a43880184a	Fix artist ribbon gen6+ ... having 4 ribbons is sufficient (normal/super/hyper/master = 4, etc) https://projectpokemon.org/home/forums/topic/42933-2-issues-invalid-ribbons-artist-encounter-level-in-origin-game/	2017-12-07 07:57:07 -08:00
Kurt	f9946368a0	Remove usage of LegalityAnalysis from PK* ... CK3<->XK3 transfers to PK3 first now (no direct transfer legally)	2017-12-06 21:28:34 -08:00
Kurt	bd9f7fc7e2	Remove fossils from usum capture list	2017-12-06 21:05:36 -08:00
Kurt	4550f656d0	Update gs vc check female ... will be revised when/if vc-c is released	2017-12-05 15:08:02 -08:00
Kurt	88f67ebd36	fix crystal gender flagging ... C->GS->Gen7 keeps female OT but gives GS version also fixes wrong logic path for format2 thanks randomdice101	2017-12-05 14:43:02 -08:00
Kurt	5bc2e6da88	Refactoring ... de-linq some areas where direct accessing is possible (list/array)	2017-12-04 20:16:54 -08:00
Kurt	4a63769351	Add voltorb to beast ball permissible table ... closes #1694	2017-12-04 16:54:09 -08:00
Kurt	3d7b2a2b29	Misc tweaks ... RNG frame mismatch -> fishy (for now) fix xmldoc copypaste clean up some resharper warnings	2017-12-04 16:26:26 -08:00
Kurt	1007c5ddb8	don't flag pokespot for frame not matching ... #1693	2017-12-04 16:05:21 -08:00