Kurt
6929b637cc
Misc clean
...
refactor some common operations
2019-01-01 20:05:36 -08:00
Kurt
80ef196468
fix info output off by one
2019-01-01 20:05:00 -08:00
Kurt
552e7a1a39
Fix pokewalker pid check for female-only
...
pidGender check failed as 0xFE (female only) returned male if pid ended
in 0xFE or 0xFF
jump out early if the pkm is fixed gender rather than genderless only
https://projectpokemon.org/home/forums/topic/48956-pokewalker-happiny-pid-mismatch/
Thanks Taargüs Taargüs!
2019-01-01 20:04:29 -08:00
Kurt
2b5272a395
Simplify gen4 save type detection
...
footer identifiers work just fine for any legitimately created save
file; I might have had the checksum check code for pokesav blank
savefiles
dropping support for bad-blanks in favor of a non-negligible speedup is
favorable :)
2019-01-01 11:16:31 -08:00
Kurt
7ba2860db8
more block details
2019-01-01 00:57:51 -08:00
Kurt
473c4adaa9
Fix encounter browser startup
2018-12-31 23:39:08 -08:00
Kurt
8129e91694
Add more detailed block offset docs
2018-12-31 22:19:40 -08:00
Kurt
92d633e8ad
Allow IsPokeStar=false
2018-12-31 21:04:13 -08:00
Kurt
5fcd8541ba
Add pokestar studio fame / star stat pk5[0x87]
...
how did this get forgotten so easily lol
added legality check; eggs can't participate in pokestar studio.
not editable from GUI, use ExtraBytes editor.
Re-add 0x86 (array was copied from pk4?) and reorder/comment
2018-12-31 21:01:58 -08:00
XxPhoenix1996xX
ede44aaa1b
Update text_Ribbons_es.txt ( #2225 )
2018-12-31 16:07:34 -08:00
Kurt
6c4fdfa559
Merge pull request #2224 from XxPhoenix1996xX/patch-9
...
Update lang_es.txt
2018-12-31 16:07:22 -08:00
Kurt
758ec7f55b
Update MessageStrings_es.txt ( #2223 )
2018-12-31 16:07:06 -08:00
XxPhoenix1996xX
fe57789160
Update LegalityCheckStrings_es.txt ( #2222 )
2018-12-31 16:06:59 -08:00
XxPhoenix1996xX
31b5b4eea4
Update lang_es.txt
2018-12-31 19:30:29 -03:00
XxPhoenix1996xX
f6c9c7b265
Update MessageStrings_es.txt
2018-12-31 18:50:00 -03:00
Kurt
e7f7e3dc3f
Update encounter search
...
Add version specific search or all compatible
Add encounter type checkboxes (others are ignored)
Only return distinct encounters (by reference)
Refresh Checksum from generated iencounterable->pk before converting (to
eventually be fixed in iencounterable rewrite maybe)
Closes #2219
2018-12-30 17:33:31 -08:00
Kurt
bd56999b20
Increase search flexibility
...
add more version fetch methods, add reset method to reset encounter
priority
#2219
2018-12-30 17:30:57 -08:00
Kurt
2ecd3f1f30
Replace IV3 with FlawlessIVCount
...
Other games may vary the flawless IV count so best to have consistent
declarations
(the vc transfer encounter has 5 or 3 depending if it's a mew/celebi)
2018-12-30 10:33:00 -08:00
Kurt
82eae79823
Remove cosplay fixed IV
...
Was added a few months ago
https://github.com/kwsch/PKHeX/pull/2117
Game ignores the fixed IVs and instead does 3 flawless IVs
2018-12-30 01:10:53 -08:00
Kurt
2716d960bb
Update debug ver string display
2018-12-30 00:05:19 -08:00
Kurt
bf1a56af9d
Add xmldoc
2018-12-29 23:38:59 -08:00
Kurt
4fcee0ae7a
Move wr7 to mysterygift folder
2018-12-29 23:34:34 -08:00
Kurt
e7531dca30
Add wr7->pkm
...
Not sure if one of the 'level' fields is a move ID instead. Pound=1,
Level=1
Maybe a Chansey record would shed more light.
2018-12-29 23:33:36 -08:00
Kurt
78ff441e8b
Update iencounterable api with new criteria arg
...
rearrange some logic for clearer function (extract some methods)
2018-12-29 22:24:34 -08:00
Kurt
c2422d6927
Misc updates
...
possibly gonna update the iencounterable api for criteria
check/enforcement, rather than just generating random encounter data.
2018-12-29 22:19:44 -08:00
Kurt
03ad20dd16
Improve card title/filename logic
...
mystery gift editor still fails to generate a description (heldItem < 0
-> exception), the fallback behavior is fine I guess.
2018-12-29 22:15:40 -08:00
Kurt
6140c973ae
Account for wr7 deviance from gen7 format extension
2018-12-29 22:10:33 -08:00
Kurt
8a33a95974
Add mystery gift record getset
...
Mystery Gift button now appears for GG, doesn't work yet
2018-12-29 22:09:59 -08:00
Kurt
f5e3358aaf
Split up WR7 to separate files
...
settled on the class name; looks like it'll be roughly readable as a
mystery gift so inherit some properties. maybe can get r/w in the
mystery gift editor :)
2018-12-29 22:09:27 -08:00
Kurt
ce8c4d1ccd
Allow rows to have non-multiples of 6
...
Say the count of gifts isn't a multiple of 6, it'd crash
just so happened that all prior games were mults of 6 lol
2018-12-29 22:00:17 -08:00
Kurt
71dc944cbd
Add wb7 gift record rw
...
another block documented ;)
https://projectpokemon.org/docs/gen-7/lets-go-pikachu-eevee-wonder-card-album-r109/
names subject to change
2018-12-29 21:24:38 -08:00
Kurt
6f22599baf
Prevent slot overwriting on bulk import
...
https://projectpokemon.org/home/forums/topic/48912-how-to-batch-import-pokemon-boxes-without-erasing-existing-pokemon/
2018-12-28 17:58:13 -08:00
Kurt
3e05e9655e
Store hidden power type
2018-12-28 16:54:01 -08:00
Kurt
a133fcd498
Misc fixes
...
Fix encounter browser fetching for gen1/2
fix changing to gen1 savefile (extrabytes)
2018-12-27 21:28:47 -08:00
Kurt
d5a8d29088
Misc updates
...
reduce some allocs, clearer names/enum usage
2018-12-27 20:24:24 -08:00
Kurt
1430460573
Hide medals/ribbons/memories on pb7
...
Closes #2216
2018-12-27 20:01:29 -08:00
Kurt
d90f099a68
Next unoccupied after starting position
2018-12-27 13:10:55 -08:00
Kurt
f9eb1746ea
Add NextOpenBoxSlot fetch for empty slot overwrites
...
< 0 is storage full
2018-12-27 01:08:42 -08:00
Kurt
2d75e93ef0
Move encounter matching logic to iencounterable
...
generator logic is now clean
2018-12-27 01:00:08 -08:00
Kurt
3481780e06
Add initial sizes
...
maximum is always 3; sometimes we know the max size so specify.
bcl has default size = 0, which then resizes to 4 on first addition
wow such optimization
2018-12-26 22:13:04 -08:00
Kurt
988e71bec5
Remove QRText property
...
removes PKM<-QRPKM class dependency
fix invalid value oob exception (nature & ability fuzz)
2018-12-26 17:31:23 -08:00
Kurt
cf0ebf6a4e
Add automatic backup disable setting
...
even if folder exists, can turn off the feature
2018-12-26 17:25:22 -08:00
Kurt
36fb61ab09
Add setting to skip save detection on load
2018-12-26 17:17:44 -08:00
Kurt
423afa4518
Fix boxviewer not being initialized
...
2d774ac7cc
2018-12-26 13:06:58 -08:00
Kurt
950d0a8525
Add nature bounds check & legality
...
expand string array check to cast and check against length; batch editor
Nature>=25 causes problems in hover tooltips. Previous commit fixed for
pb7 stat calcs for invalid natures, pretty sure the actual game is
exploitable for stat calcs and invalid natures (bad access), but isn't
exploitable as it's only used to retrieve an enum to switch against.
2018-12-25 22:59:52 -08:00
Kurt
9db771c0d5
Split out common 6+ pkm format to abstract class
...
Didn't really feel like pulling out the shared structure get/set
operations, only the derived properties & overall fixer methods. Should
be easier to maintain if any handling updates.
Clean up pb7 unused stuff; removes ribbon logic since none are used.
c# 8.0 interface defaults can maybe pull out more logic (ex making
FixRelearn and relearn moves into an interface); multiple inheritance
can be useful as features are added/dropped between generations.
2018-12-25 22:56:32 -08:00
Kurt
69a3272036
Remove fossils from key item (count==1) list
...
Closes #2215
can't depend on 'key item' item flag since the game allows you to get
multiples
2018-12-25 12:31:13 -08:00
Kurt
2cef99e444
Add setter for pk1/2 Language
...
https://projectpokemon.org/home/forums/topic/48873-batch-editor-language-is-not-working/
2018-12-22 14:47:31 -08:00
Kurt
75d2b8d0bc
Split out location bank fetch
...
Getting a little congested in one method
2018-12-22 14:45:47 -08:00
Kurt
f7cf96be65
Add version name fetch
...
only for pkm game IDs that have already been localized; not game
groupings.
use version name long description if hide-savefile details is enabled.
2018-12-22 13:16:16 -08:00
