Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-15 16:48:01 +00:00
Code Issues Projects Releases Packages Wiki Activity
6041 commits 3 branches 76 tags 106 MiB
Commit graph

6041 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kurt
a133abc615 Add pokegear caller ID enum 
#2379
Cheat as requested in issue not implemented yet; pending future changes
to split sav4.
 2019-08-27 16:17:29 -07:00
Kurt
f0df115ccd Fix box load on uninitialized box load 
Closes #2376
probably will be rewritten at a later time; am reworking the slot info
messaging for drag/drop/display
 2019-08-23 18:03:10 -07:00
Kurt
bf6c25eca7 Break up SlotChangeManager logic 
A little bit cleaner when the logic is separated
Keep an abstraction of BoxEdit to cache the current box contents.
Already fetched to show sprites; any future fetches (for preview text /
hover sprite) can reuse the already fetched pkm data.

Should probably rewrite this stuff completely, but effort better spent
elsewhere
 2019-08-20 19:50:28 -07:00
Kurt
d0ae47eb6c Update 19.08.19 
Update event binaries with latest from the Event Gallery
 2019-08-18 21:51:40 -07:00
Kurt
39f5500d8a Show summary tooltip on mouse enter 
Thanks SadisticMystic for the suggestion!
 2019-08-14 22:51:49 -07:00
Kurt
4f3745e3c6 Change enumerate -> array fetch to force eval 
https://projectpokemon.org/home/forums/topic/54426-pkhex-error/
trycatch will trip here rather than be uncaught when evaluated later
tbh I don't like pkhex's method chain (enumerable, bool, throws), but
this fixes the error.
 2019-08-14 16:45:21 -07:00
Kurt
cf574337e9 Rewrite encounter move suggestion logic 
more straightforward logic flow, don't repeat same <= 2 comparison
 2019-08-14 16:35:25 -07:00
Matt
d85a57ac1e Update Generation 3 Event Flags/Constants (#2374) 2019-08-12 15:26:00 -07:00
Kurt
d237a171e7
Merge pull request #2373 from sora10pls/patch-1 
Unban GO Shiny Poliwag
 2019-08-05 21:28:47 -07:00
Matt
fb4a33ce7e
Unban GO Shiny Poliwag 
Yokohama GO Fest
 2019-08-05 21:06:57 -04:00
Kurt
8b49ddb0ad
Merge pull request #2372 from XxPhoenix1996xX/patch-13 
Update lang_es.txt
 2019-08-04 23:09:07 -07:00
Kurt
b81742c38c
Update MessageStrings_es.txt (#2371) 2019-08-04 23:08:58 -07:00
XxPhoenix1996xX
ec9ae87340 Update LegalityCheckStrings_es.txt (#2370) 2019-08-04 23:08:52 -07:00
XxPhoenix1996xX
e89c2f6d25
Update lang_es.txt 2019-08-04 19:13:56 -04:00
XxPhoenix1996xX
e2227cbddf
Update MessageStrings_es.txt 2019-08-04 18:50:34 -04:00
Kurt
9c58903f55 Fix blank sav3 : sapphire init 
lol it's been this way for 7+mo
Closes #2369 ty @CorvusAtrox !
 2019-08-04 00:59:59 -07:00
Kurt
f462f49eec Fix sav7 map data rw 
https://projectpokemon.org/home/forums/topic/54197-issues-with-newest-version-of-pkhex/
 2019-08-02 15:11:22 -07:00
ReignOfComputer
33ae5b3ac5 Add Realgam Tower to Colosseum Encounters (#2368) 
https://github.com/kwsch/PKHeX/issues/2367
 2019-07-30 08:43:30 -07:00
Kurt
7424cf6fb0 Remove GSC/C differentiation in PK2 
Allows for no adjusting the game group
 2019-07-28 13:26:39 -07:00
Matt
79127d02e4 Update GO Shiny banlist (#2365) 2019-07-26 15:33:19 -07:00
Riccardo Boninsegna
3e7be6832c Even more FR/LG stuff (#2364) 
* corrections and styling
* FR/LG: some more story/item related variables
* FR/LG: More HMs and Oak's Aide's items
* FR/LG: League beaten flag fairly confirmed
* FR/LG: variables
 2019-07-25 17:42:41 -07:00
Kurt
db632905fd Remove WasEgg setter 
WasEgg (aka WasDefinitelyAnEgg) from stored properties is one thing,
WasEgg from encounter info is another; don't mix
 2019-07-25 17:42:20 -07:00
Riccardo Boninsegna
8ffcdc9570 FR/LG: More variables! (#2363) 
* FR/LG/E: Altering Cave variable

* FR/LG: Pokemon Tower related variables

* FR/LG: Pokedex/Oak/Rival (part 1) related variables

* FR/LG: more story related variables
 2019-07-23 16:08:54 -07:00
Riccardo Boninsegna
c508d49f87 FR/LG flag names (#2362) 
* FR/LG: Event flags for eventually reaching event-only places

(required to enable processing of the appropriate items; officially set by DLC scripts)

* FR/LG: Badge names and Running Shoes
 2019-07-23 09:40:41 -07:00
Kurt
9ed47cc8fd Minor tweaks, no functional change 2019-07-21 12:30:21 -07:00
Matt
9cab2e366d Misc Let's Go updates (#2361) 2019-07-15 09:05:53 -07:00
Kurt
894237449b Allow differentiation between SAV2 blanks 
Choosing G/S will initialize as GS
Choosing C will initialize as C
calling via their own code (GSC/GS) will choose the most recent (crystal
if possible).
Closes #2359
 2019-07-14 15:13:13 -07:00
Kurt
a608e0b252 Minor clean 
Remove some unnecessary properties from SaveFile
Enumerate checksum flag results for GC memcard checking
Remove unnecessary checks on savefile type
Add some documentation
Decapitalize some method parameters
 2019-07-14 15:06:45 -07:00
Kurt
839500a7ee Fix medicine offset for AO 2019-07-13 17:43:29 -07:00
Kurt
c7eecf5976 Extract summary object to core 2019-07-13 17:43:05 -07:00
Kurt
82f305cd36 Fix dex gender set again 
Closes #2356
update test case to actually set a genderless gender
 2019-07-12 23:43:12 -07:00
Kurt
f37a587a1c Minor simplifications 
move some pk3->pk4 stuff into object constructor
annotate pk3->pk4 string buffer (trash) quirks
split Heal into Party/PP method uses. Setting suggested stats no longer
refreshes PP
apply current level to Stat Level (wasn't being set previously)
 2019-07-12 16:41:13 -07:00
Kurt
d153224af1 Add traded egg allowance for nickname 
store bool for reuse, not any slower :)
Closes #2320
 2019-07-11 22:55:41 -07:00
Kurt
face8d64a9 Fix gen5 dexflag set 
Add unit tests to check
Closes #2356
 2019-07-11 00:13:52 -07:00
Kurt
c64ff5dd76 Fix sav5 behavior 
Closes #2356 ty @Ammako
 2019-07-10 00:19:59 -07:00
Kurt
ab735de2d9 Revert "Decapitalize non-nicknamed on 4->5 transfer" 
This reverts commit 904dc84b52.
 2019-07-09 20:24:47 -07:00
Kurt
1de685c6d8 Add Happy Hour/Hold Hands 
per confirmation from @PP-theSLAYER

https://projectpokemon.org/home/forums/topic/53818-these-events-are-flagged/?do=findComment&comment=246918
they probably won't release these two moves tho, LGPE has become stale
 2019-07-08 22:18:15 -07:00
Kurt
90cc8ca3ec Add Celebrate for lgpe valid move filter 
event move only
still haven't bothered finding the table in the exefs that results in
the pkm with an oob move being dummied. hardcoded based on data for now
:)
 2019-07-08 22:14:21 -07:00
Kurt
3f4f02cee1 Add string quality tests 
Expect no duplicates in met locations, items, or moves. These are arrays
with common duplicate strings (poor localizations).

Should help futureproof / help implementation for this type of err:

https://projectpokemon.org/home/forums/topic/53818-these-events-are-flagged/
 2019-07-08 22:05:59 -07:00
Kurt
605b410d52
Make Distribution Super Training missions invalid 
Was initially implemented as fishy during SM's initial implementation. Any nonzero value in this byte is invalid, don't even bother checking unused/count.

Now that Gen6 (and Gen7) are no longer current gen, any hope for them being released is the same as hoping for Gen4's Azure Flute Arceus. Thus we mark as invalid :)

Closes #2353 by effect of no longer flagging as Fishy. I think that my initial implementation of VC stuff had assumed the Generation==7, but later used 1/2 for factual correctness.
 2019-07-08 12:12:16 -07:00
Kurt
cf0908a21e Remove check for impossible conditions 
#2354
SUBE is never < 0 with the latest change (blank saves behave same as
retail saves).
 2019-07-08 10:03:53 -07:00
NotTsunami
e29da1a8e8 Remove check for impossible condition in XY Save (#2354) 
XY can't be ORASDEMO
 2019-07-07 22:58:33 -07:00
Kurt
fef4dbb9dc More super training checks 
Check the secret unlocked/complete flags for eggs
Check the count for VC, and flags too (even though they're checked
later, just do it here)
#2353
 2019-07-07 15:04:58 -07:00
Kurt
15c44139c3 Fix record read offset 
Closes #2353
first 100 are u32, second 100 are u16; shift accordingly
 2019-07-07 14:54:38 -07:00
Kurt
8f88e630c2 Fix ORAS inventory class type 
now no longer removes items from pouch

https://projectpokemon.org/home/forums/topic/53761-oras-item-problems-with-new-version/
 2019-07-07 08:43:58 -07:00
Kurt
772a2715c0 Fix SecondsTo* read offset 
copypasted from gen6's, oops
Thanks CreamatedReptile2018!
 2019-07-07 08:43:04 -07:00
Kurt
f2ac29ff4e Relocate some logic 
slightly reduces savefile.cs footprint
 2019-07-05 22:02:29 -07:00
Kurt
9a61f0de0f Minor relocation of logic 
and the gradual shift to full-oop continues
 2019-07-05 21:39:47 -07:00
Kurt
c0eda5eb61 Add more dex bulk manip options 
unused, not sure how an abstraction can work for all games (needs some
virtual methods to actually work, since 1-3 don't have langflags)
 2019-07-05 18:49:43 -07:00
Kurt
aa94c70df2 Hide gen6 dex logic behind zukan class 
Same as prior commit for gen5 & gen7
 2019-07-05 18:04:36 -07:00