Kurt
33bdacebe8
Minor tweaks
...
Handle some compiler/extension suggestions
2020-04-12 16:07:59 -07:00
Kurt
0ada4cbd77
Remove some unnecessary null checks
2020-04-12 13:20:40 -07:00
Kurt
270d984130
Minor clean
...
Remove unnecessary null checks
Mark some methods with nullable type
2020-04-04 19:30:50 -07:00
Kurt
d65338557e
Add hp stat
2020-03-24 11:44:54 -07:00
CanoeHope
df09868470
Add another SWSH block ( #2793 )
...
Nothing special. Just found it and figured why not add it.
2020-03-19 11:38:17 -07:00
Kurt
287a2ac5c5
Rework handling of bk4 constructor
...
Can't really detect if it's shuffled or not; just assume it's always unshuffled unless it originates from a save file read. Probably not a perfect solution, but achieves better results.
https://projectpokemon.org/home/forums/topic/56217-error-in-archive-bk4/
2020-03-18 23:34:53 -07:00
Kermalis
face69d469
Fix Emerald decorations ( #2788 )
2020-03-18 00:25:02 -07:00
Kurt
429a3b1a08
Expose decoration list for editing
...
Closes #2785 , not making a GUI for this (someone else can do it)
Moves RTC3 to the appropriate folder
2020-03-17 12:14:01 -07:00
Kurt
1c6b99185d
Ignore bits above the first 3
...
Some save files use bits 3-7?
2020-03-15 11:11:55 -07:00
pi1024e
8a1e73e5b3
Change OT_Class to have an expression body ( #2759 )
2020-03-13 10:28:50 -07:00
Kurt
b68e9472cb
Break apart value fetch -> compare
...
easier to debug
2020-03-12 15:05:59 -07:00
Kurt
fbd533092d
Fix misspelling of the word "Received"
...
Closes #2757
Co-Authored-By: pi1024e <pi1024e@users.noreply.github.com>
2020-03-12 15:05:34 -07:00
Kurt
eb01591861
Remove duplicate method
...
Extract magic number 0x40000
2020-03-11 21:09:36 -07:00
Kurt
0aa6282d73
Sanity check value types via generic method
2020-03-11 16:31:53 -07:00
Kurt
f9bbeba3ad
Add get/set for swsh current box
...
Closes #2742
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-03-10 23:18:51 -07:00
CanoeHope
e51df9855d
Add blocks for NPC and Friend League Cards ( #2741 )
...
* Add blocks for NPC and Friend League Cards
* Update SaveBlockAccessor8SWSH.cs
2020-03-01 00:47:56 -08:00
Kurt
4fb33413e3
Only set display shiny of not owned
...
Closes #2740 ; we don't want to set display shiny if it's not shiny
we only want to set display-shiny if (!owned && shiny)
Co-Authored-By: canoehope <canoehope@users.noreply.github.com>
2020-02-28 17:35:50 -08:00
Kurt
d80d1598dc
Only set displayed form if not previously owned
...
Closes #2739
2020-02-28 15:31:26 -08:00
Kurt
e378821101
Remove duplicate key item list for pc items
...
Closes #2733
Co-Authored-By: kermalis <kermalis@users.noreply.github.com>
2020-02-22 19:47:25 -08:00
Kurt
4116fb5b9b
Fix sprite format for gen3
...
Closes #2725
Fix crash if canceling the FRLG version select
Co-Authored-By: Kermalis <kermalis@users.noreply.github.com>
2020-02-20 19:36:06 -08:00
Kurt
0d4cff81c6
Clean
2020-02-15 14:29:23 -08:00
Kurt
3ce590aca8
Don't clear FormArgument on set to box slot
...
Closes #2706
removal of isParty prevents the erroneous force-0 behavior
Co-Authored-By: Russell Jones <questiondesk@gmail.com>
2020-02-13 16:35:37 -08:00
Kurt
9f6d234c53
Fix hgss box wallpaper read
...
lol oops
Closes #2698
Co-Authored-By: ammako <ammako@users.noreply.github.com>
2020-02-11 23:24:03 -08:00
CanoeHope
7ab128de89
Add SwSh Birthday blocks ( #2696 )
...
Because the Switch doesn't have a feature to internally store your B-day like the DS and 3DS does, you set it in-game by the "Fortune Girl" right in front of Wedgehurst's PokeCenter in month and day.
https://www.serebii.net/swordshield/birthdays.shtml
2020-02-10 18:14:20 -08:00
CanoeHope
acb9cc2a9d
Add Gender to Gen 8 Trainer Card ( #2694 )
2020-02-10 12:02:52 -08:00
Kurt
1bf22467de
Add Rental Team (gen8) reader
2020-02-07 17:23:26 -08:00
Kurt
d52366b0d5
Add download rules/comp block labels
...
https: //projectpokemon.org/home/forums/topic/56121-swsh-blocks-and-save-research/
Co-Authored-By: pp-theslayer <pp-theslayer@users.noreply.github.com>
2020-02-07 16:32:05 -08:00
Kurt
a73f14836d
Add HoF time block accessor object
...
Not gonna add it to the interface
Closes #2691
Co-Authored-By: canoehope <canoehope@users.noreply.github.com>
2020-02-07 15:59:36 -08:00
Kurt
c08cf9c95f
Add rental team hashes
...
Co-Authored-By: Archit Date <architdate@gmail.com>
2020-02-07 15:33:53 -08:00
Kurt
7866958af8
Add dynamax crystal type, exclude from activation
...
Closes #2690
Co-Authored-By: slp32 <slp32@users.noreply.github.com>
2020-02-07 10:16:27 -08:00
Kurt
cc05a38548
Clear team slots on blank load
...
Closes #2688
2020-02-06 20:11:58 -08:00
Frank
e5286f3325
RaidSpawnList8 fix DenType and Flags ( #2686 )
...
* RaidSpawnList8 use enum RaidType for DenType
fix IsWishingPiece and add WattsHarvested
* Add check between RaidType.Event and IsEvent flag
2020-02-06 17:12:26 -08:00
Kurt
a004b301d0
Add record count incrementing for sav8
...
Closes #2685 ty @CanoeHope
2020-02-05 19:42:46 -08:00
Kurt
bc45660f99
Update legal raid clamp
...
https: //github.com/kwsch/PKHeX/issues/2681#issuecomment-582215498
Co-Authored-By: slp32 <slp32@users.noreply.github.com>
2020-02-04 19:06:33 -08:00
Kurt
2e1528b199
Merge branch 'master' of https://github.com/kwsch/PKHeX
2020-02-04 16:55:42 -08:00
Kurt
7e6cae4004
Clamp activating raids to available indexes
...
Closes #2681
2020-02-04 16:55:40 -08:00
CanoeHope
9b172d2666
Correct Day offset ( #2679 )
...
a1ae14325a (commitcomment-37103852)
2020-02-04 07:35:02 -08:00
Kurt
0e1fd49be1
Decrement runtime language if appropriate
...
Closes #2674
2020-02-03 19:16:30 -08:00
Kurt
a1ae14325a
Add more block documentation
...
Ty @CanoeHope !
Closes #2677
To edit these values, use the Block Data editor and select the *Object Trainer Card
Co-Authored-By: CanoeHope <canoehope@users.noreply.github.com>
2020-02-03 18:56:35 -08:00
Kurt
b31f0428cf
Add raidtype docs & wishing piece indication
2020-02-02 10:21:34 -08:00
Kurt
43036e7e94
Add team index recognition
...
lock by default until we find the location that locks team slots
2020-02-01 18:56:23 -08:00
Kurt
b35d53368f
Sort blocks by initial value
...
allows some lumping of similar-value blocks for easier analysis
2020-01-28 19:08:26 -08:00
Kurt
ee5c033b51
Add dlc block annotations
...
ty @pp-theslayer
https://projectpokemon.org/home/forums/topic/56121-swsh-blocks-and-save-research/
add another array detail
2020-01-28 16:21:11 -08:00
Kurt
c301ce88ab
Update Random to be a bit more thread safe
...
Random isn't thread safe; users of PKHeX.Core.dll might run multithreaded operations (see PKSM + ALM), so we need to have a thread-specific RNG available.
Thread Local get; to improve performance, save the random object locally whenever it is used more than once in the method.
https://docs.microsoft.com/en-us/dotnet/api/system.threading.threadlocal-1?redirectedfrom=MSDN&view=netframework-4.8
https://stackoverflow.com/questions/18333885/threadstatic-v-s-threadlocalt-is-generic-better-than-attribute/18337158#18337158
2020-01-25 21:49:52 -08:00
Kurt
527442bb49
Only fetch strings when required for compat check
...
if item == 0, don't bother checking. Fetch strings only if there's an issue with the item.
2020-01-25 12:16:45 -08:00
Kurt
9b6a10df46
Extract metadata-reflection class to PKHeX.Core
...
separate GUI logic from non-gui logic :)
2020-01-24 17:57:47 -08:00
Kurt
92d1ccf3d9
Fix Pokewalker course unlock all
...
write to correct location
https://projectpokemon.org/home/forums/topic/56084-pokewalker-courses/
2020-01-24 17:10:53 -08:00
Kurt
46156b48c6
Add missing generation to accessor type name
...
Now matches Interface declaration style (iAccessorGenGame), and is consistently named with the other accessors already using the same naming style
plus they are now ordered in the file tree :)
no functional change
2020-01-23 23:22:54 -08:00
Kurt
fb02295c70
Use object block names in diff
2020-01-23 23:19:38 -08:00
Kurt
12244909ba
Split off SCBlock-logic from SWSH accessor
...
In case a future game uses this same setup.
2020-01-23 23:16:09 -08:00