Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-23 12:33:06 +00:00
Code Issues Projects Releases Packages Wiki Activity
9045 commits 3 branches 76 tags 106 MiB
Commit graph

2016 commits

Author SHA1 Message Date
Kurt
665880e081 Include form in GetEncounters, iterate all forms for savefile 2021-06-11 10:58:38 -07:00
Kurt
24d6c0d713 Change "Some" EV train rating from [0,127] to (0,127] 2021-06-10 19:18:58 -07:00
Kurt
2abf95cdf8 Minor clean 
expand some expressions, extract some methods, add comments
 2021-06-08 20:14:55 -07:00
Kurt
71fd8b36e9 Enable batch filters for encounter database 2021-06-08 20:14:27 -07:00
Kurt
910fce9812 Change namespace to usual PKHeX.WinForms.Controls 
no more oddball namespaces
 2021-06-07 20:04:01 -07:00
Kurt
035584dc7c Extract templating from EditPKMUtil, rename methods 2021-06-07 20:02:57 -07:00
Kurt
e32daee3f3 Add setting to disable loading plugins 2021-06-04 14:19:22 -07:00
Kurt
3764e60b37 Show extra details for exported legality results (debug only) 
same as encdb showing full encounter details, spit them out here too.
 2021-06-03 17:59:53 -07:00
Kurt
5636e1ef4a Add setting to hide unavailable species. 
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2021-06-03 17:48:32 -07:00
Kurt
34ec5416e5 Add setting to disable return-none if empty criteria 
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2021-06-03 17:36:16 -07:00
Kurt
9ba683688e Clear tooltips when changing results 
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2021-06-03 17:32:13 -07:00
Kurt
066aedfc21 Separate scblock ctor's 
No longer need to set byte[] twice
Add value-setter checks for bad mutations (size change, bool1<->bool2 only)
 2021-06-03 12:35:39 -07:00
Kurt
8c970ec991 Minor tweaks 
no functional change, readability++
add more xmldoc
 2021-06-03 12:04:19 -07:00
Kurt
7e32ff9b03 Add settings to toggle loading of saves for pkmdb 
https://projectpokemon.org/home/forums/topic/58942-question-about-custom-backup-path-pkm-database-path-avoid-to-scan-sub-folders/
 2021-06-02 10:52:20 -07:00
Kurt
138501da2f Minor clean 
Condense some expressions
Use less linq
Rename some fields
 2021-05-29 15:31:47 -07:00
Kurt
7a8d75aec4 Show gender in encounter browser 
Extract methods, add some comments, simplify array fetch.
 2021-05-27 10:27:50 -07:00
Kurt
386d9cc94f Repoint hall data fetches outside blocks 
Reverts prior commit repointing which was incorrect; these are outside the sav general/storage blocks.

871f9b0627 (diff-3560dca7e50959e98ae8fa32d9403f8846b9243815d653c78a07f2a3455a1874L481)

Keep the first as General as it's some value index within the General block used to index which extrablock matches it, or something

Closes #3211
 2021-05-25 22:16:04 -07:00
Exorcism
02605b402d
Update French Translation (#3209) 
* Update language French (Français)

* Update French Translation

* Update MessageStrings_fr.txt

* Update text_EncounterType_fr.txt

* Update text_Ribbons_fr.txt

* Update text_Ribbons_fr.txt

* Update lang_fr.txt
 2021-05-24 09:16:07 -07:00
Kurt
8cc2967395 Update MemoryAmie.cs 2021-05-23 12:51:25 -07:00
Kurt
c9499f95be Add sociability to Memory editor, add legality checks 2021-05-23 11:22:09 -07:00
Kurt
15afd6f3bc Move mail get to sav obj 2021-05-22 09:28:04 -07:00
Easy World
6b693b9b7e
Update Chinese translation (#3208) 2021-05-20 22:04:32 -07:00
Kurt
207680b2f1 Update translatable lists 2021-05-20 15:05:40 -07:00
Kurt
aa55346bde Add setting to not show changelog on update 2021-05-20 15:03:15 -07:00
Alberto Tudela
7d27136bdc
Update spanish translations (#3207) 
* Update spanish translations

* MInor Folder list fixes

* Update spanish translation
 2021-05-20 13:21:21 -07:00
Kurt
4b3a3a4afe Update 21.05.21 2021-05-20 09:37:15 -07:00
Kurt
f462017670 Fix padding mask 
Closes #3205 -- padding char
Closes #3206 -- sav3rs doesn't use SecurityKey, it's always 0

Co-Authored-By: Michi97 <24464847+Michi97@users.noreply.github.com>
 2021-05-20 08:27:08 -07:00
Kurt
2658c8b89a Update 21.05.19 2021-05-18 17:49:54 -07:00
Kurt
1d71d151e8 Add gen8 to generation dropdown 2021-05-18 16:59:19 -07:00
Kurt
5355d251a6 Align shiny checkbox same as pkmdb 2021-05-18 16:59:01 -07:00
Kurt
53e9d31545 Allow searching encounter db for shiny state 
random shinies behave like not-shinies
so it only really filters for "always shiny" or "can be nonshiny".
 2021-05-18 16:17:57 -07:00
Kurt
74e0cba3b0 Minor tweaks 
use assert instead of manual exceptions
span
remove some dead logic
 2021-05-18 16:16:48 -07:00
Kurt
2c820bfbe9 Minor tweaks 2021-05-18 13:29:55 -07:00
Kurt
565f161226 Show shiny state of encounter in db 
Force shiny state for GO encounters

For encounters, this interface property is mainly just for exposing metadata for sprites.
 2021-05-18 10:36:45 -07:00
Kurt
acdbda4e12 Split DateUtil from Util class 2021-05-14 16:46:48 -07:00
Kurt
50b15cd740 Use range/index 
More in line with modernizing the codebase with latest c# syntax

improve web-qr decode speed slightly (no linq skiptake)
get money/coin mask without a temporary string (lol performance)
 2021-05-14 15:30:55 -07:00
Kurt
871f9b0627 Convert checksum operations to span-based 
Fix SAV.Data references in SAV_Misc4 to use the General block instead
 2021-05-14 12:30:40 -07:00
Kurt
d21c1fb135 Set editing mode when loading data to form 
Prevents wiping of Multiplayer sprite assignment
 2021-05-12 15:44:28 -07:00
Kurt
d340642b09 Minor perf improvements 2021-05-10 01:01:45 -07:00
Kurt
43af6322e8 Clean up csproj's 
no functional change
yay wildcards
 2021-05-09 12:57:26 -07:00
Kurt
cea2edb3e9 Add controls in one action 
reduces the amount of control redraws
 2021-05-09 12:10:32 -07:00
Kurt
9826067a18 Handle latest custom folder path buttons correctly 
no longer tab separated paths; just show the parent folder name.
 2021-05-03 16:58:23 -07:00
Kurt
f063014879 Improve clarity of plugin load failures 2021-05-02 18:27:04 -07:00
Kurt
b049c82284 Update SAV_MysteryGiftDB.cs 2021-04-21 19:36:10 -07:00
Kurt
8e1be1f911 Pre-filter gifts that aren't available for current save 2021-04-21 19:28:01 -07:00
Kurt
5607d833be Remove affixed on none-ribbon 
don't care about remove all legal retaining if not removed
 2021-04-21 19:19:58 -07:00
Kurt
802275ced0 Fix recently loaded tracking 
Not present would return instantly; just chain it with the remove tail
 2021-04-21 19:02:30 -07:00
Kurt
778aacb9cf Show larger sprite box 2021-04-19 23:30:46 -07:00
Kurt
4bb5433489 Change default setting so that "Legal!" pops up unless opted out 2021-04-14 14:09:54 -07:00
Kurt
7bc733c900 Update SK2 language coercion 
Closes #3194
Exports are fine, imports with an ambiguous language (can be either JPN or INT) while illegal don't result in the above branches passing it.

Inputs with <=6 chars for OT&Nick will be ambiguous; PKM editor.
 2021-04-11 20:50:34 -07:00
Kurt
0d45075d4b
Rewrite settings handling; enhance some user experiences (#3193) 
- Settings now stored as json next to exe
- Settings now exposes all legality checking setttings that can be changed
- Slot hovering now can play cries in MGDB/PKMDB/etc, not just the main boxes.
- Enhanced hover text for mystery gifts and encounters that have movesets
- Show recently loaded save files in ctrl-f browser
- Toggle auto-load savefile setting to be none/detect-latest/last-loaded
- Custom extensions & extra backup paths can now be configured directly in the json settings
- Settings editor now uses propertygrid & tabs.
 2021-04-11 18:09:54 -07:00
Kurt
4dea69e068 Fix met location list misbehavior 
PKM Editor is so spaghetti anyway
 2021-04-10 10:30:10 -07:00
Kurt
329a2cbd44 Remove indirect data fetching 2021-04-09 19:44:14 -07:00
Kurt
0576b9dfba 68x56 2021-04-09 17:23:09 -07:00
Kurt
bfd581e89d Rearrange daycare for 68x56 layout 2021-04-09 17:20:42 -07:00
Kurt
9bc07b6e01 Remove unused setting 2021-04-09 17:20:30 -07:00
Kurt
5ed73e0bff Revise Party tab labels 2021-04-09 17:20:00 -07:00
Kurt
d73baebad2 Use wider sprite boxes for Mystery Gift album display 2021-04-09 16:37:32 -07:00
Kurt
b3b60894b6 Remove 40x30 sprite assets 
Farewell; let's assume things are 68x56 from now on.
 2021-04-09 16:24:19 -07:00
Kurt
c7b997865c Minor clean 2021-04-09 14:52:49 -07:00
Kurt
f8a2bb3229 Add missing research tab flag set 
Closes #3187
 2021-04-07 22:46:28 -07:00
Kurt
b0700ba281 Extract Gen7 HoF class, extend event flag count 
4k flags exactly, and probably 4950 for USUM (alignment +1 byte for an even 4960)

The old flag + count (4 bytes total) are just +32 event flags.
 2021-04-07 00:20:02 -07:00
Kurt
2f4b754505 Fix incorrect event flag reference 
Thanks SneakyPeekyFox!

Also fix crash if pressing escape on the save differentiation popup.
 2021-04-06 17:26:13 -07:00
Kurt
c05fc854b1 Update 21.04.06 
Mostly because of Gen3 save editing bugfixes, forcing a new version.

Last version added the PID checks for Gen8; this one adds move ordering checks for eggs. More fun :)
 2021-04-05 22:57:05 -07:00
Kurt
673c0d93a6 Extract event flag/work editing from GUI 
now <200 lines for editing (ignoring the diff functions), yay
Opening the editor allocates less (no copying save file)
 2021-04-05 20:52:49 -07:00
Kurt
ecf1f361fe Show encounter's full details on hover (mgdb/encdb) 
Won't work neatly for Mystery Gift types since those aren't record types.
 2021-04-04 12:05:00 -07:00
Kurt
790da981f0 Fix gen3 trainer card team list 
don't bother casting
 2021-04-01 14:16:33 -07:00
Kurt
4700fdd1e3 Set updated version when resetting personal 
Closes #3180

Improves handling for corrupt gen3 saves (pokedex cheaters)
 2021-04-01 13:37:39 -07:00
Kurt
4cf926f703 Update 21.04.01 
Latest cumulative update release with mgdb/pget binaries updated.

There aren't any April Fools jokes in this release.
 2021-03-31 21:52:15 -07:00
Kurt
645f2b4db5 Revert implicit casting 
Looks like netstandard2.0 wasn't meant to receive that new c#9 goodie
 2021-03-29 00:14:44 -07:00
Kurt
3822981590
Rework EncounterCriteria to be ability indexed rather than direct ability (#3179) 
* Exploration: rework ability criteria to ability numbers desired

* Sync remaining changes

* Update EncounterCriteria.cs

* Add xmldoc

* Improve speed of IsDualGender check

* More xmldoc updates

Should be doing this on main but meh, this branch is gonna get merged later

* Fix typo

* Update WC7.cs

* Update PersonalInfo.cs
 2021-03-23 17:05:15 -07:00
Kurt
d6dc8a0410 fix signed g7id display 
>2^31 would show a negative G7SID, no more!
 2021-03-20 19:38:01 -07:00
Kurt
e547a9cf63 Extract report generation from LegalityAnalysis object functions 
Can replace the default functionality with your own formatter, I guess.
 2021-03-20 13:21:04 -07:00
Kurt
8d3f990667 Make some properties into consts 2021-03-20 12:47:21 -07:00
Kurt
33e2c64721 Split SAV3 into version classes 
Begone are the version-switch cases for value fetching.
 2021-03-15 23:51:58 -07:00
Kurt
6bce4eea14 Minor clean 
Annotations (nullable), some switch cases for readability
 2021-03-14 16:16:55 -07:00
Kurt
4f6258e492 Add direct object editing for accessor type saves 2021-03-14 16:14:15 -07:00
Kurt
154d95982a Error message on trying to interact with deleted/removed files 2021-03-08 11:37:46 -08:00
Kurt
49541e6073 Rework mainline sav3 to not operate off chunks 
Previous style was to resize the sav buffer and concat all the storage chunks at the end. Allocated a double save file.

Now, just allocate 3 buffers.
 2021-03-07 23:22:07 -08:00
Kurt
9e4f1d11cc Show misc encounter details on hover 2021-03-07 12:35:26 -08:00
Kurt
8145456ca8 Add u32 hex key -> enter to jump to key (ignoring named blocks) 2021-02-27 22:34:05 -08:00
Egzon
815da3ff0c
Update spanish translation (#3160) 
* Update LegalityCheckStrings_es.txt

* Update lang_es.txt
 2021-02-23 06:27:27 -08:00
Easy World
595223e1af
Update lang_zh.txt (#3157) 2021-02-21 19:29:25 -08:00
Kurt
32eff161cc Repopulate translations with latest additions/removals 2021-02-21 15:22:28 -08:00
Kurt
41096fb56e Minor xmldoc / usage updates 2021-02-21 15:01:28 -08:00
Kurt
c11cf3d6d4 Extract gen4 pokedex logic 2021-02-21 09:59:10 -08:00
Kurt
a7a7be7c44 Allow loading of savpaths, load misc & party slots 2021-02-13 13:04:43 -08:00
Kurt
d5e9775081 Update RibbonEditor.Designer.cs 
https://github.com/kwsch/PKHeX/issues/3146#issuecomment-777060691
 2021-02-10 14:12:14 -08:00
Kurt
d4be8aa7be Update PKMEditor.cs 2021-02-10 14:02:25 -08:00
Kurt
4cabbc49a2 Add affixed ribbon drop-down 
Closes #3146
 2021-02-10 13:34:49 -08:00
Kurt
b0fac2dd34 Update PKMEditor.cs 2021-02-09 08:46:03 -08:00
Kurt
666a1805ba Relocate formargument logic 2021-02-08 20:42:19 -08:00
Kurt
ff7817a749 Create FormArgument extension logic 2021-02-08 20:39:46 -08:00
Kurt
37cb15749e Update FormArgument handling for gen6/7 
Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor.

Change UpdatePKM to include isParty, as we want it optional to update FormArgument too.

Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values.

Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only.
PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed)
PK7: u8 remain, u8 elapsed, u8 max, u8 unused.
PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
 2021-02-08 20:26:53 -08:00
Kurt
a0351efc81 Show preview tooltip in mgdb view 
Show card header to differentiate gifts
 2021-02-07 08:32:01 -08:00
Kurt
a2d5d7d769 Show preview for encounter database slots on hover 2021-02-06 22:33:13 -08:00
Kurt
a7f65554ad Update formarg handling 2021-02-05 16:52:46 -08:00
Kurt
a7cc51f633 Show alolan height/weight records 2021-02-05 07:46:06 -08:00
Kurt
726f100496 Update SAV_Encounters.cs 2021-02-03 11:48:23 -08:00
Kurt
8db21c2bd0 Update 21.01.30 
Latest cumulative update release with mgdb/pget binaries updated.
 2021-01-30 10:46:05 -08:00
Kurt
1e86fdcea8
Fracture the encounter matching checks to allow progressive validation (#3137) 
## Issue

We want to discard-but-remember any slots that aren't a perfect fit, on the off chance that a better one exists later in the search space. If there's no better match, then we gotta go with what we got.

## Example:
Wurmple exists in area `X`, and also has a more rare slot for Silcoon, with the same level for both slots. 
* We have a Silcoon that we've leveled up a few times.

Was our Silcoon originally a Wurmple, or was it caught as a Silcoon? 
* To be sure, we have to check the EC/PID if the Wurmple wouldn't evolve into Cascoon instead.
* We don't want to wholly reject that Wurmple slot, as maybe the Met Level isn't within Silcoon's slot range.

---

Existing implementation would store "deferred" matches in a list; we only need to keep 1 of these matches around (less allocation!). We also want to differentiate between a "good" deferral and a "bad" deferral; I don't think this is necessary but it's currently used by Mystery Gift matching (implemented for the Eeveelution mystery gifts which matter for evolution moves).

The existing logic didn't use inheritance, and instead had static methods being reused across generations. Quite kludgy. Also, the existing logic was a pain to modify the master encounter yield methods, as one generation's quirks had to not impact all other generations that used the method.

---

The new implementation splits out the encounter yielding methods to be separate for each generation / subset. Now, things don't have to check `WasLink` for Gen7 origin, because Pokémon Link wasn't a thing in Gen7.

---

## Future
Maybe refactoring yielders into "GameCores" that expose yielding behaviors / properties, rather than the static logic. As more generations and side-gamegroups get added (thanks LGPE/GO/GameCube), all this switch stuff gets annoying to maintain instead of just overriding/inheritance.

## Conclusion

This shouldn't impact any legality results negatively; if you notice any regressions, report them! This should reduce false flags where we didn't defer-discard an encounter when we should have (wild area mons being confused with raids).
 2021-01-29 17:55:27 -08:00
Kurt
ceb14c8468 Add consistent ctrl/alt modifiers for IV/EV/AV 
Closes #3132
 2021-01-20 22:09:25 -08:00
Kurt
803b8675fe Rework batrev current slot handling 
Show all slots even if they're uninitialized. Empty first slots but present second slots caused errors on init.
 2021-01-20 20:29:26 -08:00
Kurt
4c49d489a8 Update SAV_Inventory.cs 2021-01-20 20:01:59 -08:00
Kurt
46b988b6fa Remove unused checkbox 2021-01-20 17:06:37 -08:00
Kurt
d805167e7c Save battle version value on value change 2021-01-18 18:18:42 -08:00
Kurt
680e8b711d Add some code analysis for try-return with nullable out 2021-01-17 00:05:07 -08:00
Kurt
c31285fd6d Dump csv async 
Skip Sprite column completely
 2021-01-16 17:25:55 -08:00
Kurt
3c42978afa Use IndexOf instead of FindIndex when possible 2021-01-16 12:47:02 -08:00
Kurt
613e6db744 Use StringConverter api consistently; use stringbuilder when possible 
Retain a stringbuilder to mutate the string rather than finalizing temporary strings

yields some speed improvements (less gen0 string objects allocated)
 2021-01-14 22:50:13 -08:00
Kurt
6566b0ed1f Add Pokedex flag properties 
Closes #2954 ; can set directly from propertygrid already, but might as well clean things up a little bit to match the disassembly logic.

Open the simple editor center parent rather than next-form-position
 2021-01-09 23:27:22 -08:00
Kurt
3e0b52195a Minor clean 2021-01-08 13:17:59 -08:00
Kurt
f615814548 Add xmldoc, increase swish util flexibility 2021-01-07 15:34:26 -08:00
Kurt
6e741a0cf0 Minor tweaks 
Add xmldoc
Remove linq from memecrypto code (speed lmao)
Hide some methods that shouldn't be called directly
Name variables better for accessor const's
 2021-01-06 23:30:30 -08:00
Kurt
cc43550357 Simplify more expressions 2021-01-04 17:31:43 -08:00
Kurt
cdcbc3750b Update PKMEditor.cs 2021-01-02 12:46:46 -08:00
Kurt
d02dd29e83 More version-location shenanigans 
Should be behaving correctly for gen!2=>gen2 now
 2021-01-02 10:35:48 -08:00
Kurt
09089da14e Use more expression return style 
Reduces indentation & bracketing, a bit more concise
 2021-01-01 17:08:49 -08:00
Kurt
813180453e Delete duplicate HT bit fetch method 
Make expression methods
 2021-01-01 16:39:33 -08:00
Kurt
7523e0e200 Make ContestStat fields byte (from int) 2021-01-01 13:39:08 -08:00
Kurt
d66486ac29 More pkm.form visibility/initialize tweaks 
Gen7 started up showing a form=-1 marshadow, initialize the combobox with an empty string since we no longer set formlist if it has none
label/combobox visibility should be managed by gen2 flowlayout case below
 2021-01-01 11:29:20 -08:00
Kurt
fb008be6a6 Condense some more expressions 2020-12-31 23:13:27 -08:00
Kurt
989c4314ae Hide formarg control when not present for format 
Set initial visibility state to false for startup anyways; parent usercontrol should get set invisible by PKMEditor during its setup-format logic.
 2020-12-31 15:15:22 -08:00
Kurt
d0d7895fa5 Only refresh localized data sources if needed (generation) 
Faster same-type savefile loading
 2020-12-31 15:10:37 -08:00
Kurt
f4bf9dd208 Minor clean 
add download count to changelog
move 2019 changelog to uncompiled resource (for record)
 2020-12-31 10:36:09 -08:00
Kurt
99292c75f9 Update 20.12.30 2020-12-30 21:16:38 -08:00
Kurt
ec4358372a Finish implementing form-argument control behavior 2020-12-30 00:32:17 -08:00
Kurt
2af9e800fb Add RotomAffection and rotoloto1/2 flag editing to GUI 2020-12-29 11:39:19 -08:00
Kurt
d9a4eacaf4 Allow deactivating all raids 2020-12-29 10:53:47 -08:00
Kurt
de840f40d4 Invert some "!is" to "is not" 2020-12-29 00:58:08 -08:00
Kurt
e8c23f6644 Simplify some repeated comparisons with expressions 
Less prone for bugs since it uses the same value for all comparisons without re-specifying
 2020-12-29 00:37:59 -08:00
Kurt
c119f18af3 spec->species 2020-12-28 22:22:52 -08:00
Kurt
6502c9df33 Condense some expressions, extract static class 2020-12-28 21:42:54 -08:00
Kurt
0a46f45b00 Split MetDataSource from GameDataSource 2020-12-28 21:12:46 -08:00
Kurt
74ee22e66e Make ComboItem a record 2020-12-28 11:57:34 -08:00
Kurt
a124168e87 Make FormArg editing a complex control 
Shows a dropdown for alcremie only, and a number entry for everything else.

See 771086a222 for initial implementation; I don't want the lag anymore lol
 2020-12-28 11:51:25 -08:00
Kurt
7298910f04 Simplify some logic 
The save editor buttons were originally checked for visibility in order to determine if we should hide the groupbox completely. This didn't work if the groupbox wasn't being displayed (get visibility checks if it is currently rendered, in addition to can be shown). So the "enabled" state was used to determine if it should be shown.

Now that we have the "Blocks" raw editing always being shown, the GroupBox will always be shown. Can just set the visibility directly, rather than doing the workaround.

Make the hall of fame editors slightly less SaveFile_type-specific.
 2020-12-28 10:26:08 -08:00
Kurt
ee5349ff98 moar is or 2020-12-25 12:30:26 -08:00
Kurt
4a8a495d04 Condense some switch expressions 
Should be it for now; exhaustively searched for all that made sense to change
 2020-12-25 10:58:33 -08:00
Kurt
4d0108331a Move LegalityAnalysis derived movesets out of class 
LegalityAnalysis just does the analysis; no need to do unnecessary suggestion logic inside the object.
 2020-12-24 16:36:50 -08:00
Kurt
43dd390f21 Split IContestStats, mark trades as records 2020-12-24 00:06:40 -08:00
Kurt
93910df2c6 Use new switch statements 2020-12-23 17:14:38 -08:00
Kurt
7e4eb86e93 c#9 is not sugar 2020-12-22 21:24:41 -08:00
Kurt
e34c8df044 Revise some method signatures 2020-12-22 20:50:33 -08:00
Kurt
997e0751f3 Minor clean 
Handle remainder of c#9 sugar
Fix some spelling mistakes
 2020-12-21 23:37:07 -08:00
Kurt
514b60b447 Merge type check with usage in if statements 
if x is y with z property true, then :D
 2020-12-21 22:33:48 -08:00
Kurt
d225f3391a Split up DataUtil to separate files 
ya i know there's already a localizeutil class, whatever
 2020-12-21 19:13:18 -08:00
Kurt
63aa8dcd43 Bump langver to 9 for other subprojects 2020-12-21 19:12:24 -08:00
Kurt
6d030831ab Bump PKHeX.Core to C#9 language version 
Add FrameworkUtil.cs which is compiled if the build isn't net5+, needed to support init setters & records
 2020-12-21 16:52:11 -08:00
Kurt
62018cce1a Unify concepts with different names 
AltForm & Form & Forme => Form
GenNumber & Generation => Generation

Extract out SpeciesForm interface, and re-add IGeneration

For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
 2020-12-10 20:42:30 -08:00
Kurt
98ef0299b6 Add xmldoc for save meta/state tracking 
Move some logic around to the more appropriate spot
 2020-12-07 19:49:04 -08:00
Kurt
6f7602f2ad Change signatures to use readonly if possible 
Extract get/set team methods for battle video
 2020-12-05 06:09:33 -08:00
Kurt
e72c80613e Extract metadata/state tracking from SaveFile obj 2020-12-05 05:36:23 -08:00
Kurt
fefc38bacb Minor debug optimizations 
Trees:
- Only retain the objects needed after calculation
- Reduce size of TreeCoordinates and remove allocation penalty (now a struct)

No more warnings for Release compilation :D
 2020-11-28 14:55:09 -08:00
Kurt
0eb7bf7a4b Add alert if database load fails 
Task is executed without reporting exceptions; continue after the task with another that checks if it failed.
 2020-11-28 14:53:32 -08:00
Kurt
8778d8c6b7 Update 20.11.28 2020-11-27 21:40:36 -08:00
Kurt
9b178fefe2 Xmldoc, minor tweaks 
Move form-info logic from FormConverter to AltFormInfo; now FormConverter is entirely form=>string[]
Add a bunch of xmldoc
Make pogo no-end-date cmp agaisnt UTCnow rather than local now.
 2020-11-27 11:51:02 -08:00
Kurt
038903a2f9 Update BoxMenuStrip.cs 
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
 2020-11-19 15:59:33 -08:00
Lusamine
6a91dfbaba
Fix parsing SID error (#3090) 2020-11-19 15:38:56 -08:00
Kurt
81110b4231 Upgrade netcore build to NET 5.0 
keep with the times, kids

handle some compiler messages
 2020-11-14 08:20:48 -08:00
Kurt
df5ebd1f54 Minor clean 
Resolve some messages
 2020-11-11 21:01:41 -08:00
Kurt
f3ad96d056 Update KChart.cs 2020-11-06 11:20:52 -08:00
Kurt
23e765e550 Add opening for rental team dumps 
Dunno why anyone would want these, lol
Closes #3074
 2020-11-03 20:12:42 -08:00
sora10pls
5c401fa936 Update GetIsNative for KChart 
We want to show that the Species is native if it appears in any Dex (Galar, Armor, Crown), not just the main Galar Dex.
 2020-11-03 12:02:08 -05:00
Kurt
b8023605ad Update 20.10.31 2020-10-31 12:01:01 -07:00
Kurt
28767df0fb Split gamesync details to interface 2020-10-31 11:43:57 -07:00
Kurt
4012977c3c Adapt when loading new 
See previous commit message
 2020-10-31 09:22:13 -07:00
Kurt
c9587c16c7 Adapt dropped/opened PKM to currently loaded savefile 
Closes #3067
 2020-10-30 22:44:08 -07:00
Kurt
80a5d8e451 Remove layer null check 
Move to the place that triggered the null
 2020-10-30 19:56:16 -07:00
Kurt
7a24651aef Remove splashscreen from main form init 
I want to start abstracting the main GUI to reduce the amount of things the main/pkm/sav editor classes do directly.
 2020-10-28 17:27:11 -07:00
ReignOfComputer
3767a61171
Fix Stat Tooltips (#3057) 
Was only updating based on Stat Nature?
 2020-10-27 09:18:12 -07:00
Easy World
be7b586d7a
Update Chinese translations (#3052) 
* Update lang_zh.txt

* Update LegalityCheckStrings_zh.txt
 2020-10-26 07:42:00 -07:00
Kurt
9e380fdcde Update sprite on gmax field change 2020-10-25 13:47:42 -07:00
Kurt
9264150b2b Add shiny1 batch editor, add ctrl-shiny (1) 
GUI: Ctrl click star to get shiny1, shift click for shiny0, any-click to get random

make Alt click modify the SID instead of PID

add SetShinySID shiny type
 2020-10-25 10:42:48 -07:00
Kurt
3e1bc1f59d Show extra slots in the "Other" tab 2020-10-24 14:57:53 -07:00
Kurt
040ebb63f0 Handle more release build warnings 2020-10-24 12:38:14 -07:00
Kurt
bc33c87c6c Add click handler for crown raids 
oops
hotfixing exe soon
 2020-10-24 12:28:59 -07:00
Kurt
1d596225e5 Update 20.10.24 - Crown Tundra 
Update mgdb with latest from the Events Gallery.

Handle nullable warnings for release build.
 2020-10-24 11:59:35 -07:00
Kurt
5cdf8db912 Update GUI localization files with latest available strings 2020-10-24 11:42:29 -07:00
Kurt
8a2a25fde1 Update data structures for Crown Tundra 
Adds a wild area Raid den detail editor like mainland/armor raids.
 2020-10-24 11:09:29 -07:00
Kurt
14a678b57d Revise save detect logic flow 
Double-Clicking SAV tab no longer hides any error message; now shows it like the auto-detect would.

Move high-level detection method to Core
 2020-10-18 19:49:46 -07:00
Kurt
cce4707604
Enable nullable for winforms csproj (#3037) 
Handle all warnings
obviously the usage of null! could potentially be avoided if the object init wasn't such garbage, but here we are with years of old junk and lack of abstraction in the GUI project
 2020-10-18 11:02:39 -07:00
Kurt
7a01b1249c Minor clean 
Handle more messages, add more xmldoc
 2020-10-18 09:43:41 -07:00
XxPhoenix1996xX
cb8e2ed3d2
Update lang_es.txt 2020-10-17 08:25:04 -03:00
Kurt
0a6534a208 Extend individual transfer count to 999mil 
Closes #3028
Thanks @CarlosofKalos !

Setting 9999 for both on Rattata; capturing the 10,000th didn't increment, but transferring the 10,000th did.

Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2020-10-12 14:16:55 -07:00
Kurt
7bb51f4da2 Update 20.10.10 
Update event database with latest from the event gallery repo :)

This is the last release prior to any release for Crown Tundra.
 2020-10-10 00:30:21 -07:00
Kurt
bb65f2d2c2 Show trainer name&id for registered Stadium teams in dropdown 2020-10-09 20:31:13 -07:00
Kurt
9d21e5acdd Add GUI for Capture Records 
Accessible from Pokedex window
ur welcome matt
 2020-10-08 18:06:29 -07:00
Kurt
3686ee9ec4 Set suggested Encounter Type on Met Location click too 
Closes #3010
 2020-10-08 15:01:23 -07:00
Kurt
61dc9a45ae Revise Shadow state detection 
Closes #3012
 2020-10-06 22:36:27 -07:00
Kurt
d4452ce3af SK2 coerce to load to a hint language 
This format won't be supported cleanly, so let's just try to allow language detection to work as best as it can without storing metadata in the SK2 bytes.
 2020-10-04 14:42:48 -07:00
Kurt
6938d2f94d Split VivillonTables into two classes 
Indicate that the content is for 3DS specific logic
Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin
 2020-10-04 14:15:13 -07:00
Kurt
09c6359e3a Add flexibility for SK2 imports 
Check language character table for English vs Japanese when loading for a destination
 2020-10-04 10:25:34 -07:00
Kurt
f8de9fe1bf Minor tweaks 
now that stadium saves all expose registered teams, can just call from the parent class
rental sk2's have no TID; add that to the requirement to not get flagged for missing OT
 2020-10-04 09:26:15 -07:00
Kurt
d13b893351 Use ＰＫＨｅＸ as blanksav language 
Closes #3009

Make QRPK7 implement IEncounterable and remove hardcoded PKHeX strings
Let force hatching for WC3 eggs try to hatch from the savefile's language, then revert to english if failed to set an OT.
 2020-10-04 08:59:33 -07:00
Kurt
262561d5d1 Fix stad1 missing team types 
off by 1 (8=>9, and EN has unused interstitial teams).
Fix last-viewed-slot indication color tracking
 2020-10-03 19:48:56 -07:00
Kurt
7efaa5ab71 Minor clean 
collapse some expressions
handle some compiler messages
 2020-10-03 18:59:36 -07:00
Kurt
816f24e3db Add Misc pkm array viewer for Stadium saves 
Readonly slots

Things could be expanded on to use interfaces and wrappers for a "SlotReference" and properties for readonly.

But that's kinda unnecessary
 2020-10-03 18:22:29 -07:00
Kurt
bca8a80b39 Minor clean 2020-10-03 17:09:22 -07:00
Kurt
b242aed429 Add ability to load blank japanese/korean save files 
Detects the language of the currently loaded save file, and passes that info to the blank sav creator

Use a trainer name of "1337" instead of PKHeX for any Japanese save file, because Gen1/2(/3?) character tables don't have regular ascii chars.
 2020-10-03 11:22:06 -07:00
Kurt
52a67f2425 Add Stadium2 Support 
Introducing a new PKM format: SK2
Split ICaughtData2 off of PK2 so it can be shared with SK2 when type-checks occur
Add conversion for PK2<->SK2
Split the split-buffer handling for GBPKM to GBPKML (what a name), so that I can reuse shared accessor logic for SK2.
 2020-10-02 18:08:40 -07:00
Kurt
22f37910f0 Remove unnecessary single-member interfaces 2020-09-27 18:19:28 -07:00
Kurt
82afefa335 Make GP1 expose IEncounterable for metadata 
Make the main loader handle IEncounterable objects
 2020-09-26 11:33:21 -07:00
Kurt
6243135f28 Minor clean 
Move Home8 location to Locations.cs for documentation
Move FestaFacility to correct folder
Remove unnecessary public modifier on interface method
Pass the program's Version to any loaded plugins, if they wanted to check compatibility...?
 2020-09-25 23:55:31 -07:00
Kurt
efc17a1271 Add interface for revised savefile types (patches) 
SWSH is the first common savefile type that has different revisions after official patches. We want to indicate in the Program Title which revision we're currently editing, because people still are not editing latest-format saves and complaining y no urshifu.

Use short descriptions to indicate revision (Base, IoA, CT), rather than magic numbers (v0/v1) or 1.X or 1.X.Y+, because GameFreak can't follow semver rules.

go away ranch platinum update, i might handle you another time
 2020-09-25 23:41:20 -07:00
Kurt
2b7e06e217 Refactoring 
Extract some logic, suppress some compiler messages
 2020-09-18 22:11:13 -07:00
Kurt
7a1c438b74 Minor tweaks 
add method to randomize AVs from interface extension method
revise stat presence check to check ATK since HP is stored in gen1 format
 2020-09-17 18:13:08 -07:00
soopercool101
1a1cfbda4a
Fix Hidden Power Power calculations (and add to UI) (#2989) 
* Fix broken hidden power power calculation

* Fix broken Gen 2 Hidden Power calculation

* Add parentheses

* WIP UI

* Finalize UI, only show on gens 1-5

* Inline some logic to reduce allocations

* Add unit tests for both hidden power calculation cases

Co-authored-by: Kurt <kaphotics@gmail.com>
 2020-09-14 20:06:11 -07:00
soopercool101
63be1fb0e7
Update Underground Editor UI (#2988) 2020-09-14 19:05:49 -07:00
Egzon
4b1a9a89da
Add support for reading and editing Underground Items (#2987) 
Adds a sub-editor with localized support for editing Underground Items.
 2020-09-13 14:55:50 -07:00
Kurt
407c986c89 Update netcore target from 3.0 to 3.1 
.NET 5 is in 2 months, might as well bump things to the current LTS
 2020-09-09 18:27:12 -07:00
Kurt
01fb233e48 Minor tweaks 
Extract some interfaces
Suppress some warning messages with commented reasons if appropriate
 2020-09-09 12:47:24 -07:00
Kurt
5d3bc289b6 seal hunting 
Mark things as sealed as they shouldn't be inherited from or overriden in a derived class.
 2020-09-07 13:51:13 -07:00
Kurt
9191f023a3 Minor clean 
Nullability annotations and some logic simplification
 2020-09-06 11:24:54 -07:00
Kurt
cf9e5ec37f Minor refactoring 
Change Ability array to IReadOnlyList, add method to check ability index in personal data
Suppress some message warnings
Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue.

Simplify pk5 conversion
 2020-09-06 10:53:13 -07:00
Kurt
c2ec4d55e4 Minor clean 
Add some xmldoc, remove some empty lines, move some small logic pieces to a better spot
 2020-09-03 14:28:51 -07:00
Kurt
b03a5f2818 Fix pika beach score reading 
fix reads as little endian instead of big endian
fix truncation if editor value from byte => ushort
Closes #2976
 2020-09-01 16:05:52 -07:00
Kurt
9667e86446 Simplify dreamworld encounter init 
precompute result size
set Gen5 as lumped group for common encounters
remove linq usage (besides Sum call, whatever)
GetEncounters now only filters the in-game static encounters rather than the dreamworld too, as those are already filtered by separate arrays.
 2020-08-30 19:51:44 -07:00
Kurt
bd11affa13 Minor clean 2020-08-30 19:24:40 -07:00
Kurt
75da70069c Remove access to modified captured variable 
Get the variable rather than indexing into the array each time

Simplify some expressions in sav7 for readability
Make SAV_EventFlags use comboitem explicitly by type rather than an anonymous type with same member names
 2020-08-30 15:48:11 -07:00
Jonathan Herbert
6eb348848d
Handle Exception When Adding Font File (#2977) 2020-08-25 11:42:08 -07:00
Kurt
890f3375c9 Misc clean 2020-08-18 15:39:45 -07:00
Matt
f9b4c1950b
Add Catch Rate to KChart (#2972) 2020-08-15 16:13:15 -07:00
Kurt
541c9761df Minor clean 
Make flag indexes immutable
Rename some properties for clarity
 2020-08-14 20:23:54 -07:00
Kurt
d8fe197a3a Update 20.08.07 2020-08-06 19:15:16 -07:00
Kurt
12d9397c8c Split GO from "GG" gameversion 
Make Gen7b as the combined ver for that expression
 2020-08-06 18:24:20 -07:00
Kurt
85d1b0e7ad Split gen6/7 affection stats to interface 
not in future formats, doesn't belong
 2020-08-02 11:06:30 -07:00
Regnum
9e40fa132f
Improved Pokewalker Editing (#2958) 
* Added PokeWalker Courses, Watts, and Steps editing

* Use util method for getting bitflags

* Keep old cheat method

Change signature so that the default value passed is to unlock all; can pass 0 instead to lock all

* Pass reference to derived sav4-type object

Wev'e already type-tested once, capture the reference and pass it into the appropriate load/save methods.

* Add control anchoring for window resizing

Also widen the labels for localization (longer strings possibly)
 2020-08-01 09:20:13 -07:00
Kurt
e84ce77008 Split memories from main pkm class to interface 
pk6/7/8, not pb7
 2020-07-31 17:25:14 -07:00
Kurt
b7211000b0 Split Country/Region/ConsoleRegion from ITrainerInfo 
Only present in mainline gen6/7 game pairs, so it's not wise to have it for all games
 2020-07-31 13:53:42 -07:00
Kurt
36684ab867 Minor clean 
Simplify some expressions
 2020-07-31 11:20:48 -07:00
Kurt
27f15d2f20 Split Country/Region/ConsoleRegion to interface 2020-07-31 11:17:31 -07:00
Kurt
a221a27074 Click version/battleversion -> dropdown combobox 
User error help
 2020-07-25 09:58:21 -07:00
Kurt
6bb2612059 Restart program on settings reset 2020-07-25 09:51:56 -07:00
Kurt
318016e9e5 Fix re-layout on grid refresh 
closes #2946
 2020-07-21 23:50:23 -05:00
Alberto Tudela
2bae3e09e0
Spanish minor fixes (#2947) 
Minor Folder list fixes
 2020-07-21 11:59:51 -05:00
Kurt
a6a3c6eaaa Refactoring 
change some expressions for better perf/readability
 2020-07-19 17:48:45 -05:00
Kurt
e4092e64df Relocate gen3 ereader berry logic 2020-07-18 22:51:55 -05:00
Kurt
851d77ed3a Show "NEW" for gen8 item edits 
why not
 2020-07-18 20:27:22 -05:00
Kurt
a21bb09c37 Perserve & Display Favorite flag for items 
Also clamp give all for TMs to 1 instead of whatever the giveall value is, like for prior games' HMs

reuse the "free space" bool; no real benefit in increasing the amount of abstraction (even though that's my current urge for legality)
 2020-07-18 20:15:41 -05:00
Kurt
65ecd3ca9a Sync missing change 2020-07-18 20:07:55 -05:00
Kurt
705822c965 Abstract some gen1/2 encounter types from their parent class 2020-07-18 15:36:30 -05:00
Kurt
5c7f992ea9 Update 20.07.18 2020-07-17 21:45:46 -05:00
Kurt
523edecf7b Get actual value rather than magic index 
logic doesn't really work for gen2/3, so gate it behind gen4+ format only
 2020-07-06 17:32:40 -05:00
Kurt
993673f0de Minor clean 
no functional change
 2020-06-27 23:36:53 -05:00
Kurt
a7ba178005 Remove unreachable/const logic 
Earlier compares result in some logic being unnecessary

The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)
 2020-06-27 22:44:14 -05:00
Kurt
0836d3191d Rewrite some magic gender value logic 
it's always been a byte for ratios, but we never know; plus, it's a little more self documenting
 2020-06-27 12:01:28 -05:00
kckxpyr1
38d9bf18c0
Update lang_zh.txt (#2906) 
This is more in line with the Chinese translation, I hope it can be modified
 2020-06-25 07:06:40 -05:00
Kurt
66a797371a add pokedex urshifu gmax translation strings 
copied localization from the other checkbox ;)
 2020-06-24 19:01:15 -05:00
Kurt
6574732380 Update 20.06.22 
Update wc8 binary with events from past month
 2020-06-21 23:06:52 -05:00
Kurt
6fb2ebe039 Minor clean 
add some xmldoc
 2020-06-21 19:46:06 -05:00
gjfkkk
6b506957c9
Update lang_zh.txt (#2876) 
* Update lang_zh.txt
 2020-06-21 09:33:44 -05:00
Kurt
b53a29a0af Add flag for urshifu-1 gmax pokedex 
ty @sora10pls
 2020-06-20 20:00:35 -05:00
Kurt
4f7845547e Minor clean 
Remove met location dynamic sizing for C/XD (already resized for SWSH)
add some xmldoc comments
rename some parameters
 2020-06-20 18:23:03 -05:00
Easy World
c0ee00cb7a
Update Chinese Localization (#2871) 
* Update LegalityCheckStrings_zh.txt

* Update lang_zh.txt
 2020-06-19 21:18:40 -05:00
XxPhoenix1996xX
0839882fda
Update Spanish Localization (#2870) 
* Update LegalityCheckStrings_es.txt

* Update lang_es.txt
 2020-06-19 20:53:21 -05:00
Kurt
e72a58bdee Dump latest translatable strings 2020-06-19 20:18:37 -05:00
Kurt
45a234814b Fix raid seed editing 
Because we pass in a reference to the raid block, rather than obtain the reference from the to-be-edited save file object (which was cloned), we need to restore the unmodified data to the save file instead of copying the modified save data.

Bad explanation, but we've edited the origin save data. Revert to original.
 2020-06-19 20:13:26 -05:00
Kurt
d6c5c6071d Hide armor raids when not available 2020-06-19 19:56:24 -05:00
Kurt
1c1e01bc1a Update 20.06.19 
Now with Isle of Armor support!
Closes #2867 , #2855
 2020-06-19 19:48:38 -05:00
Kurt
86a9711cc1 Show xor & tsv on gen3-5 
TSV/PSV was never abused during these gens, but whatever, show the raw details.
Closes #2868
 2020-06-19 18:59:00 -05:00
Kurt
36dd5ece21 Initial Isle of Armor support 
Co-Authored-By: sciresm <sciresm@users.noreply.github.com>
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
Co-Authored-By: Archit Date <architdate@gmail.com>
 2020-06-19 18:51:15 -05:00
Kurt
ce3f887a97 Handle dragdrop from zip (win explorer) 2020-06-16 21:53:24 -05:00
Kurt
2cdb5d26db Clean up some method signatures 
rename things to be a little more consistent in naming conventions
 2020-06-16 21:46:22 -05:00
Kurt
bfef634a1a Set shiny type regardless of format 
Don't loop if not required to loop
 2020-06-12 11:45:56 -07:00
Kurt
e338fce910 Minor simplification 2020-06-11 09:29:46 -07:00
XxPhoenix1996xX
2bd33dd7de
Update Spanish Translation (#2850) 
* Update MessageStrings_es.txt

* Update lang_es.txt
 2020-06-06 17:11:35 -07:00
Kurt
afa368823e Minor clean 
handle some compiler messages
 2020-05-26 16:59:47 -07:00
Kurt
4f039fe732 Remove duplicate icon 
only one icon file remains

make splash screen smaller since we don't have a 64x64 icon preview anymore (only 32x32 & smaller)
 2020-05-26 14:43:57 -07:00
Kurt
46b443903d Fix SM dex form fetch for spewpa 
Closes #2826

It doesn't find it in the SM table, but didn't return -1
rework logic flow to return when found, rather than after loop finishes.

Also fix display off-by-1 since we're not using zero indexing for our entry numbers.

Thanks @Ammako !
 2020-05-24 20:42:45 -07:00
Kurt
c4326698a5 Add prompt for loading new save with unsaved changes 
Closes #2823

remove old gen6 powersaves decrypted-xorpad strings (unused logic)
remove gen8 save fixing beta-pkhex-caused corruption (behaved for 6months)
 2020-05-24 11:03:23 -07:00
Matt
8c6d674472
Misc changes (#2838) 
Allow for up to 16 characters in SWSH Box Names.
Fix Rockruff-1 big sprite display.
 2020-05-21 16:19:25 -07:00
Kurt
6164884700 Merge IGeneration into IEncounterable 
all but egg exposed it; now, just make egg expose it and remove the unnecessary interface

we still need to Set generation for non-eggs/mgift, so have a separate Settable interface for internal purposes.
 2020-05-17 12:32:28 -07:00
Kurt
9f490a605e Rearrange order/anchoring for main tab 
allows expanding the window to show location names
Closes #2825
 2020-04-29 09:32:29 -07:00
Kurt
8c723b32ee Don't show/modify earned bp on RS saves 
Closes #2819
 2020-04-26 17:53:50 -07:00
Kurt
73045ba7a4 Hide fame time until selected 
Closes #2820
 2020-04-26 17:49:32 -07:00
Kurt
a8f967e935 Disallow scrolling in Trainer Stat/Record 
Unfinished text edits aren't pushed until after the combobox changes index
#2820
can't tell the numericupdown to finalize entry, even with a Focus() call to the combobox (to change focus from the numericupdown).
 2020-04-26 17:49:10 -07:00
Kurt
460062a07c add generic sav block editor 2020-04-26 16:23:06 -07:00
Kurt
8a0295e4e9 Minor clean 
GetLanguageIndex never returns <0
 2020-04-23 20:54:20 -07:00
Kurt
d6171669e4 Add swsh box wallpapers 
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
 2020-04-16 14:50:41 -07:00
Kurt
24edf7efe5 Improve detected savefile load speeds 
Don't discard the initially detected data just to re-load it from the path; keep a reference and load the reference.
 2020-04-16 13:15:35 -07:00
Kurt
b8814d2448 Split GG into LGPE (GP/GE), GG (LGPE||GO) 
Update usages
 2020-04-16 12:48:18 -07:00
Kurt
567b54b10f Update Main.cs 2020-04-14 11:50:33 -07:00
Kurt
546412e410 Rename class/method name 2020-04-14 10:59:16 -07:00
Kurt
ee1cfa8912 Hanle some compiler messages 2020-04-14 10:52:19 -07:00
Kurt
49e4fd396d Remove some unnecessary null checks 2020-04-14 10:08:56 -07:00
Kurt
f22b1c3e52 Update 20.04.14 2020-04-13 10:16:49 -07:00
Kurt
d398ad56d5 Update translations 
Not really much here, but that's all that's been added since last time.
 2020-04-13 09:55:21 -07:00
Kurt
bf47317dd1 Add setting to force large sprites for past gen 
Causes the Other tab (daycare/gts/fused) to look wonky (not scaled), but I'm ok with that being a known flaw for now.
 2020-04-13 09:52:25 -07:00
Kurt
33bdacebe8 Minor tweaks 
Handle some compiler/extension suggestions
 2020-04-12 16:07:59 -07:00
Kurt
e83f2a7dd0 Expand met location combobox 
stupid long met location names in SW/SH; doesn't really hurt.
Not gonna measure all string lengths and dynamically stretch it -- not worth.
 2020-04-12 13:26:35 -07:00
Kurt
0ada4cbd77 Remove some unnecessary null checks 2020-04-12 13:20:40 -07:00
Kurt
30d21e4532 Extract out showdown set interface 2020-04-12 13:05:29 -07:00
Kurt
270d984130 Minor clean 
Remove unnecessary null checks
Mark some methods with nullable type
 2020-04-04 19:30:50 -07:00
Kurt
80bedf2140 Add HomeTracker to list of hideable secrets 2020-03-21 10:56:15 -07:00
XxPhoenix1996xX
d66d761d3c
Update Spanish Translation (#2795) 
* Update lang_es.txt

* Create flags_gg_es.txt

* Update PKHeX.Core.csproj
 2020-03-20 11:42:58 -07:00
Kurt
5e32e9203e Add setting to apply nature to statnature on import 
Co-Authored-By: toim22 <toim22@users.noreply.github.com>

#2794
 2020-03-19 13:47:25 -07:00
Kermalis
5bdfd74862
Fix sav path after exporting to new name (#2791) 2020-03-18 22:15:34 -07:00
XxPhoenix1996xX
8a1405125e
Add Spanish Event Flags Translation / Update Spanish Translation (#2786) 2020-03-18 10:25:22 -07:00
Kurt
68324847bb Update PKMEditor.cs 2020-03-17 10:35:30 -07:00
Kurt
f1beef872f Reorder origin mark returns 
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
 2020-03-17 10:34:23 -07:00
Kurt
696bdf7cae Update 20.03.14 2020-03-14 14:58:36 -07:00
Kurt
a885f6b48f Clean up PID/EC auto-update 
Now loads & saves version-less data fine

Co-Authored-By: lusamine <lusamine@users.noreply.github.com>
 2020-03-13 19:56:53 -07:00
pi1024e
8a1e73e5b3
Change OT_Class to have an expression body (#2759) 2020-03-13 10:28:50 -07:00
Kurt
fbd533092d Fix misspelling of the word "Received" 
Closes #2757

Co-Authored-By: pi1024e <pi1024e@users.noreply.github.com>
 2020-03-12 15:05:34 -07:00
Kurt
dcb7336d92 Hide pika beach on !YW, add a few RS flags 
Closes #2745 , ty @FeralFalcon

hidden items are meh, items can be hacked in.

Co-Authored-By: feralfalcon <feralfalcon@users.noreply.github.com>
 2020-03-11 19:33:17 -07:00
Kurt
0aa6282d73 Sanity check value types via generic method 2020-03-11 16:31:53 -07:00
XxPhoenix1996xX
f6a157b2a1
Update lang_es.txt (#2755) 2020-03-07 20:44:58 -08:00
Kurt
4c226340fe Add shiny sprites, alcremie sprites & big sprites for all 
Keeping the 30x40 for now; might change my mind later.
Kept the gmax sprites but they're unused.
 2020-03-03 20:22:57 -08:00
Kurt
9b30bb8a2f Don't copy PID->EC if bad GenNumber 
Reading raw uncaptured data from RAM
 2020-02-29 10:55:30 -08:00
Kurt
d58426ebf5 Hide affection fields, remove setters for unused 
#2738
 2020-02-27 20:53:33 -08:00
qhq
8d413bb047
Update lang_zh.txt (#2729) 
SAV_Database.L_Version=OT Version: >来源版本:
SAV_Encounters.L_Version=OT Version: >来源版本:
SAV_Database.L_EVTraining=EV Training:>努力值:
 2020-02-20 19:26:51 -08:00
qhq
3d6fd82523
Update lang_zh.txt (#2727) 2020-02-19 22:05:54 -08:00
Easy World
4bfb57836a
Update lang_zh.txt (#2722) 
* AV means 覚醒値(Japanese), Awakening values(English), not the Species strength
* OT means おや(Japanese), Original Trainer(English), not the Trainer
* L_RHeightMin min means minimum not minute
 2020-02-19 06:59:35 -08:00
qhq
79b63b3af1
Update lang_zh.txt (#2718) 
* Update lang_zh.txt
 2020-02-17 20:22:21 -08:00
Kurt
66efbaf407 Add box manip for heal all slots 2020-02-17 19:28:20 -08:00
Kurt
620dd04064 Lock main window panel splitters 
Nobody needs to resize things; was leaving things open for a bit but no more...
 2020-02-16 20:27:24 -08:00
Kurt
fc9d0b4b24 Add hint for pkm with dummied moves 
Closes #2716
 2020-02-16 12:17:36 -08:00
Kurt
0ab63dd20f Update shortcuts.txt 2020-02-15 15:59:54 -08:00
CanoeHope
b7a3d278b2
Update shortcuts.txt (#2712) 
Very useful.
 2020-02-15 15:47:43 -08:00
Kurt
0d4cff81c6 Clean 2020-02-15 14:29:23 -08:00
Kurt
5c845a3875 Hide home tracker on non pk8 formats 2020-02-14 11:54:04 -08:00
Kurt
e8759ee538 Determine shiny as square if fateful && shiny 
regardless of xor value result
gotta make those shinies pop ;)
ty anubis
 2020-02-13 16:51:14 -08:00
Kurt
92b22b9f44
Fix HOME tracker value GUI character entry length 
Closes #2705 
It's recommended that you NOT set a "random" value here; instead, let HOME regenerate one for you.
Clearing it still functions properly.
 2020-02-13 10:52:19 -08:00
Kurt
ff23d094f0 Update 20.02.14 2020-02-13 08:44:07 -08:00
Kurt
6346444db7 Extract home tracker to interface 2020-02-12 18:52:48 -08:00
Kurt
a8a775b39c Move setting update location 2020-02-12 18:22:32 -08:00
Kurt
6ef2950cc4 Add toggleable flag setting for tracker, update translations 2020-02-12 18:14:23 -08:00
Kurt
e77fa205a0 Add tracker editor 2020-02-12 18:10:03 -08:00
ReignOfComputer
fbcbbc7b05
Batch Editor Alert Fix (#2703) 
Running a batch editor job in the same window pops the alert message in incrementing numbers until the window is closed.
 2020-02-12 09:58:46 -08:00
Kurt
8e9664ba6c Update database filters 
Allow if it can exist in SWSH
 2020-02-11 20:23:59 -08:00
Kurt
ebf20d927b More transfer implications 
Totems are downsized to regular
araquanid, togedemaru, and ribombee totems can't transfer (at the moment)
 2020-02-11 20:11:33 -08:00
Kurt
239b2f4b52 Fix entree randomization for encounters with no special move 
https://projectpokemon.org/home/forums/topic/56211-error-an-unhandled-exception-has-ocurred/

ty Pocket Monsters
 2020-02-08 20:56:16 -08:00
Kurt
fe092ce043 Update changelog.txt 
muh spell check
 2020-02-07 23:39:32 -08:00
Kurt
fb640505a5 Update 20.02.08 
No event gallery updates since last release :)
 2020-02-07 23:38:28 -08:00
Yurical
a4e579c49b
Update Korean translation (#2680) 2020-02-04 07:36:40 -08:00
Kurt
0e8ce7427a Move using to release build option 
am not using reflection for debug, gets rid of a warning
 2020-02-02 10:20:51 -08:00
Kurt
d260249b5e Apply met location before suggestion check 
Closes #2667
 2020-01-28 18:29:05 -08:00
Kurt
dd07126d83 Relocate level suggestions to EncounterSuggestion 2020-01-28 16:21:38 -08:00
Kurt
e40f739494 Update tab ordering 
Closes #2665
 2020-01-27 17:15:58 -08:00
Kurt
410fcee85b Sort sav sub-editors on load 2020-01-27 17:14:18 -08:00
matty
06522c2235 quality of life improvements on the mystery gift form (#2664) 
* delete received items with the delete key

mass selection of received items for mass deletion as well
improved index selection on deletion

* tab indexing for the form
 2020-01-26 11:19:58 -08:00
Kurt
1ba271db50 Fix block dump changing type on load 
Loading the window and assigning the datasource fired the index changed event, changing the first block (array) to the (selected index of type), which was bool1. Exporting the save caused a bad block type write, yielding a bad size.

Only add the event after the constructor is finished, so that it only fires via user interaction.

Similarly reported but not exactly noticed in #2658
Closes #2663

Gonna update the release with a hotfix
 2020-01-26 09:24:00 -08:00
Evan Dixon
4ef48a4e79 Add check for old PKHeX.Core.dll (#2662) 2020-01-26 08:55:13 -08:00
Kurt
a3e9649f09 Update 20.01.26 
Update with latest events from EventsGallery
 2020-01-26 00:35:31 -08:00
Kurt
c301ce88ab Update Random to be a bit more thread safe 
Random isn't thread safe; users of PKHeX.Core.dll might run multithreaded operations (see PKSM + ALM), so we need to have a thread-specific RNG available.

Thread Local get; to improve performance, save the random object locally whenever it is used more than once in the method.

https://docs.microsoft.com/en-us/dotnet/api/system.threading.threadlocal-1?redirectedfrom=MSDN&view=netframework-4.8
https://stackoverflow.com/questions/18333885/threadstatic-v-s-threadlocalt-is-generic-better-than-attribute/18337158#18337158
 2020-01-25 21:49:52 -08:00
Kurt
1520210e68 Revert overload usage 
yay core/framework enhancements
 2020-01-25 18:12:58 -08:00
Kurt
38759be662 Update gui translations with latest 
For dev update utility, move them to the new location in PKHeX.WinForms project
 2020-01-25 18:06:04 -08:00
Kurt
b5d48bc14f Split up portions of CommonEdits 
Cuts out about half the size; there's still a bunch of apply-value logic but it's not really big enough for a separate class.

Rename BallRandomizer->BallApplicator
 2020-01-25 16:47:44 -08:00
Kurt
88dcb59798 Extract language initialization to core 
Call this method whenever you boot a separate app that needs legality strings to be ready.
 2020-01-25 16:27:16 -08:00