Commit graph

30 commits

Author SHA1 Message Date
Kaphotics
01a1e61d2f Fix g3 ribboncount set 2016-07-23 23:18:23 -07:00
Kaphotics
945ac79b1f Misc gen3 fixes
Fix boolean get/set, fix met location, add gen3 egg gift location
2016-07-23 14:55:12 -07:00
Kaphotics
da1f7c7426 Add movepp tables for 3->6
Split from the PKX table (now removed); since PP differs between gens we
have to keep track. Not gonna add a separate binary, just use a
reference table.
2016-07-21 23:49:52 -07:00
Kaphotics
5293c30766 Continue glue removal
PersonalTable.RS exists, no need to have a hard coded ability table.
(re)moved some unnecessary stuff.
2016-07-21 23:20:10 -07:00
Kaphotics
1bceb99306 Fix gen3 ability setting
main form wouldn't set back properly, simplify loading,
fix pk4->pk4
disassociate from PKX.Gen3Abilities (to be deleted now that
PersonalTable.RS exists).
2016-07-21 23:13:58 -07:00
Kaphotics
6029913b55 Move stat calc to PKM object
ref PersonalInfo entry to calculate from

Fixes species with changed BST between gens.
Worked fine before PKX Personal was split from SAV (to fix box report),
this fixes by requiring the actual personal reference instead of looking
it up.
2016-07-20 20:40:03 -07:00
Kaphotics
985a3eec23 Update getGenderIsValid
never used, just copy the gen3/4 implementation with the earlier return
2016-07-18 23:31:09 -07:00
Kaphotics
027feebe77 Add gen3 met locations to Report view
Remove unnecessary pkx function
2016-07-18 23:28:36 -07:00
Kaphotics
02a208a74d Break PKX-SAV personaltable relationship
Opening Database and having a species in the results with species#
greater than the current loaded save file's allowed (ie volcanion in db
with loaded emerald) causes Report to throw errors when opened from
Database.
2016-07-18 23:28:10 -07:00
Tyler Dunn
de8cebf2a4 Use Direct Casts and Conditional Access to Avoid NPEs 2016-07-18 14:51:26 -04:00
Kaphotics
016a0e3aee Reduce reliance on PKX
Certain calculations are best done with direct references.
Indirectly fixed Shiny button bug (8 <= xor < 16) for past gen games.
2016-07-17 23:40:40 -07:00
Kaphotics
f981621452 Simplify ability / entry retrieval 2016-07-17 23:04:39 -07:00
Kaphotics
f5bacf236c Add&Split out PersonalTable
Will eventually have more complex operations associated with it, as the
PersonalInfo[] could not do that sort of logic.
2016-07-17 22:39:18 -07:00
Kaphotics
07e4483ef7 Prefix marking property name
Alphabetically sorting properties now has them grouped together (for
batch editor).
2016-07-17 17:07:53 -07:00
Kaphotics
d6d2503051 Fix marking setters
Markings[x] didn't prompt the MarkByte to update, just force each bit
manually like ribbons.
2016-07-17 17:05:26 -07:00
Tyler Dunn
641f1f61f6 Additional Code Style Fixes 2016-07-17 13:09:01 -04:00
Kaphotics
3fb86f6dc5 Update ribbons
Added all gen3-6 ribbons.

Fixed bugs:
* Increased speed that the subform pops up (yay profiling!) --
TableLayoutPanel would be reconfigured on every row added; adding a lot
of rows constantly reconfigures, so disable the layout updates so that
it only procs at the end.
* Cleaned up display of the ribbons, fixed width (40x40) instead of
autosize. Now display 3 per row.
* Now display the golden "complete" ribbon for g6 memory ribbons.
2016-07-16 19:59:53 -07:00
Kaphotics
ba74b043e2 Fateful Encounter fix
Met location of 0xFF for pkm without an 'obedience' flag.
2016-07-16 17:59:04 -07:00
Kaphotics
b47b26222f More descriptive pkm properties (ribbon/training)
Adding new update for editors
2016-07-16 15:52:33 -07:00
Kaphotics
0a8dc20de1 Add gen3 items list
english only
2016-07-08 18:38:40 -07:00
Kaphotics
e21037c57e Change converter country
31 should have been 0x31 == 49 (USA).

Ha.
2016-07-04 16:11:03 -07:00
Kaphotics
1e2ef19d9a Tweak detection of pk6 party file 2016-07-03 18:27:12 -07:00
Kaphotics
1779420af1 Add gen3 personal info, move object refs
All PersonalInfo arrays are referenced from PersonalInfo's class instead
of Legal

Fixed a few bugs in the process (species translation, gen switch)
2016-07-03 15:05:15 -07:00
Kaphotics
54bc0b320d Add PersonalInfo for gens4/5
Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.
2016-07-02 20:24:17 -07:00
Kaphotics
08ccec7a07 Fix pk3 sprite helditem fetch
g3item is raw value (gen 3 index), HeldItem returns the equivalent gen4
item.

In the future the populatefields(PK3) method will use the gen3 index
(list needs to be init first) but the display is always the helditem.
2016-06-30 18:10:09 -07:00
Kaphotics
8e62803897 Tweak savefile enumeration
Use one enum to denote Version across all code, also identifies if data
is invalid
Move some SAV code to virtual members in abstract class
(BAK/Exportable/Footer)

Few minor bugfixes here and there (hiding Characteristic label, loading
pk6 to sav3, sav3 version detection via gamecode)
2016-06-27 23:03:57 -07:00
Kaphotics
92b357c660 Simplify hidden power calc
Calculate inline
2016-06-27 22:26:39 -07:00
Kaphotics
6ddaa036d4 Update database to load formats correctly 2016-06-27 22:20:31 -07:00
Kaphotics
e6e3caabb2 Sync basic gen3 support
Still many things not yet working (item/inventory editing needs new
string resources)
2016-06-26 14:23:41 -07:00
Kaphotics
6378eb7f56 Current progress
Still a few milestones left to hit before official release.
2016-06-19 21:22:43 -07:00