122 commits

Author	SHA1	Message	Date
Kurt	279c9d4665	Fix tradeback detect for gen2->1->2 evolve case ... https://projectpokemon.org/home/forums/topic/46909-certain-gen-i-moves-are-showing-invalid/ Thanks Raptor385!	2018-08-04 13:36:05 -07:00
Kurt	19a897923d	Reference original encounter for sensitive checks ... https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=234360 thanks paf!	2018-08-01 20:39:20 -07:00
Kurt	3d0a2946eb	Allow only one movepool for BW-B2W2 source ... they're both the same, but bw's pool does not have b2w2 formes Closes #2078	2018-07-26 21:51:11 -07:00
Kurt	4b0c3f6aec	Update shuckle pkm	2018-07-26 15:11:45 -07:00
Kurt	75801e22e0	Update egg location -> encounter generating checks ... WasEgg only checks for EncounterEgg valid locations; check for any value instead.	2018-07-26 14:55:49 -07:00
Kurt	9a91619580	Update vc1 invalid transfer pruning ... Closes #2065 Thanks @WEERSOQUEER ! Single evo species weren't getting flagged in the evolution verification as they early returned (species matched), just move the sanity check before that	2018-07-19 16:42:45 -07:00
Kurt	e4aa16f396	Fill out gen5 hidden ability banlist ... now flags gen5 contrary serperior ;)	2018-07-16 21:53:46 -07:00
Kurt	f211f03eaa	Add test case ... #2062 Thanks @PrometheusG !	2018-07-16 16:18:55 -07:00
Kurt	7ec1cab9a7	Update gen1/2 trade generator to emit gen1 if match ... Closes #2060	2018-07-16 15:22:40 -07:00
Kurt	8e950e83b3	Rewrite ability verification ... Closes #2040 , adds test cases: invalid bulbasaur.wc3: hidden ability invalid charmander.pcd: hidden ability valid camerupt: gen3->4 unevolved mismatch valid leafeon: pcd mismatch -> evolved now matching should be much easier to maintain; methods are reused with less overall nesting	2018-07-02 20:34:41 -07:00
Kurt	09c96558ea	Disable gen2 chain clamp ... not sure of the implications, but fixes #2031 might have to rework this method to clean up the optional params if things are misbehaving	2018-06-24 08:02:22 -07:00
Kurt	7a0b65e74f	Add low bound range check for species not in chain ... Closes #2028 Thanks @iiippppk !	2018-06-23 08:23:05 -07:00
Kurt	5dd58c7197	Update gen1 evo chain detect ... Closes #2017	2018-06-22 22:48:10 -07:00
Kurt	8387da64fb	Disallow East Gastrodon friendsafari ... Closes #2023	2018-06-21 20:22:14 -07:00
Kurt	1db41c8b21	Add vc2 evo chain check ... queue should be checking against none left rather than any left. Add test cases	2018-06-20 21:43:54 -07:00
Kurt	c3cbb0fc44	Fix gen2 vc1 evo prune ... https://github.com/kwsch/PKHeX/issues/1999#issuecomment-397818377 evo chain had already pruned tyrogue due to level 20 transfer level (lvl19 tyrogue not possible), can't just remove last entry. Remove any entry after the g1 species.	2018-06-16 09:06:12 -07:00
Kurt	b0b2fb5d4b	ShowdownSet parse refactoring ... Rework line parse to be simpler Closes #2009 , now handles case	2018-06-15 20:30:23 -07:00
Kurt	49c36e2173	Misc legality gen tweaks ... bypass savefile language checks if no language set fix gen2 static gift egg that is really a wild encounter -- egg flag was set & not cleared -> no wild pkm, bad! Adds test case for this. (probably isn't a better place to clear, enforces only once per generation rather than on every yield/end of every static yield)	2018-06-15 18:47:17 -07:00
Kurt	b9652a835d	Weaken gen2 egg species checks for pre-evos in gen1 ... VC can inhabit both gens Add Tradeback setting setter for legality tests Add GBCartEra setting setter for legality tests Thanks @iiippppk !	2018-06-12 18:46:31 -07:00
Kurt	242fc295b4	Handle smeargle egg case ... #1993 Just use precomputed array since it can only know sketch	2018-06-11 08:03:10 -07:00
Kurt	ca9f21fa49	Fix base move count vs inherit check ... Closes #1990 Thanks @iiippppk !	2018-06-10 20:26:59 -07:00
Kurt	c9d0811281	Handle evolutions-in-eggs case for past gen (2/3) ... Closes #1989 Thanks @iiippppk ! (eggs don't always come at level 1, past gen has level 5)	2018-06-10 19:38:06 -07:00
Kurt	c9181963f2	handle pichu array->interface when adding egg list ... egg fetch returns array, need to add to the collection force everything as readonly to prevent adds outside of the constructor Closes #1988 Thanks @iiippppk !	2018-06-10 19:07:55 -07:00
Kurt	3b84f33776	Misc changes ... Revert linq chain Closes #1987 change encountermatch comparison (never null), add comparison for vc output remove unused strings (will get removed from translation files in later update)	2018-06-10 00:26:33 -07:00
Kurt	f351e9550f	Add contest stat check for VC ... https://projectpokemon.org/home/forums/topic/45681-virtual-console-pkm-with-beauty-stats-marked-as-legal/ Thanks yologgebolo!	2018-06-09 08:39:16 -07:00
Kurt	b5962d6b50	Emit final showdownset from lines if present ... Closes #1986 , was missing a check if there were any lines in the list. Calling the method with an empty line set would have yielded an empty set (behavior unknown). Although calling the method without lines is unintended, should handle behavior correctly now. Fix yielding an empty set if the first line(s) are empty. Add test to verify parsing works for multiple lines. Add test to verify parsing yields nothing for no lines. Add test to verify parsing yields nothing for empty lines.	2018-06-09 08:12:47 -07:00
Kurt	1202474cd5	Defer & flag VC korean unobtainable encounters ... Closes #1985	2018-06-06 21:49:30 -07:00
Kurt	dcdeb361f0	Handle meowstic formes ... Closes #1984	2018-06-06 16:22:14 -07:00
Kurt	ab393e1f99	Rework set PID-ability checks ... Closes #1979, adds test cases.	2018-06-02 13:22:52 -07:00
Kurt	15b5de11c0	Handle hatched wc3 metlevel oddballs ... Closes #1978 Met Level at 5, when hatched ingame is reset to 0.	2018-06-02 07:50:48 -07:00
Kurt	e82dcdb124	update memory captured check ... gen5 landorus witnessing another species should use gen6 https://projectpokemon.org/home/forums/topic/45424-landorus-memory-flagged-as-illegal/	2018-05-30 21:50:11 -07:00
Kurt	c31ab63a1a	Initialize mgdb for tests that need it initialized ... don't initialize multiple times	2018-05-27 15:57:28 -07:00
Kurt	a57cdb5f48	Update fateful handling ... #1970 add files as test cases	2018-05-27 14:38:03 -07:00
Kurt	e6765d3691	Flag langid=0 when appropriate ... only jpn bw ingame trades can lack a languageID. skip language checks for pk1/pk2 as they have no language stored.	2018-05-26 14:40:02 -07:00
Kurt	c103220e0c	Handle gen3->4->5 levelup evochain pruning ... Gen7 weavile can exist in gen4 as sneasel; existing code had pruned it from gen4. Skip pruning for this case probably overdid the checks but whatever. works. Thanks /u/ThrowawayReddNinja for pointing out this false flagged case with an example!	2018-05-20 10:35:58 -07:00
Kurt	407cca38dd	Update generator to handle link celebi ... Had relearnmoves defined but no current moves; better for generator to spit out all moves rather than the special move (hold back) store current moves for all link gifts	2018-05-20 09:06:32 -07:00
Kurt	cd3b24c122	Handle smeargle generating ... Needed moves is essentially none (unless you have invalid sketch moves).	2018-05-20 08:19:03 -07:00
Kurt	e216c38151	Misc updates ... Add GetShowdownSets text output methods Add party/box overload methods for easier slot setting api Protect locked slots when importing BoxData Misc saveditor simplifications Add wc3->pk3 test	2018-05-19 20:48:03 -07:00
Kurt	5a3c8f4147	Remove trailing whitespace	2018-05-12 08:41:29 -07:00
Kurt	9c5814346b	Add showdownset parse case template test	2018-05-11 21:44:09 -07:00
Kurt	9f8e86b2b5	Finish rough generator ... * handle gen6+ egg case where egg move count < 4 (cannot displace Levelup lvl1 moves) * handle minior altform case generates all species/encounters possible, yielding 144,094 pkm files (all detected as legal!)	2018-05-09 19:21:44 -07:00
Kurt	734edfae20	Remove cutecharm swarm restriction ... only affects species (can't force gender on a fixed gender swarm slot) https://github.com/kwsch/PKHeX/pull/1314 https://projectpokemon.org/home/forums/topic/45153-bug-cute-charm-swarming-illegal/ Add swarm cutecharm test cases from thread, thanks @PP-theSLAYER !	2018-05-07 16:14:31 -07:00
Kurt	e91cb806e5	Extract extension->prefer format method ... fails for 'pkx' (returned 8 instead of 6); establish standard behavior	2018-04-21 14:38:18 -07:00
Kurt	8250bc58cd	Fix levelup->evo fetching of next levelup move ... Correctly fixes #1163 (test cases added), eg wooper->quagsire would learn yawn at 31 before evolving; the getmoves wouldn't provide yawn (stopped at 30) with the old code; the lvl decrement was removed in the incorrect commit, providing a legal verdict which was obtained incorrectly (dexlevels were inaccurate)	2018-04-17 19:49:33 -07:00
Kurt	78f533605c	Handle untranslated Italian LeafGreen Jynx trade ... lul nice translating team u got there, would be a shame if they forget to translate something ;) /s Thanks cicciochiave!	2018-04-12 21:22:04 -07:00
Kurt	b3b9713aa2	Switch assert comparison ... AreEqual checking by Reference? strip out newlines and compare with string equals instead add testing method for generating full dex of pkm (still WIP hence commented out attributes)	2018-04-03 19:34:24 -07:00
Kurt	867c705597	Fix broken gen2 tests ... add oddish to the mix	2018-04-01 15:51:55 -07:00
Kurt	ba4c911566	Refactoring & finish eevee test case ... generates a legal pk* for every possible encounter; there's likely other scenarios and more roughness to smooth out, but seems legit for now	2018-03-31 20:37:36 -07:00
Kurt	d03ff147d4	Add template -> pkm method ... fix signature if no versions are provided (empty params is [0], not null)	2018-03-29 21:04:05 -07:00
Kurt	e74e7878cd	Lower dragonair encounter level req for trade ... https://projectpokemon.org/home/forums/topic/44555-gen2-legality-issue-with-in-game-trade/ Thanks Bumidek !	2018-03-29 08:50:23 -07:00