Commit graph

80 commits

Author SHA1 Message Date
Kurt
50b15cd740 Use range/index
More in line with modernizing the codebase with latest c# syntax

improve web-qr decode speed slightly (no linq skiptake)
get money/coin mask without a temporary string (lol performance)
2021-05-14 15:30:55 -07:00
Kurt
aaa69eac15 Rename Gen3 Champ ribbon to be more accurate
been like this since mid 2016

this ribbon can be obtained in either Hoenn or Kanto within Gen3
https://bulbapedia.bulbagarden.net/wiki/List_of_Ribbons_in_the_games#League_Ribbons
2021-04-10 12:09:43 -07:00
Kurt
b3b60894b6 Remove 40x30 sprite assets
Farewell; let's assume things are 68x56 from now on.
2021-04-09 16:24:19 -07:00
sora10pls
3784ab39fc Update Shiny Ho-Oh sprite 2021-03-24 10:55:31 -04:00
Kurt
b5c30193fa Set initial capacity for stringbuilder to reduce reallocation
Default capacity is 16 so it's rarely an issue, but sometimes we don't need that much.

Update xmldoc for more clarity
2021-01-16 17:31:05 -08:00
Kurt
09089da14e Use more expression return style
Reduces indentation & bracketing, a bit more concise
2021-01-01 17:08:49 -08:00
Kurt
e8c23f6644 Simplify some repeated comparisons with expressions
Less prone for bugs since it uses the same value for all comparisons without re-specifying
2020-12-29 00:37:59 -08:00
Kurt
cce4d80419 Update nuget packages 2020-12-26 09:28:00 -08:00
Kurt
4a8a495d04 Condense some switch expressions
Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 10:58:33 -08:00
sora10pls
c5d59d392e Update SWSH Box Wallpapers
It turns out that Pokémon HOME has pre-colored Box Wallpaper patterns in its assets... for some reason?
These new tiled wallpapers have much more vivid colors, which look a lot nicer now.
2020-12-23 14:24:31 -05:00
Kurt
997e0751f3 Minor clean
Handle remainder of c#9 sugar
Fix some spelling mistakes
2020-12-21 23:37:07 -08:00
Kurt
514b60b447 Merge type check with usage in if statements
if x is y with z property true, then :D
2020-12-21 22:33:48 -08:00
Kurt
63aa8dcd43 Bump langver to 9 for other subprojects 2020-12-21 19:12:24 -08:00
Kurt
6d030831ab Bump PKHeX.Core to C#9 language version
Add FrameworkUtil.cs which is compiled if the build isn't net5+, needed to support init setters & records
2020-12-21 16:52:11 -08:00
Kurt
62018cce1a Unify concepts with different names
AltForm & Form & Forme => Form
GenNumber & Generation => Generation

Extract out SpeciesForm interface, and re-add IGeneration

For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-10 20:42:30 -08:00
Kurt
05a3753404 Fix 40x30 cosplay sprite fetch
Closes #3102

#2966
2020-12-05 06:29:28 -08:00
Kurt
c1ae32ba8b Use more efficient string append 2020-12-05 06:06:22 -08:00
Kurt
9b178fefe2 Xmldoc, minor tweaks
Move form-info logic from FormConverter to AltFormInfo; now FormConverter is entirely form=>string[]
Add a bunch of xmldoc
Make pogo no-end-date cmp agaisnt UTCnow rather than local now.
2020-11-27 11:51:02 -08:00
sora10pls
8e8fa233ae Update Shiny Galarian Articuno sprite
As per 0253884c50
2020-11-23 16:21:04 -05:00
sora10pls
dea6c57dc1 Add Shiny Sprites for Crown Tundra
Many thanks to @msikma for these sprites!
2020-11-20 12:13:06 -05:00
Kurt
81110b4231 Upgrade netcore build to NET 5.0
keep with the times, kids

handle some compiler messages
2020-11-14 08:20:48 -08:00
Kurt
80a5d8e451 Remove layer null check
Move to the place that triggered the null
2020-10-30 19:56:16 -07:00
Kurt
215536a0cb Update Sprites for Crown Tundra
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2020-10-24 10:47:21 -07:00
Kurt
61dc9a45ae Revise Shadow state detection
Closes #3012
2020-10-06 22:36:27 -07:00
Kurt
2b7e06e217 Refactoring
Extract some logic, suppress some compiler messages
2020-09-18 22:11:13 -07:00
Kurt
407c986c89 Update netcore target from 3.0 to 3.1
.NET 5 is in 2 months, might as well bump things to the current LTS
2020-09-09 18:27:12 -07:00
Kurt
5d3bc289b6 seal hunting
Mark things as sealed as they shouldn't be inherited from or overriden in a derived class.
2020-09-07 13:51:13 -07:00
Kurt
c2ec4d55e4 Minor clean
Add some xmldoc, remove some empty lines, move some small logic pieces to a better spot
2020-09-03 14:28:51 -07:00
Matt
1d0ca29e8c
Misc changes (#2969)
Adjust EggItemShift to account for using the big Egg sprite
Add Marowak to non-transferrable Totems (none of the USUM Totems can be transferred to SWSH)
2020-08-14 13:56:37 -07:00
Matt
3d4f8432cc
Misc big sprite fixes/additions (#2966)
* Misc big sprite fixes/additions
Add big Manaphy Egg sprite, do some renaming to fix Cosplay Pikachu, and fix Egg overlay (no more floating Egg in the top-left!)

* Show Cosplay sprite regardless of Gender
2020-08-10 18:33:44 -07:00
Matt
d8630b7cee
Update Female Pikachu sprite transparency (#2940) 2020-07-12 21:09:36 -05:00
Matt
b2935eefc5
Add Isle of Armor Shiny Sprites (#2933)
Also update with latest pokesprite changes for Pikachu, Castform, Minior, and Marshadow. 40x30 sprites unchanged since they'll be gone eventually.
Many thanks to @msikma for the provided sprite work!
2020-07-09 18:10:11 -05:00
Kurt
993673f0de Minor clean
no functional change
2020-06-27 23:36:53 -05:00
Kurt
36dd5ece21 Initial Isle of Armor support
Co-Authored-By: sciresm <sciresm@users.noreply.github.com>
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
Co-Authored-By: Archit Date <architdate@gmail.com>
2020-06-19 18:51:15 -05:00
Kurt
2cdb5d26db Clean up some method signatures
rename things to be a little more consistent in naming conventions
2020-06-16 21:46:22 -05:00
Kurt
5eb98594cb Add shadow lugia to big sprites, expand canvas
Closes #2849
2020-06-03 10:38:00 -07:00
Kurt
afa368823e Minor clean
handle some compiler messages
2020-05-26 16:59:47 -07:00
Matt
8c6d674472
Misc changes (#2838)
Allow for up to 16 characters in SWSH Box Names.
Fix Rockruff-1 big sprite display.
2020-05-21 16:19:25 -07:00
Matt
068f6e2f5f
Fix Big Sprite ItemShiftY (#2816)
Strange Souvenir and Room Service would get cut off since they're tall.
Also remove Adventure Guide from resources, and add Discount Coupon to Gen 7 unreleased items.
2020-04-25 11:05:12 -07:00
Kurt
b481652c03 Add 666-meadow
Closes #2815
2020-04-24 16:57:40 -07:00
Matt
c5c8615eb0
Finalize Past-Gen Item Sprites (#2811)
Add in some missing Items, remove non-hold Items, and fix outlines on various Z-Crystals
2020-04-16 19:36:43 -07:00
Kurt
9a2d109749 Misc sprite swap/clean
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-04-16 17:35:28 -07:00
Kurt
8d01b81351 Add past-gen held items 2020-04-16 16:32:20 -07:00
Kurt
46b8e6427a Add big unknown held item sprite
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-04-16 15:14:36 -07:00
Kurt
e9f0552152 Update BoxWallpaper.cs 2020-04-16 15:07:04 -07:00
Kurt
d6171669e4 Add swsh box wallpapers
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-04-16 14:50:41 -07:00
Kurt
bf47317dd1 Add setting to force large sprites for past gen
Causes the Other tab (daycare/gts/fused) to look wonky (not scaled), but I'm ok with that being a known flaw for now.
2020-04-13 09:52:25 -07:00
Kurt
dab57be918 Update ImageUtil.cs 2020-04-11 23:11:22 -07:00
Kurt
775e8a61d4 Remove unused method 2020-04-09 23:03:12 -07:00
Matt
6f39f25189
Misc changes (#2806)
Add small Female Hippopotas/Hippowdon sprites (Closes #2789)
Add Pt Togepi Gift Egg Event Constant (Closes #2801)
Remove Pokémon Den from Egg Locations (Closes #2804)
Fix Shiny Dhelmise sprite (as per 3774e0dd34)
2020-04-04 17:10:41 -07:00