Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-14 16:27:21 +00:00
Code Issues Projects Releases Packages Wiki Activity
4964 commits 3 branches 76 tags 106 MiB
Commit graph

1433 commits

Author SHA1 Message Date
Kurt
1ff8ebf777 Misc overload add/use 
Some values are already computed; pass them in to overloads for quicker
execution
 2018-07-19 19:38:44 -07:00
Kurt
614d2629ce Remove unnecessary ref passing 
object is already passed byref, don't need to repoint the reference
 2018-07-19 18:09:37 -07:00
Kurt
9a91619580 Update vc1 invalid transfer pruning 
Closes #2065 Thanks @WEERSOQUEER !

Single evo species weren't getting flagged in the evolution verification
as they early returned (species matched), just move the sanity check
before that
 2018-07-19 16:42:45 -07:00
Kurt
69e7d49d03 Simplify Stadium OT Check 
TID is always 2000 : #2065
 2018-07-19 15:54:34 -07:00
Kurt
ff4ca47ebe Remove GBEncounterData boxing 
Interfaces implement enough detail, so can simplify
extract local methods (likely will be inlined)

less obj allocations = faster!
 2018-07-18 16:37:21 -07:00
Kurt
1c75093e27 Specify altform for ranch shellos 
1 not 0

https://projectpokemon.org/home/files/file/336-shellos/?do=findComment&comment=1290&tab=comments
 2018-07-18 07:15:46 -07:00
Kurt
01c4ca348f Allow FolderList to be translated 2018-07-17 21:02:01 -07:00
Kurt
a100488142 add gen12 generator kadabra catch rate case 
https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/

Thanks Cloud AC !

update misc verifier for catchrate to better indicate for
any->nontradeback scenarios
 2018-07-17 16:54:23 -07:00
Kurt
fe7fea877b Replace boolean OrderBy with DeferBy 
orderby consumes the entire input enumerable in 'sorting' the list;
since we don't care about the order besides a yes/no, just manage the
yield order ourselves.

don't bother using this method more than the spot it's in; was a fun
exercise but other spots are set up for easier debugging
(overall flow is where->deferby->yield), could make things easier to
read but meh
 2018-07-17 16:28:42 -07:00
Kurt
e4aa16f396 Fill out gen5 hidden ability banlist 
now flags gen5 contrary serperior ;)
 2018-07-16 21:53:46 -07:00
Kurt
99c790a4b0 Update File name/path/folder fields 
original file path is not saved with the two listed properties, add
FileFolder and relcoate existing FilePath functions to that field

move some GetVariantSAV usages to the string method instead of byte[]
 2018-07-16 21:00:43 -07:00
Kurt
bdb5aaee36 Ignore mismatch if explicitly permitted by prior check 
Closes #2062
 2018-07-16 16:12:19 -07:00
Kurt
7ec1cab9a7 Update gen1/2 trade generator to emit gen1 if match 
Closes #2060
 2018-07-16 15:22:40 -07:00
Kurt
f51ac7d1f3 Update translations 
Internal repositioning to match source
(auto generated changes)
 2018-07-16 15:12:40 -07:00
kang1806
afca1b8145 Update MessageStrings_zh.txt (#2063) 2018-07-16 15:09:01 -07:00
Kurt
9a1695f319 Update 18.07.16 
Update event binaries with latest from the Event Gallery
 2018-07-15 21:44:50 -07:00
Kurt
a81c28f114 Upgrade FolderList to show recent/backups 
sortable grid like the ReportGrid for pkm, can open/browse individual
files
 2018-07-15 17:48:31 -07:00
Kurt
99673706a0 Rework recent savefile detection 
return a reference to the savefile rather than the path, since a
SaveFile has a FilePath property.
 2018-07-15 13:35:58 -07:00
Kurt
cc509de83c Add lgpe properties 2018-07-14 21:55:45 -07:00
Kurt
0f17445ef4 Update gen3 event pidiv method check for eggs 
closes #2057
Thanks @kamronbatman !

(nothing currently implemented uses BACD_U_S)
 2018-07-14 20:19:13 -07:00
Kurt
cb80c02011 Check Yellow catchrates when updating species 
https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/
 2018-07-14 18:08:51 -07:00
Kurt
d2eba35504 Update interface parameter names 
sync to previous
 2018-07-14 18:08:30 -07:00
Kurt
6c8374f26f Extract inner sprite building to class 
any romhack maker can replace the behavior with their own builder
 2018-07-14 17:53:37 -07:00
Kurt
6b7ba49cba Remove unnecessary logic 
gamestrings: call but not value used
text.cs: use gamestrings method for auto-filtered, now removes korean in
Gen3 context
 2018-07-14 16:53:14 -07:00
Kurt
8c2b74c149 Refactoring 
max IVs use flawless method directly with 6 IVs specified
move color blend/stat calc to ImageUtil
move potential string to commonedits
expose color properties for pkmeditor
don't constantly create/dispose brushes for drawing legal moves
 2018-07-14 15:08:14 -07:00
Kurt
baac632218 Enable editing gen1/2 hidden power type 2018-07-14 10:56:11 -07:00
Kurt
625a77589b Extract geolocation logic to interface 
mixins would be nice but I guess extensions cover this
 2018-07-14 10:34:34 -07:00
Kurt
7d1994dc8a Add xmldoc for public members 2018-07-14 09:55:22 -07:00
Kurt
b039112a1d Add gen1/2 hidden power setter calc 2018-07-13 20:30:57 -07:00
Kurt
5d20c79568 Add showdownset localization for slot previews 
Localization only for game strings (not Ability/Nature/Stat/etc labels)
feels kinda goofy but it works
 2018-07-13 19:13:25 -07:00
Kurt
83e61923f7 Add bw/2 jellicent deferral case 
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?tab=comments#comment-233860

Thanks paf!
 2018-07-13 13:48:27 -07:00
XxPhoenix1996xX
9f2712cf4d Update text_Mail4_es.txt (#2056) 2018-07-13 08:40:18 -07:00
Kurt
ebed1026cd Update national dex magic setting 
bulbapedia is wrong, first 4 bytes are info values:

0x0 = dex order (alphabetical, numerical), unused in frlg
0x1 = mode (unused in frlg), regional vs national
0x2 = national magic rse (always set in frlg)
0x3 = national magic frlg (never set in rse)

refer to disassembly (pokefirered isn't too helpful, less developed.
just compare save files & edit ram!)
the other 2 values being set are the eventflag & event const, could use
the abstraction for those rather than direct ofs writes
 2018-07-12 23:23:36 -07:00
Kurt
d42cc7cacd Add spinda/unown PID properties 2018-07-12 22:07:44 -07:00
Kurt
98a1677d14 Fix property reference 
oops
 2018-07-12 20:36:59 -07:00
Kurt
ea5a981f4a Add Hidden Power type calculation for pk1/pk2 
Use format specific for import, with format guess to the current
savefile known to pkmconverter.
 2018-07-12 18:16:24 -07:00
Kurt
296d1c20ed Use ITrainerInfo interface for trdata 2018-07-12 18:15:20 -07:00
Kurt
3da4873f94 Bounds check species ID for negative 
certain downstream consumers of the library be doin silly things
 2018-07-12 17:09:39 -07:00
Kurt
04765ef411 Add more xmldoc 
Covers all gameversion enum members (whew)
 2018-07-12 16:55:24 -07:00
Kurt
d20706dd70 Update xmldoc 
le lenny goes here
 2018-07-11 19:19:19 -07:00
Kurt
e4e5018aa7 Extract some methods 2018-07-11 19:13:09 -07:00
Kurt
6816c2de43 Update OT affection check for 3-5 memories 
https://projectpokemon.org/home/forums/topic/46180-oras-transfered-pokemon-invalid-ribbon/
Thanks piplupwater!

(there's no other usages of V129)
 2018-07-11 17:43:48 -07:00
Kurt
8a83b9bde8 Update manaphy ability check again 
57250823a8
covered it for format>=6, in 4/5 the abilitynumber is derived from
PIDAbility
Closes #2052
 2018-07-10 21:30:13 -07:00
Kurt
01323c0ee8 Add id7 setters 
can now set TrainerID7 / TrainerSID7 via batch editor
 2018-07-10 21:25:03 -07:00
Kurt
7f31fdf874 Simplify string trim 
RemoveRange instead of while {remove last}
 2018-07-10 17:54:05 -07:00
Kurt
f8c43d4a06 Rework gen1 trade OT handling 
convert all dictionaries to char-byte instead of string (saves 50KB on
compressed dll, lul)
update OT string comparison for pre/post transfer specimens

Showing "TRAINER" for all languages isn't correct, just show a mapped
character

Closes #2049 , thanks @egzonqj & @WEERSOQUEER !
 2018-07-10 16:45:24 -07:00
Kurt
027d898f3d Update Yancy Curtis trade OT checks 
Thanks paf!
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/
 2018-07-10 12:37:40 -07:00
Kurt
c8897161b7 Fix gen6 evo tree resize miss 
https://projectpokemon.org/home/forums/topic/46144-a-couple-of-new-problems-in-the-pkhex-version/

Thanks CreamatedReptile2018 !
 2018-07-09 22:51:01 -07:00
Kurt
93876d98eb Fix CanInhabitGen1 comparison 
extracted and forgot to double check the boolean comparison when
inverting the return value

https://projectpokemon.org/home/forums/topic/46148-bug-gen-1-moves-and-legendaries-incorrectly-flagged-in-gen-2-game/

Thanks Raptor385!
 2018-07-09 21:59:38 -07:00
Kurt
d45a8afef2 Remove erroneous chain trim logic 
latter half of the method seems to do everything that is required

Closes #2048
 2018-07-09 21:26:45 -07:00