Kurt
27eb68335b
Update learn handling for side-game wiped movesets
2022-09-10 12:02:15 -07:00
Kurt
0a88cdc32e
Update Encounters8.cs
2022-09-10 01:13:34 -07:00
Kurt
c611bba9b5
Update WA8.cs
2022-09-08 23:11:58 -07:00
sora10pls
39ccb50580
Add latest distribution raid data
2022-09-08 20:04:39 -04:00
Lusamine
f79560b8a2
Add Continental Vivillon pattern to Nagasaki, Japan for 3DS
...
Updated earlier this year:
https://docs.google.com/spreadsheets/d/e/2PACX-1vTVVOEZbXLVQvjIdzGACpZ_IrOWgVDBr_Wa-xULK3191BP9lf1tep-z-PsmcAfaH_aE56j3GHDX_9UO/pubhtml
2022-09-07 23:58:04 -05:00
Kurt
17b42219af
Improve xd umbreon detection
...
Make PIDIV for xd starter indicate the TID/SID origin seed too.
2022-09-07 15:49:53 -07:00
Kurt
bbc45d8b0c
CXD played: Use TotalHours to set elapsed hours
2022-09-07 14:39:58 -07:00
Kurt
a0c998fdd5
Simplify contest ribbon deadlock set
...
Was missing the check & revert step; just fix the logic completely.
We should have the contest star ribbon if we've set all the ribbons, otherwise it was already removed.
2022-09-06 21:05:39 -07:00
Kurt
20dcb8d407
Remove old showdown set aliases
...
Don't need to support sets that don't follow the current standard.
2022-09-06 21:04:40 -07:00
Kurt
d6e83362b3
Fix binarysearch result compare
...
Method returns a negative number if not found; not always -1
https://projectpokemon.org/home/forums/topic/62246-g3-xd-move-tutor-legality/
2022-09-05 08:50:27 -07:00
Kurt
06196e0440
Minor tweaks
...
Less alloc
2022-09-04 22:23:35 -07:00
Kurt
6a61b0e449
Update EvolutionTree.cs
2022-09-04 22:20:35 -07:00
Kurt
92a50264cc
Refactor RNG advance/reverse methods ( #3579 )
...
The new LCRNG/GCRNG/ARNG classes are static, rather than singletons. Allows them to be inlined much better.
2022-09-04 12:03:37 -07:00
Kurt
d9ad0052a1
Completely remove chatelaine memory check
...
Gen6 can get the memory on those who did not participate by being in the party with other participants.
This includes those who cannot enter into the Maison; having memory and no ribbon is entirely legal.
2022-09-03 10:12:42 -07:00
Kurt
fd27bde673
Update RibbonVerifierCommon6.cs
2022-09-03 08:25:12 -07:00
Kurt
da642ee16e
Remap context for sidegame HT memory checks
...
gastrodon with recover as HT memory needs to verify within the context of SW/SH and prior learn environments.
2022-09-02 15:41:22 -07:00
Kurt
a1f3e9b081
Fix database search
2022-09-02 10:29:55 -07:00
Kurt
ac9bece46e
Remove checksum check for Sprite building
...
Hot path 99.9999% will never be false
2022-09-02 10:29:32 -07:00
Kurt
1960b335fd
Remove PersonalInfo.Abilities, use interfaces
...
If you must get a list of abilities, then use the span extension methods.
Also reworks some initial moveset fetching to allocate less
2022-09-02 10:20:19 -07:00
Lusamine
a97e74e628
Correct Arceus Chronicles Growlithe dates
2022-09-02 02:40:40 -05:00
Lusamine
7bab0270bb
Fix Wish Ralts moveset
...
Thanks @Kermalis !
2022-09-01 23:27:58 -05:00
Kurt
59c518f268
Condense moveset deletion check
2022-09-01 20:57:39 -07:00
Lusamine
8ecbd08efd
Add start date for Arceus Chronicles Growlithe event
2022-09-01 21:04:56 -05:00
Kurt
e8aa2c8ed1
Correctly check xy/sm if not ao/usum levelup
2022-09-01 09:34:40 -07:00
Kurt
4a008e510d
Sanity check friendship and level values parsed
...
Don't accept Level: 101, for example.
2022-08-31 22:22:23 -07:00
Kurt
d8cdc9fe34
Merge branch 'master' of https://github.com/kwsch/PKHeX
2022-08-31 21:04:12 -07:00
Kurt
f4f9df3a81
Don't add new gs moves to pk1 permit array
...
Out of range
https://projectpokemon.org/home/forums/topic/62190-user-message-an-unhandled-exception-has-occurred-you-can-continue-running-pkhex-but-please-report-this-error
2022-08-31 21:03:26 -07:00
Kurt
125d18e2be
Don't add new gs moves to pk1 permit array
...
Out of range
https://projectpokemon.org/home/forums/topic/62190-user-message-an-unhandled-exception-has-occurred-you-can-continue-running-pkhex-but-please-report-this-error
2022-08-31 20:41:05 -07:00
Kurt
88ac14946d
Don't be as strict with shedinja evo moves
...
EncounterMovesetGenerator doesn't specify a clean encounter, don't check it as thoroughly.
2022-08-31 19:09:06 -07:00
Kurt
fb9deab202
Specify full gift egg wc3 moveset
...
PKHeX needs the exact moveset rather than a "permit this extra move" because our recent logic improvements check for strict moveset matching when it is still an egg.
Closes #3577 thanks @wararjey !
2022-08-31 18:55:17 -07:00
Kurt
71e08222cf
Update 22.08.31
2022-08-30 22:49:54 -07:00
Kurt
d350bb7fee
Misc fixes & pickle updates
2022-08-30 21:15:07 -07:00
Kurt
66e0613d82
Minor clean
2022-08-30 15:00:45 -07:00
Kurt
319a671a6d
Simplify munchlax tree list usage
2022-08-29 17:38:27 -07:00
Kurt
f18e884407
Remove unused BDSP bcat logic
...
ded game, underground distributions unused. no need to differentiate, no need to allocate unused collections.
2022-08-29 17:37:54 -07:00
Kurt
bf37be3ea1
Update LearnVerifierEgg.cs
...
Order of operations being spooky
2022-08-29 16:08:56 -07:00
Kurt
40649084b3
stackalloc temp unreleased item arrays
2022-08-29 16:08:30 -07:00
Kurt
d8fe34011d
Remove some bounds checks, int->byte form oops
...
https://github.com/kwsch/PKHeX/pull/3575#issuecomment-1229244453
ty @Kermalis !
2022-08-27 12:53:30 -07:00
Kurt
3c232505e5
Refactoring: Narrow some value types (Species, Move, Form) ( #3575 )
...
In this pull request I've changed a ton of method signatures to reflect the more-narrow types of Species, Move# and Form; additionally, I've narrowed other large collections that stored lists of species / permitted values, and reworked them to be more performant with the latest API spaghetti that PKHeX provides. Roamer met locations, usually in a range of [max-min]<64, can be quickly checked using a bitflag operation on a UInt64. Other collections (like "Is this from Colosseum or XD") were eliminated -- shadow state is not transferred COLO<->XD, so having a Shadow ID or matching the met location from a gift/wild encounter is a sufficient check for "originated in XD".
2022-08-26 23:43:36 -07:00
Kurt
444c3d2209
Narrow more types
2022-08-26 10:07:24 -07:00
Kurt
6e4613a3a7
Narrow met location value checks for eggs s32->u16
2022-08-26 10:03:46 -07:00
Kurt
28d726da80
Simplify wild ball permitted checks
2022-08-26 01:20:49 -07:00
Kurt
e700a0e3e6
Handle traded BDSP egg transfers
2022-08-25 23:04:38 -07:00
Kurt
528a377f84
Handle version restrict for new gen4 legend cards
...
The other existing Eiscue/Stonjourner dmax crystal gifts are version restricted too, using this byte with same values.
2022-08-25 13:10:39 -07:00
Kurt
ad28f7b261
Delete old utility methods (unused)
...
MoveEgg: already range check in the Safe method
Inline some logic
2022-08-24 23:49:00 -07:00
Kurt
b241c19520
Simplify some memory args
2022-08-24 23:29:03 -07:00
Kurt
d3c2d77d11
Misc move/memory tweaks
...
Disallow max moves from Sketch
Hide dmax moves from legal dropdown lists
Pass ushort for moves for validating memories
Internal class for move pp (hide empty class from dll users)
2022-08-24 20:32:40 -07:00
Kurt
43871e856c
Specify some lambdas as static
...
Rewrite some usages to be more clear
bikeshedding at its finest, ignoring more important things to update/fix :)
2022-08-23 23:11:26 -07:00
Kurt
26b1453002
Narrow ribbon count type from int->byte, split interface
...
Fix RibbonVerifier4 not checking gen4 contest ribbons correctly
Split IRibbonCommon6 to have memory ribbons separate, as they are not implemented in mystery gifts. Also, we can add the boolean flags to the interface, and check that the boolean is set if count is nonzero.
Fix adding ribbons to Gen8 gift templates
Improve Gen8 template ribbon fetch (no closure, faster IndexOf)
2022-08-23 21:25:22 -07:00
Kurt
eb2cef10c9
Minor clean
...
Stability intensifies
2022-08-22 23:18:53 -07:00
