Commit graph

3519 commits

Author SHA1 Message Date
Kurt
7feb5a8451 Add Pickup item record
This only applies to Pickup/honey gather ability procs

179 is incremented if some value is >10000, which is immediately after
photos rated (119)
184 is incremented if GetSelectRankRoyal == 3 (after 159 and 137)

other pairs: 5,137

eh just check Savedata::IncRecord usages
2017-03-29 00:58:19 -07:00
ReignOfComputer
d6f9ad9bf8 Unban Pidgeotite and Steelixite (#1009)
Stones have been released.
2017-03-29 00:48:56 -07:00
wwwwwwzx
c2f225b523 Two minor fixes (#1006)
* Fix ingame trade legality check

- fix early return
- fix locations of the same name "a link trade", otherwise
metlocation=30001 in sm be recogized as 30002

* Fix wc7 to pkm for event egg

Nickname should be added

* Fix gen4 in-game trade

- fix ivs order
- use default met location to compact table

* Support multiple ingame trade filtering

Fix Steelix glitch, fix some table data, thanks to RoCs' PC

* Minor improvement

As suggested

* Fix gen5 in-game trade

- skip gender checks if set to default
- fix in-game trade metloaction for gen5
- fix ivs order
2017-03-29 00:48:31 -07:00
ReignOfComputer
1e8e8bbb8e General Fixes (#1005)
* Fix FRLG Viapois Chamber Location

* Gen 3 In-game Trade Fixes

3rd Gen Trades still need changes to verifyNicknameTrade to work though.
Temporarily suppressed the legality warning. It seems Bulbapedia may
have some mistakes?

* Fix Squirtle Gift in HGSS
2017-03-28 02:02:46 -07:00
Kurt
0aa2149ca6 Merge pull request #1004 from javierhimura/master
Fix gen 3 level up moves and add some missing g3/4 encounters
2017-03-27 14:29:29 -07:00
javierhimura
c70d690e9a Return fr/lg level up moves for gen 3 pokemon 2017-03-27 23:11:16 +02:00
javierhimura
c84f599e76 Static encounter for gen 3 and 4 game corner pokemon prizes
Fix Squirtle gen 3 starter encounter
Add met location to gen 3 ingame trades
2017-03-27 23:11:01 +02:00
Kurt
ef79b45347 Merge pull request #1002 from javierhimura/master
Fix issue #1001 Better approach for verifyEncounterG3Transfer function
2017-03-27 12:25:33 -07:00
javierhimura
56eaaf2299 Mew and Deoxys correction 2017-03-27 21:20:54 +02:00
javierhimura
a3fcb31530 Fix issue #1001
Changed verifyEncounterG3Transfer, when both Egg Result and other Result happens Egg only overwrite if is the only valid encounter
Corrections in verifyEncounterG3Transfer also adding code to check gen 3 WasEvent pokemon, but for now it will return Mistery Gift not found
Changed verifyEncounterG3Transfer and verifyEncounterG4Transfer to return both message error for InvalidTransfer and G3/G4 invalid encounter if both errors happen at the same time
Excluded fateful encounter pokemon from getWasEgg23, it can be WasEgg pokemon because FatefulEncounter from eggs is lost when hatch
2017-03-27 21:10:30 +02:00
Kurt
f86ad4ed0e Merge pull request #1000 from wwwwwwzx/master
Misc gen4 legality database update
2017-03-26 20:47:03 -07:00
wwwwwwzx
dbab260a81 Misc fixes
- Add data from serebii for safari zone in hgss
- Fix several typos
- Update chinese translation
2017-03-26 20:25:17 -07:00
wwwwwwzx
543e7bab88 Add daily changing pokemon in Great Marsh (dppt)
add batch encounterarea generation function
2017-03-26 20:23:45 -07:00
wwwwwwzx
d0427f0322 Fix hgss swarm slots replacement
note that dppt only have grass swarm
2017-03-26 20:21:44 -07:00
Kurt
f014f5ed1c Misc changes
remove multiple iteration of ienumerable, reduce nesting
2017-03-26 19:10:37 -07:00
Kurt
89e32b24f0 Merge pull request #998 from pokecal/pokecal-patch-2
Add G7BattleTree Supers Unlock
2017-03-26 19:08:09 -07:00
Kurt
5b892eb7ec Merge pull request #997 from javierhimura/master
Gen3 WasEgg Pokemon in gen 4 or later, Gen 4 transfer encounter
2017-03-26 19:08:02 -07:00
pokecal
f69e4a0c81 Add G7BattleTree Supers Unlock
Not checked for legality(e.g.MaxStreaks)
2017-03-27 11:04:25 +09:00
javierhimura
8511c2a36d verifyEncounterEgg Fix for Manaphy egg from gen4 2017-03-27 02:56:25 +02:00
javierhimura
22e0b0f873 Unreleased Shaymin from Diamond and Pearl 2017-03-27 01:56:38 +02:00
javierhimura
a66f106aef Detect English faraway island mew and hall of origin arceus as invalid, they are unreleased events 2017-03-27 01:51:19 +02:00
javierhimura
f1d4bccb09 WasEvent included in PK4 2017-03-27 01:38:31 +02:00
javierhimura
4bb9e01ff9 Better approach of WasEgg functions
Private variable _WasEgg is only needed for pokemon from gen 2 and 3, for gen 4 return WasEgg if EggLocation > 0
A gen4 Legal.EggLocations array should be created in the future
2017-03-27 01:36:08 +02:00
javierhimura
c93acf4767 In PK6 and PK7 defer to base properties when GenNumber < 5 for WasEgg, WasTradedEgg and WasIngameTrade 2017-03-27 01:28:34 +02:00
javierhimura
ed681fa626 Crown error text 2017-03-27 01:27:10 +02:00
javierhimura
bff867ce31 Add transporter or crown location text error 2017-03-27 01:18:26 +02:00
javierhimura
8729ddf17a Add verifyEncounterG4Transfer, is similar to gen3transfer but more simple, it just add an invalid transfer to gen 5 validation and return that if is wrong and there is no other wrong encounter result 2017-03-27 01:15:24 +02:00
javierhimura
25180a32c5 Include check of invalid transfer to gen 4/5 2017-03-27 01:00:52 +02:00
javierhimura
6d8d6b7758 Ignore NonEgg Encounter for gen 3 illegal transfer unhatched eggs 2017-03-27 00:48:50 +02:00
javierhimura
7f21973038 verifyEncounterG3Transfer function
For gen 3 transfer pokemon it checks the non egg possible encounter and if the pokemon could have been hatched egg encounter
Return the result from one of the two encounters that is valid, with non egg preference but marking WasEgg a True if it can be from an egg
In verify moves both possible encounters are considered, there is no way to discart one or another
2017-03-27 00:37:56 +02:00
javierhimura
286c8524d5 Merge remote-tracking branch 'remotes/kwsch/master' 2017-03-27 00:12:12 +02:00
javierhimura
c704fe5625 If pokemon is transfer from gen 3 to 4 or latter and it can be from an egg (pokeball 4, level and met level above 5, etc) check always for an egg encounter first, if does not match egg encounter then check other encounters
When verify moves for this pokemon it here is a non egg possible encounter first check moves from that encounter and if does not match check egg encounters
Also for gen 2 unhatched eggs ignore gen 1 encounters
2017-03-27 00:11:09 +02:00
Kurt
a3408b37f1 Merge pull request #996 from javierhimura/master
Gen 3 and 4 Safari Zones and Bug Contest Encounters
2017-03-26 14:44:02 -07:00
javierhimura
98fd09b653 Gen 4 Bug Contest source link was incorrect 2017-03-26 23:21:04 +02:00
javierhimura
14a42b5dc4 Merge remote-tracking branch 'remotes/kwsch/master' 2017-03-26 23:17:39 +02:00
javierhimura
cc994c7e7d Fix for pokemon with encounters in both safari zone and bug contest 2017-03-26 23:15:17 +02:00
Kurt
d17c92c2a8 Merge pull request #995 from pokecal/pokecal-patch-2
Add controls of G7Stamp,BallThrow
2017-03-26 14:12:02 -07:00
javierhimura
406d267ba6 Fix Magikarp rockey beach safari encounter 2017-03-26 23:10:49 +02:00
javierhimura
a12979ed41 Mark G3 and G4 Safari Slots 2017-03-26 22:46:05 +02:00
javierhimura
2f2014cdde Check safari ball and sport ball legality in encounters when met location is lost 2017-03-26 22:23:57 +02:00
pokecal
dce4b839b1 Add controls of G7Stamp,BallThrow
Some function has already included in SAV7, but no controls?
Add function about BallThrow Flags.
2017-03-27 04:50:38 +09:00
javierhimura
e952b8f435 Check valid ball for Safari Zone and Bug Contest 2017-03-26 21:44:56 +02:00
javierhimura
5371a51c43 HG SS Bug Contest Encounters
Safari Zone locations
2017-03-26 21:33:32 +02:00
javierhimura
082d87f5d0 HG SS Safari Zone encounters, extracted from Bulbapedia
Commented encounters with unknown levels
2017-03-26 21:11:00 +02:00
Kurt
a1e477606e Merge pull request #993 from wwwwwwzx/master
Fix gen4 encounters reading
2017-03-26 11:08:23 -07:00
Kurt
c42355b7bf Merge branch 'master' into master 2017-03-26 11:08:05 -07:00
Kurt
5b9e390909 Merge pull request #994 from javierhimura/master
Pre relearn egg moves analysis improved
2017-03-26 11:06:16 -07:00
javierhimura
d85f2444fc Revert "The last commit was reverted because the change should not apply to base moves from was egg pokemon, unlike egg moves base level moves are not equal among all generations."
Pokemon crystal does not store egg received location like generation 3 games, that means both crystal and gold/silver should be checked for base egg moves always
2017-03-26 19:17:30 +02:00
javierhimura
d9d138d2a5 Fix getBaseGamesIsEgg, there is some cases when crystal origin can be discarted 2017-03-26 18:47:26 +02:00
javierhimura
ca63bf2e51 Names changed to avoid confusions 2017-03-26 18:45:01 +02:00