Commit graph

2865 commits

Author SHA1 Message Date
wwwwwwzx
ea7a9dcef0 Fix gen3/4 encounterstatic table
- add static encounters for gen4 (rotom/drifloon/electrode/spiky pichu)
- fix Uxie/Azelf location (Lake -> Cavern)
- fix ball for sinjoh ruins event (the player recieve the pkm without
battle poke ball only)
- fix ball for gen5 zorua (the player can choose ball)
2017-03-24 01:05:09 -07:00
Kurt
d8dcb47252 Add gen4 event recognition
fixes ribbon fetch, unown form comparison, and improves exception
handling (no more swallowing exceptions and yielding a vague message)

properly generate manaphy egg on gen4 saves

will have to iron out the legality checks for nicknames at a later point
in time
2017-03-23 23:15:49 -07:00
wwwwwwzx
cfa1b6d744 Add gen5 pgl dream world gift
- add ability to table
2017-03-23 22:31:55 -07:00
wwwwwwzx
2e64df7b6e Merge pull request #1 from kwsch/master
Update from upstream repo kwsch/PKHeX
2017-03-23 22:24:50 -07:00
Kurt
b6c4eab36b Misc legality fixes & improvements
Recognize gen4/5 events
check ability mismatch
check nature mismatch
2017-03-23 21:42:33 -07:00
wwwwwwzx
f59d62161e Add gen5 Dream World table
- Add a lengthy dream world table with special moves and levels (wonder
if there is already a binary database). I guess location can be a good
flag from PDW.( directly writing the location into table would be
better?)
- Fixed a minor typo at vivillontables.
- Working on adding PGL Gift from Dream World
2017-03-23 21:26:57 -07:00
Kurt
a922bda342 Fix relearnmove suggestion for eggs
Closes #979
Forgot that the window deal was initially programmed to check the order
of the base moves as well, but inheritance allowed them to be shuffled
in.

suggestion is always count=4 due to earlier padding, no need to Take(4).

--mud;
2017-03-23 20:05:13 -07:00
Kurt
cb24ba2857 Add PID-nature/gender checks for 3-4(5)
nature is no longer associated on gen5

split up medals check and some encounter checks
2017-03-23 19:47:53 -07:00
Kurt
7c05bf2aa9 Simplify addExtraTableSlots
remove unnecessary ToArray() as the output of the method is always
ToArray'd
2017-03-23 18:38:31 -07:00
Kurt
e779498aae Cap gen6 boxes unlocked at 30
Closes #975
Doesn't hide the 31st box from the editor, only prevents
adding&selecting 31 from the dropdown for unlocked count.
2017-03-23 18:17:22 -07:00
Kurt
121a821180 Fix clickOT order of operations
Closes #976
subregion was set first, but changing the country caused it to reset the
subregion to 0/existing value.

thus, load country first then subregion (why not move 3DSReg first 👍
)
2017-03-23 18:10:14 -07:00
Kurt
6b25367be7 Change vivillon check invalid->fishy
compact the table for easier browsing
2017-03-23 18:07:15 -07:00
Kurt
05d31ef530 Update relearn check logic
No functional change, just a little optimization and grouping of
suggestion logic (can be more easily commented out if making a slimmer
checker)
2017-03-23 17:57:21 -07:00
javierhimura
0d4c724783 Fix addExtraTableSlots for areas only in extra table (#977)
* Add shellos and gastrodom alt form in east sea locations

* Improved MarkG4AltFormSlots

* Remove inside of truck

* Move code for group by Areas to a propert function, to avoid duplicate code, also group by Areas in gen 2, 6 and 7. Is not needed in gen 1

* Reduce all gen7 areas

* legality_en.txt file format fix

* addExtraTableSlots: Include locations from the SpecialSlots array that does not exits in game GameSlots array
changed the types to IEnumerable to avoid using multiple ToArray when the function is used more that one time for the same game

* Fix Shellos AltForm location
2017-03-23 14:50:01 -07:00
Kurt
49b35371f4 Merge pull request #973 from wwwwwwzx/master
Impl vivillon form legality checking
2017-03-23 11:37:28 -07:00
wwwwwwzx
e0b68bf9b7 Fix typos 2017-03-23 04:22:15 -07:00
wwwwwwzx
5755a5765a Update chinese translation for legality checking 2017-03-23 04:02:03 -07:00
wwwwwwzx
5273df3e0a Impl vivillon form legality checking
Fix issue #274
2017-03-23 03:21:04 -07:00
wwwwwwzx
71b3ed87b2 Merge pull request #3 from kwsch/master
Update from upstream repo kwsch/PKHeX
2017-03-23 00:45:28 -07:00
Kurt
fb803958bd Refactor move legality checking
With the refactoring of result strings outside of Checks.cs, the logic
became harder to follow as the result strings functioned as comments.

This commit splits up the large move checking methods into smaller parts
and added comments.

Moved keldeo move check to a form check and simplifies the check to only
search once.
2017-03-22 23:34:38 -07:00
Kurt
eaa3b2832f Merge pull request #972 from Tsunamical/NetUtil
Fix Typo in NetUtil
2017-03-22 22:49:33 -07:00
Tsunamical
0f3b316baa Fix Typo in NetUtil 2017-03-23 01:37:59 -04:00
Kurt
d685fb39a9 Refactor remaining strings out 2017-03-22 20:12:45 -07:00
wwwwwwzx
a11d3f0dd0 Merge pull request #2 from kwsch/master
Update from upstream repo kwsch/PKHeX
2017-03-22 19:57:45 -07:00
Kurt
9104dd5f98 Cleanup
Add gen5 hidden ability check for pkm that shouldn't have hidden ability
(wonder if there's any pkm that can be encountered in wild / grotto)

time to extract more strings
2017-03-22 19:43:31 -07:00
wwwwwwzx
6f9c27a98f Merge pull request #1 from kwsch/master
Update from upstream repo kwsch/PKHeX
2017-03-22 18:30:09 -07:00
Kurt
38bcfe30cc Add setting for unset changes notification
opt in setting
resx too goofy

Closes #970
2017-03-22 18:02:05 -07:00
Kurt
d9164068d3 Merge pull request #969 from wwwwwwzx/master
Misc legality checking addition
2017-03-22 17:01:31 -07:00
wwwwwwzx
d12f76388f Add Hidden Grotto Ability checking 2017-03-22 16:47:14 -07:00
wwwwwwzx
d5323ccb22 Add manaphy as a fateful gift 2017-03-22 15:57:26 -07:00
wwwwwwzx
4702802842 Add gen4/5 egg valid met locations
-also fix Regis met location in b2w2
2017-03-22 15:42:59 -07:00
wwwwwwzx
656e34a28e Add legality Chinese translation 2017-03-22 14:38:00 -07:00
wwwwwwzx
5b83d5b2d4 Merge pull request #1 from kwsch/master
Update from upstream repo kwsch/PKHeX
2017-03-22 13:28:41 -07:00
Kurt
38ee35d3e4 Merge pull request #968 from pokecal/pokecal-patch-1
fix gen4dex forms
2017-03-22 08:48:48 -07:00
pokecal
5b85c4dfdc fix gen4dex forms
mismatch of formFlag and languageFlag also fixed.
full editing of DexUpgrade added.
DP,with SetToSavOption,some mons otherLangDexFlag will be edit.
2017-03-22 17:01:02 +09:00
Kurt
eb8b9602b2 Add pkm modified & unset alert
Same for save edited check on closing, this will alert the user if View
is called without the data being Set first.
2017-03-21 23:25:17 -07:00
wwwwwwzx
207a6b8b44 Add B2W2 hidden grotto table (#966) 2017-03-21 23:22:22 -07:00
Kurt
503a9b9d71 Finish legality string translation feature
Same " = " separator as the main form translation, uses the cache style
in GameStrings to only load once.

Closes #959, feel free to discuss there.
2017-03-21 21:40:33 -07:00
Kurt
db3783bb0b Fix exeggutor forme tutors
Closes #964
2017-03-21 20:19:58 -07:00
Kurt
a3862b99be Cleanup
No functional changes, just simplification
sneaky linq to generate slots for unown forms on one line
2017-03-21 20:17:21 -07:00
Kurt
68fe715774 Add party data editing for batch editor
functions properly for games without a party (RS BOX) by checking if a
party exists
if there's ever a game that doesn't have a box, it'll work for that too
:P
2017-03-21 19:27:45 -07:00
Kurt
7adcbbea3d Merge pull request #965 from wwwwwwzx/master
Add gen5/ fix gen4 swarming encounters tables
2017-03-21 18:47:23 -07:00
wwwwwwzx
8d5454136e Minor fix
- Fix location index of route 3 in gen5
- reduce loop
2017-03-21 18:14:16 -07:00
wwwwwwzx
1d72876632 Fix gen4 swarm encounters table
- Make the table compact
- fix Delibird location in dppt (216/217)
- fix Spoink location in dppt (224->214)
- fix fishing encounter type in hgss (some pkm can only be caught via
super rod etc.)
2017-03-21 18:02:04 -07:00
wwwwwwzx
812aa32a3b Remove unused hgss swarm table 2017-03-21 17:57:59 -07:00
wwwwwwzx
ea69f22492 Add gen5 swarm encounters table 2017-03-21 17:57:23 -07:00
wwwwwwzx
e08d831ce5 Misc table fixes (#963)
* FIx hgss encounter table

- fix roaming location mixup
- uncomment Unown A

* Fix dppt roaming locations

- roaming pkm can be met on water in dppt
- can not go to route 223 224 and northwest island 225-230
- Add 2 non-route location

* Fix FRLG roaming locations

it's also possible to encounter on water

* Fix unable to save uncheck seen&caught states

* Revert unown
2017-03-21 08:57:10 -07:00
ReignOfComputer
6f7c8e73a0 Dump Single Box (#962)
* Dump Single Box

Probably can be better optimized or something. The code works, the thing
is I can't seem to edit the Menu Items to add this in as it causes the
view to go haywire. VS can be silly sometimes. For your consideration :)

Related:
https://projectpokemon.org/forums/forums/topic/40358-how-to-export-all-pokemon-in-boxes-as-pk7/

* Manual Design Edit of Main
2017-03-21 00:21:03 -07:00
javierhimura
2bb9f61033 Shellos and Gastrodom East Sea Form in Gen 4 Encounters (#961)
* Add shellos and gastrodom alt form in east sea locations

* Improved MarkG4AltFormSlots

* Remove inside of truck

* Move code for group by Areas to a propert function, to avoid duplicate code, also group by Areas in gen 2, 6 and 7. Is not needed in gen 1

* Reduce all gen7 areas
2017-03-21 00:20:51 -07:00
Kurt
3027eadb8d Refactory legality strings
For future translation feature as per #959
3 helper methods provided to facilitate the localization (import /
export / update)

I decided to simplify some duplicate-function sections
2017-03-21 00:18:44 -07:00