115 commits

Author	SHA1	Message	Date
Kurt	7cb6ee0060	Move some static arrays closer to where they're used ... Split EvolutionRestrictions to its own class Can probably refine things further to clamp down access to these arrays	2020-11-02 13:11:51 -08:00
Kurt	6938d2f94d	Split VivillonTables into two classes ... Indicate that the content is for 3DS specific logic Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin	2020-10-04 14:15:13 -07:00
Kurt	52a67f2425	Add Stadium2 Support ... Introducing a new PKM format: SK2 Split ICaughtData2 off of PK2 so it can be shared with SK2 when type-checks occur Add conversion for PK2<->SK2 Split the split-buffer handling for GBPKM to GBPKML (what a name), so that I can reuse shared accessor logic for SK2.	2020-10-02 18:08:40 -07:00
Kurt	5d3bc289b6	seal hunting ... Mark things as sealed as they shouldn't be inherited from or overriden in a derived class.	2020-09-07 13:51:13 -07:00
Kurt	c1adab9703	Refactoring ... Move logic closer to where it is used rather than in larger static classes EncounterStatic(7): move VC transfer template creation to class, simplify some sanity checks EvoChain: g==2 case is never hit as the generation check at the top of the loop already skips	2020-09-05 12:11:43 -07:00
Kurt	75da70069c	Remove access to modified captured variable ... Get the variable rather than indexing into the array each time Simplify some expressions in sav7 for readability Make SAV_EventFlags use comboitem explicitly by type rather than an anonymous type with same member names	2020-08-30 15:48:11 -07:00
Kurt	e532a29e72	Allow gen1 moves on gen2 met data pk2's ... Thanks MrPerson0 on discord for notifying us of this mechanic. Stadium 2 can utilize Gen1 learnset data while keeping them in PK2 format, retaining the met data.	2020-08-29 23:47:03 -07:00
Kurt	e84ce77008	Split memories from main pkm class to interface ... pk6/7/8, not pb7	2020-07-31 17:25:14 -07:00
Kurt	27f15d2f20	Split Country/Region/ConsoleRegion to interface	2020-07-31 11:17:31 -07:00
Kurt	993673f0de	Minor clean ... no functional change	2020-06-27 23:36:53 -05:00
Kurt	645db23706	Extract EvoBase and MoveList from Core ... These are really old bloated parts of the original legality checking logic; separating for now to rewrite.	2020-06-20 19:44:05 -05:00
Kurt	cce3d5d9f5	Handle race condition on get->set new cached string ... overwrite add if it somehow was added from another thread in between lock checks	2020-05-19 20:40:51 -07:00
Kurt	c301ce88ab	Update Random to be a bit more thread safe ... Random isn't thread safe; users of PKHeX.Core.dll might run multithreaded operations (see PKSM + ALM), so we need to have a thread-specific RNG available. Thread Local get; to improve performance, save the random object locally whenever it is used more than once in the method. https://docs.microsoft.com/en-us/dotnet/api/system.threading.threadlocal-1?redirectedfrom=MSDN&view=netframework-4.8 https://stackoverflow.com/questions/18333885/threadstatic-v-s-threadlocalt-is-generic-better-than-attribute/18337158#18337158	2020-01-25 21:49:52 -08:00
Kurt	c730dfa1ba	Remove empty ushort[1], improve item combo fetch ... held item list now allocates less (concat arrays instead of ienumerables) item list already prunes out of range items, so simplify data source fetch simplify item list prune (return as list, so we can call RemoveAll instead of Where.ToList)	2020-01-24 23:29:45 -08:00
Kurt	c739af4767	Extract item restrictions to separate class ... Move similar classes to folder	2020-01-16 19:27:29 -08:00