Commit graph

21 commits

Author SHA1 Message Date
Kaphotics
02a208a74d Break PKX-SAV personaltable relationship
Opening Database and having a species in the results with species#
greater than the current loaded save file's allowed (ie volcanion in db
with loaded emerald) causes Report to throw errors when opened from
Database.
2016-07-18 23:28:10 -07:00
Kaphotics
89ad1cc896 Cast when loading sav6
fb9c18c
2016-07-18 21:39:43 -07:00
Kaphotics
fb9c18c151 Tweak casting
I'm a little too averse for extra lines of code :)

Regarding remaining discussion on #136
Resharper gives suggestion to null check
Path.GetFileNameWithoutExtension and Path.GetExtension, so it won't
hurt. Just because it's set up to work properly now doesn't mean someone
modifying it / operating systems years from now will supply the correct
arguments.
2016-07-18 20:36:52 -07:00
Kaphotics
83c2f02fd1 Merge pull request #136 from Tsunamical/master
Final Set of Code Improvement Patches
2016-07-18 20:27:41 -07:00
Kaphotics
85ffe06807 Fix setIsShiny
Thanks Wanderer1391!

Set value back only if it was the one that updated the value. No need to
prompt update after loading as it refreshes when each field loads.
2016-07-18 20:25:54 -07:00
Tyler Dunn
de8cebf2a4 Use Direct Casts and Conditional Access to Avoid NPEs 2016-07-18 14:51:26 -04:00
Kaphotics
016a0e3aee Reduce reliance on PKX
Certain calculations are best done with direct references.
Indirectly fixed Shiny button bug (8 <= xor < 16) for past gen games.
2016-07-17 23:40:40 -07:00
Kaphotics
f981621452 Simplify ability / entry retrieval 2016-07-17 23:04:39 -07:00
Tyler Dunn
641f1f61f6 Additional Code Style Fixes 2016-07-17 13:09:01 -04:00
Kaphotics
df51269c7e Add gen3 met locations
English only for now.
2016-07-16 21:31:49 -07:00
Kaphotics
8a0976e6e3 Minor updates
Expose the buttons for medal/ribbon
2016-07-16 17:19:26 -07:00
Kaphotics
cb353e0065 Disallow box sorting if no boxes 2016-07-14 20:37:18 -07:00
Kaphotics
69e7f19101 Add Japanese prompt for <=Gen3 games 2016-07-14 20:22:24 -07:00
Kaphotics
b6e9202158 Allow batch editor without HaX
May be a mistake :)

Tweak ability display to behave properly regarding gen1/2 saves if ever
implemented
2016-07-14 20:15:05 -07:00
Kaphotics
a1ac548485 Add Batch Editor (HaX)
= acts as a 'modify if' filter
! acts as a 'do not modify if' filter
. acts as a 'set property to' to value

!HeldItem=0
^ do not modify if held item is zero

=HeldItem=5
^ only modify if held item is index 5

.Species=7
^ set species to 7

!SID=666
.TID=666
^ set TID to 666 if SID is not 666

.TID=666
!SID=666
^ set TID to 666 if SID is not 666 (filtering can be after property
settings)

Run one 'batch modify' script at a time.
2016-07-12 22:19:51 -07:00
Kaphotics
109bd291f6 Delay d&d file deletion
Gives web browser programs enough time to acquire the data since the
file isn't being moved to a location on the user's local storage.
2016-07-10 10:35:44 -07:00
Kaphotics
5d25b919a4 PK6->PKM for labels/controls
Reflects multi generational
2016-07-10 10:32:51 -07:00
Kaphotics
171ab7b85f Split out pk# population/retrieval 2016-07-09 16:17:55 -07:00
Kaphotics
592390d1ca Move cbItem to ComboItem 2016-07-09 15:34:38 -07:00
Kaphotics
cc2b3fc081 remove f#- from f1-f4 forms
Not relevant
2016-07-09 14:32:52 -07:00
Kaphotics
08d751d54b Move files
Getting a little crowded and misleading (PKX/SAV folders), let's
relocate.
2016-07-09 14:30:49 -07:00