Add GSC version IDs (supposed)

This is speculation and for preparation purposes only

PKHeX.Core/Game/GameInfo.cs

@@ -315,6 +315,7 @@ namespace PKHeX.Core
             AbilityDataSource = Util.GetCBList(s.abilitylist, null);
             VersionDataSource = Util.GetCBList(s.gamelist, Legal.Games_7sm, Legal.Games_6oras, Legal.Games_6xy, Legal.Games_5, Legal.Games_4, Legal.Games_4e, Legal.Games_4r, Legal.Games_3, Legal.Games_3e, Legal.Games_3r, Legal.Games_3s);
             VersionDataSource.AddRange(Util.GetCBList(s.gamelist, Legal.Games_7vc1).OrderBy(g => g.Value)); // stuff to end unsorted
+            VersionDataSource.AddRange(Util.GetCBList(s.gamelist, Legal.Games_7vc2).OrderBy(g => g.Value)); // stuff to end unsorted
             VersionDataSource.AddRange(Util.GetCBList(s.gamelist, Legal.Games_7go).OrderBy(g => g.Value)); // stuff to end unsorted
 
             HaXMoveDataSource = Util.GetCBList(s.movelist, null);

PKHeX.Core/Legality/Analysis.cs

@@ -316,7 +316,7 @@ namespace PKHeX.Core
         }
         private string GetVerboseLegalityReport()
         {
-            if (!Parsed)
+            if (!Parsed || pkm == null)
                 return V189;
 
             const string separator = "===";

PKHeX.Core/Legality/Tables7.cs

@@ -9,7 +9,7 @@ namespace PKHeX.Core
         internal const int MaxItemID_7 = 920;
         internal const int MaxAbilityID_7 = 232;
         internal const int MaxBallID_7 = 0x1A; // 26
-        internal const int MaxGameID_7 = 38; // Yellow VC
+        internal const int MaxGameID_7 = 41; // Crystal (VC?)
 
         #region Met Locations
 

PKHeX.Core/PKM/PK2.cs

@@ -381,7 +381,7 @@ namespace PKHeX.Core
                 PID = Util.Rand32(),
                 Ball = 4,
                 MetDate = DateTime.Now,
-                Version = (int)GameVersion.S,
+                Version = (int)GameVersion.SV,
                 Move1 = Move1,
                 Move2 = Move2,
                 Move3 = Move3,

PKHeX.Core/Resources/text/de/text_Games_de.txt

@@ -36,4 +36,7 @@ GO
 Rote
 Blaue [INT]/Grüne [JP]
 Blaue [JP]
-Gelbe
+Gelbe
+Goldene
+Silberne
+Kristall

PKHeX.Core/Resources/text/en/text_Games_en.txt

@@ -36,4 +36,7 @@ GO
 Red
 Blue [INT]/Green [JP]
 Blue [JP]
-Yellow
+Yellow
+Gold
+Silver
+Crystal

PKHeX.Core/Resources/text/es/text_Games_es.txt

@@ -36,4 +36,7 @@ GO
 Roja
 Azul [INT]/Verde [JP]
 Azul [JP]
-Amarilla
+Amarilla
+Oro
+Plata
+Cristal

PKHeX.Core/Resources/text/fr/text_Games_fr.txt

@@ -36,4 +36,7 @@ GO
 Rouge
 Bleue [INT]/Vert [JP]
 Bleue [JP]
-Jaune
+Jaune
+Or
+Argent
+Cristal

PKHeX.Core/Resources/text/it/text_Games_it.txt

@@ -36,4 +36,7 @@ GO
 Rossa
 Blu [INT]/Verde [JP]
 Blu [JP]
-Gialla
+Gialla
+Oro
+Argento
+Cristallo

PKHeX.Core/Resources/text/ja/text_Games_ja.txt

@@ -36,4 +36,7 @@ GO
 赤
 青 [INT]/緑 [JP]
 青 [JP]
-黄
+黄
+金
+銀
+クリスタル

PKHeX.Core/Resources/text/ko/text_Games_ko.txt

@@ -36,4 +36,7 @@ Y
 레드
 블루 [INT]/그린 [JP]
 블루 [JP]
-옐로
+옐로
+금
+은
+결정

PKHeX.Core/Resources/text/zh/text_Games_zh.txt

@@ -36,4 +36,7 @@ GO
 红
 蓝 [国际]/绿 [日]
 蓝 [日]
-黄
+黄
+金
+银
+水晶