Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-17 17:48:08 +00:00
Code Issues Projects Releases Packages Wiki Activity

Improve batch editor alerts

Browse source 
Add detection for incomplete commands (instead of throwing and catching
exceptions).
Add 'error' skip tracking, add counter for actual files iterated over
(930 -> actual count of nonempty files for a gen6 save).

Processing folder files now writes back ONLY if the file is modified.
This commit is contained in:
Kaphotics 2016-07-20 22:43:26 -07:00
parent 583859ffd3
commit dc11719902
1 changed files with 50 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

66
Subforms/PKM Editors/BatchEditor.cs
View file

@ -55,10 +55,16 @@ namespace PKHeX
private BackgroundWorker b = new BackgroundWorker { WorkerReportsProgress = true };
private void runBackgroundWorker()
{
var Filters = getFilters().ToList();
if (Filters.Any(z => string.IsNullOrWhiteSpace(z.PropertyValue)))
{ Util.Error("Empty Filter Value detected."); return; }
var Instructions = getInstructions().ToList();
if (Instructions.Any(z => string.IsNullOrWhiteSpace(z.PropertyValue)))
{ Util.Error("Empty Property Value detected."); return; }
FLP_RB.Enabled = RTB_Instructions.Enabled = B_Go.Enabled = false;
var Filters = getFilters().ToList();
var Instructions = getInstructions().ToList();
b = new BackgroundWorker {WorkerReportsProgress = true};
b.DoWork += (sender, e) => {
@ -133,20 +139,32 @@ namespace PKHeX
}
private void processSAV(PKM[] data, List<StringInstruction> Filters, List<StringInstruction> Instructions)
{
int len = 0;
int err = 0;
int ctr = 0;
for (int i = 0; i < data.Length; i++)
{
var pkm = data[i];
if (ProcessPKM(pkm, Filters, Instructions))
ModifyResult r = ProcessPKM(pkm, Filters, Instructions);
if (r != ModifyResult.Invalid)
len++;
if (r == ModifyResult.Error)
err++;
if (r == ModifyResult.Modified)
ctr++;
b.ReportProgress(i);
}
Main.SAV.BoxData = data;
result = $"Modified {ctr}/{data.Length} files.";
result = $"Modified {ctr}/{len} files.";
if (err > 0)
result += Environment.NewLine + $"{err} files ignored due to an internal error.";
}
private void processFolder(string[] files, List<StringInstruction> Filters, List<StringInstruction> Instructions)
{
int len = 0;
int err = 0;
int ctr = 0;
for (int i = 0; i < files.Length; i++)
{
@ -159,13 +177,22 @@ namespace PKHeX
byte[] data = File.ReadAllBytes(file);
var pkm = PKMConverter.getPKMfromBytes(data);
if (ProcessPKM(pkm, Filters, Instructions))
ModifyResult r = ProcessPKM(pkm, Filters, Instructions);
if (r != ModifyResult.Invalid)
len++;
if (r == ModifyResult.Error)
err++;
if (r == ModifyResult.Modified)
{
ctr++;
File.WriteAllBytes(file, pkm.DecryptedBoxData);
}
File.WriteAllBytes(file, pkm.DecryptedBoxData);
b.ReportProgress(i);
}
result = $"Modified {ctr}/{files.Length} files.";
result = $"Modified {ctr}/{len} files.";
if (err > 0)
result += Environment.NewLine + $"{err} files ignored due to an internal error.";
}
private void tabMain_DragEnter(object sender, DragEventArgs e)
@ -190,32 +217,39 @@ namespace PKHeX
public string PropertyValue;
public bool Evaluator;
}
private static bool ProcessPKM(PKM PKM, IEnumerable<StringInstruction> Filters, IEnumerable<StringInstruction> Instructions)
private enum ModifyResult
{
if (!PKM.ChecksumValid)
return false;
if (PKM.Species == 0)
return false;
Invalid,
Error,
Filtered,
Modified,
}
private static ModifyResult ProcessPKM(PKM PKM, IEnumerable<StringInstruction> Filters, IEnumerable<StringInstruction> Instructions)
{
if (!PKM.ChecksumValid || PKM.Species == 0)
return ModifyResult.Invalid;
foreach (var cmd in Filters)
{
try
{
if (ReflectUtil.GetValueEquals(PKM, cmd.PropertyName, cmd.PropertyValue) != cmd.Evaluator)
return false;
return ModifyResult.Filtered;
}
catch
{
Console.WriteLine($"Unable to compare {cmd.PropertyName} to {cmd.PropertyValue}.");
return false;
return ModifyResult.Filtered;
}
}
ModifyResult result = ModifyResult.Error;
foreach (var cmd in Instructions)
{
try { ReflectUtil.SetValue(PKM, cmd.PropertyName, cmd.PropertyValue); }
try { ReflectUtil.SetValue(PKM, cmd.PropertyName, cmd.PropertyValue); result = ModifyResult.Modified; }
catch { Console.WriteLine($"Unable to set {cmd.PropertyName} to {cmd.PropertyValue}."); }
}
return true;
return result;
}
private void B_Add_Click(object sender, EventArgs e)