From cd16a7721b04d0e02abf672feb0d17ab909ed929 Mon Sep 17 00:00:00 2001 From: Kurt Date: Sun, 22 Oct 2017 17:17:17 -0700 Subject: [PATCH] Set roamer data back on save existing code cloned the savedata reference to a new array, and didn't copy back the Roamer3 reader/writer does all the r/w, and writing only happens with the setter when the form is called to Save. Thanks TheRealAlphA! --- PKHeX.WinForms/Subforms/Save Editors/Gen3/SAV_Roamer3.cs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/PKHeX.WinForms/Subforms/Save Editors/Gen3/SAV_Roamer3.cs b/PKHeX.WinForms/Subforms/Save Editors/Gen3/SAV_Roamer3.cs index 6eae436ab..da750efb3 100644 --- a/PKHeX.WinForms/Subforms/Save Editors/Gen3/SAV_Roamer3.cs +++ b/PKHeX.WinForms/Subforms/Save Editors/Gen3/SAV_Roamer3.cs @@ -7,20 +7,17 @@ namespace PKHeX.WinForms { public partial class SAV_Roamer3 : Form { - private readonly SaveFile Origin; - private readonly SAV3 SAV; private readonly Roamer3 Reader; public SAV_Roamer3(SaveFile sav) { - SAV = (SAV3)(Origin = sav).Clone(); - Reader = new Roamer3(SAV); + Reader = new Roamer3((SAV3)sav); InitializeComponent(); WinFormsUtil.TranslateInterface(this, Main.CurrentLanguage); CB_Species.DisplayMember = "Text"; CB_Species.ValueMember = "Value"; - CB_Species.DataSource = new BindingSource(GameInfo.SpeciesDataSource.Where(id => id.Value <= SAV.MaxSpeciesID).ToList(), null); + CB_Species.DataSource = new BindingSource(GameInfo.SpeciesDataSource.Where(id => id.Value <= sav.MaxSpeciesID).ToList(), null); LoadData(); }