Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-24 13:03:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add gen7 memory checks

Browse source 
No memories, should not have any.
Closes #481
This commit is contained in:
Kurt 2016-11-25 17:30:39 -08:00
parent c62841027b
commit b58a9d4b70
1 changed files with 59 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

64
PKHeX/Legality/Checks.cs
View file

@ -1174,16 +1174,25 @@ namespace PKHeX
} }
private void verifyOTMemory() private void verifyOTMemory()
{ {
if (!History.Valid) if (pkm.Format < 6)
return;
if (pkm.GenNumber < 6)
return; return;
if (EncounterType == typeof(EncounterTrade)) if (!History.Valid)
return;
if (pkm.GenNumber < 6)
{ {
AddLine(Severity.Valid, "OT Memory (Ingame Trade) is valid.", CheckIdentifier.Memory); if (pkm.OT_Memory != 0)
AddLine(Severity.Invalid, "Should not have an OT Memory.", CheckIdentifier.Memory);
if (pkm.OT_Intensity != 0)
AddLine(Severity.Invalid, "Should not have an OT Memory Intensity value.", CheckIdentifier.Memory);
if (pkm.OT_TextVar != 0)
AddLine(Severity.Invalid, "Should not have an OT Memory TextVar value.", CheckIdentifier.Memory);
if (pkm.OT_Feeling != 0)
AddLine(Severity.Invalid, "Should not have an OT Memory Feeling value.", CheckIdentifier.Memory);
return; return;
} }
if (EncounterType == typeof(WC6)) if (EncounterType == typeof(WC6))
{ {
WC6 MatchedWC6 = EncounterMatch as WC6; WC6 MatchedWC6 = EncounterMatch as WC6;
@ -1196,6 +1205,38 @@ namespace PKHeX
if (pkm.OT_Feeling != MatchedWC6.OT_Feeling) if (pkm.OT_Feeling != MatchedWC6.OT_Feeling)
AddLine(Severity.Invalid, "Event " + (MatchedWC6.OT_Feeling == 0 ? "should not have an OT Memory Feeling value" : "OT Memory Feeling should be index " + MatchedWC6.OT_Feeling) + ".", CheckIdentifier.Memory); AddLine(Severity.Invalid, "Event " + (MatchedWC6.OT_Feeling == 0 ? "should not have an OT Memory Feeling value" : "OT Memory Feeling should be index " + MatchedWC6.OT_Feeling) + ".", CheckIdentifier.Memory);
} }
if (EncounterType == typeof(WC7))
{
WC7 MatchedWC7 = EncounterMatch as WC7;
if (pkm.OT_Memory != MatchedWC7.OT_Memory)
AddLine(Severity.Invalid, "Event " + (MatchedWC7.OT_Memory == 0 ? "should not have an OT Memory" : "OT Memory should be index " + MatchedWC7.OT_Memory) + ".", CheckIdentifier.Memory);
if (pkm.OT_Intensity != MatchedWC7.OT_Intensity)
AddLine(Severity.Invalid, "Event " + (MatchedWC7.OT_Intensity == 0 ? "should not have an OT Memory Intensity value" : "OT Memory Intensity should be index " + MatchedWC7.OT_Intensity) + ".", CheckIdentifier.Memory);
if (pkm.OT_TextVar != MatchedWC7.OT_TextVar)
AddLine(Severity.Invalid, "Event " + (MatchedWC7.OT_TextVar == 0 ? "should not have an OT Memory TextVar value" : "OT Memory TextVar should be index " + MatchedWC7.OT_TextVar) + ".", CheckIdentifier.Memory);
if (pkm.OT_Feeling != MatchedWC7.OT_Feeling)
AddLine(Severity.Invalid, "Event " + (MatchedWC7.OT_Feeling == 0 ? "should not have an OT Memory Feeling value" : "OT Memory Feeling should be index " + MatchedWC7.OT_Feeling) + ".", CheckIdentifier.Memory);
}
if (EncounterType == typeof(EncounterTrade))
{
// Undocumented, uncommon, and insignificant -- don't bother.
AddLine(Severity.Valid, "OT Memory (Ingame Trade) is valid.", CheckIdentifier.Memory);
return;
}
if (pkm.GenNumber == 7)
{
if (pkm.OT_Memory != 0)
AddLine(Severity.Invalid, "Should not have an OT Memory.", CheckIdentifier.Memory);
if (pkm.OT_Intensity != 0)
AddLine(Severity.Invalid, "Should not have an OT Memory Intensity value.", CheckIdentifier.Memory);
if (pkm.OT_TextVar != 0)
AddLine(Severity.Invalid, "Should not have an OT Memory TextVar value.", CheckIdentifier.Memory);
if (pkm.OT_Feeling != 0)
AddLine(Severity.Invalid, "Should not have an OT Memory Feeling value.", CheckIdentifier.Memory);
return;
}
switch (pkm.OT_Memory) switch (pkm.OT_Memory)
{ {
case 2: // {0} hatched from an Egg and saw {1} for the first time at... {2}. {4} that {3}. case 2: // {0} hatched from an Egg and saw {1} for the first time at... {2}. {4} that {3}.
@ -1240,6 +1281,19 @@ namespace PKHeX
if (!History.Valid) if (!History.Valid)
return; return;
if (pkm.GenNumber == 7)
{
if (pkm.HT_Memory != 0)
AddLine(Severity.Invalid, "Should not have a HT Memory", CheckIdentifier.Memory);
if (pkm.HT_Intensity != 0)
AddLine(Severity.Invalid, "Should not have a HT Memory Intensity value", CheckIdentifier.Memory);
if (pkm.HT_TextVar != 0)
AddLine(Severity.Invalid, "Should not have a HT Memory TextVar value.", CheckIdentifier.Memory);
if (pkm.HT_Feeling != 0)
AddLine(Severity.Invalid, "Should not have a HT Memory Feeling value", CheckIdentifier.Memory);
return;
}
switch (pkm.HT_Memory) switch (pkm.HT_Memory)
{ {
case 1: // {0} met {1} at... {2}. {1} threw a Poké Ball at it, and they started to travel together. {4} that {3}. case 1: // {0} met {1} at... {2}. {1} threw a Poké Ball at it, and they started to travel together. {4} that {3}.