Update shiny stars to modern game icon

This swaps the old red star to a red two-star icon from Switch games.
Improves visibility of the square shiny icon (red/white stars).

Closes #3749

PKHeX.Drawing.PokeSprite/Builder/SpriteBuilder.cs

@@ -200,11 +200,19 @@ public abstract class SpriteBuilder : ISpriteBuilder<Image>
         // Add shiny star to top left of image.
         Bitmap rare;
         if (shiny is Shiny.AlwaysSquare)
-            rare = Resources.rare_icon_2;
+        {
-        else if (tweak.HasFlag(SpriteBuilderTweak.BoxBackgroundRed))
+            if (tweak.HasFlag(SpriteBuilderTweak.BoxBackgroundRed))
-            rare = Resources.rare_icon_alt;
+                rare = Resources.rare_icon_alt_2;
+            else
+                rare = Resources.rare_icon_2;
+        }
         else
-            rare = Resources.rare_icon;
+        {
+            if (tweak.HasFlag(SpriteBuilderTweak.BoxBackgroundRed))
+                rare = Resources.rare_icon_alt;
+            else
+                rare = Resources.rare_icon;
+        }
         return ImageUtil.LayerImage(baseImage, rare, 0, 0, ShinyTransparency);
     }
 

PKHeX.Drawing.PokeSprite/Properties/Resources.Designer.cs

@@ -53190,6 +53190,16 @@ namespace PKHeX.Drawing.PokeSprite.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized resource of type System.Drawing.Bitmap.
+        /// </summary>
+        public static System.Drawing.Bitmap rare_icon_alt_2 {
+            get {
+                object obj = ResourceManager.GetObject("rare_icon_alt_2", resourceCulture);
+                return ((System.Drawing.Bitmap)(obj));
+            }
+        }
+
         /// <summary>
         ///   Looks up a localized resource of type System.Drawing.Bitmap.
         /// </summary>