Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-10 22:54:14 +00:00
Code Issues Projects Releases Packages Wiki Activity

potential revisions for gible (#3462)

Browse source 
ddc6f414df caused it to be `<=` instead of `<`, but maybe the underlying issue was fixed a different way since all tests still pass with this reversion.
This commit is contained in:
Kurt 2022-03-12 17:08:49 -08:00 committed by Kurt
parent 69fafcab83
commit 801892b59e
6 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
PKHeX.Core/Legality/Moves/Breeding/MoveBreed2.cs
View file

@ -137,7 +137,7 @@ namespace PKHeX.Core
var baseIndex = baseMoves.IndexOf(moves[i]);
var min = moves.Length - baseMoves.Length + baseIndex;
if (i <= min + count)
if (i < min + count)
return false;
}

2
PKHeX.Core/Legality/Moves/Breeding/MoveBreed3.cs
View file

@ -133,7 +133,7 @@ namespace PKHeX.Core
var baseIndex = baseMoves.IndexOf(moves[i]);
var min = moves.Length - baseMoves.Length + baseIndex;
if (i <= min + count)
if (i < min + count)
return false;
}

2
PKHeX.Core/Legality/Moves/Breeding/MoveBreed4.cs
View file

@ -134,7 +134,7 @@ namespace PKHeX.Core
var baseIndex = baseMoves.IndexOf(moves[i]);
var min = moves.Length - baseMoves.Length + baseIndex;
if (i <= min + count)
if (i < min + count)
return false;
}

2
PKHeX.Core/Legality/Moves/Breeding/MoveBreed5.cs
View file

@ -133,7 +133,7 @@ namespace PKHeX.Core
var baseIndex = baseMoves.IndexOf(moves[i]);
var min = moves.Length - baseMoves.Length + baseIndex;
if (i <= min + count)
if (i < min + count)
return false;
}

2
PKHeX.Core/Legality/Moves/Breeding/MoveBreed6.cs
View file

@ -133,7 +133,7 @@ namespace PKHeX.Core
var baseIndex = baseMoves.IndexOf(info.Moves[i]);
var min = info.Moves.Length - baseMoves.Length + baseIndex;
if (i <= min + count)
if (i < min + count)
return false;
}

4
Tests/PKHeX.Core.Tests/Legality/BreedTests.cs
View file

@ -32,6 +32,9 @@ namespace PKHeX.Tests.Legality
[InlineData(OR, Growlithe, 0, MorningSun, IronTail, Crunch, HeatWave)]
[InlineData(OR, Dratini, 0, Wrap, Leer, DragonDance, ExtremeSpeed)]
[InlineData(OR, Rotom, 0, Astonish, ThunderWave, ThunderShock, ConfuseRay)]
[InlineData(BD, Gible, 0, IronHead, BodySlam, SandTomb, Outrage)]
[InlineData(BD, Gible, 0, IronHead, BodySlam, Outrage, SandTomb)]
[InlineData(BD, Gible, 0, BodySlam, Outrage, SandTomb, DragonBreath)]
public void VerifyBreed(GameVersion game, Species species, int form, params Move[] movelist)
{
var gen = game.GetGeneration();
@ -63,6 +66,7 @@ namespace PKHeX.Tests.Legality
[Theory]
[InlineData(GD, Bulbasaur, 0, Growl, Tackle)] // swap order, two base moves
[InlineData(UM, Charmander, 0, Ember, BellyDrum, Scratch, Growl)] // swap order, inherit + egg moves
[InlineData(BD, Gible, 0, BodySlam, SandTomb, Outrage, DragonBreath)]
public void CheckFix(GameVersion game, Species species, int form, params Move[] movelist)
{
var gen = game.GetGeneration();