Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-23 12:33:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move

Browse source
This commit is contained in:
javierhimura 2017-03-31 13:19:17 +02:00
parent 780aad4af8
commit 57f5ac1bbb
1 changed files with 37 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
PKHeX/Legality/Checks.cs
View file

@ -2595,6 +2595,17 @@ namespace PKHeX.Core
EventEggMovesLearned.Add(m); EventEggMovesLearned.Add(m);
} }
if (pkm.Species == 292)
{
// Check Shedinja evolved moves from Ninjask after egg moves
// Those moves could also be inherited egg moves
var shedinjamove = ParseShedinjaEvolveMoves(moves, BaseEggMovesLearned, ref res);
if (shedinjamove > 0)
{
BaseEggMovesLearned.Remove(shedinjamove);
}
}
// A pokemon could have normal egg moves and regular egg moves // A pokemon could have normal egg moves and regular egg moves
// Only if all regular egg moves are event egg moves or all event egg moves are regular egg moves // Only if all regular egg moves are event egg moves or all event egg moves are regular egg moves
var RegularEggMovesLearned = EggMovesLearned.Union(BaseEggMovesLearned); var RegularEggMovesLearned = EggMovesLearned.Union(BaseEggMovesLearned);
@ -2643,13 +2654,6 @@ namespace PKHeX.Core
return res; return res;
} }
if (pkm.Species == 292)
{
// Check Shedinja evolved moves from Ninjask after egg moves
// Those moves could also be inherited egg moves
ParseShedinjaEvolveMoves(moves, ref res);
}
for (int m = 0; m < 4; m++) for (int m = 0; m < 4; m++)
{ {
if (res[m] == null) if (res[m] == null)
@ -2657,31 +2661,52 @@ namespace PKHeX.Core
} }
return res; return res;
} }
private void ParseShedinjaEvolveMoves(int[] moves, ref CheckResult[] res) private int ParseShedinjaEvolveMoves(int[] moves, List<int> BaseEggMovesLearned, ref CheckResult[] res)
{ {
List<int>[] ShedinjaEvoMoves = Legal.getShedinjaEvolveMoves(pkm); List<int>[] ShedinjaEvoMoves = Legal.getShedinjaEvolveMoves(pkm);
var ShedinjaEvoMovesLearned = new List<int>(); var ShedinjaEvoMovesLearned = new List<int>();
var genfound = 0;
for (int gen = 4; gen >= 3; gen--) for (int gen = 4; gen >= 3; gen--)
{ {
bool native = gen == pkm.Format; bool native = gen == pkm.Format;
for (int m = 0; m < 4; m++) for (int m = 0; m < 4; m++)
{ {
if (res[m]?.Valid ?? false) if (res[m]?.Valid ?? false || BaseEggMovesLearned.Contains(m))
continue; continue;
if (ShedinjaEvoMoves[gen].Contains(moves[m])) if (ShedinjaEvoMoves[gen].Contains(moves[m]))
{ {
if(!BaseEggMovesLearned.Contains(m))
res[m] = new CheckResult(Severity.Valid, native ? V355 : string.Format(V356, gen), CheckIdentifier.Move); res[m] = new CheckResult(Severity.Valid, native ? V355 : string.Format(V356, gen), CheckIdentifier.Move);
ShedinjaEvoMovesLearned.Add(m); ShedinjaEvoMovesLearned.Add(m);
// store the generation of the last move found, if there are two or more moves genfound wont be used
genfound = gen;
} }
} }
} }
if (ShedinjaEvoMovesLearned.Count() > 1) // Only one move is legal
var shedinjanotbase = ShedinjaEvoMovesLearned.Except(BaseEggMovesLearned);
if (shedinjanotbase.Count() > 1)
{ {
foreach (int m in ShedinjaEvoMovesLearned) // Have more than one move that are also not base egg moves
// shedinjanotbase moves are illegal, base egg moves could be illegal if it is an event egg
foreach (int m in shedinjanotbase)
res[m] = new CheckResult(Severity.Invalid, V357, CheckIdentifier.Move); res[m] = new CheckResult(Severity.Invalid, V357, CheckIdentifier.Move);
return 0;
} }
if (ShedinjaEvoMovesLearned.Count() == 1 && BaseEggMovesLearned.Count() == 1)
{
// there is only one evolve move that is also a base egg moves, changes the move result to evolve move
// to avoid flag it illegal if it is an event egg
var evolvemove = ShedinjaEvoMovesLearned.First();
var native = pkm.Format > 4 ? false : genfound == pkm.Format;
res[evolvemove] = new CheckResult(Severity.Valid, native ? V355 : string.Format(V356, genfound), CheckIdentifier.Move);
return evolvemove;
}
// Multiple base egg moves but only one non-base egg move
// that is the evolve move
return shedinjanotbase.FirstOrDefault();
} }
private void verifyPreRelearn() private void verifyPreRelearn()