Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-27 14:30:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

Isolate japanese config from legality settings

Browse source 
Loading the save initially needs it specified by the program (per save
file); when a save is cloned it needs to clone the Japanese parameter

No functional change when used with PKHeX, but other applications of
Core will now function correctly. (init 1 EN save, 1 JP save -> cloned
EN became JP; this no longer happens)

SAV3 is the only save object that needs the JP bool specified... I
wonder if there's some way to reliably detect with just the SAV data...
This commit is contained in:
Kurt 2017-04-12 18:19:31 -07:00
parent ad962712f1
commit 552237166f
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
PKHeX/Saves/SAV3.cs
View file

@ -135,7 +135,6 @@ namespace PKHeX.Core
LegalTMHMs = Legal.Pouch_TMHM_RS;
LegalBerries = Legal.Pouch_Berries_RS;
HeldItems = Legal.HeldItems_RS;
Japanese = Legal.SavegameJapanese;
if (!Exportable)
resetBoxes();
@ -164,7 +163,7 @@ namespace PKHeX.Core
public int getBlockOffset(int block) => BlockOfs[block];
// Configuration
public override SaveFile Clone() { return new SAV3(Write(DSV:false), Version); }
public override SaveFile Clone() { return new SAV3(Write(DSV:false), Version) {Japanese = Japanese}; }
public override bool IndeterminateGame => Version == GameVersion.Unknown;
public override bool IndeterminateLanguage => true; // Unknown JP/International
public override bool IndeterminateSubVersion => Version == GameVersion.FRLG;